From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284E1C43603 for ; Wed, 11 Dec 2019 15:55:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED2052073B for ; Wed, 11 Dec 2019 15:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576079713; bh=IR01qSHp6woWHUiQv3fVdxwTp4HmAqvzwqI58O3SPTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YRL8OSHQlOjmA1gEVwT/34AfskA75rCqas/dbMz9qZ+4bcAJ9u+TXCcMUWLXFmXJO 9aPBA7eBavOO4W2QK1zvBTv23MB30duXyJkLmtSCnHOViRHZx6z5+rJeT5M/FXicxy WjaJ8u37BDP4Pb3dIgAhxEB6psB5+dUtvWlhOws8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731936AbfLKPQp (ORCPT ); Wed, 11 Dec 2019 10:16:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:43910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731731AbfLKPQj (ORCPT ); Wed, 11 Dec 2019 10:16:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A61A92465E; Wed, 11 Dec 2019 15:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077399; bh=IR01qSHp6woWHUiQv3fVdxwTp4HmAqvzwqI58O3SPTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NN7mV+BsN/wyr1qQv/4+L6tN6BiqGMwxH+UB/ufCj3Z9MJSZCpbth4R3AiYEdg8eo thgVJmiAua2SVqg9Yd7wjsHy0t/+KLC5XM/93OHNZ1BB+ij81ispNfFLG3Wij2eQyg Q/c/x8RvSlIGaIuBPvszV6ZjoOK3LhqXgIOZeI9U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Jens Axboe , Sasha Levin Subject: [PATCH 4.19 024/243] rsxx: add missed destroy_workqueue calls in remove Date: Wed, 11 Dec 2019 16:03:06 +0100 Message-Id: <20191211150340.554169791@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit dcb77e4b274b8f13ac6482dfb09160cd2fae9a40 ] The driver misses calling destroy_workqueue in remove like what is done when probe fails. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/rsxx/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index f2c631ce793cc..14056dc450642 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -1014,8 +1014,10 @@ static void rsxx_pci_remove(struct pci_dev *dev) cancel_work_sync(&card->event_work); + destroy_workqueue(card->event_wq); rsxx_destroy_dev(card); rsxx_dma_destroy(card); + destroy_workqueue(card->creg_ctrl.creg_wq); spin_lock_irqsave(&card->irq_lock, flags); rsxx_disable_ier_and_isr(card, CR_INTR_ALL); -- 2.20.1