From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F98C43603 for ; Wed, 11 Dec 2019 15:18:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55BDB22527 for ; Wed, 11 Dec 2019 15:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077485; bh=P0XpjsJYlFEVbD4liZs7NI70Ujoy8NXzHF2fp/q2yno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kT71A2gM7BcaUWnl4z44L3kCblWfNqpMFFcuRvZ5Y53QP6FKaH09rLQi7/LsG8kAX cJJcVx0cG5tZ+RB6DfDeFiZDuaGa6bcT4GeFUG82DJ3fjgaxbQ+4qI67Q2uchjBByJ ETHk48Uq6c5qVLnx/VRVkhIVoSlHCe5sAgIfkFa8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731948AbfLKPSD (ORCPT ); Wed, 11 Dec 2019 10:18:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:45658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732077AbfLKPSA (ORCPT ); Wed, 11 Dec 2019 10:18:00 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FC3A2073D; Wed, 11 Dec 2019 15:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077479; bh=P0XpjsJYlFEVbD4liZs7NI70Ujoy8NXzHF2fp/q2yno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A+ASRbfoxWx45U3krYBikKmRD63C9W5foPNPlEC46soCabzutCVOxFcQ949tqfdkt UE70KUEcoDXX1wXI7+YAKxV+cfG04855hFUbQxkyDZk9hX5ZKGkEcohh91l8UgYtZb z05c521y5Go5q2GB0iIIVjIVlOeLshBRM0Eoiogs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steffen Maier , Benjamin Block , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 054/243] scsi: zfcp: drop default switch case which might paper over missing case Date: Wed, 11 Dec 2019 16:03:36 +0100 Message-Id: <20191211150342.753674310@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steffen Maier [ Upstream commit 0c902936e55cff9335b27ed632fc45e7115ced75 ] This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix missing REC trigger trace for all objects in ERP_FAILED") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example: drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_handle_failed': drivers/s390/scsi/zfcp_erp.c:126:2: warning: enumeration value 'ZFCP_ERP_ACTION_REOPEN_PORT_FORCED' not handled in switch [-Wswitch] switch (want) { ^~~~~~ But then again, only with W=1 we would notice unhandled enum cases. Without the default cases and a missed unhandled enum case, the code might perform unforeseen things we might not want... As of today, we never run through the removed default case, so removing it is no functional change. In the future, we never should run through a default case but introduce the necessary specific case(s) to handle new functionality. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/s390/scsi/zfcp_erp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/s390/scsi/zfcp_erp.c b/drivers/s390/scsi/zfcp_erp.c index 332701db7379d..f602b42b8343d 100644 --- a/drivers/s390/scsi/zfcp_erp.c +++ b/drivers/s390/scsi/zfcp_erp.c @@ -172,9 +172,6 @@ static int zfcp_erp_handle_failed(int want, struct zfcp_adapter *adapter, adapter, ZFCP_STATUS_COMMON_ERP_FAILED); } break; - default: - need = 0; - break; } return need; -- 2.20.1