From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B496C3F68F for ; Wed, 11 Dec 2019 15:54:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 283FA24658 for ; Wed, 11 Dec 2019 15:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576079641; bh=5EaPEyrukBMg3O+QebSDf5gJFnoIyQFT0LBomUN5WwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Nog89IAM0AlI0B/4R0f8148ZiOVLGZzXZ3RQqqtdtrxQRvaeW7e03FTy8EsSpp+m6 73pmQASQl5uTlujk9kFLuJhLNoupTcZ17Q7xauWSm0w8OvHGvjfBJmaHK+CIF7/p50 fw9/l8Qd2A6FHgOWMtOTBCZ2s1PfHh5ZS23whoD4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731851AbfLKPSb (ORCPT ); Wed, 11 Dec 2019 10:18:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:46358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731836AbfLKPSX (ORCPT ); Wed, 11 Dec 2019 10:18:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9489F2073D; Wed, 11 Dec 2019 15:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077503; bh=5EaPEyrukBMg3O+QebSDf5gJFnoIyQFT0LBomUN5WwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UXJAkLWXf9a1NyRlXXRtIFixfzBrUaHG/OHBMCPRfuVj+goOVFDcFJcWU6DcG3y8l v2t0+eqyr4bDBN2hwqOYFTcf9f9rmtVCwRfoI1bjnOri1c9jeVllG3Z/Zim+iJDg9J cvVcR1T//KZPrTi0f/eMtBtL1x1gzKeDYsrtPeNQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shreeya Patel , Jonathan Cameron , Sasha Levin Subject: [PATCH 4.19 062/243] Staging: iio: adt7316: Fix i2c data reading, set the data field Date: Wed, 11 Dec 2019 16:03:44 +0100 Message-Id: <20191211150343.286588810@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shreeya Patel [ Upstream commit 688cd642ba0c393344c802647848da5f0d925d0e ] adt7316_i2c_read function nowhere sets the data field. It is necessary to have an appropriate value for it. Hence, assign the value stored in 'ret' variable to data field. This is an ancient bug, and as no one seems to have noticed, probably no sense in applying it to stable. Signed-off-by: Shreeya Patel Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/staging/iio/addac/adt7316-i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio/addac/adt7316-i2c.c index f66dd3ebbab1f..856bcfa60c6c4 100644 --- a/drivers/staging/iio/addac/adt7316-i2c.c +++ b/drivers/staging/iio/addac/adt7316-i2c.c @@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data) return ret; } + *data = ret; + return 0; } -- 2.20.1