From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B4CC43603 for ; Wed, 11 Dec 2019 15:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E33EA22527 for ; Wed, 11 Dec 2019 15:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077743; bh=YqjW69vwErr91/xZdqliXDP/8OWoPj/I6tAL6NlEC/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Wo8lXuo04vgwV7W0+g6hP1dkKOQraVpqiWA2cGYQPnsJOPpJxK16GpdzNHZgm2O3G 3mYyCZ3r0fWMz3W5Weawa9hyFVmSDwkhmGcDiO8ln5SBjxTYghuciOQO2eUBSxWeYv 10MWq52keOINEeg9hgtkRhjkRzii2G3GBFdIjPZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732082AbfLKPWW (ORCPT ); Wed, 11 Dec 2019 10:22:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:52926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732573AbfLKPWR (ORCPT ); Wed, 11 Dec 2019 10:22:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B10CA2073D; Wed, 11 Dec 2019 15:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077737; bh=YqjW69vwErr91/xZdqliXDP/8OWoPj/I6tAL6NlEC/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WUueRgJ4M/Wu1yHkMVZ5kZJjxj1TGPAIUq8scS6mOg0zoJKFuGtKCSKE5TGT7G+Z+ 3BrD4aZBwIUZaFGabKrC2HOuSih6+CMm8uyBCGsBsvcFXkeO8vkmiD95BkF5r6udKn GbFkB8jd96wV6k3t85p8AL14SG+PHROHcP6zMD8Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Agner , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 4.19 114/243] serial: imx: fix error handling in console_setup Date: Wed, 11 Dec 2019 16:04:36 +0100 Message-Id: <20191211150346.829357354@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Agner [ Upstream commit 63fd4b94b948c14eeb27a3bbf50ea0f7f0593bad ] The ipg clock only needs to be unprepared in case preparing per clock fails. The ipg clock has already disabled at the point. Fixes: 1cf93e0d5488 ("serial: imx: remove the uart_console() check") Signed-off-by: Stefan Agner Reviewed-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 105de92b0b3bf..989ca7d662f3f 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2071,7 +2071,7 @@ imx_uart_console_setup(struct console *co, char *options) retval = clk_prepare(sport->clk_per); if (retval) - clk_disable_unprepare(sport->clk_ipg); + clk_unprepare(sport->clk_ipg); error_console: return retval; -- 2.20.1