From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9373C43603 for ; Wed, 11 Dec 2019 15:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 741D9208C3 for ; Wed, 11 Dec 2019 15:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576079402; bh=2nZs4ApWwNQIsCU08z+BurQFudeLwNmTRiebfxufrRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=G4us33Dbhtm5Xl7J51+9LVmiu7/DTw6yOwxSuEFBpEG1Ebz13oMt0zGVwZO/H/nBz xR5Ey0TWPzcg3TOuYXmlQxfy/gTucFpX3mQ1XlgIWZuR0fxMQeK0KPa4YmaYhhsDmS c2HgWeUDcNoYsdMSsRJvbphF3e3DFUnbh7K1+Ux4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733001AbfLKPuB (ORCPT ); Wed, 11 Dec 2019 10:50:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:55372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732794AbfLKPYG (ORCPT ); Wed, 11 Dec 2019 10:24:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BED532173E; Wed, 11 Dec 2019 15:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077846; bh=2nZs4ApWwNQIsCU08z+BurQFudeLwNmTRiebfxufrRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UMd/kh09dVSzs7ys/65KQFFcQaYjpyQ84WnUIfdeXfKuoRcwmjFcqBKom5W9dirri YlJFWeTxO3NM7FV83fqXJ/zA9wMegtejtn9nSQzDwzo1z5LB2OtmZ8NAJgnzqPwkKR xQsVLmWQwuGzrWKeY0dBlIgW86urCeC1+5rjkbH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yuchung Cheng , Eric Dumazet , Neal Cardwell , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 156/243] tcp: fix SNMP under-estimation on failed retransmission Date: Wed, 11 Dec 2019 16:05:18 +0100 Message-Id: <20191211150349.699865325@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yuchung Cheng [ Upstream commit ec641b39457e17774313b66697a8a1dc070257bd ] Previously the SNMP counter LINUX_MIB_TCPRETRANSFAIL is not counting the TSO/GSO properly on failed retransmission. This patch fixes that. Signed-off-by: Yuchung Cheng Signed-off-by: Eric Dumazet Signed-off-by: Neal Cardwell Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/tcp_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 53f910bb55087..8971cc15d278b 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2919,7 +2919,7 @@ int __tcp_retransmit_skb(struct sock *sk, struct sk_buff *skb, int segs) TCP_SKB_CB(skb)->sacked |= TCPCB_EVER_RETRANS; trace_tcp_retransmit_skb(sk, skb); } else if (err != -EBUSY) { - NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL); + NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL, segs); } return err; } -- 2.20.1