From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D64AC43603 for ; Wed, 11 Dec 2019 15:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F42922B48 for ; Wed, 11 Dec 2019 15:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078000; bh=CUq/QJulsZE6gr8Sp5//TUm3pgrhKTYBsdvSjudCuyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tOQ5M68NOQ5oURJu21fmMPe4Pl93wnHvvtvPZxS0WUq89bjEPCJxsA8QKvsvtdTa2 tuzFsdwsCq9AmFtUTdahKT8bv5MRB9tXUlp0AYQtuXzPAB47D2JKN/LRu7IcUmWjDY zi0ANu2chvQs8ddhKQbHduZyPpDtzAekQ0a46ELs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733161AbfLKP0j (ORCPT ); Wed, 11 Dec 2019 10:26:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:60016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733151AbfLKP0h (ORCPT ); Wed, 11 Dec 2019 10:26:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF8B524658; Wed, 11 Dec 2019 15:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077997; bh=CUq/QJulsZE6gr8Sp5//TUm3pgrhKTYBsdvSjudCuyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRTCsvNmfmLR1DW91h2hWKy7GeBjymv+5HNwwbhesvxlnWhmlqHTP5xPPAMc+QRly +gHuAPl8okBFSurAMjl+5TJ5VXKV6t423OGM8grgQs3XI7aXl0v9PP0SQ6m7cM0li8 449tGvdsHey6A1qB2XEpTiyYAA9brpzTZQBnNUus= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakob Unterwurzacher , Martin Elshuber , Philipp Tomsich , Johan Hovold , Marc Kleine-Budde Subject: [PATCH 4.19 237/243] can: ucan: fix non-atomic allocation in completion handler Date: Wed, 11 Dec 2019 16:06:39 +0100 Message-Id: <20191211150355.333300351@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 870db5d1015c8bd63e93b579e857223c96249ff7 upstream. USB completion handlers are called in atomic context and must specifically not allocate memory using GFP_KERNEL. Fixes: 9f2d3eae88d2 ("can: ucan: add driver for Theobroma Systems UCAN devices") Cc: stable # 4.19 Cc: Jakob Unterwurzacher Cc: Martin Elshuber Cc: Philipp Tomsich Signed-off-by: Johan Hovold Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/ucan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb/ucan.c @@ -796,7 +796,7 @@ resubmit: up); usb_anchor_urb(urb, &up->rx_urbs); - ret = usb_submit_urb(urb, GFP_KERNEL); + ret = usb_submit_urb(urb, GFP_ATOMIC); if (ret < 0) { netdev_err(up->netdev,