* [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions
@ 2019-12-11 15:47 Michael Straube
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
This series converts the drivers rtl8192{ce,cu,de} to use the generic
functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
Michael Straube (6):
rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
.../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++----------------
.../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++-----------------
.../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++----------------
3 files changed, 14 insertions(+), 130 deletions(-)
--
2.24.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-18 19:07 ` Kalle Valo
2019-12-11 15:47 ` [PATCH 2/6] rtlwifi: rtl8192cu: " Michael Straube
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92c_query_rxpwrpercentage is identical to the generic
version rtl_query_rxpwrpercentage. Remove _rtl92c_query_rxpwrpercentage
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../net/wireless/realtek/rtlwifi/rtl8192ce/trx.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
index fc9a3aae047f..dec66b3ac365 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
@@ -23,16 +23,6 @@ static u8 _rtl92ce_map_hwqueue_to_fwqueue(struct sk_buff *skb, u8 hw_queue)
return skb->priority;
}
-static u8 _rtl92c_query_rxpwrpercentage(s8 antpower)
-{
- if ((antpower <= -100) || (antpower >= 20))
- return 0;
- else if (antpower >= 0)
- return 100;
- else
- return 100 + antpower;
-}
-
static long _rtl92ce_signal_scale_mapping(struct ieee80211_hw *hw,
long currsig)
{
@@ -194,7 +184,7 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
rx_pwr[i] =
((p_drvinfo->gain_trsw[i] & 0x3f) * 2) - 110;
/* Translate DBM to percentage. */
- rssi = _rtl92c_query_rxpwrpercentage(rx_pwr[i]);
+ rssi = rtl_query_rxpwrpercentage(rx_pwr[i]);
total_rssi += rssi;
/* Get Rx snr value in DB */
rtlpriv->stats.rx_snr_db[i] =
@@ -209,7 +199,7 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
* hardware (for rate adaptive)
*/
rx_pwr_all = ((p_drvinfo->pwdb_all >> 1) & 0x7f) - 110;
- pwdb_all = _rtl92c_query_rxpwrpercentage(rx_pwr_all);
+ pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
pstats->rx_pwdb_all = pwdb_all;
pstats->rxpower = rx_pwr_all;
pstats->recvsignalpower = rx_pwr_all;
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/6] rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-11 15:47 ` [PATCH 3/6] rtlwifi: rtl8192de: " Michael Straube
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92c_query_rxpwrpercentage is identical to the generic
version rtl_query_rxpwrpercentage. Remove _rtl92c_query_rxpwrpercentage
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index cec19b32c7e2..c8652283a516 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
@@ -567,16 +567,6 @@ void rtl92c_set_min_space(struct ieee80211_hw *hw, bool is2T)
/*==============================================================*/
-static u8 _rtl92c_query_rxpwrpercentage(s8 antpower)
-{
- if ((antpower <= -100) || (antpower >= 20))
- return 0;
- else if (antpower >= 0)
- return 100;
- else
- return 100 + antpower;
-}
-
static long _rtl92c_signal_scale_mapping(struct ieee80211_hw *hw,
long currsig)
{
@@ -678,7 +668,7 @@ static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
break;
}
}
- pwdb_all = _rtl92c_query_rxpwrpercentage(rx_pwr_all);
+ pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
pstats->rx_pwdb_all = pwdb_all;
pstats->recvsignalpower = rx_pwr_all;
if (packet_match_bssid) {
@@ -707,7 +697,7 @@ static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
rf_rx_num++;
rx_pwr[i] =
((p_drvinfo->gain_trsw[i] & 0x3f) * 2) - 110;
- rssi = _rtl92c_query_rxpwrpercentage(rx_pwr[i]);
+ rssi = rtl_query_rxpwrpercentage(rx_pwr[i]);
total_rssi += rssi;
rtlpriv->stats.rx_snr_db[i] =
(long)(p_drvinfo->rxsnr[i] / 2);
@@ -716,7 +706,7 @@ static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
pstats->rx_mimo_signalstrength[i] = (u8) rssi;
}
rx_pwr_all = ((p_drvinfo->pwdb_all >> 1) & 0x7f) - 110;
- pwdb_all = _rtl92c_query_rxpwrpercentage(rx_pwr_all);
+ pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
pstats->rx_pwdb_all = pwdb_all;
pstats->rxpower = rx_pwr_all;
pstats->recvsignalpower = rx_pwr_all;
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/6] rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
2019-12-11 15:47 ` [PATCH 2/6] rtlwifi: rtl8192cu: " Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-11 15:47 ` [PATCH 4/6] rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping Michael Straube
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92d_query_rxpwrpercentage is identical to the generic
version rtl_query_rxpwrpercentage. Remove _rtl92d_query_rxpwrpercentage
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../net/wireless/realtek/rtlwifi/rtl8192de/trx.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
index 92c9fb45f800..abb35d33cf69 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
@@ -23,16 +23,6 @@ static u8 _rtl92de_map_hwqueue_to_fwqueue(struct sk_buff *skb, u8 hw_queue)
return skb->priority;
}
-static u8 _rtl92d_query_rxpwrpercentage(s8 antpower)
-{
- if ((antpower <= -100) || (antpower >= 20))
- return 0;
- else if (antpower >= 0)
- return 100;
- else
- return 100 + antpower;
-}
-
static long _rtl92de_translate_todbm(struct ieee80211_hw *hw,
u8 signal_strength_index)
{
@@ -141,7 +131,7 @@ static void _rtl92de_query_rxphystatus(struct ieee80211_hw *hw,
break;
}
}
- pwdb_all = _rtl92d_query_rxpwrpercentage(rx_pwr_all);
+ pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
/* CCK gain is smaller than OFDM/MCS gain, */
/* so we add gain diff by experiences, the val is 6 */
pwdb_all += 6;
@@ -183,7 +173,7 @@ static void _rtl92de_query_rxphystatus(struct ieee80211_hw *hw,
rf_rx_num++;
rx_pwr[i] = ((p_drvinfo->gain_trsw[i] & 0x3f) * 2)
- 110;
- rssi = _rtl92d_query_rxpwrpercentage(rx_pwr[i]);
+ rssi = rtl_query_rxpwrpercentage(rx_pwr[i]);
total_rssi += rssi;
rtlpriv->stats.rx_snr_db[i] =
(long)(p_drvinfo->rxsnr[i] / 2);
@@ -191,7 +181,7 @@ static void _rtl92de_query_rxphystatus(struct ieee80211_hw *hw,
pstats->rx_mimo_signalstrength[i] = (u8) rssi;
}
rx_pwr_all = ((p_drvinfo->pwdb_all >> 1) & 0x7f) - 106;
- pwdb_all = _rtl92d_query_rxpwrpercentage(rx_pwr_all);
+ pwdb_all = rtl_query_rxpwrpercentage(rx_pwr_all);
pstats->rx_pwdb_all = pwdb_all;
pstats->rxpower = rx_pwr_all;
pstats->recvsignalpower = rx_pwr_all;
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/6] rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
` (2 preceding siblings ...)
2019-12-11 15:47 ` [PATCH 3/6] rtlwifi: rtl8192de: " Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-11 15:47 ` [PATCH 5/6] rtlwifi: rtl8192cu: " Michael Straube
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92ce_signal_scale_mapping is identical to the generic
version rtl_signal_scale_mapping. Remove _rtl92ce_signal_scale_mapping
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 34 ++-----------------
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
index dec66b3ac365..8fc3cb824066 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
@@ -23,35 +23,6 @@ static u8 _rtl92ce_map_hwqueue_to_fwqueue(struct sk_buff *skb, u8 hw_queue)
return skb->priority;
}
-static long _rtl92ce_signal_scale_mapping(struct ieee80211_hw *hw,
- long currsig)
-{
- long retsig;
-
- if (currsig >= 61 && currsig <= 100)
- retsig = 90 + ((currsig - 60) / 4);
- else if (currsig >= 41 && currsig <= 60)
- retsig = 78 + ((currsig - 40) / 2);
- else if (currsig >= 31 && currsig <= 40)
- retsig = 66 + (currsig - 30);
- else if (currsig >= 21 && currsig <= 30)
- retsig = 54 + (currsig - 20);
- else if (currsig >= 5 && currsig <= 20)
- retsig = 42 + (((currsig - 5) * 2) / 3);
- else if (currsig == 4)
- retsig = 36;
- else if (currsig == 3)
- retsig = 27;
- else if (currsig == 2)
- retsig = 18;
- else if (currsig == 1)
- retsig = 9;
- else
- retsig = currsig;
-
- return retsig;
-}
-
static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
struct rtl_stats *pstats,
struct rx_desc_92c *pdesc,
@@ -231,11 +202,10 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
*/
if (is_cck_rate)
pstats->signalstrength =
- (u8)(_rtl92ce_signal_scale_mapping(hw, pwdb_all));
+ (u8)(rtl_signal_scale_mapping(hw, pwdb_all));
else if (rf_rx_num != 0)
pstats->signalstrength =
- (u8)(_rtl92ce_signal_scale_mapping
- (hw, total_rssi /= rf_rx_num));
+ (u8)(rtl_signal_scale_mapping(hw, total_rssi /= rf_rx_num));
}
static void _rtl92ce_translate_rx_signal_stuff(struct ieee80211_hw *hw,
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/6] rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
` (3 preceding siblings ...)
2019-12-11 15:47 ` [PATCH 4/6] rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-11 15:47 ` [PATCH 6/6] rtlwifi: rtl8192de: " Michael Straube
2019-12-12 1:47 ` [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Pkshih
6 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92c_signal_scale_mapping is identical to the generic
version rtl_signal_scale_mapping. Remove _rtl92c_signal_scale_mapping
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 33 ++-----------------
1 file changed, 2 insertions(+), 31 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index c8652283a516..b4b67341dc83 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
@@ -567,34 +567,6 @@ void rtl92c_set_min_space(struct ieee80211_hw *hw, bool is2T)
/*==============================================================*/
-static long _rtl92c_signal_scale_mapping(struct ieee80211_hw *hw,
- long currsig)
-{
- long retsig;
-
- if (currsig >= 61 && currsig <= 100)
- retsig = 90 + ((currsig - 60) / 4);
- else if (currsig >= 41 && currsig <= 60)
- retsig = 78 + ((currsig - 40) / 2);
- else if (currsig >= 31 && currsig <= 40)
- retsig = 66 + (currsig - 30);
- else if (currsig >= 21 && currsig <= 30)
- retsig = 54 + (currsig - 20);
- else if (currsig >= 5 && currsig <= 20)
- retsig = 42 + (((currsig - 5) * 2) / 3);
- else if (currsig == 4)
- retsig = 36;
- else if (currsig == 3)
- retsig = 27;
- else if (currsig == 2)
- retsig = 18;
- else if (currsig == 1)
- retsig = 9;
- else
- retsig = currsig;
- return retsig;
-}
-
static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
struct rtl_stats *pstats,
struct rx_desc_92c *p_desc,
@@ -729,11 +701,10 @@ static void _rtl92c_query_rxphystatus(struct ieee80211_hw *hw,
}
if (is_cck_rate)
pstats->signalstrength =
- (u8) (_rtl92c_signal_scale_mapping(hw, pwdb_all));
+ (u8)(rtl_signal_scale_mapping(hw, pwdb_all));
else if (rf_rx_num != 0)
pstats->signalstrength =
- (u8) (_rtl92c_signal_scale_mapping
- (hw, total_rssi /= rf_rx_num));
+ (u8)(rtl_signal_scale_mapping(hw, total_rssi /= rf_rx_num));
}
void rtl92c_translate_rx_signal_stuff(struct ieee80211_hw *hw,
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/6] rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
` (4 preceding siblings ...)
2019-12-11 15:47 ` [PATCH 5/6] rtlwifi: rtl8192cu: " Michael Straube
@ 2019-12-11 15:47 ` Michael Straube
2019-12-12 1:47 ` [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Pkshih
6 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-11 15:47 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Function _rtl92de_signal_scale_mapping is identical to the generic
version rtl_signal_scale_mapping. Remove _rtl92de_signal_scale_mapping
and use the generic function.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
.../wireless/realtek/rtlwifi/rtl8192de/trx.c | 31 ++-----------------
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
index abb35d33cf69..85194aa30c36 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c
@@ -33,33 +33,6 @@ static long _rtl92de_translate_todbm(struct ieee80211_hw *hw,
return signal_power;
}
-static long _rtl92de_signal_scale_mapping(struct ieee80211_hw *hw, long currsig)
-{
- long retsig;
-
- if (currsig >= 61 && currsig <= 100)
- retsig = 90 + ((currsig - 60) / 4);
- else if (currsig >= 41 && currsig <= 60)
- retsig = 78 + ((currsig - 40) / 2);
- else if (currsig >= 31 && currsig <= 40)
- retsig = 66 + (currsig - 30);
- else if (currsig >= 21 && currsig <= 30)
- retsig = 54 + (currsig - 20);
- else if (currsig >= 5 && currsig <= 20)
- retsig = 42 + (((currsig - 5) * 2) / 3);
- else if (currsig == 4)
- retsig = 36;
- else if (currsig == 3)
- retsig = 27;
- else if (currsig == 2)
- retsig = 18;
- else if (currsig == 1)
- retsig = 9;
- else
- retsig = currsig;
- return retsig;
-}
-
static void _rtl92de_query_rxphystatus(struct ieee80211_hw *hw,
struct rtl_stats *pstats,
struct rx_desc_92d *pdesc,
@@ -202,10 +175,10 @@ static void _rtl92de_query_rxphystatus(struct ieee80211_hw *hw,
}
}
if (is_cck_rate)
- pstats->signalstrength = (u8)(_rtl92de_signal_scale_mapping(hw,
+ pstats->signalstrength = (u8)(rtl_signal_scale_mapping(hw,
pwdb_all));
else if (rf_rx_num != 0)
- pstats->signalstrength = (u8)(_rtl92de_signal_scale_mapping(hw,
+ pstats->signalstrength = (u8)(rtl_signal_scale_mapping(hw,
total_rssi /= rf_rx_num));
}
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
` (5 preceding siblings ...)
2019-12-11 15:47 ` [PATCH 6/6] rtlwifi: rtl8192de: " Michael Straube
@ 2019-12-12 1:47 ` Pkshih
2019-12-13 11:46 ` Michael Straube
6 siblings, 1 reply; 10+ messages in thread
From: Pkshih @ 2019-12-12 1:47 UTC (permalink / raw)
To: straube.linux; +Cc: linux-wireless, kvalo, davem, netdev, linux-kernel
On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote:
> This series converts the drivers rtl8192{ce,cu,de} to use the generic
> functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
>
> Michael Straube (6):
> rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
> rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
> rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
> rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
> rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
> rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
>
> .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++----------------
> .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++-----------------
> .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++----------------
> 3 files changed, 14 insertions(+), 130 deletions(-)
>
For all patches:
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Curiously. How can you find these function are identical?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions
2019-12-12 1:47 ` [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Pkshih
@ 2019-12-13 11:46 ` Michael Straube
0 siblings, 0 replies; 10+ messages in thread
From: Michael Straube @ 2019-12-13 11:46 UTC (permalink / raw)
To: Pkshih; +Cc: linux-wireless, kvalo, davem, netdev, linux-kernel
On 2019-12-12 02:47, Pkshih wrote:
> On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote:
>> This series converts the drivers rtl8192{ce,cu,de} to use the generic
>> functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
>>
>> Michael Straube (6):
>> rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
>> rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
>> rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
>> rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
>>
>> .../wireless/realtek/rtlwifi/rtl8192ce/trx.c | 48 ++----------------
>> .../wireless/realtek/rtlwifi/rtl8192cu/mac.c | 49 ++-----------------
>> .../wireless/realtek/rtlwifi/rtl8192de/trx.c | 47 ++----------------
>> 3 files changed, 14 insertions(+), 130 deletions(-)
>>
>
> For all patches:
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
Thanks.
> Curiously. How can you find these function are identical?
>
While sending cleanup patches for some staging wifi drivers I noticed
that these functions are used in many of the realtek drivers and all
looked very similar. Then used grep and diff to verify.
Michael
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
@ 2019-12-18 19:07 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-12-18 19:07 UTC (permalink / raw)
To: Michael Straube
Cc: pkshih, davem, linux-wireless, netdev, linux-kernel, Michael Straube
Michael Straube <straube.linux@gmail.com> wrote:
> Function _rtl92c_query_rxpwrpercentage is identical to the generic
> version rtl_query_rxpwrpercentage. Remove _rtl92c_query_rxpwrpercentage
> and use the generic function.
>
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
6 patches applied to wireless-drivers-next.git, thanks.
f365f2f67b6a rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
b8a19dd64501 rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
5a87ae1d676e rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
d01b26734297 rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
fef91a2b5f5f rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
716c733f52ec rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
--
https://patchwork.kernel.org/patch/11285545/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-12-18 19:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 15:47 [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Michael Straube
2019-12-11 15:47 ` [PATCH 1/6] rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage Michael Straube
2019-12-18 19:07 ` Kalle Valo
2019-12-11 15:47 ` [PATCH 2/6] rtlwifi: rtl8192cu: " Michael Straube
2019-12-11 15:47 ` [PATCH 3/6] rtlwifi: rtl8192de: " Michael Straube
2019-12-11 15:47 ` [PATCH 4/6] rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping Michael Straube
2019-12-11 15:47 ` [PATCH 5/6] rtlwifi: rtl8192cu: " Michael Straube
2019-12-11 15:47 ` [PATCH 6/6] rtlwifi: rtl8192de: " Michael Straube
2019-12-12 1:47 ` [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions Pkshih
2019-12-13 11:46 ` Michael Straube
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.