From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
a.zummo@towertech.it, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v3 6/6] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver
Date: Wed, 11 Dec 2019 21:17:09 +0100 [thread overview]
Message-ID: <20191211201709.GD1463890@piout.net> (raw)
In-Reply-To: <20191211203321.3635b0c4@kemnade.info>
On 11/12/2019 20:33:21+0100, Andreas Kemnade wrote:
> Hi,
>
> On Mon, 2 Dec 2019 10:39:35 +0100
> Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
>
> > On 29/11/2019 22:20:45+0100, Andreas Kemnade wrote:
> > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619,
> > > which is implemented as a variant of rn5t618.
> > >
> will capitalize chip names in the commit text as requested for the other
> patches by Lee.
>
> > > rtc-range output:
> > > Testing 2000-02-28 23:59:59.
> > > OK
> > >
> > > Testing 2038-01-19 03:14:07.
> > > OK
> > >
> > > Testing 2069-12-31 23:59:59.
> > > OK
> > >
> > > Testing 2099-12-31 23:59:59.
> > > KO RTC_RD_TIME returned 22 (line 138)
> > >
> > > Testing 2100-02-28 23:59:59.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Testing 2106-02-07 06:28:15.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Testing 2262-04-11 23:47:16.
> > > KO RTC_SET_TIME returned 34 (line 122)
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> >
> I will remove
> static int rc5t619_rtc_alarm_is_enabled(struct device *dev, uint8_t *enabled)
>
> since it is unused now so gcc emits a warning, which I have overlooked.
> I hope your Acked-by still counts for that.
>
Sure, you can keep it.
While at it, the subject should be:
rtc: rc5t619: add ricoh rc5t619 RTC driver
If you want, you can capitalize the second rc5t619 but not the first
one.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-12-11 20:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:20 [PATCH v3 0/6] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 1/6] dt-bindings: mfd: rn5t618: Document optional property interrupts Andreas Kemnade
2019-12-10 8:52 ` Lee Jones
2019-11-29 21:20 ` [PATCH v3 2/6] mfd: rn5t618: prepare for irq handling Andreas Kemnade
2019-12-10 9:13 ` Lee Jones
2019-12-10 17:06 ` Andreas Kemnade
2019-12-11 7:44 ` Lee Jones
2019-11-29 21:20 ` [PATCH v3 3/6] mfd: rn5t618: add irq support Andreas Kemnade
2019-12-10 9:32 ` Lee Jones
2019-12-10 16:59 ` Andreas Kemnade
2019-12-11 7:50 ` Lee Jones
2019-12-11 11:43 ` Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 4/6] mfd: rn5t618: add rtc related registers Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 5/6] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 6/6] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver Andreas Kemnade
2019-12-02 9:39 ` Alexandre Belloni
2019-12-11 19:33 ` Andreas Kemnade
2019-12-11 20:17 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211201709.GD1463890@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phh@phh.me \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.