From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D626BC43603 for ; Thu, 12 Dec 2019 11:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABFF3214AF for ; Thu, 12 Dec 2019 11:07:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bLPkQT4m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728913AbfLLLHr (ORCPT ); Thu, 12 Dec 2019 06:07:47 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:34214 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728613AbfLLLHr (ORCPT ); Thu, 12 Dec 2019 06:07:47 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBCAwwB0056725; Thu, 12 Dec 2019 11:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=YRk6g7FxBAzSfJq2rxanLkGSDrmUILvwq1H4o0Nf8a0=; b=bLPkQT4mKEuc+Fxi6AsqdsjDk7SkewoV2cW2scJzIgOoM6V1VVjV6yYT2VGz/llEMpli 9+AOLjuW/a+GW5xS4GUHGkgVqHujAQ2xuJ+LgZTcWmeJOyHE0/dMHrqPMlK08daP53NR ynuC13Tt3ntLOtezqcZZ5jksE/F66YAABFmXqgqr24/U/zmvZLGGoibPU/EpERAXKk8o f/eFw0+as9S6ouBrMbN/WJFuBzv/mkC5SxaZy3OiYbwJ8Mlq9qVF39i6/1czkx2D/pEw AmlXnm4spgO+P5xr+5MkpYJyhb38NfJhB2T+SXm4/xy3uvb3lq6QWDHRnH0gO7J84HGp nA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2wr41qjaqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 11:07:41 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBCB7MRO095116; Thu, 12 Dec 2019 11:07:40 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2wu3k15fa3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 11:07:40 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBCB7cZZ011111; Thu, 12 Dec 2019 11:07:39 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Dec 2019 03:07:38 -0800 Date: Thu, 12 Dec 2019 14:07:29 +0300 From: Dan Carpenter To: Sergei Shtylyov Cc: Scott Schafer , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, netdev@vger.kernel.org, GR-Linux-NIC-Dev@marvell.com, linux-kernel@vger.kernel.org, Manish Chopra Subject: Re: [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay Message-ID: <20191212110729.GD2070@kadam> References: <337af773-a1da-0c04-6180-aa3597372522@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <337af773-a1da-0c04-6180-aa3597372522@cogentembedded.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120082 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120082 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.12.2019 21:12, Scott Schafer wrote: > > > chage udelay() to usleep_range() > > Change? > > > Signed-off-by: Scott Schafer > > --- > > drivers/staging/qlge/qlge_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > > index e18aa335c899..9427386e4a1e 100644 > > --- a/drivers/staging/qlge/qlge_main.c > > +++ b/drivers/staging/qlge/qlge_main.c > > @@ -147,7 +147,7 @@ int ql_sem_spinlock(struct ql_adapter *qdev, u32 sem_mask) > > do { > > if (!ql_sem_trylock(qdev, sem_mask)) > > return 0; > > - udelay(100); > > + usleep_range(100, 200); > > I hope you're not in atomic context... I have an unpublished Smatch check which says that we aren't in atomic context, but still this has spin_lock() in the name so you're right, it shouldn't sleep. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77004C2D0C9 for ; Thu, 12 Dec 2019 11:07:49 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 498F02173E for ; Thu, 12 Dec 2019 11:07:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bLPkQT4m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498F02173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 17F448630A; Thu, 12 Dec 2019 11:07:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6CAd+kF1q3Rw; Thu, 12 Dec 2019 11:07:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 60DD886239; Thu, 12 Dec 2019 11:07:46 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 214821BF3EC for ; Thu, 12 Dec 2019 11:07:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1DB0486F6D for ; Thu, 12 Dec 2019 11:07:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xqVhna9RT8K8 for ; Thu, 12 Dec 2019 11:07:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E0FEA86F60 for ; Thu, 12 Dec 2019 11:07:42 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBCAwwB0056725; Thu, 12 Dec 2019 11:07:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=YRk6g7FxBAzSfJq2rxanLkGSDrmUILvwq1H4o0Nf8a0=; b=bLPkQT4mKEuc+Fxi6AsqdsjDk7SkewoV2cW2scJzIgOoM6V1VVjV6yYT2VGz/llEMpli 9+AOLjuW/a+GW5xS4GUHGkgVqHujAQ2xuJ+LgZTcWmeJOyHE0/dMHrqPMlK08daP53NR ynuC13Tt3ntLOtezqcZZ5jksE/F66YAABFmXqgqr24/U/zmvZLGGoibPU/EpERAXKk8o f/eFw0+as9S6ouBrMbN/WJFuBzv/mkC5SxaZy3OiYbwJ8Mlq9qVF39i6/1czkx2D/pEw AmlXnm4spgO+P5xr+5MkpYJyhb38NfJhB2T+SXm4/xy3uvb3lq6QWDHRnH0gO7J84HGp nA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2wr41qjaqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 11:07:41 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBCB7MRO095116; Thu, 12 Dec 2019 11:07:40 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2wu3k15fa3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Dec 2019 11:07:40 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBCB7cZZ011111; Thu, 12 Dec 2019 11:07:39 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Dec 2019 03:07:38 -0800 Date: Thu, 12 Dec 2019 14:07:29 +0300 From: Dan Carpenter To: Sergei Shtylyov Subject: Re: [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay Message-ID: <20191212110729.GD2070@kadam> References: <337af773-a1da-0c04-6180-aa3597372522@cogentembedded.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <337af773-a1da-0c04-6180-aa3597372522@cogentembedded.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120082 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9468 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912120082 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Scott Schafer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.12.2019 21:12, Scott Schafer wrote: > > > chage udelay() to usleep_range() > > Change? > > > Signed-off-by: Scott Schafer > > --- > > drivers/staging/qlge/qlge_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > > index e18aa335c899..9427386e4a1e 100644 > > --- a/drivers/staging/qlge/qlge_main.c > > +++ b/drivers/staging/qlge/qlge_main.c > > @@ -147,7 +147,7 @@ int ql_sem_spinlock(struct ql_adapter *qdev, u32 sem_mask) > > do { > > if (!ql_sem_trylock(qdev, sem_mask)) > > return 0; > > - udelay(100); > > + usleep_range(100, 200); > > I hope you're not in atomic context... I have an unpublished Smatch check which says that we aren't in atomic context, but still this has spin_lock() in the name so you're right, it shouldn't sleep. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel