From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E37EC43603 for ; Thu, 12 Dec 2019 16:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB7E222527 for ; Thu, 12 Dec 2019 16:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576166596; bh=hfABrdLSbH0bF01p271neeli3FQecfhJg4XVLx7Gzt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e6SAPDW0cecyQOV3kz+Oad94jwVzvxgAzQWNIks/juiVdXNXzV2LU8tEswf6NnN13 IyUUuYVP4TPopEEYet4acdXfd65rnpe+07FPQlVGyvDyYgWGJ12J/SU2sMPT5fUIiB NMLft84Uh1OVS006KWQWsv/f+vIAhV8zOoPDwvAo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729817AbfLLQDP (ORCPT ); Thu, 12 Dec 2019 11:03:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:49960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729247AbfLLQDP (ORCPT ); Thu, 12 Dec 2019 11:03:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A87C22173E; Thu, 12 Dec 2019 16:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576166595; bh=hfABrdLSbH0bF01p271neeli3FQecfhJg4XVLx7Gzt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xoPRm99RqXB4G6cle4WwUEdyyR/xvWEN2/Pv6Q1/dEW7dcz94kHXPQUoWAlzNwVf6 CfAhr/QJHu8bLnf8dLLvaKAuEubbTEUmyqMocdFxvWs8wxkeif566rlC19JCkNCBuo 1ZP/hc43GyOhkAPxmlTplERgVf0xW5BcW91kOcy0= Date: Thu, 12 Dec 2019 17:03:12 +0100 From: Greg KH To: Scott Schafer Cc: Dan Carpenter , devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement Message-ID: <20191212160312.GA1672580@kroah.com> References: <0e1fc1a16725094676fdab63d3a24a986309a759.1576086080.git.schaferjscott@gmail.com> <20191212121206.GB1895@kadam> <20191212150200.GA8219@karen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191212150200.GA8219@karen> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote: > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp) > > > mbcp->out_count = 6; > > > > > > status = ql_get_mb_sts(qdev, mbcp); > > > - if (status) > > > + if (status) { > > > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n"); > > > + } > > > else { > > > > The close } should be on the same line as the else. > > > > > int i; > > > > > > > regards, > > dan carpenter > > this was fixed in patch 22 Don't add a warning that you later fix up :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DC7C43603 for ; Thu, 12 Dec 2019 16:03:18 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7729C22527 for ; Thu, 12 Dec 2019 16:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xoPRm99R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7729C22527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 43D01882FC; Thu, 12 Dec 2019 16:03:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15b2zbkW170X; Thu, 12 Dec 2019 16:03:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A827C8834C; Thu, 12 Dec 2019 16:03:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id CBD041BF86C for ; Thu, 12 Dec 2019 16:03:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C37738834C for ; Thu, 12 Dec 2019 16:03:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8ACWTu0wMWlC for ; Thu, 12 Dec 2019 16:03:15 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 410F7882FC for ; Thu, 12 Dec 2019 16:03:15 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A87C22173E; Thu, 12 Dec 2019 16:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576166595; bh=hfABrdLSbH0bF01p271neeli3FQecfhJg4XVLx7Gzt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xoPRm99RqXB4G6cle4WwUEdyyR/xvWEN2/Pv6Q1/dEW7dcz94kHXPQUoWAlzNwVf6 CfAhr/QJHu8bLnf8dLLvaKAuEubbTEUmyqMocdFxvWs8wxkeif566rlC19JCkNCBuo 1ZP/hc43GyOhkAPxmlTplERgVf0xW5BcW91kOcy0= Date: Thu, 12 Dec 2019 17:03:12 +0100 From: Greg KH To: Scott Schafer Subject: Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement Message-ID: <20191212160312.GA1672580@kroah.com> References: <0e1fc1a16725094676fdab63d3a24a986309a759.1576086080.git.schaferjscott@gmail.com> <20191212121206.GB1895@kadam> <20191212150200.GA8219@karen> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191212150200.GA8219@karen> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Dec 12, 2019 at 09:02:00AM -0600, Scott Schafer wrote: > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp) > > > mbcp->out_count = 6; > > > > > > status = ql_get_mb_sts(qdev, mbcp); > > > - if (status) > > > + if (status) { > > > netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n"); > > > + } > > > else { > > > > The close } should be on the same line as the else. > > > > > int i; > > > > > > > regards, > > dan carpenter > > this was fixed in patch 22 Don't add a warning that you later fix up :) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel