From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4C9C43603 for ; Thu, 12 Dec 2019 16:48:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A51B21655 for ; Thu, 12 Dec 2019 16:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VYMlukS+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A51B21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifRdy-0006YB-MC for qemu-devel@archiver.kernel.org; Thu, 12 Dec 2019 11:48:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44008) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifRV3-00059b-Hw for qemu-devel@nongnu.org; Thu, 12 Dec 2019 11:39:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifRV2-0001Cx-B9 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 11:39:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60596 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifRV2-0001Az-58 for qemu-devel@nongnu.org; Thu, 12 Dec 2019 11:39:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576168774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fpH8VVxfz2mYhtV7I/EfiqNshb8FuXw7lbiKT3c1kg=; b=VYMlukS++5yNb6j3c3DlbRnsBUN+Mver2hO8sCTwiNAC509oU7o/KvtZYycMNsqbTqGXAL VtefjZKzcxq2Nkh2eaX7Rgg9v7TaVB9nUJFdCSK3NA4wcKQRcmkl9Egr3uYXsYyFvKcyUT PBfwF1CIehWh84Z3NB+rDZd8RgsaEzY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-VtENEmi2M8Swhazz__pbKQ-1; Thu, 12 Dec 2019 11:39:31 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03C161800D42 for ; Thu, 12 Dec 2019 16:39:31 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-116-226.ams2.redhat.com [10.36.116.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C3E060BE1; Thu, 12 Dec 2019 16:39:30 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com Subject: [PATCH 010/104] virtiofsd: Fix fuse_daemonize ignored return values Date: Thu, 12 Dec 2019 16:37:30 +0000 Message-Id: <20191212163904.159893-11-dgilbert@redhat.com> In-Reply-To: <20191212163904.159893-1-dgilbert@redhat.com> References: <20191212163904.159893-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: VtENEmi2M8Swhazz__pbKQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" QEMU's compiler enables warnings/errors for ignored values and the (void) trick used in the fuse code isn't enough. Turn all the return values into a return value on the function. Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/helper.c | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c index d8c42401a7..8afccfc15e 100644 --- a/tools/virtiofsd/helper.c +++ b/tools/virtiofsd/helper.c @@ -10,12 +10,10 @@ * See the file COPYING.LIB. */ =20 -#include "config.h" #include "fuse_i.h" #include "fuse_lowlevel.h" #include "fuse_misc.h" #include "fuse_opt.h" -#include "mount_util.h" =20 #include #include @@ -177,6 +175,7 @@ int fuse_parse_cmdline(struct fuse_args *args, struct f= use_cmdline_opts *opts) =20 int fuse_daemonize(int foreground) { + int ret =3D 0, rett; if (!foreground) { int nullfd; int waiter[2]; @@ -198,8 +197,8 @@ int fuse_daemonize(int foreground) case 0: break; default: - (void)read(waiter[0], &completed, sizeof(completed)); - _exit(0); + _exit(read(waiter[0], &completed, + sizeof(completed) !=3D sizeof(completed))); } =20 if (setsid() =3D=3D -1) { @@ -207,13 +206,22 @@ int fuse_daemonize(int foreground) return -1; } =20 - (void)chdir("/"); + ret =3D chdir("/"); =20 nullfd =3D open("/dev/null", O_RDWR, 0); if (nullfd !=3D -1) { - (void)dup2(nullfd, 0); - (void)dup2(nullfd, 1); - (void)dup2(nullfd, 2); + rett =3D dup2(nullfd, 0); + if (!ret) { + ret =3D rett; + } + rett =3D dup2(nullfd, 1); + if (!ret) { + ret =3D rett; + } + rett =3D dup2(nullfd, 2); + if (!ret) { + ret =3D rett; + } if (nullfd > 2) { close(nullfd); } @@ -221,13 +229,16 @@ int fuse_daemonize(int foreground) =20 /* Propagate completion of daemon initialization */ completed =3D 1; - (void)write(waiter[1], &completed, sizeof(completed)); + rett =3D write(waiter[1], &completed, sizeof(completed)); + if (!ret) { + ret =3D rett; + } close(waiter[0]); close(waiter[1]); } else { - (void)chdir("/"); + ret =3D chdir("/"); } - return 0; + return ret; } =20 void fuse_apply_conn_info_opts(struct fuse_conn_info_opts *opts, --=20 2.23.0