From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/gma500: globle no more!
Date: Fri, 13 Dec 2019 11:33:06 +0100 [thread overview]
Message-ID: <20191213103306.GI624164@phenom.ffwll.local> (raw)
In-Reply-To: <87r21b2cl7.fsf@intel.com>
On Wed, Dec 11, 2019 at 03:53:08PM +0200, Jani Nikula wrote:
> On Wed, 11 Dec 2019, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > globle, goblin, moblin?
> >
> > It's dead code, we lucked out.
>
> Oh, sad to see it go. The oldest reference to globle_dev I could find
> was from 2011.
>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
Thanks for taking a look, applied.
-Daniel
>
> >
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/gma500/mdfld_intel_display.c | 23 --------------------
> > 1 file changed, 23 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> > index b8bfb96008b8..4fff110c4921 100644
> > --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> > +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> > @@ -113,27 +113,6 @@ static int psb_intel_panel_fitter_pipe(struct drm_device *dev)
> > return (pfit_control >> 29) & 0x3;
> > }
> >
> > -static struct drm_device globle_dev;
> > -
> > -void mdfld__intel_plane_set_alpha(int enable)
> > -{
> > - struct drm_device *dev = &globle_dev;
> > - int dspcntr_reg = DSPACNTR;
> > - u32 dspcntr;
> > -
> > - dspcntr = REG_READ(dspcntr_reg);
> > -
> > - if (enable) {
> > - dspcntr &= ~DISPPLANE_32BPP_NO_ALPHA;
> > - dspcntr |= DISPPLANE_32BPP;
> > - } else {
> > - dspcntr &= ~DISPPLANE_32BPP;
> > - dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
> > - }
> > -
> > - REG_WRITE(dspcntr_reg, dspcntr);
> > -}
> > -
> > static int check_fb(struct drm_framebuffer *fb)
> > {
> > if (!fb)
> > @@ -164,8 +143,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
> > u32 dspcntr;
> > int ret;
> >
> > - memcpy(&globle_dev, dev, sizeof(struct drm_device));
> > -
> > dev_dbg(dev->dev, "pipe = 0x%x.\n", pipe);
> >
> > /* no fb bound */
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-12-13 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 12:00 [PATCH] drm/gma500: globle no more! Daniel Vetter
2019-12-11 13:53 ` Jani Nikula
2019-12-13 10:33 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213103306.GI624164@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.