From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9368EC3497B for ; Fri, 13 Dec 2019 20:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C96C6246AC for ; Fri, 13 Dec 2019 20:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576269385; bh=ladYn8c8xl9+MFyl6aehoPQocrw/xZ3C142IjJPuxcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e2+tE1H5EALyds8BqD58r/K8IA4MfMwFyD2EA5YF7PXBZwI8Eng64yJcv0eD1bBdy n6P68hRFigAeFie5cAHbNGwR0v6OJKUwVoB4Zpu54kBkxPPBGlhHJGCpwpbTmrVs2X ZzRYemHbC2NZzJK6GByrpXWJwBLOBva+NucZZIB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfLMLco (ORCPT ); Fri, 13 Dec 2019 06:32:44 -0500 Received: from foss.arm.com ([217.140.110.172]:55758 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfLMLco (ORCPT ); Fri, 13 Dec 2019 06:32:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4EA11045; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30B113F718; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Date: Fri, 13 Dec 2019 11:32:41 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Cc: Jeff Chang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "matthias.bgg@gmail.com" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20191213113241.GA4644@sirena.org.uk> References: <1576152740-11979-1-git-send-email-richtek.jeff.chang@gmail.com> <20191212145330.GC4310@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 13, 2019 at 07:36:15AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > Dear Mark: >=20 >=20 >=20 > Thanks for your replying. I consider that there was only one item= I should modify. So I kept resending. >=20 >=20 >=20 > Please refer my red comment after your comment. I can't tell what's in red or not, kernel development gets done with plain text e-mail. Please fix your mail configuration, it is extremely difficult to read your messages for this and other reasons. > The writes to reserved registers should be fine but things like this whic= h looks like it's configuring the input path should just be left at the chi= p default, we don't want to be configuring for particular boards since the = same driver will be used for every board with the chip. >=20 >=20 >=20 > The chip default cannot be modified anymore. How can I do if I re= ally need write these setting in our drivers? Settings should be done through some combination of userspace configuration at runtime and device tree or ACPI properties. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zdtYACgkQJNaLcl1U h9B8kwf+IpjaEaGa2G/sBNA8Uba5iLxJH77tx+EkitOF1sumwNDj1XNcuYqb9lDl ak4VjrPpISMuFyn2bA1jcGMDT9Kt7Iu9Ho2H/trihujQasAESaDskolv4ePg0XVV azTK7X98WsarZRy6EpuWWSCmF1ePPpA60fHtM3rjQbKDhAb+6VVIl6kDEeWvhwtt aPl5Twi1fjMqgPtqSdCe/aREpmiREG19zoTy/M/INreV7T5KY4ndfV/m6YNnBVss T0ambE+xjV94LIULzEsa5fno9DKIgGOmrKxunAXswLk8B4Za0Auhv7E3XBvc/CpR 7kTt0mjLMsVXjv75mbnn2BKi7Zdovw== =PyY0 -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6B6C2D0C9 for ; Fri, 13 Dec 2019 21:01:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 376FB246B5 for ; Fri, 13 Dec 2019 21:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qql1uQPK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 376FB246B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE0C71772; Fri, 13 Dec 2019 12:32:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE0C71772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576236826; bh=TYvdw6dOPVb3ilJ0H47pLeyvzAkjlWXe6H6AD0qSlgU=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qql1uQPK9r81vD9EKwni7SkWAfDqh1TLeQODArh7TQYTkJRPaMlgMT9FBVvvfgUfT aA+UIFhnXCI5ura9gFFlsbtxzI2LiB+Ms9pd0nay2pWhqA5qqc23KLEkvwvxDPqM2Z 3QwTdGCK7lj19mWuLMwlul98koodXp5ye57F9Y10= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 55E4AF8019B; Fri, 13 Dec 2019 12:32:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9253F801F4; Fri, 13 Dec 2019 12:32:48 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id CF409F800AB for ; Fri, 13 Dec 2019 12:32:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CF409F800AB Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4EA11045; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30B113F718; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Date: Fri, 13 Dec 2019 11:32:41 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Message-ID: <20191213113241.GA4644@sirena.org.uk> References: <1576152740-11979-1-git-send-email-richtek.jeff.chang@gmail.com> <20191212145330.GC4310@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , Jeff Chang , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [alsa-devel] [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2120516141434417198==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============2120516141434417198== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 13, 2019 at 07:36:15AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > Dear Mark: >=20 >=20 >=20 > Thanks for your replying. I consider that there was only one item= I should modify. So I kept resending. >=20 >=20 >=20 > Please refer my red comment after your comment. I can't tell what's in red or not, kernel development gets done with plain text e-mail. Please fix your mail configuration, it is extremely difficult to read your messages for this and other reasons. > The writes to reserved registers should be fine but things like this whic= h looks like it's configuring the input path should just be left at the chi= p default, we don't want to be configuring for particular boards since the = same driver will be used for every board with the chip. >=20 >=20 >=20 > The chip default cannot be modified anymore. How can I do if I re= ally need write these setting in our drivers? Settings should be done through some combination of userspace configuration at runtime and device tree or ACPI properties. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zdtYACgkQJNaLcl1U h9B8kwf+IpjaEaGa2G/sBNA8Uba5iLxJH77tx+EkitOF1sumwNDj1XNcuYqb9lDl ak4VjrPpISMuFyn2bA1jcGMDT9Kt7Iu9Ho2H/trihujQasAESaDskolv4ePg0XVV azTK7X98WsarZRy6EpuWWSCmF1ePPpA60fHtM3rjQbKDhAb+6VVIl6kDEeWvhwtt aPl5Twi1fjMqgPtqSdCe/aREpmiREG19zoTy/M/INreV7T5KY4ndfV/m6YNnBVss T0ambE+xjV94LIULzEsa5fno9DKIgGOmrKxunAXswLk8B4Za0Auhv7E3XBvc/CpR 7kTt0mjLMsVXjv75mbnn2BKi7Zdovw== =PyY0 -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- --===============2120516141434417198== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============2120516141434417198==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F32DC2D0C9 for ; Fri, 13 Dec 2019 22:25:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 592602077B for ; Fri, 13 Dec 2019 22:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYB820by" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 592602077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+07qTgWSu0e8/u+/HINaz7YBPDZNuSZ0z2SG6zoNWVM=; b=lYB820by3Rx4JVf6y4T4Qkymb /W+OLw3adcSU+ERovsp4LEWVafcmVDX8se/f2lBenTlimXJ6fHxEsgHKFAW7S5RUlimS2uNCDCSmh lJR+WjOFf2oUTxTAft1g/ZbB1eU2XtbPQ+90ahLQRKss+XLI9SYq+baEObSvZbyw6dh+nFL2VDOyk l6Hd8MxZ1PPfU1RqiPCBNkEyo3pTgQd0HLesf9WhZKAEDuHaWp7U0qaDZ8IOoRD/QjbF22N2s2vDE E85R8ikH0yGTIAVJJfYKfDsNQqnLcLS0hvMqIE5ZlDDBkjskk/wQsP49AKzPe99/9qUZvXoghFtcn q2X09IN8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifjBf-0007Bz-HJ; Fri, 13 Dec 2019 11:32:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifjBc-0007BV-Js for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 11:32:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4EA11045; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30B113F718; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Date: Fri, 13 Dec 2019 11:32:41 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20191213113241.GA4644@sirena.org.uk> References: <1576152740-11979-1-git-send-email-richtek.jeff.chang@gmail.com> <20191212145330.GC4310@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_033244_694853_D30EC295 X-CRM114-Status: GOOD ( 11.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , Jeff Chang , "matthias.bgg@gmail.com" , "perex@perex.cz" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============2574263652463399982==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2574263652463399982== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 13, 2019 at 07:36:15AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > Dear Mark: >=20 >=20 >=20 > Thanks for your replying. I consider that there was only one item= I should modify. So I kept resending. >=20 >=20 >=20 > Please refer my red comment after your comment. I can't tell what's in red or not, kernel development gets done with plain text e-mail. Please fix your mail configuration, it is extremely difficult to read your messages for this and other reasons. > The writes to reserved registers should be fine but things like this whic= h looks like it's configuring the input path should just be left at the chi= p default, we don't want to be configuring for particular boards since the = same driver will be used for every board with the chip. >=20 >=20 >=20 > The chip default cannot be modified anymore. How can I do if I re= ally need write these setting in our drivers? Settings should be done through some combination of userspace configuration at runtime and device tree or ACPI properties. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zdtYACgkQJNaLcl1U h9B8kwf+IpjaEaGa2G/sBNA8Uba5iLxJH77tx+EkitOF1sumwNDj1XNcuYqb9lDl ak4VjrPpISMuFyn2bA1jcGMDT9Kt7Iu9Ho2H/trihujQasAESaDskolv4ePg0XVV azTK7X98WsarZRy6EpuWWSCmF1ePPpA60fHtM3rjQbKDhAb+6VVIl6kDEeWvhwtt aPl5Twi1fjMqgPtqSdCe/aREpmiREG19zoTy/M/INreV7T5KY4ndfV/m6YNnBVss T0ambE+xjV94LIULzEsa5fno9DKIgGOmrKxunAXswLk8B4Za0Auhv7E3XBvc/CpR 7kTt0mjLMsVXjv75mbnn2BKi7Zdovw== =PyY0 -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- --===============2574263652463399982== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2574263652463399982==--