* [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
@ 2019-12-13 15:28 Ville Syrjala
2019-12-13 15:54 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Ville Syrjala @ 2019-12-13 15:28 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Include dev_name() in the tracpoints so one can filter based on
the device.
Example:
echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
TODO: maybe don't both specifying the field name always and just
make it 'dev' (or whatever) always?
TODO: add for other tracpoints too if this is deemed good enough
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
1 file changed, 65 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index 7ef7a1e1664c..8931b6756f44 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -20,11 +20,18 @@
/* watermark/fifo updates */
+#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
+#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
+#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
+#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
+#define __get_dev_name(field) __get_str(field)
+
TRACE_EVENT(intel_pipe_enable,
TP_PROTO(struct intel_crtc *crtc),
TP_ARGS(crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__array(u32, frame, 3)
__array(u32, scanline, 3)
__field(enum pipe, pipe)
@@ -32,6 +39,7 @@ TRACE_EVENT(intel_pipe_enable,
TP_fast_assign(
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
struct intel_crtc *it__;
+ __assign_dev_name_crtc(dev, crtc);
for_each_intel_crtc(&dev_priv->drm, it__) {
__entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
__entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
@@ -39,8 +47,8 @@ TRACE_EVENT(intel_pipe_enable,
__entry->pipe = crtc->pipe;
),
- TP_printk("pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- pipe_name(__entry->pipe),
+ TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe),
__entry->frame[PIPE_A], __entry->scanline[PIPE_A],
__entry->frame[PIPE_B], __entry->scanline[PIPE_B],
__entry->frame[PIPE_C], __entry->scanline[PIPE_C])
@@ -51,6 +59,7 @@ TRACE_EVENT(intel_pipe_disable,
TP_ARGS(crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__array(u32, frame, 3)
__array(u32, scanline, 3)
__field(enum pipe, pipe)
@@ -59,6 +68,7 @@ TRACE_EVENT(intel_pipe_disable,
TP_fast_assign(
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
struct intel_crtc *it__;
+ __assign_dev_name_crtc(dev, crtc);
for_each_intel_crtc(&dev_priv->drm, it__) {
__entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
__entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
@@ -66,8 +76,8 @@ TRACE_EVENT(intel_pipe_disable,
__entry->pipe = crtc->pipe;
),
- TP_printk("pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- pipe_name(__entry->pipe),
+ TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe),
__entry->frame[PIPE_A], __entry->scanline[PIPE_A],
__entry->frame[PIPE_B], __entry->scanline[PIPE_B],
__entry->frame[PIPE_C], __entry->scanline[PIPE_C])
@@ -78,6 +88,7 @@ TRACE_EVENT(intel_pipe_crc,
TP_ARGS(crtc, crcs),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -85,14 +96,15 @@ TRACE_EVENT(intel_pipe_crc,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
memcpy(__entry->crcs, crcs, sizeof(__entry->crcs));
),
- TP_printk("pipe %c, frame=%u, scanline=%u crc=%08x %08x %08x %08x %08x",
- pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u crc=%08x %08x %08x %08x %08x",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
__entry->crcs[0], __entry->crcs[1], __entry->crcs[2],
__entry->crcs[3], __entry->crcs[4])
);
@@ -102,20 +114,22 @@ TRACE_EVENT(intel_cpu_fifo_underrun,
TP_ARGS(dev_priv, pipe),
TP_STRUCT__entry(
+ __dev_name_i915(dev, dev_priv)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
- struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
+ struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
+ __assign_dev_name_i915(dev, dev_priv);
__entry->pipe = pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
- TP_printk("pipe %c, frame=%u, scanline=%u",
- pipe_name(__entry->pipe),
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe),
__entry->frame, __entry->scanline)
);
@@ -124,6 +138,7 @@ TRACE_EVENT(intel_pch_fifo_underrun,
TP_ARGS(dev_priv, pch_transcoder),
TP_STRUCT__entry(
+ __dev_name_i915(dev, dev_priv)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -132,13 +147,14 @@ TRACE_EVENT(intel_pch_fifo_underrun,
TP_fast_assign(
enum pipe pipe = pch_transcoder;
struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
+ __assign_dev_name_i915(dev, dev_priv);
__entry->pipe = pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
- TP_printk("pch transcoder %c, frame=%u, scanline=%u",
- pipe_name(__entry->pipe),
+ TP_printk("dev %s, pch transcoder %c, frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe),
__entry->frame, __entry->scanline)
);
@@ -147,6 +163,7 @@ TRACE_EVENT(intel_memory_cxsr,
TP_ARGS(dev_priv, old, new),
TP_STRUCT__entry(
+ __dev_name_i915(dev, dev_priv)
__array(u32, frame, 3)
__array(u32, scanline, 3)
__field(bool, old)
@@ -155,6 +172,7 @@ TRACE_EVENT(intel_memory_cxsr,
TP_fast_assign(
struct intel_crtc *crtc;
+ __assign_dev_name_i915(dev, dev_priv);
for_each_intel_crtc(&dev_priv->drm, crtc) {
__entry->frame[crtc->pipe] = intel_crtc_get_vblank_counter(crtc);
__entry->scanline[crtc->pipe] = intel_get_crtc_scanline(crtc);
@@ -163,8 +181,8 @@ TRACE_EVENT(intel_memory_cxsr,
__entry->new = new;
),
- TP_printk("%s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- onoff(__entry->old), onoff(__entry->new),
+ TP_printk("dev %s, %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
+ __get_dev_name(dev), onoff(__entry->old), onoff(__entry->new),
__entry->frame[PIPE_A], __entry->scanline[PIPE_A],
__entry->frame[PIPE_B], __entry->scanline[PIPE_B],
__entry->frame[PIPE_C], __entry->scanline[PIPE_C])
@@ -175,6 +193,7 @@ TRACE_EVENT(g4x_wm,
TP_ARGS(crtc, wm),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -193,6 +212,7 @@ TRACE_EVENT(g4x_wm,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
@@ -210,8 +230,8 @@ TRACE_EVENT(g4x_wm,
__entry->fbc = wm->fbc_en;
),
- TP_printk("pipe %c, frame=%u, scanline=%u, wm %d/%d/%d, sr %s/%d/%d/%d, hpll %s/%d/%d/%d, fbc %s",
- pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, wm %d/%d/%d, sr %s/%d/%d/%d, hpll %s/%d/%d/%d, fbc %s",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
__entry->primary, __entry->sprite, __entry->cursor,
yesno(__entry->cxsr), __entry->sr_plane, __entry->sr_cursor, __entry->sr_fbc,
yesno(__entry->hpll), __entry->hpll_plane, __entry->hpll_cursor, __entry->hpll_fbc,
@@ -223,6 +243,7 @@ TRACE_EVENT(vlv_wm,
TP_ARGS(crtc, wm),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -237,6 +258,7 @@ TRACE_EVENT(vlv_wm,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
@@ -250,8 +272,8 @@ TRACE_EVENT(vlv_wm,
__entry->sr_cursor = wm->sr.cursor;
),
- TP_printk("pipe %c, frame=%u, scanline=%u, level=%d, cxsr=%d, wm %d/%d/%d/%d, sr %d/%d",
- pipe_name(__entry->pipe), __entry->frame,
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, level=%d, cxsr=%d, wm %d/%d/%d/%d, sr %d/%d",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame,
__entry->scanline, __entry->level, __entry->cxsr,
__entry->primary, __entry->sprite0, __entry->sprite1, __entry->cursor,
__entry->sr_plane, __entry->sr_cursor)
@@ -262,6 +284,7 @@ TRACE_EVENT(vlv_fifo_size,
TP_ARGS(crtc, sprite0_start, sprite1_start, fifo_size),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -271,6 +294,7 @@ TRACE_EVENT(vlv_fifo_size,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
@@ -279,8 +303,8 @@ TRACE_EVENT(vlv_fifo_size,
__entry->fifo_size = fifo_size;
),
- TP_printk("pipe %c, frame=%u, scanline=%u, %d/%d/%d",
- pipe_name(__entry->pipe), __entry->frame,
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, %d/%d/%d",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame,
__entry->scanline, __entry->sprite0_start,
__entry->sprite1_start, __entry->fifo_size)
);
@@ -292,6 +316,7 @@ TRACE_EVENT(intel_update_plane,
TP_ARGS(plane, crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -301,6 +326,7 @@ TRACE_EVENT(intel_update_plane,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__assign_str(name, plane->name);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
@@ -309,8 +335,8 @@ TRACE_EVENT(intel_update_plane,
memcpy(__entry->dst, &plane->state->dst, sizeof(__entry->dst));
),
- TP_printk("pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
- pipe_name(__entry->pipe), __get_str(name),
+ TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
+ __get_dev_name(dev), pipe_name(__entry->pipe), __get_str(name),
__entry->frame, __entry->scanline,
DRM_RECT_FP_ARG((const struct drm_rect *)__entry->src),
DRM_RECT_ARG((const struct drm_rect *)__entry->dst))
@@ -321,6 +347,7 @@ TRACE_EVENT(intel_disable_plane,
TP_ARGS(plane, crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -328,14 +355,15 @@ TRACE_EVENT(intel_disable_plane,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__assign_str(name, plane->name);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
- TP_printk("pipe %c, plane %s, frame=%u, scanline=%u",
- pipe_name(__entry->pipe), __get_str(name),
+ TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __get_str(name),
__entry->frame, __entry->scanline)
);
@@ -346,6 +374,7 @@ TRACE_EVENT(i915_pipe_update_start,
TP_ARGS(crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -354,6 +383,7 @@ TRACE_EVENT(i915_pipe_update_start,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
@@ -361,9 +391,9 @@ TRACE_EVENT(i915_pipe_update_start,
__entry->max = crtc->debug.max_vbl;
),
- TP_printk("pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
- pipe_name(__entry->pipe), __entry->frame,
- __entry->scanline, __entry->min, __entry->max)
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame,
+ __entry->scanline, __entry->min, __entry->max)
);
TRACE_EVENT(i915_pipe_update_vblank_evaded,
@@ -371,6 +401,7 @@ TRACE_EVENT(i915_pipe_update_vblank_evaded,
TP_ARGS(crtc),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
@@ -379,6 +410,7 @@ TRACE_EVENT(i915_pipe_update_vblank_evaded,
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = crtc->debug.start_vbl_count;
__entry->scanline = crtc->debug.scanline_start;
@@ -386,9 +418,9 @@ TRACE_EVENT(i915_pipe_update_vblank_evaded,
__entry->max = crtc->debug.max_vbl;
),
- TP_printk("pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
- pipe_name(__entry->pipe), __entry->frame,
- __entry->scanline, __entry->min, __entry->max)
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame,
+ __entry->scanline, __entry->min, __entry->max)
);
TRACE_EVENT(i915_pipe_update_end,
@@ -396,19 +428,21 @@ TRACE_EVENT(i915_pipe_update_end,
TP_ARGS(crtc, frame, scanline_end),
TP_STRUCT__entry(
+ __dev_name_crtc(dev, crtc)
__field(enum pipe, pipe)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
+ __assign_dev_name_crtc(dev, crtc);
__entry->pipe = crtc->pipe;
__entry->frame = frame;
__entry->scanline = scanline_end;
),
- TP_printk("pipe %c, frame=%u, scanline=%u",
- pipe_name(__entry->pipe), __entry->frame,
+ TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame,
__entry->scanline)
);
--
2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2019-12-13 15:28 [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints Ville Syrjala
@ 2019-12-13 15:54 ` Chris Wilson
2019-12-13 17:06 ` Ville Syrjälä
2019-12-13 21:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2019-12-13 15:54 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
Quoting Ville Syrjala (2019-12-13 15:28:23)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Include dev_name() in the tracpoints so one can filter based on
> the device.
>
> Example:
> echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
>
> TODO: maybe don't both specifying the field name always and just
> make it 'dev' (or whatever) always?
> TODO: add for other tracpoints too if this is deemed good enough
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> 1 file changed, 65 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 7ef7a1e1664c..8931b6756f44 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -20,11 +20,18 @@
>
> /* watermark/fifo updates */
>
> +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> +#define __get_dev_name(field) __get_str(field)
Storing the string is quite expensive, I thought. Can we stash the i915
and stringify in the TP_printk? Or is stashing the string the secret for
the dev== filter?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2019-12-13 15:54 ` Chris Wilson
@ 2019-12-13 17:06 ` Ville Syrjälä
2019-12-13 17:17 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2019-12-13 17:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-12-13 15:28:23)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Include dev_name() in the tracpoints so one can filter based on
> > the device.
> >
> > Example:
> > echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
> >
> > TODO: maybe don't both specifying the field name always and just
> > make it 'dev' (or whatever) always?
> > TODO: add for other tracpoints too if this is deemed good enough
> >
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> > 1 file changed, 65 insertions(+), 31 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> > index 7ef7a1e1664c..8931b6756f44 100644
> > --- a/drivers/gpu/drm/i915/i915_trace.h
> > +++ b/drivers/gpu/drm/i915/i915_trace.h
> > @@ -20,11 +20,18 @@
> >
> > /* watermark/fifo updates */
> >
> > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> > +#define __get_dev_name(field) __get_str(field)
>
> Storing the string is quite expensive, I thought. Can we stash the i915
> and stringify in the TP_printk? Or is stashing the string the secret for
> the dev== filter?
Last time I stashed a pointer in there people complained that it can
disappear before being consumed and cause a very theoretical oops.
But I guess we could stash just the pci devfn and whatnot.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2019-12-13 17:06 ` Ville Syrjälä
@ 2019-12-13 17:17 ` Ville Syrjälä
2020-03-07 22:13 ` Chris Wilson
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2019-12-13 17:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Dec 13, 2019 at 07:06:01PM +0200, Ville Syrjälä wrote:
> On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote:
> > Quoting Ville Syrjala (2019-12-13 15:28:23)
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Include dev_name() in the tracpoints so one can filter based on
> > > the device.
> > >
> > > Example:
> > > echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
> > >
> > > TODO: maybe don't both specifying the field name always and just
> > > make it 'dev' (or whatever) always?
> > > TODO: add for other tracpoints too if this is deemed good enough
> > >
> > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> > > 1 file changed, 65 insertions(+), 31 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> > > index 7ef7a1e1664c..8931b6756f44 100644
> > > --- a/drivers/gpu/drm/i915/i915_trace.h
> > > +++ b/drivers/gpu/drm/i915/i915_trace.h
> > > @@ -20,11 +20,18 @@
> > >
> > > /* watermark/fifo updates */
> > >
> > > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> > > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> > > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> > > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> > > +#define __get_dev_name(field) __get_str(field)
> >
> > Storing the string is quite expensive, I thought. Can we stash the i915
> > and stringify in the TP_printk? Or is stashing the string the secret for
> > the dev== filter?
>
> Last time I stashed a pointer in there people complained that it can
> disappear before being consumed and cause a very theoretical oops.
> But I guess we could stash just the pci devfn and whatnot.
I believe 'domain + bus + devfn' would amount to 4 bytes. The downside
is that it'd be just an integer so we'd lose the dev=domain:bus:dev.fn
syntax for the filter. Suppose I could try to implement a new filter
type for it, but no guarantees that would get accepted. Seems a bit too
pci specific for kernel/trace/.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add device name to display tracepoints
2019-12-13 15:28 [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints Ville Syrjala
2019-12-13 15:54 ` Chris Wilson
@ 2019-12-13 21:19 ` Patchwork
2019-12-13 22:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-14 19:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-13 21:19 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add device name to display tracepoints
URL : https://patchwork.freedesktop.org/series/70886/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
78e6434185eb drm/i915: Add device name to display tracepoints
-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/i915_trace.h:107:
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
-:129: WARNING:TABSTOP: Statements should start on a tabstop
#129: FILE: drivers/gpu/drm/i915/i915_trace.h:124:
+ struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
-:130: WARNING:LINE_SPACING: Missing a blank line after declarations
#130: FILE: drivers/gpu/drm/i915/i915_trace.h:125:
+ struct intel_crtc *crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
+ __assign_dev_name_i915(dev, dev_priv);
-:218: WARNING:LONG_LINE: line over 100 characters
#218: FILE: drivers/gpu/drm/i915/i915_trace.h:234:
+ __get_dev_name(dev), pipe_name(__entry->pipe), __entry->frame, __entry->scanline,
-:298: WARNING:LONG_LINE: line over 100 characters
#298: FILE: drivers/gpu/drm/i915/i915_trace.h:338:
+ TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
total: 0 errors, 5 warnings, 0 checks, 350 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add device name to display tracepoints
2019-12-13 15:28 [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints Ville Syrjala
2019-12-13 15:54 ` Chris Wilson
2019-12-13 21:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-12-13 22:09 ` Patchwork
2019-12-14 19:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-13 22:09 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add device name to display tracepoints
URL : https://patchwork.freedesktop.org/series/70886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7563 -> Patchwork_15750
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/index.html
Known issues
------------
Here are the changes found in Patchwork_15750 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [PASS][1] -> [TIMEOUT][2] ([i915#816])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-byt-n2820/igt@gem_close_race@basic-threads.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-byt-n2820/igt@gem_close_race@basic-threads.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][3] -> [DMESG-WARN][4] ([i915#592])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [PASS][5] -> [DMESG-FAIL][6] ([i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-hsw-4770r/igt@i915_selftest@live_blt.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- {fi-tgl-guc}: [INCOMPLETE][7] ([fdo#111593]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-tgl-guc/igt@gem_exec_gttfill@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-tgl-guc/igt@gem_exec_gttfill@basic.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][9] ([i915#553] / [i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-hsw-4770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-ivb-3770: [DMESG-FAIL][11] ([i915#722]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-ivb-3770/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111096] / [i915#323]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (55 -> 47)
------------------------------
Missing (8): fi-icl-1065g7 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7563 -> Patchwork_15750
CI-20190529: 20190529
CI_DRM_7563: aa81d2aa468b726e50faba4a455efae4c4be2a67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15750: 78e6434185eb07eaf4410704fa7401dc8bb62e44 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
78e6434185eb drm/i915: Add device name to display tracepoints
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add device name to display tracepoints
2019-12-13 15:28 [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints Ville Syrjala
` (2 preceding siblings ...)
2019-12-13 22:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2019-12-14 19:19 ` Patchwork
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-12-14 19:19 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add device name to display tracepoints
URL : https://patchwork.freedesktop.org/series/70886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7563_full -> Patchwork_15750_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15750_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15750_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15750_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gen7_exec_parse@cmd-crossing-page}:
- shard-tglb: NOTRUN -> [SKIP][1] +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb5/igt@gen7_exec_parse@cmd-crossing-page.html
* {igt@gen9_exec_parse@unaligned-access}:
- shard-iclb: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb8/igt@gen9_exec_parse@unaligned-access.html
### Piglit changes ###
#### Possible regressions ####
* spec@ext_packed_float@fbo-alphatest-formats (NEW):
- pig-hsw-4770r: NOTRUN -> [FAIL][3] +10 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/pig-hsw-4770r/spec@ext_packed_float@fbo-alphatest-formats.html
New tests
---------
New tests have been introduced between CI_DRM_7563_full and Patchwork_15750_full:
### New Piglit tests (7) ###
* spec@!opengl 3.2@coord-replace-doesnt-eliminate-frag-tex-coords:
- Statuses : 1 fail(s)
- Exec time: [0.56] s
* spec@arb_es2_compatibility@fbo-alphatest-formats:
- Statuses : 1 fail(s)
- Exec time: [0.10] s
* spec@arb_gpu_shader5@texturegatheroffset@vs-rgb-2-int-2darray:
- Statuses : 1 fail(s)
- Exec time: [7.38] s
* spec@arb_stencil_texturing@draw:
- Statuses : 1 fail(s)
- Exec time: [0.12] s
* spec@ext_packed_float@fbo-alphatest-formats:
- Statuses : 1 fail(s)
- Exec time: [0.12] s
* spec@glsl-4.20@execution@vs_in@vs-input-position-double_dvec4-int_int:
- Statuses : 1 fail(s)
- Exec time: [0.18] s
* spec@glsl-4.20@execution@vs_in@vs-input-position-ubyte_uvec3-short_int-double_dvec3:
- Statuses : 1 fail(s)
- Exec time: [0.17] s
Known issues
------------
Here are the changes found in Patchwork_15750_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_create@madvise:
- shard-tglb: [PASS][4] -> [INCOMPLETE][5] ([i915#435]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb8/igt@gem_exec_create@madvise.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb6/igt@gem_exec_create@madvise.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [PASS][6] -> [INCOMPLETE][7] ([fdo#111593])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb3/igt@gem_exec_gttfill@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb7/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@contexts:
- shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([i915#470])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb4/igt@gem_exec_parallel@contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb6/igt@gem_exec_parallel@contexts.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112146]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1:
- shard-tglb: [PASS][14] -> [INCOMPLETE][15] ([fdo#111677])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb4/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd1.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-snb: [PASS][16] -> [DMESG-WARN][17] ([fdo#111870])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-snb4/igt@gem_userptr_blits@dmabuf-unsync.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-snb6/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@i915_selftest@mock_sanitycheck:
- shard-kbl: [PASS][18] -> [DMESG-WARN][19] ([i915#747])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl3/igt@i915_selftest@mock_sanitycheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl2/igt@i915_selftest@mock_sanitycheck.html
- shard-skl: [PASS][20] -> [DMESG-WARN][21] ([i915#747])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl10/igt@i915_selftest@mock_sanitycheck.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl4/igt@i915_selftest@mock_sanitycheck.html
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([i915#747])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-snb5/igt@i915_selftest@mock_sanitycheck.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-snb6/igt@i915_selftest@mock_sanitycheck.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][24] -> [FAIL][25] ([fdo#103375])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
- shard-skl: [PASS][26] -> [FAIL][27] ([i915#54]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- shard-skl: [PASS][28] -> [DMESG-WARN][29] ([i915#88])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl1/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl6/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][30] -> [INCOMPLETE][31] ([i915#221])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl4/igt@kms_flip@flip-vs-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl2/igt@kms_flip@flip-vs-suspend.html
- shard-snb: [PASS][32] -> [INCOMPLETE][33] ([i915#82])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-snb2/igt@kms_flip@flip-vs-suspend.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#34])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-tglb: [PASS][36] -> [FAIL][37] ([i915#49])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][38] -> [INCOMPLETE][39] ([i915#456] / [i915#460] / [i915#474])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([i915#180]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-iclb: [PASS][42] -> [INCOMPLETE][43] ([i915#140] / [i915#246])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb1/igt@kms_plane@pixel-format-pipe-a-planes.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb6/igt@kms_plane@pixel-format-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-tglb: [PASS][44] -> [INCOMPLETE][45] ([i915#456] / [i915#460]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb9/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-skl: [PASS][46] -> [DMESG-WARN][47] ([IGT#6])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl4/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl10/igt@kms_plane_multiple@atomic-pipe-b-tiling-yf.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][50] -> [DMESG-WARN][51] ([i915#180])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-reset:
- shard-iclb: [SKIP][52] ([fdo#109276] / [fdo#112080]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb3/igt@gem_ctx_isolation@vcs1-reset.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb1/igt@gem_ctx_isolation@vcs1-reset.html
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [INCOMPLETE][54] ([i915#461]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb4/igt@gem_ctx_shared@q-smoketest-bsd.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb7/igt@gem_ctx_shared@q-smoketest-bsd.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-skl: [FAIL][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl7/igt@gem_eio@in-flight-contexts-1us.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl3/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [DMESG-WARN][58] ([i915#180]) -> [PASS][59] +5 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl1/igt@gem_eio@in-flight-suspend.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl1/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][60] ([fdo#110854]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb3/igt@gem_exec_balancer@smoke.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_nop@basic-parallel:
- shard-tglb: [INCOMPLETE][62] ([i915#435]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb4/igt@gem_exec_nop@basic-parallel.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb1/igt@gem_exec_nop@basic-parallel.html
* igt@gem_exec_schedule@fifo-bsd:
- shard-iclb: [SKIP][64] ([fdo#112146]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb2/igt@gem_exec_schedule@fifo-bsd.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb8/igt@gem_exec_schedule@fifo-bsd.html
* igt@gem_exec_schedule@preempt-queue-chain-vebox:
- shard-tglb: [INCOMPLETE][66] ([fdo#111677]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-vebox.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb4/igt@gem_exec_schedule@preempt-queue-chain-vebox.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][68] ([i915#180]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-apl6/igt@gem_softpin@noreloc-s3.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-apl7/igt@gem_softpin@noreloc-s3.html
* igt@gem_sync@basic-store-all:
- shard-tglb: [INCOMPLETE][70] ([i915#472]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb6/igt@gem_sync@basic-store-all.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb9/igt@gem_sync@basic-store-all.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [DMESG-WARN][74] ([i915#109]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl9/igt@kms_color@pipe-a-ctm-0-25.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl3/igt@kms_color@pipe-a-ctm-0-25.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement:
- shard-skl: [DMESG-WARN][76] ([i915#744]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen:
- shard-skl: [FAIL][78] ([i915#54]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-tglb: [INCOMPLETE][80] ([i915#456] / [i915#460]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled:
- shard-tglb: [INCOMPLETE][82] ([i915#667]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb1/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb2/igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [INCOMPLETE][84] ([i915#435] / [i915#456] / [i915#460]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-kbl: [INCOMPLETE][86] ([fdo#103665] / [i915#667]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-kbl: [INCOMPLETE][88] ([fdo#103665] / [i915#648] / [i915#667]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-kbl7/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-kbl4/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][90] ([fdo#108145] / [i915#265]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@perf_pmu@busy-accuracy-98-vcs1:
- shard-iclb: [SKIP][92] ([fdo#112080]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb3/igt@perf_pmu@busy-accuracy-98-vcs1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb1/igt@perf_pmu@busy-accuracy-98-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][94] ([fdo#109276]) -> [PASS][95] +3 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-iclb3/igt@prime_vgem@fence-wait-bsd2.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-tglb: [SKIP][96] ([fdo#112016] / [fdo#112021]) -> [SKIP][97] ([fdo#112021])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-tglb6/igt@kms_atomic_transition@6x-modeset-transitions.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-skl: [INCOMPLETE][98] ([fdo#112347] / [i915#648] / [i915#667]) -> [INCOMPLETE][99] ([fdo#112347] / [fdo#112391] / [i915#648] / [i915#667]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl7/igt@kms_plane@pixel-format-pipe-b-planes.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl3/igt@kms_plane@pixel-format-pipe-b-planes.html
* igt@runner@aborted:
- shard-skl: [FAIL][100] ([i915#69]) -> [FAIL][101] ([i915#69] / [k.org#204565])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7563/shard-skl10/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/shard-skl4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112016]: https://bugs.freedesktop.org/show_bug.cgi?id=112016
[fdo#112021]: https://bugs.freedesktop.org/show_bug.cgi?id=112021
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347
[fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#246]: https://gitlab.freedesktop.org/drm/intel/issues/246
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460
[i915#461]: https://gitlab.freedesktop.org/drm/intel/issues/461
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
[i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#744]: https://gitlab.freedesktop.org/drm/intel/issues/744
[i915#747]: https://gitlab.freedesktop.org/drm/intel/issues/747
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#88]: https://gitlab.freedesktop.org/drm/intel/issues/88
[k.org#204565]: https://bugzilla.kernel.org/show_bug.cgi?id=204565
Participating hosts (10 -> 11)
------------------------------
Additional (1): pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7563 -> Patchwork_15750
CI-20190529: 20190529
CI_DRM_7563: aa81d2aa468b726e50faba4a455efae4c4be2a67 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15750: 78e6434185eb07eaf4410704fa7401dc8bb62e44 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15750/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2019-12-13 17:17 ` Ville Syrjälä
@ 2020-03-07 22:13 ` Chris Wilson
2020-03-09 14:21 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2020-03-07 22:13 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Quoting Ville Syrjälä (2019-12-13 17:17:39)
> On Fri, Dec 13, 2019 at 07:06:01PM +0200, Ville Syrjälä wrote:
> > On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote:
> > > Quoting Ville Syrjala (2019-12-13 15:28:23)
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > Include dev_name() in the tracpoints so one can filter based on
> > > > the device.
> > > >
> > > > Example:
> > > > echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
> > > >
> > > > TODO: maybe don't both specifying the field name always and just
> > > > make it 'dev' (or whatever) always?
> > > > TODO: add for other tracpoints too if this is deemed good enough
> > > >
> > > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> > > > 1 file changed, 65 insertions(+), 31 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> > > > index 7ef7a1e1664c..8931b6756f44 100644
> > > > --- a/drivers/gpu/drm/i915/i915_trace.h
> > > > +++ b/drivers/gpu/drm/i915/i915_trace.h
> > > > @@ -20,11 +20,18 @@
> > > >
> > > > /* watermark/fifo updates */
> > > >
> > > > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> > > > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> > > > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> > > > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> > > > +#define __get_dev_name(field) __get_str(field)
> > >
> > > Storing the string is quite expensive, I thought. Can we stash the i915
> > > and stringify in the TP_printk? Or is stashing the string the secret for
> > > the dev== filter?
> >
> > Last time I stashed a pointer in there people complained that it can
> > disappear before being consumed and cause a very theoretical oops.
> > But I guess we could stash just the pci devfn and whatnot.
>
> I believe 'domain + bus + devfn' would amount to 4 bytes. The downside
> is that it'd be just an integer so we'd lose the dev=domain:bus:dev.fn
> syntax for the filter. Suppose I could try to implement a new filter
> type for it, but no guarantees that would get accepted. Seems a bit too
> pci specific for kernel/trace/.
Put the name string in there, it's simplest and most foolproof.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2020-03-07 22:13 ` Chris Wilson
@ 2020-03-09 14:21 ` Ville Syrjälä
2020-03-09 14:24 ` Chris Wilson
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2020-03-09 14:21 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Sat, Mar 07, 2020 at 10:13:10PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjälä (2019-12-13 17:17:39)
> > On Fri, Dec 13, 2019 at 07:06:01PM +0200, Ville Syrjälä wrote:
> > > On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote:
> > > > Quoting Ville Syrjala (2019-12-13 15:28:23)
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > Include dev_name() in the tracpoints so one can filter based on
> > > > > the device.
> > > > >
> > > > > Example:
> > > > > echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
> > > > >
> > > > > TODO: maybe don't both specifying the field name always and just
> > > > > make it 'dev' (or whatever) always?
> > > > > TODO: add for other tracpoints too if this is deemed good enough
> > > > >
> > > > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> > > > > 1 file changed, 65 insertions(+), 31 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> > > > > index 7ef7a1e1664c..8931b6756f44 100644
> > > > > --- a/drivers/gpu/drm/i915/i915_trace.h
> > > > > +++ b/drivers/gpu/drm/i915/i915_trace.h
> > > > > @@ -20,11 +20,18 @@
> > > > >
> > > > > /* watermark/fifo updates */
> > > > >
> > > > > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> > > > > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> > > > > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> > > > > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> > > > > +#define __get_dev_name(field) __get_str(field)
> > > >
> > > > Storing the string is quite expensive, I thought. Can we stash the i915
> > > > and stringify in the TP_printk? Or is stashing the string the secret for
> > > > the dev== filter?
> > >
> > > Last time I stashed a pointer in there people complained that it can
> > > disappear before being consumed and cause a very theoretical oops.
> > > But I guess we could stash just the pci devfn and whatnot.
> >
> > I believe 'domain + bus + devfn' would amount to 4 bytes. The downside
> > is that it'd be just an integer so we'd lose the dev=domain:bus:dev.fn
> > syntax for the filter. Suppose I could try to implement a new filter
> > type for it, but no guarantees that would get accepted. Seems a bit too
> > pci specific for kernel/trace/.
>
> Put the name string in there, it's simplest and most foolproof.
You mean just go with the original patch?
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints
2020-03-09 14:21 ` Ville Syrjälä
@ 2020-03-09 14:24 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2020-03-09 14:24 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Quoting Ville Syrjälä (2020-03-09 14:21:20)
> On Sat, Mar 07, 2020 at 10:13:10PM +0000, Chris Wilson wrote:
> > Quoting Ville Syrjälä (2019-12-13 17:17:39)
> > > On Fri, Dec 13, 2019 at 07:06:01PM +0200, Ville Syrjälä wrote:
> > > > On Fri, Dec 13, 2019 at 03:54:33PM +0000, Chris Wilson wrote:
> > > > > Quoting Ville Syrjala (2019-12-13 15:28:23)
> > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > >
> > > > > > Include dev_name() in the tracpoints so one can filter based on
> > > > > > the device.
> > > > > >
> > > > > > Example:
> > > > > > echo 'dev=="0000:00:02.0"' > events/i915/intel_cpu_fifo_underrun/filter
> > > > > >
> > > > > > TODO: maybe don't both specifying the field name always and just
> > > > > > make it 'dev' (or whatever) always?
> > > > > > TODO: add for other tracpoints too if this is deemed good enough
> > > > > >
> > > > > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > > ---
> > > > > > drivers/gpu/drm/i915/i915_trace.h | 96 +++++++++++++++++++++----------
> > > > > > 1 file changed, 65 insertions(+), 31 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> > > > > > index 7ef7a1e1664c..8931b6756f44 100644
> > > > > > --- a/drivers/gpu/drm/i915/i915_trace.h
> > > > > > +++ b/drivers/gpu/drm/i915/i915_trace.h
> > > > > > @@ -20,11 +20,18 @@
> > > > > >
> > > > > > /* watermark/fifo updates */
> > > > > >
> > > > > > +#define __dev_name_i915(field, i915) __string(field, dev_name((i915)->drm.dev))
> > > > > > +#define __dev_name_crtc(field, crtc) __string(field, dev_name((crtc)->base.dev->dev))
> > > > > > +#define __assign_dev_name_i915(field, i915) __assign_str(field, dev_name((i915)->drm.dev))
> > > > > > +#define __assign_dev_name_crtc(field, crtc) __assign_str(field, dev_name((crtc)->base.dev->dev))
> > > > > > +#define __get_dev_name(field) __get_str(field)
> > > > >
> > > > > Storing the string is quite expensive, I thought. Can we stash the i915
> > > > > and stringify in the TP_printk? Or is stashing the string the secret for
> > > > > the dev== filter?
> > > >
> > > > Last time I stashed a pointer in there people complained that it can
> > > > disappear before being consumed and cause a very theoretical oops.
> > > > But I guess we could stash just the pci devfn and whatnot.
> > >
> > > I believe 'domain + bus + devfn' would amount to 4 bytes. The downside
> > > is that it'd be just an integer so we'd lose the dev=domain:bus:dev.fn
> > > syntax for the filter. Suppose I could try to implement a new filter
> > > type for it, but no guarantees that would get accepted. Seems a bit too
> > > pci specific for kernel/trace/.
> >
> > Put the name string in there, it's simplest and most foolproof.
>
> You mean just go with the original patch?
Yes. There doesn't seem to be a clear winner, so go with what works
already. For the record, we have dev=%d % i915->drm.primary->index
elsewhere.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-03-09 14:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 15:28 [Intel-gfx] [PATCH] drm/i915: Add device name to display tracepoints Ville Syrjala
2019-12-13 15:54 ` Chris Wilson
2019-12-13 17:06 ` Ville Syrjälä
2019-12-13 17:17 ` Ville Syrjälä
2020-03-07 22:13 ` Chris Wilson
2020-03-09 14:21 ` Ville Syrjälä
2020-03-09 14:24 ` Chris Wilson
2019-12-13 21:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-12-13 22:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-14 19:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.