From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B4BC43603 for ; Fri, 13 Dec 2019 21:27:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D2924125 for ; Fri, 13 Dec 2019 21:27:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F68vm6hK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D2924125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifoG5-0000pn-Jd for qemu-devel@archiver.kernel.org; Fri, 13 Dec 2019 11:57:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39851) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifoFS-0000L3-91 for qemu-devel@nongnu.org; Fri, 13 Dec 2019 11:57:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifoFP-0004uY-IP for qemu-devel@nongnu.org; Fri, 13 Dec 2019 11:57:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:45532 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifoFP-0004sg-Db for qemu-devel@nongnu.org; Fri, 13 Dec 2019 11:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576256218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pq7lolIRfKv7T5Xf3TIhvB5H/tc/hMMwKGM+sW3QDH0=; b=F68vm6hKYNa99GOXWZr0ZqM/UIFxskav5TijPnt045Ef/YgC8QXR1GGO+3Swb73aL8E5M1 qgWzcGJtWeok1W7tqhyY4glF3obZHg2X/kFOkvoivnpGK6ICRDNINUpxQYyCrjiJcSZnZl B+Lg4UiSooRy4THLBjXUYlJYnKPCFTg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-VaHvOFBAM-a0pVsixn_2OQ-1; Fri, 13 Dec 2019 11:56:56 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C52264A7E; Fri, 13 Dec 2019 16:56:55 +0000 (UTC) Received: from work-vm (unknown [10.36.117.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67F6461F37; Fri, 13 Dec 2019 16:56:52 +0000 (UTC) Date: Fri, 13 Dec 2019 16:56:49 +0000 From: "Dr. David Alan Gilbert" To: Liam Merwick Subject: Re: [PATCH 025/104] virtiofsd: Add Makefile wiring for virtiofsd contrib Message-ID: <20191213165649.GN3713@work-vm> References: <20191212163904.159893-1-dgilbert@redhat.com> <20191212163904.159893-26-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.13.0 (2019-11-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: VaHvOFBAM-a0pVsixn_2OQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Liam Merwick (liam.merwick@oracle.com) wrote: > On 12/12/2019 16:37, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > >=20 > > Wire up the building of the virtiofsd in contrib. >=20 > s/contrib/tools/ Ah! My sed of s-contrib/virtiofsd-tools/virtiofsd- wasn't smart enough for that! > otherwise >=20 > Reviewed-by: Liam Merwick Thanks. Dave >=20 > >=20 > > virtiofsd relies on Linux-specific system calls and seccomp. Anyone > > wishing to port it to other host operating systems should do so > > carefully and without reducing security. > >=20 > > Only allow building on Linux hosts. > >=20 > > Signed-off-by: Dr. David Alan Gilbert > > Signed-off-by: Stefan Hajnoczi > > --- > > Makefile | 8 ++++++++ > > Makefile.objs | 1 + > > tools/virtiofsd/Makefile.objs | 10 ++++++++++ > > 3 files changed, 19 insertions(+) > > create mode 100644 tools/virtiofsd/Makefile.objs > >=20 > > diff --git a/Makefile b/Makefile > > index b437a346d7..b7f7019a50 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -322,6 +322,8 @@ HELPERS-y =3D > > HELPERS-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_LINUX)) =3D qemu-bridg= e-helper$(EXESUF) > > ifdef CONFIG_LINUX > > +HELPERS-y +=3D virtiofsd$(EXESUF) > > + > > ifdef CONFIG_VIRGL > > ifdef CONFIG_GBM > > HELPERS-y +=3D vhost-user-gpu$(EXESUF) > > @@ -430,6 +432,7 @@ dummy :=3D $(call unnest-vars,, \ > > elf2dmp-obj-y \ > > ivshmem-client-obj-y \ > > ivshmem-server-obj-y \ > > + virtiofsd-obj-y \ > > rdmacm-mux-obj-y \ > > libvhost-user-obj-y \ > > vhost-user-scsi-obj-y \ > > @@ -674,6 +677,11 @@ rdmacm-mux$(EXESUF): LIBS +=3D "-libumad" > > rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS) > > =09$(call LINK, $^) > > +ifdef CONFIG_LINUX # relies on Linux-specific syscalls > > +virtiofsd$(EXESUF): $(virtiofsd-obj-y) libvhost-user.a $(COMMON_LDADDS= ) > > +=09$(call LINK, $^) > > +endif > > + > > vhost-user-gpu$(EXESUF): $(vhost-user-gpu-obj-y) $(libvhost-user-obj-= y) libqemuutil.a libqemustub.a > > =09$(call LINK, $^) > > diff --git a/Makefile.objs b/Makefile.objs > > index 11ba1a36bd..b5f667a4ba 100644 > > --- a/Makefile.objs > > +++ b/Makefile.objs > > @@ -125,6 +125,7 @@ vhost-user-blk-obj-y =3D contrib/vhost-user-blk/ > > rdmacm-mux-obj-y =3D contrib/rdmacm-mux/ > > vhost-user-input-obj-y =3D contrib/vhost-user-input/ > > vhost-user-gpu-obj-y =3D contrib/vhost-user-gpu/ > > +virtiofsd-obj-y =3D tools/virtiofsd/ > > #####################################################################= # > > trace-events-subdirs =3D > > diff --git a/tools/virtiofsd/Makefile.objs b/tools/virtiofsd/Makefile.o= bjs > > new file mode 100644 > > index 0000000000..67be16332c > > --- /dev/null > > +++ b/tools/virtiofsd/Makefile.objs > > @@ -0,0 +1,10 @@ > > +virtiofsd-obj-y =3D buffer.o \ > > + fuse_opt.o \ > > + fuse_log.o \ > > + fuse_loop_mt.o \ > > + fuse_lowlevel.o \ > > + fuse_signals.o \ > > + fuse_virtio.o \ > > + helper.o \ > > + passthrough_ll.o > > + > >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK