From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE640C2D0C9 for ; Fri, 13 Dec 2019 21:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E729E24682 for ; Fri, 13 Dec 2019 21:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576271195; bh=TLRFub19ZhaITE7YjcFkEHRBA0pszoIN5RnRY1gDYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=U1Tys7FYaKul73/z44cNJ/Bl6FjLU4H7MqO3y05UcvzPngK6xomcicXdDjQVfHdSu XMmmGLuCA3p0Xwzqz5xPYjnucYmAKXLPDVtG+7WxTd98JpR5emrQYVG0KrETyO8pXm GafRaCaQ3gNLpnmr8AgkkW8ubZjN6T9rAKjDR6jM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfLMVGf (ORCPT ); Fri, 13 Dec 2019 16:06:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:45758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfLMVGe (ORCPT ); Fri, 13 Dec 2019 16:06:34 -0500 Received: from localhost (mobile-166-170-223-177.mycingular.net [166.170.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D28C62467A; Fri, 13 Dec 2019 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576271193; bh=TLRFub19ZhaITE7YjcFkEHRBA0pszoIN5RnRY1gDYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=E/BnZTX+a8LiIkE6EdBlArJFLe2i3cC9dAJ9uaJzsx+hIy4Neio9I5tQwh+XcB08d YZV1mMNvJ1mDG0o5Vz+DTW3Xm51ca/KJWDwKJavT60c/lw5iWIrjQWfoEI7HKwPIq7 9Ynq21FilKYcUtvUrWHTkFAx9x5ELRCpRpV7Bpkg= Date: Fri, 13 Dec 2019 15:06:31 -0600 From: Bjorn Helgaas To: Lad Prabhakar Cc: Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Frank Rowand , Gustavo Pimentel , Jingoo Han , Simon Horman , Shawn Lin , Tom Joseph , Heiko Stuebner , linux-rockchip@lists.infradead.org, "Lad, Prabhakar" Subject: Re: [v2 1/6] pci: pcie-rcar: preparation for adding endpoint support Message-ID: <20191213185011.GA170447@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213084748.11210-2-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2019 at 08:47:43AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch prepares for adding endpoint support to rcar controller, > there are no functional changes with this patch, a common file is > created so that it can be shared with endpoint driver. Alongside > this patch fixes checkpatch reported issues. Can you please split this into: - a patch that moves code only, with no other changes except any necessary Kconfig and Makefile changes - another patch that fixes the checkpatch things When the checkpatch fixes are buried in the code move, it's impossible to review them. > Signed-off-by: Lad, Prabhakar > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1056 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 129 ++++ > 6 files changed, 1242 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [v2 1/6] pci: pcie-rcar: preparation for adding endpoint support Date: Fri, 13 Dec 2019 15:06:31 -0600 Message-ID: <20191213185011.GA170447@google.com> References: <20191213084748.11210-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191213084748.11210-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Sender: linux-kernel-owner@vger.kernel.org To: Lad Prabhakar Cc: Rob Herring , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Chris Paterson Frank Rowand List-Id: linux-rockchip.vger.kernel.org On Fri, Dec 13, 2019 at 08:47:43AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch prepares for adding endpoint support to rcar controller, > there are no functional changes with this patch, a common file is > created so that it can be shared with endpoint driver. Alongside > this patch fixes checkpatch reported issues. Can you please split this into: - a patch that moves code only, with no other changes except any necessary Kconfig and Makefile changes - another patch that fixes the checkpatch things When the checkpatch fixes are buried in the code move, it's impossible to review them. > Signed-off-by: Lad, Prabhakar > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1056 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 129 ++++ > 6 files changed, 1242 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FAKE_REPLY_C,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6CBC2D0C9 for ; Fri, 13 Dec 2019 22:31:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7BC020706 for ; Fri, 13 Dec 2019 22:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JYu8K9aY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="E/BnZTX+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7BC020706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=59Ou0XWaGX08zWLlbh5963f8LJz6W3GROUtcNZKkgjQ=; b=JYu8K9aY8c20UF 1+cEumeUfKJUZIAeklEvKs//BLUJUWmDSHEt81atCq5Yb08efDvpMEmbR4B+U/eQxEEEc1g4HQd8m 52uteQa8IjuN3dHzvDc8SQZDAJf2XdDsKvLjunndqeA9vVI3OSoJGAGoL+KuRUYzs93R61ENGYa1W UADE2GMsO4UaXhsaGfuSRRuptcMc2GasUaEgQkIBqk1jOZ1TJdA+LnpnMwufadWSU92fN00CakotQ VHoXUjQJSgsGt9Skl0EkAyhuPn1KrGd0vVAhebd7a/o+Tsv75lzg1K/FU6aLJm073MD/MWwHyQSya e8XqOsZhYDschbOLMk3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifs96-0006sk-DV; Fri, 13 Dec 2019 21:06:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifs8w-0006lE-Ja; Fri, 13 Dec 2019 21:06:36 +0000 Received: from localhost (mobile-166-170-223-177.mycingular.net [166.170.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D28C62467A; Fri, 13 Dec 2019 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576271193; bh=TLRFub19ZhaITE7YjcFkEHRBA0pszoIN5RnRY1gDYLs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=E/BnZTX+a8LiIkE6EdBlArJFLe2i3cC9dAJ9uaJzsx+hIy4Neio9I5tQwh+XcB08d YZV1mMNvJ1mDG0o5Vz+DTW3Xm51ca/KJWDwKJavT60c/lw5iWIrjQWfoEI7HKwPIq7 9Ynq21FilKYcUtvUrWHTkFAx9x5ELRCpRpV7Bpkg= Date: Fri, 13 Dec 2019 15:06:31 -0600 From: Bjorn Helgaas To: Lad Prabhakar Subject: Re: [v2 1/6] pci: pcie-rcar: preparation for adding endpoint support Message-ID: <20191213185011.GA170447@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213084748.11210-2-prabhakar.mahadev-lad.rj@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_130634_689036_6BFD6EFA X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Heiko Stuebner , Geert Uytterhoeven , linux-pci@vger.kernel.org, Shawn Lin , Frank Rowand , Marek Vasut , Lorenzo Pieralisi , Will Deacon , Magnus Damm , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Catalin Marinas , devicetree@vger.kernel.org, Chris Paterson , Arnd Bergmann , "Lad, Prabhakar" , Rob Herring , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Tom Joseph , Simon Horman , Jingoo Han , Andrew Murray , Gustavo Pimentel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 13, 2019 at 08:47:43AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch prepares for adding endpoint support to rcar controller, > there are no functional changes with this patch, a common file is > created so that it can be shared with endpoint driver. Alongside > this patch fixes checkpatch reported issues. Can you please split this into: - a patch that moves code only, with no other changes except any necessary Kconfig and Makefile changes - another patch that fixes the checkpatch things When the checkpatch fixes are buried in the code move, it's impossible to review them. > Signed-off-by: Lad, Prabhakar > --- > arch/arm64/configs/defconfig | 2 +- > drivers/pci/controller/Kconfig | 4 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 1056 ++++++++++++++++++++++++++ > drivers/pci/controller/pcie-rcar.c | 1229 ++----------------------------- > drivers/pci/controller/pcie-rcar.h | 129 ++++ > 6 files changed, 1242 insertions(+), 1180 deletions(-) > create mode 100644 drivers/pci/controller/pcie-rcar-host.c > create mode 100644 drivers/pci/controller/pcie-rcar.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel