From: Eduardo Habkost <ehabkost@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: "Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()
Date: Fri, 13 Dec 2019 17:08:17 -0300 [thread overview]
Message-ID: <20191213200817.GG498046@habkost.net> (raw)
In-Reply-To: <7c698f75-5be4-de98-2e8a-c271ae4c28d8@redhat.com>
On Sun, Dec 08, 2019 at 12:44:16AM +1100, Gavin Shan wrote:
> On 12/7/19 8:48 PM, Philippe Mathieu-Daudé wrote:
> > There is no declaration of the 'NMI' type. INTERFACE_CHECK()
> > returns an abstract type (see commit aa1b35b975d8). The abstract
> > type corresponding to the TYPE_NMI interface is 'NMIState'.
> >
> > Fixes: 9cb805fd267
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
Queued, thanks!
--
Eduardo
prev parent reply other threads:[~2019-12-13 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 9:48 [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK() Philippe Mathieu-Daudé
2019-12-07 13:44 ` Gavin Shan
2019-12-13 20:08 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213200817.GG498046@habkost.net \
--to=ehabkost@redhat.com \
--cc=aik@ozlabs.ru \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.