From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EF5C2D0C9 for ; Fri, 13 Dec 2019 21:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B07E24125 for ; Fri, 13 Dec 2019 21:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576272862; bh=i308i35R2GxOxkZnEOSRWTojjzXiolt5uBVw41WsxaY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kETjb7RUXn7kstRU6PH6scdb98bkNL9b/7DP5D6MmdlKtYmn8vkatSyOSVd5HoghF /skWENfrzRa9Qy8A6kWyy2qXS0M/ni35/YACO3jk0lHJTwM8234zUor+uL9lTtzMl9 lfn3TEjRIXnr6fJ1mKoADgpbC0NJTyvgGYryDjFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbfLMVeV (ORCPT ); Fri, 13 Dec 2019 16:34:21 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:37772 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbfLMVeV (ORCPT ); Fri, 13 Dec 2019 16:34:21 -0500 Received: by mail-ot1-f67.google.com with SMTP id k14so746052otn.4; Fri, 13 Dec 2019 13:34:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CnL0ppP0hu7PBsUqVprgfTmViSxAVBY2hM4t+lEup30=; b=KfLYesjRMXVEv5JsN9TJ0Z8DO4bfG0oqoO18/D4lEYVhPwP/dcaaqB+uIynRrnuOdc Zf9S630/ZLJ9Ub4ftx++e7KHSoZb3hPtkqPSXQV/dLjYyNqXP3kLl15YZlCF90OD57zR SItJXIdOpW4Y6eGFaGcq374RcyjUVK9ftiZKiAFyK26YeISxqt0e+mP5VyJ4sOywJFwd bC8AjB03hZfH2ELBQ1Qiz03d1O0Foc7PO2hVZCC4LzHnY3pJXUxdkS5ISK1Vnuw0WsX2 o572auBBovnGBB050+neKe4vrLRqREzpwPUxKshUL17pn3bNNgratq3R18j0K7IWEeXP QwwA== X-Gm-Message-State: APjAAAXnULB8J0UaOvzixqyJou9UoRgSm03gGTnUl4bbDCkiJwx5EBAS bb0DnxWZGNX3iixsyHnQrg== X-Google-Smtp-Source: APXvYqxtLmwCSQzcGbNdN9x9BipFNkJ2YdICwPsaYd45wZnOrdGRLQWzOOV9fMbVNvAU4hoYVvYkLw== X-Received: by 2002:a9d:6181:: with SMTP id g1mr17366399otk.104.1576272860189; Fri, 13 Dec 2019 13:34:20 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a16sm3798678otd.64.2019.12.13.13.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 13:34:19 -0800 (PST) Date: Fri, 13 Dec 2019 15:34:18 -0600 From: Rob Herring To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Mark Rutland , Mark Brown , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, Linus Walleij , linux-spi@vger.kernel.org Subject: Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes Message-ID: <20191213213418.GA17361@bogus> References: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote: > Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO > descriptors"), the prefered way to define chipselect GPIOs is using > 'cs-gpios' property instead of the legacy 'gpios' property. This will break using a new dtb on a kernel without the above commit. Or with any OS that never made the change. I'm fine with the doc change, but you should keep 'gpios' as deprecated. > > Signed-off-by: Christophe Leroy > --- > Documentation/devicetree/bindings/spi/fsl-spi.txt | 8 ++++---- > arch/powerpc/boot/dts/mgcoge.dts | 2 +- > arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +- > arch/powerpc/boot/dts/mpc8610_hpcd.dts | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0E6C43603 for ; Fri, 13 Dec 2019 21:36:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CA7A206C3 for ; Fri, 13 Dec 2019 21:36:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CA7A206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47ZPBd3SPWzDrL1 for ; Sat, 14 Dec 2019 08:36:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.66; helo=mail-ot1-f66.google.com; envelope-from=robherring2@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47ZP7h01trzDrJV for ; Sat, 14 Dec 2019 08:34:23 +1100 (AEDT) Received: by mail-ot1-f66.google.com with SMTP id 77so730418oty.6 for ; Fri, 13 Dec 2019 13:34:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CnL0ppP0hu7PBsUqVprgfTmViSxAVBY2hM4t+lEup30=; b=kVLFo5cxaUGeCAEjWBvQg4m6s6hhzQfVAhLgvHyqXOrAyI12PkXMV7Mity49i/6Tdd JrCWuPTfA/UGn4Sk2gMh5NPEVGUKJBokwdAjex8GKLDMBQ2ilfB5N7y8Vea4mjRCeuLs dcxzHPQSBrDwyws9s88NQsPzdgafX175O0wKo/vIYm4cw3BTeUgnf4g03vvyW3qEjdph MyqPFNai9XKsqersFXd5qF8m4cIqPBNZihMKIdPWRKUAFAVuv4QJcdvAPY64Wk3+tZ57 xzHRYncFmUpmZUX0GjP8RH1OV8i/+4MhU2WtyfbKQZwTFRCKRRY7yoFv5uJio3eQFN9o iRqw== X-Gm-Message-State: APjAAAUkE5hgSYTtzpV6tTZd4BkXXI28g0kXvlaCK6HVF61RhPs57N27 162nOhu+LljkMsZ935ql+A== X-Google-Smtp-Source: APXvYqxtLmwCSQzcGbNdN9x9BipFNkJ2YdICwPsaYd45wZnOrdGRLQWzOOV9fMbVNvAU4hoYVvYkLw== X-Received: by 2002:a9d:6181:: with SMTP id g1mr17366399otk.104.1576272860189; Fri, 13 Dec 2019 13:34:20 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id a16sm3798678otd.64.2019.12.13.13.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 13:34:19 -0800 (PST) Date: Fri, 13 Dec 2019 15:34:18 -0600 From: Rob Herring To: Christophe Leroy Subject: Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes Message-ID: <20191213213418.GA17361@bogus> References: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote: > Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO > descriptors"), the prefered way to define chipselect GPIOs is using > 'cs-gpios' property instead of the legacy 'gpios' property. This will break using a new dtb on a kernel without the above commit. Or with any OS that never made the change. I'm fine with the doc change, but you should keep 'gpios' as deprecated. > > Signed-off-by: Christophe Leroy > --- > Documentation/devicetree/bindings/spi/fsl-spi.txt | 8 ++++---- > arch/powerpc/boot/dts/mgcoge.dts | 2 +- > arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +- > arch/powerpc/boot/dts/mpc8610_hpcd.dts | 2 +- > 4 files changed, 7 insertions(+), 7 deletions(-)