All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 14:24 ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Annoyingly __drm_atomic_helper_crtc_reset() does two
totally separate things:
a) reset the state to defaults values
b) assign the crtc->state pointer

I just want a) without the b) so let's split out part
a) into __drm_atomic_helper_crtc_state_reset(). And
of course we'll do the same thing for planes and connectors.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
 include/drm/drm_atomic_state_helper.h     |  6 ++
 2 files changed, 67 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
index d0a937fb0c56..a972068d58cf 100644
--- a/drivers/gpu/drm/drm_atomic_state_helper.c
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
@@ -57,6 +57,22 @@
  * for these functions.
  */
 
+/**
+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
+ * @crtc_state: atomic CRTC state, must not be NULL
+ * @crtc: CRTC object, must not be NULL
+ *
+ * Initializes the newly allocated @crtc_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
+ */
+void
+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
+				     struct drm_crtc *crtc)
+{
+	crtc_state->crtc = crtc;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
+
 /**
  * __drm_atomic_helper_crtc_reset - reset state on CRTC
  * @crtc: drm CRTC
@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 			       struct drm_crtc_state *crtc_state)
 {
 	if (crtc_state)
-		crtc_state->crtc = crtc;
+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
 
 	crtc->state = crtc_state;
 }
@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
 
 /**
- * __drm_atomic_helper_plane_reset - resets planes state to default values
+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
+ * @plane_state: atomic plane state, must not be NULL
  * @plane: plane object, must not be NULL
- * @state: atomic plane state, must not be NULL
  *
- * Initializes plane state to default. This is useful for drivers that subclass
- * the plane state.
+ * Initializes the newly allocated @plane_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
  */
-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
-				     struct drm_plane_state *state)
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane)
 {
 	state->plane = plane;
 	state->rotation = DRM_MODE_ROTATE_0;
 
 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
 
-	plane->state = state;
+/**
+ * __drm_atomic_helper_plane_reset - reset state on plane
+ * @plane: drm plane
+ * @plane_state: plane state to assign
+ *
+ * Initializes the newly allocated @plane_state and assigns it to
+ * the &drm_crtc->state pointer of @plane, usually required when
+ * initializing the drivers or when called from the &drm_plane_funcs.reset
+ * hook.
+ *
+ * This is useful for drivers that subclass the plane state.
+ */
+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
+				     struct drm_plane_state *plane_state)
+{
+	if (plane_state)
+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
+
+	plane->state = plane_state;
 }
 EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
 
@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 }
 EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
 
+/**
+ * __drm_atomic_helper_connector_state_reset - reset the connector state
+ * @conn__state: atomic connector state, must not be NULL
+ * @connector: connectotr object, must not be NULL
+ *
+ * Initializes the newly allocated @conn_state with default
+ * values. This is useful for drivers that subclass the connector state.
+ */
+void
+__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					  struct drm_connector *connector)
+{
+	conn_state->connector = connector;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
+
 /**
  * __drm_atomic_helper_connector_reset - reset state on connector
  * @connector: drm connector
@@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 				    struct drm_connector_state *conn_state)
 {
 	if (conn_state)
-		conn_state->connector = connector;
+		__drm_atomic_helper_connector_state_reset(conn_state, connector);
 
 	connector->state = conn_state;
 }
diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
index e4577cc11689..8171dea4cc22 100644
--- a/include/drm/drm_atomic_state_helper.h
+++ b/include/drm/drm_atomic_state_helper.h
@@ -37,6 +37,8 @@ struct drm_private_state;
 struct drm_modeset_acquire_ctx;
 struct drm_device;
 
+void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
+					  struct drm_crtc *crtc);
 void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 				    struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
@@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 					  struct drm_crtc_state *state);
 
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane);
 void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
 				     struct drm_plane_state *state);
 void drm_atomic_helper_plane_reset(struct drm_plane *plane);
@@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
 void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 					  struct drm_plane_state *state);
 
+void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					       struct drm_connector *connector);
 void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 					 struct drm_connector_state *conn_state);
 void drm_atomic_helper_connector_reset(struct drm_connector *connector);
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 14:24 ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Annoyingly __drm_atomic_helper_crtc_reset() does two
totally separate things:
a) reset the state to defaults values
b) assign the crtc->state pointer

I just want a) without the b) so let's split out part
a) into __drm_atomic_helper_crtc_state_reset(). And
of course we'll do the same thing for planes and connectors.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
 include/drm/drm_atomic_state_helper.h     |  6 ++
 2 files changed, 67 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
index d0a937fb0c56..a972068d58cf 100644
--- a/drivers/gpu/drm/drm_atomic_state_helper.c
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
@@ -57,6 +57,22 @@
  * for these functions.
  */
 
+/**
+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
+ * @crtc_state: atomic CRTC state, must not be NULL
+ * @crtc: CRTC object, must not be NULL
+ *
+ * Initializes the newly allocated @crtc_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
+ */
+void
+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
+				     struct drm_crtc *crtc)
+{
+	crtc_state->crtc = crtc;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
+
 /**
  * __drm_atomic_helper_crtc_reset - reset state on CRTC
  * @crtc: drm CRTC
@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 			       struct drm_crtc_state *crtc_state)
 {
 	if (crtc_state)
-		crtc_state->crtc = crtc;
+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
 
 	crtc->state = crtc_state;
 }
@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
 
 /**
- * __drm_atomic_helper_plane_reset - resets planes state to default values
+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
+ * @plane_state: atomic plane state, must not be NULL
  * @plane: plane object, must not be NULL
- * @state: atomic plane state, must not be NULL
  *
- * Initializes plane state to default. This is useful for drivers that subclass
- * the plane state.
+ * Initializes the newly allocated @plane_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
  */
-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
-				     struct drm_plane_state *state)
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane)
 {
 	state->plane = plane;
 	state->rotation = DRM_MODE_ROTATE_0;
 
 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
 
-	plane->state = state;
+/**
+ * __drm_atomic_helper_plane_reset - reset state on plane
+ * @plane: drm plane
+ * @plane_state: plane state to assign
+ *
+ * Initializes the newly allocated @plane_state and assigns it to
+ * the &drm_crtc->state pointer of @plane, usually required when
+ * initializing the drivers or when called from the &drm_plane_funcs.reset
+ * hook.
+ *
+ * This is useful for drivers that subclass the plane state.
+ */
+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
+				     struct drm_plane_state *plane_state)
+{
+	if (plane_state)
+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
+
+	plane->state = plane_state;
 }
 EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
 
@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 }
 EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
 
+/**
+ * __drm_atomic_helper_connector_state_reset - reset the connector state
+ * @conn__state: atomic connector state, must not be NULL
+ * @connector: connectotr object, must not be NULL
+ *
+ * Initializes the newly allocated @conn_state with default
+ * values. This is useful for drivers that subclass the connector state.
+ */
+void
+__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					  struct drm_connector *connector)
+{
+	conn_state->connector = connector;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
+
 /**
  * __drm_atomic_helper_connector_reset - reset state on connector
  * @connector: drm connector
@@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 				    struct drm_connector_state *conn_state)
 {
 	if (conn_state)
-		conn_state->connector = connector;
+		__drm_atomic_helper_connector_state_reset(conn_state, connector);
 
 	connector->state = conn_state;
 }
diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
index e4577cc11689..8171dea4cc22 100644
--- a/include/drm/drm_atomic_state_helper.h
+++ b/include/drm/drm_atomic_state_helper.h
@@ -37,6 +37,8 @@ struct drm_private_state;
 struct drm_modeset_acquire_ctx;
 struct drm_device;
 
+void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
+					  struct drm_crtc *crtc);
 void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 				    struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
@@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 					  struct drm_crtc_state *state);
 
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane);
 void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
 				     struct drm_plane_state *state);
 void drm_atomic_helper_plane_reset(struct drm_plane *plane);
@@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
 void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 					  struct drm_plane_state *state);
 
+void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					       struct drm_connector *connector);
 void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 					 struct drm_connector_state *conn_state);
 void drm_atomic_helper_connector_reset(struct drm_connector *connector);
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 14:24 ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Annoyingly __drm_atomic_helper_crtc_reset() does two
totally separate things:
a) reset the state to defaults values
b) assign the crtc->state pointer

I just want a) without the b) so let's split out part
a) into __drm_atomic_helper_crtc_state_reset(). And
of course we'll do the same thing for planes and connectors.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
 include/drm/drm_atomic_state_helper.h     |  6 ++
 2 files changed, 67 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
index d0a937fb0c56..a972068d58cf 100644
--- a/drivers/gpu/drm/drm_atomic_state_helper.c
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
@@ -57,6 +57,22 @@
  * for these functions.
  */
 
+/**
+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
+ * @crtc_state: atomic CRTC state, must not be NULL
+ * @crtc: CRTC object, must not be NULL
+ *
+ * Initializes the newly allocated @crtc_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
+ */
+void
+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
+				     struct drm_crtc *crtc)
+{
+	crtc_state->crtc = crtc;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
+
 /**
  * __drm_atomic_helper_crtc_reset - reset state on CRTC
  * @crtc: drm CRTC
@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 			       struct drm_crtc_state *crtc_state)
 {
 	if (crtc_state)
-		crtc_state->crtc = crtc;
+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
 
 	crtc->state = crtc_state;
 }
@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
 
 /**
- * __drm_atomic_helper_plane_reset - resets planes state to default values
+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
+ * @plane_state: atomic plane state, must not be NULL
  * @plane: plane object, must not be NULL
- * @state: atomic plane state, must not be NULL
  *
- * Initializes plane state to default. This is useful for drivers that subclass
- * the plane state.
+ * Initializes the newly allocated @plane_state with default
+ * values. This is useful for drivers that subclass the CRTC state.
  */
-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
-				     struct drm_plane_state *state)
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane)
 {
 	state->plane = plane;
 	state->rotation = DRM_MODE_ROTATE_0;
 
 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
 
-	plane->state = state;
+/**
+ * __drm_atomic_helper_plane_reset - reset state on plane
+ * @plane: drm plane
+ * @plane_state: plane state to assign
+ *
+ * Initializes the newly allocated @plane_state and assigns it to
+ * the &drm_crtc->state pointer of @plane, usually required when
+ * initializing the drivers or when called from the &drm_plane_funcs.reset
+ * hook.
+ *
+ * This is useful for drivers that subclass the plane state.
+ */
+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
+				     struct drm_plane_state *plane_state)
+{
+	if (plane_state)
+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
+
+	plane->state = plane_state;
 }
 EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
 
@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 }
 EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
 
+/**
+ * __drm_atomic_helper_connector_state_reset - reset the connector state
+ * @conn__state: atomic connector state, must not be NULL
+ * @connector: connectotr object, must not be NULL
+ *
+ * Initializes the newly allocated @conn_state with default
+ * values. This is useful for drivers that subclass the connector state.
+ */
+void
+__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					  struct drm_connector *connector)
+{
+	conn_state->connector = connector;
+}
+EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
+
 /**
  * __drm_atomic_helper_connector_reset - reset state on connector
  * @connector: drm connector
@@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 				    struct drm_connector_state *conn_state)
 {
 	if (conn_state)
-		conn_state->connector = connector;
+		__drm_atomic_helper_connector_state_reset(conn_state, connector);
 
 	connector->state = conn_state;
 }
diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
index e4577cc11689..8171dea4cc22 100644
--- a/include/drm/drm_atomic_state_helper.h
+++ b/include/drm/drm_atomic_state_helper.h
@@ -37,6 +37,8 @@ struct drm_private_state;
 struct drm_modeset_acquire_ctx;
 struct drm_device;
 
+void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
+					  struct drm_crtc *crtc);
 void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
 				    struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
@@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
 void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
 					  struct drm_crtc_state *state);
 
+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
+					   struct drm_plane *plane);
 void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
 				     struct drm_plane_state *state);
 void drm_atomic_helper_plane_reset(struct drm_plane *plane);
@@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
 void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
 					  struct drm_plane_state *state);
 
+void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
+					       struct drm_connector *connector);
 void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
 					 struct drm_connector_state *conn_state);
 void drm_atomic_helper_connector_reset(struct drm_connector *connector);
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's get rid of the redundant intel_ prefix on our variables.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 32 ++++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 551de2baa569..8b889c9f29b5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -15838,14 +15838,14 @@ static const struct drm_crtc_funcs i8xx_crtc_funcs = {
 static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 {
 	const struct drm_crtc_funcs *funcs;
-	struct intel_crtc *intel_crtc;
+	struct intel_crtc *crtc;
 	struct intel_crtc_state *crtc_state = NULL;
 	struct intel_plane *primary = NULL;
 	struct intel_plane *cursor = NULL;
 	int sprite, ret;
 
-	intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL);
-	if (!intel_crtc)
+	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
+	if (!crtc)
 		return -ENOMEM;
 
 	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
@@ -15853,15 +15853,15 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = -ENOMEM;
 		goto fail;
 	}
-	__drm_atomic_helper_crtc_reset(&intel_crtc->base, &crtc_state->uapi);
-	intel_crtc->config = crtc_state;
+	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+	crtc->config = crtc_state;
 
 	primary = intel_primary_plane_create(dev_priv, pipe);
 	if (IS_ERR(primary)) {
 		ret = PTR_ERR(primary);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(primary->id);
+	crtc->plane_ids_mask |= BIT(primary->id);
 
 	for_each_sprite(dev_priv, pipe, sprite) {
 		struct intel_plane *plane;
@@ -15871,7 +15871,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			ret = PTR_ERR(plane);
 			goto fail;
 		}
-		intel_crtc->plane_ids_mask |= BIT(plane->id);
+		crtc->plane_ids_mask |= BIT(plane->id);
 	}
 
 	cursor = intel_cursor_plane_create(dev_priv, pipe);
@@ -15879,7 +15879,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = PTR_ERR(cursor);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(cursor->id);
+	crtc->plane_ids_mask |= BIT(cursor->id);
 
 	if (HAS_GMCH(dev_priv)) {
 		if (IS_CHERRYVIEW(dev_priv) ||
@@ -15900,32 +15900,32 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			funcs = &ilk_crtc_funcs;
 	}
 
-	ret = drm_crtc_init_with_planes(&dev_priv->drm, &intel_crtc->base,
+	ret = drm_crtc_init_with_planes(&dev_priv->drm, &crtc->base,
 					&primary->base, &cursor->base,
 					funcs, "pipe %c", pipe_name(pipe));
 	if (ret)
 		goto fail;
 
-	intel_crtc->pipe = pipe;
+	crtc->pipe = pipe;
 
 	/* initialize shared scalers */
-	intel_crtc_init_scalers(intel_crtc, crtc_state);
+	intel_crtc_init_scalers(crtc, crtc_state);
 
 	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
 	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
-	dev_priv->pipe_to_crtc_mapping[pipe] = intel_crtc;
+	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
 
 	if (INTEL_GEN(dev_priv) < 9) {
 		enum i9xx_plane_id i9xx_plane = primary->i9xx_plane;
 
 		BUG_ON(i9xx_plane >= ARRAY_SIZE(dev_priv->plane_to_crtc_mapping) ||
 		       dev_priv->plane_to_crtc_mapping[i9xx_plane] != NULL);
-		dev_priv->plane_to_crtc_mapping[i9xx_plane] = intel_crtc;
+		dev_priv->plane_to_crtc_mapping[i9xx_plane] = crtc;
 	}
 
-	intel_color_init(intel_crtc);
+	intel_color_init(crtc);
 
-	WARN_ON(drm_crtc_index(&intel_crtc->base) != intel_crtc->pipe);
+	WARN_ON(drm_crtc_index(&crtc->base) != crtc->pipe);
 
 	return 0;
 
@@ -15935,7 +15935,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	 * crtcs/planes already initialized.
 	 */
 	kfree(crtc_state);
-	kfree(intel_crtc);
+	kfree(crtc);
 
 	return ret;
 }
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's get rid of the redundant intel_ prefix on our variables.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 32 ++++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 551de2baa569..8b889c9f29b5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -15838,14 +15838,14 @@ static const struct drm_crtc_funcs i8xx_crtc_funcs = {
 static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 {
 	const struct drm_crtc_funcs *funcs;
-	struct intel_crtc *intel_crtc;
+	struct intel_crtc *crtc;
 	struct intel_crtc_state *crtc_state = NULL;
 	struct intel_plane *primary = NULL;
 	struct intel_plane *cursor = NULL;
 	int sprite, ret;
 
-	intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL);
-	if (!intel_crtc)
+	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
+	if (!crtc)
 		return -ENOMEM;
 
 	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
@@ -15853,15 +15853,15 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = -ENOMEM;
 		goto fail;
 	}
-	__drm_atomic_helper_crtc_reset(&intel_crtc->base, &crtc_state->uapi);
-	intel_crtc->config = crtc_state;
+	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+	crtc->config = crtc_state;
 
 	primary = intel_primary_plane_create(dev_priv, pipe);
 	if (IS_ERR(primary)) {
 		ret = PTR_ERR(primary);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(primary->id);
+	crtc->plane_ids_mask |= BIT(primary->id);
 
 	for_each_sprite(dev_priv, pipe, sprite) {
 		struct intel_plane *plane;
@@ -15871,7 +15871,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			ret = PTR_ERR(plane);
 			goto fail;
 		}
-		intel_crtc->plane_ids_mask |= BIT(plane->id);
+		crtc->plane_ids_mask |= BIT(plane->id);
 	}
 
 	cursor = intel_cursor_plane_create(dev_priv, pipe);
@@ -15879,7 +15879,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = PTR_ERR(cursor);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(cursor->id);
+	crtc->plane_ids_mask |= BIT(cursor->id);
 
 	if (HAS_GMCH(dev_priv)) {
 		if (IS_CHERRYVIEW(dev_priv) ||
@@ -15900,32 +15900,32 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			funcs = &ilk_crtc_funcs;
 	}
 
-	ret = drm_crtc_init_with_planes(&dev_priv->drm, &intel_crtc->base,
+	ret = drm_crtc_init_with_planes(&dev_priv->drm, &crtc->base,
 					&primary->base, &cursor->base,
 					funcs, "pipe %c", pipe_name(pipe));
 	if (ret)
 		goto fail;
 
-	intel_crtc->pipe = pipe;
+	crtc->pipe = pipe;
 
 	/* initialize shared scalers */
-	intel_crtc_init_scalers(intel_crtc, crtc_state);
+	intel_crtc_init_scalers(crtc, crtc_state);
 
 	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
 	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
-	dev_priv->pipe_to_crtc_mapping[pipe] = intel_crtc;
+	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
 
 	if (INTEL_GEN(dev_priv) < 9) {
 		enum i9xx_plane_id i9xx_plane = primary->i9xx_plane;
 
 		BUG_ON(i9xx_plane >= ARRAY_SIZE(dev_priv->plane_to_crtc_mapping) ||
 		       dev_priv->plane_to_crtc_mapping[i9xx_plane] != NULL);
-		dev_priv->plane_to_crtc_mapping[i9xx_plane] = intel_crtc;
+		dev_priv->plane_to_crtc_mapping[i9xx_plane] = crtc;
 	}
 
-	intel_color_init(intel_crtc);
+	intel_color_init(crtc);
 
-	WARN_ON(drm_crtc_index(&intel_crtc->base) != intel_crtc->pipe);
+	WARN_ON(drm_crtc_index(&crtc->base) != crtc->pipe);
 
 	return 0;
 
@@ -15935,7 +15935,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	 * crtcs/planes already initialized.
 	 */
 	kfree(crtc_state);
-	kfree(intel_crtc);
+	kfree(crtc);
 
 	return ret;
 }
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [Intel-gfx] [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's get rid of the redundant intel_ prefix on our variables.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 32 ++++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 551de2baa569..8b889c9f29b5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -15838,14 +15838,14 @@ static const struct drm_crtc_funcs i8xx_crtc_funcs = {
 static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 {
 	const struct drm_crtc_funcs *funcs;
-	struct intel_crtc *intel_crtc;
+	struct intel_crtc *crtc;
 	struct intel_crtc_state *crtc_state = NULL;
 	struct intel_plane *primary = NULL;
 	struct intel_plane *cursor = NULL;
 	int sprite, ret;
 
-	intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL);
-	if (!intel_crtc)
+	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
+	if (!crtc)
 		return -ENOMEM;
 
 	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
@@ -15853,15 +15853,15 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = -ENOMEM;
 		goto fail;
 	}
-	__drm_atomic_helper_crtc_reset(&intel_crtc->base, &crtc_state->uapi);
-	intel_crtc->config = crtc_state;
+	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+	crtc->config = crtc_state;
 
 	primary = intel_primary_plane_create(dev_priv, pipe);
 	if (IS_ERR(primary)) {
 		ret = PTR_ERR(primary);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(primary->id);
+	crtc->plane_ids_mask |= BIT(primary->id);
 
 	for_each_sprite(dev_priv, pipe, sprite) {
 		struct intel_plane *plane;
@@ -15871,7 +15871,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			ret = PTR_ERR(plane);
 			goto fail;
 		}
-		intel_crtc->plane_ids_mask |= BIT(plane->id);
+		crtc->plane_ids_mask |= BIT(plane->id);
 	}
 
 	cursor = intel_cursor_plane_create(dev_priv, pipe);
@@ -15879,7 +15879,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 		ret = PTR_ERR(cursor);
 		goto fail;
 	}
-	intel_crtc->plane_ids_mask |= BIT(cursor->id);
+	crtc->plane_ids_mask |= BIT(cursor->id);
 
 	if (HAS_GMCH(dev_priv)) {
 		if (IS_CHERRYVIEW(dev_priv) ||
@@ -15900,32 +15900,32 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 			funcs = &ilk_crtc_funcs;
 	}
 
-	ret = drm_crtc_init_with_planes(&dev_priv->drm, &intel_crtc->base,
+	ret = drm_crtc_init_with_planes(&dev_priv->drm, &crtc->base,
 					&primary->base, &cursor->base,
 					funcs, "pipe %c", pipe_name(pipe));
 	if (ret)
 		goto fail;
 
-	intel_crtc->pipe = pipe;
+	crtc->pipe = pipe;
 
 	/* initialize shared scalers */
-	intel_crtc_init_scalers(intel_crtc, crtc_state);
+	intel_crtc_init_scalers(crtc, crtc_state);
 
 	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
 	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
-	dev_priv->pipe_to_crtc_mapping[pipe] = intel_crtc;
+	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
 
 	if (INTEL_GEN(dev_priv) < 9) {
 		enum i9xx_plane_id i9xx_plane = primary->i9xx_plane;
 
 		BUG_ON(i9xx_plane >= ARRAY_SIZE(dev_priv->plane_to_crtc_mapping) ||
 		       dev_priv->plane_to_crtc_mapping[i9xx_plane] != NULL);
-		dev_priv->plane_to_crtc_mapping[i9xx_plane] = intel_crtc;
+		dev_priv->plane_to_crtc_mapping[i9xx_plane] = crtc;
 	}
 
-	intel_color_init(intel_crtc);
+	intel_color_init(crtc);
 
-	WARN_ON(drm_crtc_index(&intel_crtc->base) != intel_crtc->pipe);
+	WARN_ON(drm_crtc_index(&crtc->base) != crtc->pipe);
 
 	return 0;
 
@@ -15935,7 +15935,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	 * crtcs/planes already initialized.
 	 */
 	kfree(crtc_state);
-	kfree(intel_crtc);
+	kfree(crtc);
 
 	return ret;
 }
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc,free}()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We already have alloc/free helpers for planes, add the same for
crtcs. The main benefit is we get to move all the annoying state
initialization out of the main crtc_init() flow.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 74 ++++++++++----------
 1 file changed, 36 insertions(+), 38 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 8b889c9f29b5..e6291841053f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -164,8 +164,7 @@ static void vlv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
 static void chv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
-static void intel_crtc_init_scalers(struct intel_crtc *crtc,
-				    struct intel_crtc_state *crtc_state);
+static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state);
 static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state);
 static void ironlake_pfit_disable(const struct intel_crtc_state *old_crtc_state);
 static void ironlake_pfit_enable(const struct intel_crtc_state *crtc_state);
@@ -10656,7 +10655,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
 	u64 power_domain_mask;
 	bool active;
 
-	intel_crtc_init_scalers(crtc, pipe_config);
+	intel_crtc_init_scalers(pipe_config);
 
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
@@ -15746,25 +15745,12 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,
 	return ERR_PTR(ret);
 }
 
-static void intel_crtc_init_scalers(struct intel_crtc *crtc,
-				    struct intel_crtc_state *crtc_state)
+static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state)
 {
 	struct intel_crtc_scaler_state *scaler_state =
 		&crtc_state->scaler_state;
-	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-	int i;
-
-	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[crtc->pipe];
-	if (!crtc->num_scalers)
-		return;
-
-	for (i = 0; i < crtc->num_scalers; i++) {
-		struct intel_scaler *scaler = &scaler_state->scalers[i];
-
-		scaler->in_use = 0;
-		scaler->mode = 0;
-	}
 
+	memset(scaler_state, 0, sizeof(*scaler_state));
 	scaler_state->scaler_id = -1;
 }
 
@@ -15835,27 +15821,49 @@ static const struct drm_crtc_funcs i8xx_crtc_funcs = {
 	.disable_vblank = i8xx_disable_vblank,
 };
 
-static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
+static struct intel_crtc *intel_crtc_alloc(void)
 {
-	const struct drm_crtc_funcs *funcs;
+	struct intel_crtc_state *crtc_state;
 	struct intel_crtc *crtc;
-	struct intel_crtc_state *crtc_state = NULL;
-	struct intel_plane *primary = NULL;
-	struct intel_plane *cursor = NULL;
-	int sprite, ret;
 
 	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
 	if (!crtc)
-		return -ENOMEM;
+		return ERR_PTR(-ENOMEM);
 
 	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
 	if (!crtc_state) {
-		ret = -ENOMEM;
-		goto fail;
+		kfree(crtc);
+		return ERR_PTR(-ENOMEM);
 	}
+
 	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+	intel_crtc_init_scalers(crtc_state);
+
 	crtc->config = crtc_state;
 
+	return crtc;
+}
+
+static void intel_crtc_free(struct intel_crtc *crtc)
+{
+	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	kfree(crtc);
+}
+
+static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
+{
+	struct intel_plane *primary, *cursor;
+	const struct drm_crtc_funcs *funcs;
+	struct intel_crtc *crtc;
+	int sprite, ret;
+
+	crtc = intel_crtc_alloc();
+	if (IS_ERR(crtc))
+		return PTR_ERR(crtc);
+
+	crtc->pipe = pipe;
+	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[pipe];
+
 	primary = intel_primary_plane_create(dev_priv, pipe);
 	if (IS_ERR(primary)) {
 		ret = PTR_ERR(primary);
@@ -15906,11 +15914,6 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	if (ret)
 		goto fail;
 
-	crtc->pipe = pipe;
-
-	/* initialize shared scalers */
-	intel_crtc_init_scalers(crtc, crtc_state);
-
 	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
 	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
 	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
@@ -15930,12 +15933,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	return 0;
 
 fail:
-	/*
-	 * drm_mode_config_cleanup() will free up any
-	 * crtcs/planes already initialized.
-	 */
-	kfree(crtc_state);
-	kfree(crtc);
+	intel_crtc_free(crtc);
 
 	return ret;
 }
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [Intel-gfx] [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc, free}()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We already have alloc/free helpers for planes, add the same for
crtcs. The main benefit is we get to move all the annoying state
initialization out of the main crtc_init() flow.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 74 ++++++++++----------
 1 file changed, 36 insertions(+), 38 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 8b889c9f29b5..e6291841053f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -164,8 +164,7 @@ static void vlv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
 static void chv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
-static void intel_crtc_init_scalers(struct intel_crtc *crtc,
-				    struct intel_crtc_state *crtc_state);
+static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state);
 static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state);
 static void ironlake_pfit_disable(const struct intel_crtc_state *old_crtc_state);
 static void ironlake_pfit_enable(const struct intel_crtc_state *crtc_state);
@@ -10656,7 +10655,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
 	u64 power_domain_mask;
 	bool active;
 
-	intel_crtc_init_scalers(crtc, pipe_config);
+	intel_crtc_init_scalers(pipe_config);
 
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
@@ -15746,25 +15745,12 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,
 	return ERR_PTR(ret);
 }
 
-static void intel_crtc_init_scalers(struct intel_crtc *crtc,
-				    struct intel_crtc_state *crtc_state)
+static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state)
 {
 	struct intel_crtc_scaler_state *scaler_state =
 		&crtc_state->scaler_state;
-	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-	int i;
-
-	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[crtc->pipe];
-	if (!crtc->num_scalers)
-		return;
-
-	for (i = 0; i < crtc->num_scalers; i++) {
-		struct intel_scaler *scaler = &scaler_state->scalers[i];
-
-		scaler->in_use = 0;
-		scaler->mode = 0;
-	}
 
+	memset(scaler_state, 0, sizeof(*scaler_state));
 	scaler_state->scaler_id = -1;
 }
 
@@ -15835,27 +15821,49 @@ static const struct drm_crtc_funcs i8xx_crtc_funcs = {
 	.disable_vblank = i8xx_disable_vblank,
 };
 
-static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
+static struct intel_crtc *intel_crtc_alloc(void)
 {
-	const struct drm_crtc_funcs *funcs;
+	struct intel_crtc_state *crtc_state;
 	struct intel_crtc *crtc;
-	struct intel_crtc_state *crtc_state = NULL;
-	struct intel_plane *primary = NULL;
-	struct intel_plane *cursor = NULL;
-	int sprite, ret;
 
 	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
 	if (!crtc)
-		return -ENOMEM;
+		return ERR_PTR(-ENOMEM);
 
 	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
 	if (!crtc_state) {
-		ret = -ENOMEM;
-		goto fail;
+		kfree(crtc);
+		return ERR_PTR(-ENOMEM);
 	}
+
 	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+	intel_crtc_init_scalers(crtc_state);
+
 	crtc->config = crtc_state;
 
+	return crtc;
+}
+
+static void intel_crtc_free(struct intel_crtc *crtc)
+{
+	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
+	kfree(crtc);
+}
+
+static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
+{
+	struct intel_plane *primary, *cursor;
+	const struct drm_crtc_funcs *funcs;
+	struct intel_crtc *crtc;
+	int sprite, ret;
+
+	crtc = intel_crtc_alloc();
+	if (IS_ERR(crtc))
+		return PTR_ERR(crtc);
+
+	crtc->pipe = pipe;
+	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[pipe];
+
 	primary = intel_primary_plane_create(dev_priv, pipe);
 	if (IS_ERR(primary)) {
 		ret = PTR_ERR(primary);
@@ -15906,11 +15914,6 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	if (ret)
 		goto fail;
 
-	crtc->pipe = pipe;
-
-	/* initialize shared scalers */
-	intel_crtc_init_scalers(crtc, crtc_state);
-
 	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
 	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
 	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
@@ -15930,12 +15933,7 @@ static int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)
 	return 0;
 
 fail:
-	/*
-	 * drm_mode_config_cleanup() will free up any
-	 * crtcs/planes already initialized.
-	 */
-	kfree(crtc_state);
-	kfree(crtc);
+	intel_crtc_free(crtc);
 
 	return ret;
 }
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have a few places where we want to reset a crtc state to its
default values. Let's add a helper for that. We'll need the new
__drm_atomic_helper_crtc_state_reset() helper for this to allow
us to just reset the state itself without clobbering the
crtc->state pointer.

And while at it let's zero out the whole thing, except a few
choice member which we'll mark as "invalid". And thanks to this
we can now nuke intel_crtc_init_scalers().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 47 +++++++++-----------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index e6291841053f..fd4120533c3f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -164,7 +164,6 @@ static void vlv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
 static void chv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
-static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state);
 static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state);
 static void ironlake_pfit_disable(const struct intel_crtc_state *old_crtc_state);
 static void ironlake_pfit_enable(const struct intel_crtc_state *crtc_state);
@@ -10655,8 +10654,6 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
 	u64 power_domain_mask;
 	bool active;
 
-	intel_crtc_init_scalers(pipe_config);
-
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
 	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
@@ -11704,6 +11701,20 @@ static void ironlake_pch_clock_get(struct intel_crtc *crtc,
 					 &pipe_config->fdi_m_n);
 }
 
+static void intel_crtc_state_reset(struct intel_crtc_state *crtc_state,
+				   struct intel_crtc *crtc)
+{
+	memset(crtc_state, 0, sizeof(*crtc_state));
+
+	__drm_atomic_helper_crtc_state_reset(&crtc_state->uapi, &crtc->base);
+
+	crtc_state->cpu_transcoder = INVALID_TRANSCODER;
+	crtc_state->master_transcoder = INVALID_TRANSCODER;
+	crtc_state->hsw_workaround_pipe = INVALID_PIPE;
+	crtc_state->output_format = INTEL_OUTPUT_FORMAT_INVALID;
+	crtc_state->scaler_state.scaler_id = -1;
+}
+
 /* Returns the currently programmed mode of the given encoder. */
 struct drm_display_mode *
 intel_encoder_current_mode(struct intel_encoder *encoder)
@@ -11729,7 +11740,7 @@ intel_encoder_current_mode(struct intel_encoder *encoder)
 		return NULL;
 	}
 
-	crtc_state->uapi.crtc = &crtc->base;
+	intel_crtc_state_reset(crtc_state, crtc);
 
 	if (!dev_priv->display.get_pipe_config(crtc, crtc_state)) {
 		kfree(crtc_state);
@@ -13577,18 +13588,14 @@ verify_crtc_state(struct intel_crtc *crtc,
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_encoder *encoder;
-	struct intel_crtc_state *pipe_config;
-	struct drm_atomic_state *state;
+	struct intel_crtc_state *pipe_config = old_crtc_state;
+	struct drm_atomic_state *state = old_crtc_state->uapi.state;
 	bool active;
 
-	state = old_crtc_state->uapi.state;
 	__drm_atomic_helper_crtc_destroy_state(&old_crtc_state->uapi);
 	intel_crtc_free_hw_state(old_crtc_state);
-
-	pipe_config = old_crtc_state;
-	memset(pipe_config, 0, sizeof(*pipe_config));
-	pipe_config->uapi.crtc = &crtc->base;
-	pipe_config->uapi.state = state;
+	intel_crtc_state_reset(old_crtc_state, crtc);
+	old_crtc_state->uapi.state = state;
 
 	DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.base.id, crtc->base.name);
 
@@ -15745,15 +15752,6 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,
 	return ERR_PTR(ret);
 }
 
-static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state)
-{
-	struct intel_crtc_scaler_state *scaler_state =
-		&crtc_state->scaler_state;
-
-	memset(scaler_state, 0, sizeof(*scaler_state));
-	scaler_state->scaler_id = -1;
-}
-
 #define INTEL_CRTC_FUNCS \
 	.gamma_set = drm_atomic_helper_legacy_gamma_set, \
 	.set_config = drm_atomic_helper_set_config, \
@@ -15836,9 +15834,9 @@ static struct intel_crtc *intel_crtc_alloc(void)
 		return ERR_PTR(-ENOMEM);
 	}
 
-	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
-	intel_crtc_init_scalers(crtc_state);
+	intel_crtc_state_reset(crtc_state, crtc);
 
+	crtc->base.state = &crtc_state->uapi;
 	crtc->config = crtc_state;
 
 	return crtc;
@@ -17414,8 +17412,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
 
 		__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 		intel_crtc_free_hw_state(crtc_state);
-		memset(crtc_state, 0, sizeof(*crtc_state));
-		__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+		intel_crtc_state_reset(crtc_state, crtc);
 
 		crtc_state->hw.active = crtc_state->hw.enable =
 			dev_priv->display.get_pipe_config(crtc, crtc_state);
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [Intel-gfx] [PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We have a few places where we want to reset a crtc state to its
default values. Let's add a helper for that. We'll need the new
__drm_atomic_helper_crtc_state_reset() helper for this to allow
us to just reset the state itself without clobbering the
crtc->state pointer.

And while at it let's zero out the whole thing, except a few
choice member which we'll mark as "invalid". And thanks to this
we can now nuke intel_crtc_init_scalers().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 47 +++++++++-----------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index e6291841053f..fd4120533c3f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -164,7 +164,6 @@ static void vlv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
 static void chv_prepare_pll(struct intel_crtc *crtc,
 			    const struct intel_crtc_state *pipe_config);
-static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state);
 static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state);
 static void ironlake_pfit_disable(const struct intel_crtc_state *old_crtc_state);
 static void ironlake_pfit_enable(const struct intel_crtc_state *crtc_state);
@@ -10655,8 +10654,6 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
 	u64 power_domain_mask;
 	bool active;
 
-	intel_crtc_init_scalers(pipe_config);
-
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
 	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
@@ -11704,6 +11701,20 @@ static void ironlake_pch_clock_get(struct intel_crtc *crtc,
 					 &pipe_config->fdi_m_n);
 }
 
+static void intel_crtc_state_reset(struct intel_crtc_state *crtc_state,
+				   struct intel_crtc *crtc)
+{
+	memset(crtc_state, 0, sizeof(*crtc_state));
+
+	__drm_atomic_helper_crtc_state_reset(&crtc_state->uapi, &crtc->base);
+
+	crtc_state->cpu_transcoder = INVALID_TRANSCODER;
+	crtc_state->master_transcoder = INVALID_TRANSCODER;
+	crtc_state->hsw_workaround_pipe = INVALID_PIPE;
+	crtc_state->output_format = INTEL_OUTPUT_FORMAT_INVALID;
+	crtc_state->scaler_state.scaler_id = -1;
+}
+
 /* Returns the currently programmed mode of the given encoder. */
 struct drm_display_mode *
 intel_encoder_current_mode(struct intel_encoder *encoder)
@@ -11729,7 +11740,7 @@ intel_encoder_current_mode(struct intel_encoder *encoder)
 		return NULL;
 	}
 
-	crtc_state->uapi.crtc = &crtc->base;
+	intel_crtc_state_reset(crtc_state, crtc);
 
 	if (!dev_priv->display.get_pipe_config(crtc, crtc_state)) {
 		kfree(crtc_state);
@@ -13577,18 +13588,14 @@ verify_crtc_state(struct intel_crtc *crtc,
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct intel_encoder *encoder;
-	struct intel_crtc_state *pipe_config;
-	struct drm_atomic_state *state;
+	struct intel_crtc_state *pipe_config = old_crtc_state;
+	struct drm_atomic_state *state = old_crtc_state->uapi.state;
 	bool active;
 
-	state = old_crtc_state->uapi.state;
 	__drm_atomic_helper_crtc_destroy_state(&old_crtc_state->uapi);
 	intel_crtc_free_hw_state(old_crtc_state);
-
-	pipe_config = old_crtc_state;
-	memset(pipe_config, 0, sizeof(*pipe_config));
-	pipe_config->uapi.crtc = &crtc->base;
-	pipe_config->uapi.state = state;
+	intel_crtc_state_reset(old_crtc_state, crtc);
+	old_crtc_state->uapi.state = state;
 
 	DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.base.id, crtc->base.name);
 
@@ -15745,15 +15752,6 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,
 	return ERR_PTR(ret);
 }
 
-static void intel_crtc_init_scalers(struct intel_crtc_state *crtc_state)
-{
-	struct intel_crtc_scaler_state *scaler_state =
-		&crtc_state->scaler_state;
-
-	memset(scaler_state, 0, sizeof(*scaler_state));
-	scaler_state->scaler_id = -1;
-}
-
 #define INTEL_CRTC_FUNCS \
 	.gamma_set = drm_atomic_helper_legacy_gamma_set, \
 	.set_config = drm_atomic_helper_set_config, \
@@ -15836,9 +15834,9 @@ static struct intel_crtc *intel_crtc_alloc(void)
 		return ERR_PTR(-ENOMEM);
 	}
 
-	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
-	intel_crtc_init_scalers(crtc_state);
+	intel_crtc_state_reset(crtc_state, crtc);
 
+	crtc->base.state = &crtc_state->uapi;
 	crtc->config = crtc_state;
 
 	return crtc;
@@ -17414,8 +17412,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
 
 		__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
 		intel_crtc_free_hw_state(crtc_state);
-		memset(crtc_state, 0, sizeof(*crtc_state));
-		__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
+		intel_crtc_state_reset(crtc_state, crtc);
 
 		crtc_state->hw.active = crtc_state->hw.enable =
 			dev_priv->display.get_pipe_config(crtc, crtc_state);
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [PATCH 5/5] drm/i915: Introduce intel_plane_state_reset()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

For the sake of symmetry with the crtc stuff let's add
a helper to reset the plane state to sane default values.
For the moment this only gets caller from the plane init.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 42b3b3449d2e..9429b8e17270 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -41,6 +41,16 @@
 #include "intel_pm.h"
 #include "intel_sprite.h"
 
+static void intel_plane_state_reset(struct intel_plane_state *plane_state,
+				    struct intel_plane *plane)
+{
+	memset(plane_state, 0, sizeof(*plane_state));
+
+	__drm_atomic_helper_plane_state_reset(&plane_state->uapi, &plane->base);
+
+	plane_state->scaler_id = -1;
+}
+
 struct intel_plane *intel_plane_alloc(void)
 {
 	struct intel_plane_state *plane_state;
@@ -56,8 +66,9 @@ struct intel_plane *intel_plane_alloc(void)
 		return ERR_PTR(-ENOMEM);
 	}
 
-	__drm_atomic_helper_plane_reset(&plane->base, &plane_state->uapi);
-	plane_state->scaler_id = -1;
+	intel_plane_state_reset(plane_state, plane);
+
+	plane->base.state = &plane_state->uapi;
 
 	return plane;
 }
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* [Intel-gfx] [PATCH 5/5] drm/i915: Introduce intel_plane_state_reset()
@ 2019-11-07 14:24   ` Ville Syrjala
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjala @ 2019-11-07 14:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: dri-devel

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

For the sake of symmetry with the crtc stuff let's add
a helper to reset the plane state to sane default values.
For the moment this only gets caller from the plane init.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 42b3b3449d2e..9429b8e17270 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -41,6 +41,16 @@
 #include "intel_pm.h"
 #include "intel_sprite.h"
 
+static void intel_plane_state_reset(struct intel_plane_state *plane_state,
+				    struct intel_plane *plane)
+{
+	memset(plane_state, 0, sizeof(*plane_state));
+
+	__drm_atomic_helper_plane_state_reset(&plane_state->uapi, &plane->base);
+
+	plane_state->scaler_id = -1;
+}
+
 struct intel_plane *intel_plane_alloc(void)
 {
 	struct intel_plane_state *plane_state;
@@ -56,8 +66,9 @@ struct intel_plane *intel_plane_alloc(void)
 		return ERR_PTR(-ENOMEM);
 	}
 
-	__drm_atomic_helper_plane_reset(&plane->base, &plane_state->uapi);
-	plane_state->scaler_id = -1;
+	intel_plane_state_reset(plane_state, plane);
+
+	plane->base.state = &plane_state->uapi;
 
 	return plane;
 }
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 37+ messages in thread

* Re: [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 17:38   ` Daniel Vetter
  0 siblings, 0 replies; 37+ messages in thread
From: Daniel Vetter @ 2019-11-07 17:38 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: intel-gfx, dri-devel

On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Annoyingly __drm_atomic_helper_crtc_reset() does two
> totally separate things:
> a) reset the state to defaults values
> b) assign the crtc->state pointer
> 
> I just want a) without the b) so let's split out part
> a) into __drm_atomic_helper_crtc_state_reset(). And
> of course we'll do the same thing for planes and connectors.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

And I guess

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

for merging through drm-intel, I don't expect anyone to start using this
in the next few weeks.

Cheers, Daniel

> ---
>  drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
>  include/drm/drm_atomic_state_helper.h     |  6 ++
>  2 files changed, 67 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> index d0a937fb0c56..a972068d58cf 100644
> --- a/drivers/gpu/drm/drm_atomic_state_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> @@ -57,6 +57,22 @@
>   * for these functions.
>   */
>  
> +/**
> + * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
> + * @crtc_state: atomic CRTC state, must not be NULL
> + * @crtc: CRTC object, must not be NULL
> + *
> + * Initializes the newly allocated @crtc_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
> + */
> +void
> +__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
> +				     struct drm_crtc *crtc)
> +{
> +	crtc_state->crtc = crtc;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
> +
>  /**
>   * __drm_atomic_helper_crtc_reset - reset state on CRTC
>   * @crtc: drm CRTC
> @@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  			       struct drm_crtc_state *crtc_state)
>  {
>  	if (crtc_state)
> -		crtc_state->crtc = crtc;
> +		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
>  
>  	crtc->state = crtc_state;
>  }
> @@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
>  
>  /**
> - * __drm_atomic_helper_plane_reset - resets planes state to default values
> + * __drm_atomic_helper_plane_state_reset - resets plane state to default values
> + * @plane_state: atomic plane state, must not be NULL
>   * @plane: plane object, must not be NULL
> - * @state: atomic plane state, must not be NULL
>   *
> - * Initializes plane state to default. This is useful for drivers that subclass
> - * the plane state.
> + * Initializes the newly allocated @plane_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
>   */
> -void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> -				     struct drm_plane_state *state)
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane)
>  {
>  	state->plane = plane;
>  	state->rotation = DRM_MODE_ROTATE_0;
>  
>  	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
>  	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
>  
> -	plane->state = state;
> +/**
> + * __drm_atomic_helper_plane_reset - reset state on plane
> + * @plane: drm plane
> + * @plane_state: plane state to assign
> + *
> + * Initializes the newly allocated @plane_state and assigns it to
> + * the &drm_crtc->state pointer of @plane, usually required when
> + * initializing the drivers or when called from the &drm_plane_funcs.reset
> + * hook.
> + *
> + * This is useful for drivers that subclass the plane state.
> + */
> +void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> +				     struct drm_plane_state *plane_state)
> +{
> +	if (plane_state)
> +		__drm_atomic_helper_plane_state_reset(plane_state, plane);
> +
> +	plane->state = plane_state;
>  }
>  EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
>  
> @@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  }
>  EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
>  
> +/**
> + * __drm_atomic_helper_connector_state_reset - reset the connector state
> + * @conn__state: atomic connector state, must not be NULL
> + * @connector: connectotr object, must not be NULL
> + *
> + * Initializes the newly allocated @conn_state with default
> + * values. This is useful for drivers that subclass the connector state.
> + */
> +void
> +__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					  struct drm_connector *connector)
> +{
> +	conn_state->connector = connector;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
> +
>  /**
>   * __drm_atomic_helper_connector_reset - reset state on connector
>   * @connector: drm connector
> @@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  				    struct drm_connector_state *conn_state)
>  {
>  	if (conn_state)
> -		conn_state->connector = connector;
> +		__drm_atomic_helper_connector_state_reset(conn_state, connector);
>  
>  	connector->state = conn_state;
>  }
> diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
> index e4577cc11689..8171dea4cc22 100644
> --- a/include/drm/drm_atomic_state_helper.h
> +++ b/include/drm/drm_atomic_state_helper.h
> @@ -37,6 +37,8 @@ struct drm_private_state;
>  struct drm_modeset_acquire_ctx;
>  struct drm_device;
>  
> +void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
> +					  struct drm_crtc *crtc);
>  void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  				    struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
> @@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  					  struct drm_crtc_state *state);
>  
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane);
>  void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>  				     struct drm_plane_state *state);
>  void drm_atomic_helper_plane_reset(struct drm_plane *plane);
> @@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
>  void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  					  struct drm_plane_state *state);
>  
> +void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					       struct drm_connector *connector);
>  void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  					 struct drm_connector_state *conn_state);
>  void drm_atomic_helper_connector_reset(struct drm_connector *connector);
> -- 
> 2.23.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 17:38   ` Daniel Vetter
  0 siblings, 0 replies; 37+ messages in thread
From: Daniel Vetter @ 2019-11-07 17:38 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: intel-gfx, dri-devel

On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Annoyingly __drm_atomic_helper_crtc_reset() does two
> totally separate things:
> a) reset the state to defaults values
> b) assign the crtc->state pointer
> 
> I just want a) without the b) so let's split out part
> a) into __drm_atomic_helper_crtc_state_reset(). And
> of course we'll do the same thing for planes and connectors.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

And I guess

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

for merging through drm-intel, I don't expect anyone to start using this
in the next few weeks.

Cheers, Daniel

> ---
>  drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
>  include/drm/drm_atomic_state_helper.h     |  6 ++
>  2 files changed, 67 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> index d0a937fb0c56..a972068d58cf 100644
> --- a/drivers/gpu/drm/drm_atomic_state_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> @@ -57,6 +57,22 @@
>   * for these functions.
>   */
>  
> +/**
> + * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
> + * @crtc_state: atomic CRTC state, must not be NULL
> + * @crtc: CRTC object, must not be NULL
> + *
> + * Initializes the newly allocated @crtc_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
> + */
> +void
> +__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
> +				     struct drm_crtc *crtc)
> +{
> +	crtc_state->crtc = crtc;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
> +
>  /**
>   * __drm_atomic_helper_crtc_reset - reset state on CRTC
>   * @crtc: drm CRTC
> @@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  			       struct drm_crtc_state *crtc_state)
>  {
>  	if (crtc_state)
> -		crtc_state->crtc = crtc;
> +		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
>  
>  	crtc->state = crtc_state;
>  }
> @@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
>  
>  /**
> - * __drm_atomic_helper_plane_reset - resets planes state to default values
> + * __drm_atomic_helper_plane_state_reset - resets plane state to default values
> + * @plane_state: atomic plane state, must not be NULL
>   * @plane: plane object, must not be NULL
> - * @state: atomic plane state, must not be NULL
>   *
> - * Initializes plane state to default. This is useful for drivers that subclass
> - * the plane state.
> + * Initializes the newly allocated @plane_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
>   */
> -void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> -				     struct drm_plane_state *state)
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane)
>  {
>  	state->plane = plane;
>  	state->rotation = DRM_MODE_ROTATE_0;
>  
>  	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
>  	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
>  
> -	plane->state = state;
> +/**
> + * __drm_atomic_helper_plane_reset - reset state on plane
> + * @plane: drm plane
> + * @plane_state: plane state to assign
> + *
> + * Initializes the newly allocated @plane_state and assigns it to
> + * the &drm_crtc->state pointer of @plane, usually required when
> + * initializing the drivers or when called from the &drm_plane_funcs.reset
> + * hook.
> + *
> + * This is useful for drivers that subclass the plane state.
> + */
> +void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> +				     struct drm_plane_state *plane_state)
> +{
> +	if (plane_state)
> +		__drm_atomic_helper_plane_state_reset(plane_state, plane);
> +
> +	plane->state = plane_state;
>  }
>  EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
>  
> @@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  }
>  EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
>  
> +/**
> + * __drm_atomic_helper_connector_state_reset - reset the connector state
> + * @conn__state: atomic connector state, must not be NULL
> + * @connector: connectotr object, must not be NULL
> + *
> + * Initializes the newly allocated @conn_state with default
> + * values. This is useful for drivers that subclass the connector state.
> + */
> +void
> +__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					  struct drm_connector *connector)
> +{
> +	conn_state->connector = connector;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
> +
>  /**
>   * __drm_atomic_helper_connector_reset - reset state on connector
>   * @connector: drm connector
> @@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  				    struct drm_connector_state *conn_state)
>  {
>  	if (conn_state)
> -		conn_state->connector = connector;
> +		__drm_atomic_helper_connector_state_reset(conn_state, connector);
>  
>  	connector->state = conn_state;
>  }
> diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
> index e4577cc11689..8171dea4cc22 100644
> --- a/include/drm/drm_atomic_state_helper.h
> +++ b/include/drm/drm_atomic_state_helper.h
> @@ -37,6 +37,8 @@ struct drm_private_state;
>  struct drm_modeset_acquire_ctx;
>  struct drm_device;
>  
> +void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
> +					  struct drm_crtc *crtc);
>  void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  				    struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
> @@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  					  struct drm_crtc_state *state);
>  
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane);
>  void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>  				     struct drm_plane_state *state);
>  void drm_atomic_helper_plane_reset(struct drm_plane *plane);
> @@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
>  void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  					  struct drm_plane_state *state);
>  
> +void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					       struct drm_connector *connector);
>  void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  					 struct drm_connector_state *conn_state);
>  void drm_atomic_helper_connector_reset(struct drm_connector *connector);
> -- 
> 2.23.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 17:38   ` Daniel Vetter
  0 siblings, 0 replies; 37+ messages in thread
From: Daniel Vetter @ 2019-11-07 17:38 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: intel-gfx, dri-devel

On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Annoyingly __drm_atomic_helper_crtc_reset() does two
> totally separate things:
> a) reset the state to defaults values
> b) assign the crtc->state pointer
> 
> I just want a) without the b) so let's split out part
> a) into __drm_atomic_helper_crtc_state_reset(). And
> of course we'll do the same thing for planes and connectors.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

And I guess

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

for merging through drm-intel, I don't expect anyone to start using this
in the next few weeks.

Cheers, Daniel

> ---
>  drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
>  include/drm/drm_atomic_state_helper.h     |  6 ++
>  2 files changed, 67 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> index d0a937fb0c56..a972068d58cf 100644
> --- a/drivers/gpu/drm/drm_atomic_state_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> @@ -57,6 +57,22 @@
>   * for these functions.
>   */
>  
> +/**
> + * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
> + * @crtc_state: atomic CRTC state, must not be NULL
> + * @crtc: CRTC object, must not be NULL
> + *
> + * Initializes the newly allocated @crtc_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
> + */
> +void
> +__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
> +				     struct drm_crtc *crtc)
> +{
> +	crtc_state->crtc = crtc;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
> +
>  /**
>   * __drm_atomic_helper_crtc_reset - reset state on CRTC
>   * @crtc: drm CRTC
> @@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  			       struct drm_crtc_state *crtc_state)
>  {
>  	if (crtc_state)
> -		crtc_state->crtc = crtc;
> +		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
>  
>  	crtc->state = crtc_state;
>  }
> @@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
>  
>  /**
> - * __drm_atomic_helper_plane_reset - resets planes state to default values
> + * __drm_atomic_helper_plane_state_reset - resets plane state to default values
> + * @plane_state: atomic plane state, must not be NULL
>   * @plane: plane object, must not be NULL
> - * @state: atomic plane state, must not be NULL
>   *
> - * Initializes plane state to default. This is useful for drivers that subclass
> - * the plane state.
> + * Initializes the newly allocated @plane_state with default
> + * values. This is useful for drivers that subclass the CRTC state.
>   */
> -void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> -				     struct drm_plane_state *state)
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane)
>  {
>  	state->plane = plane;
>  	state->rotation = DRM_MODE_ROTATE_0;
>  
>  	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
>  	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
>  
> -	plane->state = state;
> +/**
> + * __drm_atomic_helper_plane_reset - reset state on plane
> + * @plane: drm plane
> + * @plane_state: plane state to assign
> + *
> + * Initializes the newly allocated @plane_state and assigns it to
> + * the &drm_crtc->state pointer of @plane, usually required when
> + * initializing the drivers or when called from the &drm_plane_funcs.reset
> + * hook.
> + *
> + * This is useful for drivers that subclass the plane state.
> + */
> +void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> +				     struct drm_plane_state *plane_state)
> +{
> +	if (plane_state)
> +		__drm_atomic_helper_plane_state_reset(plane_state, plane);
> +
> +	plane->state = plane_state;
>  }
>  EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
>  
> @@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  }
>  EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
>  
> +/**
> + * __drm_atomic_helper_connector_state_reset - reset the connector state
> + * @conn__state: atomic connector state, must not be NULL
> + * @connector: connectotr object, must not be NULL
> + *
> + * Initializes the newly allocated @conn_state with default
> + * values. This is useful for drivers that subclass the connector state.
> + */
> +void
> +__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					  struct drm_connector *connector)
> +{
> +	conn_state->connector = connector;
> +}
> +EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
> +
>  /**
>   * __drm_atomic_helper_connector_reset - reset state on connector
>   * @connector: drm connector
> @@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  				    struct drm_connector_state *conn_state)
>  {
>  	if (conn_state)
> -		conn_state->connector = connector;
> +		__drm_atomic_helper_connector_state_reset(conn_state, connector);
>  
>  	connector->state = conn_state;
>  }
> diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
> index e4577cc11689..8171dea4cc22 100644
> --- a/include/drm/drm_atomic_state_helper.h
> +++ b/include/drm/drm_atomic_state_helper.h
> @@ -37,6 +37,8 @@ struct drm_private_state;
>  struct drm_modeset_acquire_ctx;
>  struct drm_device;
>  
> +void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
> +					  struct drm_crtc *crtc);
>  void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
>  				    struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
> @@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
>  void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
>  					  struct drm_crtc_state *state);
>  
> +void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> +					   struct drm_plane *plane);
>  void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>  				     struct drm_plane_state *state);
>  void drm_atomic_helper_plane_reset(struct drm_plane *plane);
> @@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
>  void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
>  					  struct drm_plane_state *state);
>  
> +void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
> +					       struct drm_connector *connector);
>  void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
>  					 struct drm_connector_state *conn_state);
>  void drm_atomic_helper_connector_reset(struct drm_connector *connector);
> -- 
> 2.23.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 18:28   ` Patchwork
  0 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-11-07 18:28 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
URL   : https://patchwork.freedesktop.org/series/69129/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15175
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15175 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15175, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15175:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-bsw-kefka:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html

  
Known issues
------------

  Here are the changes found in Patchwork_15175 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_exec_create@basic:
    - {fi-tgl-u}:         [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-tgl-u/igt@gem_exec_create@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-tgl-u/igt@gem_exec_create@basic.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#111407]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-skl-6700k2:      [INCOMPLETE][7] ([fdo#104108]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736


Participating hosts (51 -> 45)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7288 -> Patchwork_15175

  CI-20190529: 20190529
  CI_DRM_7288: 41eb27f39e60d822edc75e6aaeb416b72bc1dcf2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15175: fc9cd4c16f83a4dfad81c650ca2be9a83caf115c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

fc9cd4c16f83 drm/i915: Introduce intel_plane_state_reset()
f77f1d0feca7 drm/i915: Introduce intel_crtc_state_reset()
1af8c56f280e drm/i915: Introduce intel_crtc_{alloc, free}()
9e996834eca6 drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
b00efdb4f412 drm: Add __drm_atomic_helper_crtc_state_reset() & co.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-11-07 18:28   ` Patchwork
  0 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-11-07 18:28 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
URL   : https://patchwork.freedesktop.org/series/69129/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7288 -> Patchwork_15175
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15175 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15175, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15175:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-bsw-kefka:       [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-bsw-kefka/igt@i915_module_load@reload-with-fault-injection.html

  
Known issues
------------

  Here are the changes found in Patchwork_15175 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_exec_create@basic:
    - {fi-tgl-u}:         [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-tgl-u/igt@gem_exec_create@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-tgl-u/igt@gem_exec_create@basic.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][5] ([fdo#111407]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-skl-6700k2:      [INCOMPLETE][7] ([fdo#104108]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7288/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/fi-skl-6700k2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736


Participating hosts (51 -> 45)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7288 -> Patchwork_15175

  CI-20190529: 20190529
  CI_DRM_7288: 41eb27f39e60d822edc75e6aaeb416b72bc1dcf2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5266: 60a67653613c87a69ebecf12cf00aa362ac87597 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15175: fc9cd4c16f83a4dfad81c650ca2be9a83caf115c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

fc9cd4c16f83 drm/i915: Introduce intel_plane_state_reset()
f77f1d0feca7 drm/i915: Introduce intel_crtc_state_reset()
1af8c56f280e drm/i915: Introduce intel_crtc_{alloc, free}()
9e996834eca6 drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
b00efdb4f412 drm: Add __drm_atomic_helper_crtc_state_reset() & co.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15175/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
  2019-11-07 14:24   ` Ville Syrjala
@ 2019-12-10  2:06     ` Souza, Jose
  -1 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:06 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Let's get rid of the redundant intel_ prefix on our variables.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 32 ++++++++++------
> ----
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 551de2baa569..8b889c9f29b5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -15838,14 +15838,14 @@ static const struct drm_crtc_funcs
> i8xx_crtc_funcs = {
>  static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
>  {
>  	const struct drm_crtc_funcs *funcs;
> -	struct intel_crtc *intel_crtc;
> +	struct intel_crtc *crtc;
>  	struct intel_crtc_state *crtc_state = NULL;
>  	struct intel_plane *primary = NULL;
>  	struct intel_plane *cursor = NULL;
>  	int sprite, ret;
>  
> -	intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL);
> -	if (!intel_crtc)
> +	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
> +	if (!crtc)
>  		return -ENOMEM;
>  
>  	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
> @@ -15853,15 +15853,15 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  		ret = -ENOMEM;
>  		goto fail;
>  	}
> -	__drm_atomic_helper_crtc_reset(&intel_crtc->base, &crtc_state-
> >uapi);
> -	intel_crtc->config = crtc_state;
> +	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> +	crtc->config = crtc_state;
>  
>  	primary = intel_primary_plane_create(dev_priv, pipe);
>  	if (IS_ERR(primary)) {
>  		ret = PTR_ERR(primary);
>  		goto fail;
>  	}
> -	intel_crtc->plane_ids_mask |= BIT(primary->id);
> +	crtc->plane_ids_mask |= BIT(primary->id);
>  
>  	for_each_sprite(dev_priv, pipe, sprite) {
>  		struct intel_plane *plane;
> @@ -15871,7 +15871,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  			ret = PTR_ERR(plane);
>  			goto fail;
>  		}
> -		intel_crtc->plane_ids_mask |= BIT(plane->id);
> +		crtc->plane_ids_mask |= BIT(plane->id);
>  	}
>  
>  	cursor = intel_cursor_plane_create(dev_priv, pipe);
> @@ -15879,7 +15879,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  		ret = PTR_ERR(cursor);
>  		goto fail;
>  	}
> -	intel_crtc->plane_ids_mask |= BIT(cursor->id);
> +	crtc->plane_ids_mask |= BIT(cursor->id);
>  
>  	if (HAS_GMCH(dev_priv)) {
>  		if (IS_CHERRYVIEW(dev_priv) ||
> @@ -15900,32 +15900,32 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  			funcs = &ilk_crtc_funcs;
>  	}
>  
> -	ret = drm_crtc_init_with_planes(&dev_priv->drm, &intel_crtc-
> >base,
> +	ret = drm_crtc_init_with_planes(&dev_priv->drm, &crtc->base,
>  					&primary->base, &cursor->base,
>  					funcs, "pipe %c",
> pipe_name(pipe));
>  	if (ret)
>  		goto fail;
>  
> -	intel_crtc->pipe = pipe;
> +	crtc->pipe = pipe;
>  
>  	/* initialize shared scalers */
> -	intel_crtc_init_scalers(intel_crtc, crtc_state);
> +	intel_crtc_init_scalers(crtc, crtc_state);
>  
>  	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
>  	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
> -	dev_priv->pipe_to_crtc_mapping[pipe] = intel_crtc;
> +	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
>  
>  	if (INTEL_GEN(dev_priv) < 9) {
>  		enum i9xx_plane_id i9xx_plane = primary->i9xx_plane;
>  
>  		BUG_ON(i9xx_plane >= ARRAY_SIZE(dev_priv-
> >plane_to_crtc_mapping) ||
>  		       dev_priv->plane_to_crtc_mapping[i9xx_plane] !=
> NULL);
> -		dev_priv->plane_to_crtc_mapping[i9xx_plane] =
> intel_crtc;
> +		dev_priv->plane_to_crtc_mapping[i9xx_plane] = crtc;
>  	}
>  
> -	intel_color_init(intel_crtc);
> +	intel_color_init(crtc);
>  
> -	WARN_ON(drm_crtc_index(&intel_crtc->base) != intel_crtc->pipe);
> +	WARN_ON(drm_crtc_index(&crtc->base) != crtc->pipe);
>  
>  	return 0;
>  
> @@ -15935,7 +15935,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	 * crtcs/planes already initialized.
>  	 */
>  	kfree(crtc_state);
> -	kfree(intel_crtc);
> +	kfree(crtc);
>  
>  	return ret;
>  }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
@ 2019-12-10  2:06     ` Souza, Jose
  0 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:06 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Let's get rid of the redundant intel_ prefix on our variables.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 32 ++++++++++------
> ----
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 551de2baa569..8b889c9f29b5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -15838,14 +15838,14 @@ static const struct drm_crtc_funcs
> i8xx_crtc_funcs = {
>  static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
>  {
>  	const struct drm_crtc_funcs *funcs;
> -	struct intel_crtc *intel_crtc;
> +	struct intel_crtc *crtc;
>  	struct intel_crtc_state *crtc_state = NULL;
>  	struct intel_plane *primary = NULL;
>  	struct intel_plane *cursor = NULL;
>  	int sprite, ret;
>  
> -	intel_crtc = kzalloc(sizeof(*intel_crtc), GFP_KERNEL);
> -	if (!intel_crtc)
> +	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
> +	if (!crtc)
>  		return -ENOMEM;
>  
>  	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
> @@ -15853,15 +15853,15 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  		ret = -ENOMEM;
>  		goto fail;
>  	}
> -	__drm_atomic_helper_crtc_reset(&intel_crtc->base, &crtc_state-
> >uapi);
> -	intel_crtc->config = crtc_state;
> +	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> +	crtc->config = crtc_state;
>  
>  	primary = intel_primary_plane_create(dev_priv, pipe);
>  	if (IS_ERR(primary)) {
>  		ret = PTR_ERR(primary);
>  		goto fail;
>  	}
> -	intel_crtc->plane_ids_mask |= BIT(primary->id);
> +	crtc->plane_ids_mask |= BIT(primary->id);
>  
>  	for_each_sprite(dev_priv, pipe, sprite) {
>  		struct intel_plane *plane;
> @@ -15871,7 +15871,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  			ret = PTR_ERR(plane);
>  			goto fail;
>  		}
> -		intel_crtc->plane_ids_mask |= BIT(plane->id);
> +		crtc->plane_ids_mask |= BIT(plane->id);
>  	}
>  
>  	cursor = intel_cursor_plane_create(dev_priv, pipe);
> @@ -15879,7 +15879,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  		ret = PTR_ERR(cursor);
>  		goto fail;
>  	}
> -	intel_crtc->plane_ids_mask |= BIT(cursor->id);
> +	crtc->plane_ids_mask |= BIT(cursor->id);
>  
>  	if (HAS_GMCH(dev_priv)) {
>  		if (IS_CHERRYVIEW(dev_priv) ||
> @@ -15900,32 +15900,32 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  			funcs = &ilk_crtc_funcs;
>  	}
>  
> -	ret = drm_crtc_init_with_planes(&dev_priv->drm, &intel_crtc-
> >base,
> +	ret = drm_crtc_init_with_planes(&dev_priv->drm, &crtc->base,
>  					&primary->base, &cursor->base,
>  					funcs, "pipe %c",
> pipe_name(pipe));
>  	if (ret)
>  		goto fail;
>  
> -	intel_crtc->pipe = pipe;
> +	crtc->pipe = pipe;
>  
>  	/* initialize shared scalers */
> -	intel_crtc_init_scalers(intel_crtc, crtc_state);
> +	intel_crtc_init_scalers(crtc, crtc_state);
>  
>  	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
>  	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
> -	dev_priv->pipe_to_crtc_mapping[pipe] = intel_crtc;
> +	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
>  
>  	if (INTEL_GEN(dev_priv) < 9) {
>  		enum i9xx_plane_id i9xx_plane = primary->i9xx_plane;
>  
>  		BUG_ON(i9xx_plane >= ARRAY_SIZE(dev_priv-
> >plane_to_crtc_mapping) ||
>  		       dev_priv->plane_to_crtc_mapping[i9xx_plane] !=
> NULL);
> -		dev_priv->plane_to_crtc_mapping[i9xx_plane] =
> intel_crtc;
> +		dev_priv->plane_to_crtc_mapping[i9xx_plane] = crtc;
>  	}
>  
> -	intel_color_init(intel_crtc);
> +	intel_color_init(crtc);
>  
> -	WARN_ON(drm_crtc_index(&intel_crtc->base) != intel_crtc->pipe);
> +	WARN_ON(drm_crtc_index(&crtc->base) != crtc->pipe);
>  
>  	return 0;
>  
> @@ -15935,7 +15935,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	 * crtcs/planes already initialized.
>  	 */
>  	kfree(crtc_state);
> -	kfree(intel_crtc);
> +	kfree(crtc);
>  
>  	return ret;
>  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc,free}()
  2019-11-07 14:24   ` [Intel-gfx] [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc, free}() Ville Syrjala
@ 2019-12-10  2:09     ` Souza, Jose
  -1 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:09 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We already have alloc/free helpers for planes, add the same for
> crtcs. The main benefit is we get to move all the annoying state
> initialization out of the main crtc_init() flow.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 74 ++++++++++------
> ----
>  1 file changed, 36 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 8b889c9f29b5..e6291841053f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -164,8 +164,7 @@ static void vlv_prepare_pll(struct intel_crtc
> *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
>  static void chv_prepare_pll(struct intel_crtc *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
> -static void intel_crtc_init_scalers(struct intel_crtc *crtc,
> -				    struct intel_crtc_state
> *crtc_state);
> +static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state);
>  static void skylake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
>  static void ironlake_pfit_disable(const struct intel_crtc_state
> *old_crtc_state);
>  static void ironlake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
> @@ -10656,7 +10655,7 @@ static bool haswell_get_pipe_config(struct
> intel_crtc *crtc,
>  	u64 power_domain_mask;
>  	bool active;
>  
> -	intel_crtc_init_scalers(crtc, pipe_config);
> +	intel_crtc_init_scalers(pipe_config);
>  
>  	pipe_config->master_transcoder = INVALID_TRANSCODER;
>  
> @@ -15746,25 +15745,12 @@ intel_cursor_plane_create(struct
> drm_i915_private *dev_priv,
>  	return ERR_PTR(ret);
>  }
>  
> -static void intel_crtc_init_scalers(struct intel_crtc *crtc,
> -				    struct intel_crtc_state
> *crtc_state)
> +static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state)
>  {
>  	struct intel_crtc_scaler_state *scaler_state =
>  		&crtc_state->scaler_state;
> -	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> -	int i;
> -
> -	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[crtc-
> >pipe];
> -	if (!crtc->num_scalers)
> -		return;
> -
> -	for (i = 0; i < crtc->num_scalers; i++) {
> -		struct intel_scaler *scaler = &scaler_state-
> >scalers[i];
> -
> -		scaler->in_use = 0;
> -		scaler->mode = 0;
> -	}
>  
> +	memset(scaler_state, 0, sizeof(*scaler_state));
>  	scaler_state->scaler_id = -1;
>  }
>  
> @@ -15835,27 +15821,49 @@ static const struct drm_crtc_funcs
> i8xx_crtc_funcs = {
>  	.disable_vblank = i8xx_disable_vblank,
>  };
>  
> -static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
> +static struct intel_crtc *intel_crtc_alloc(void)
>  {
> -	const struct drm_crtc_funcs *funcs;
> +	struct intel_crtc_state *crtc_state;
>  	struct intel_crtc *crtc;
> -	struct intel_crtc_state *crtc_state = NULL;
> -	struct intel_plane *primary = NULL;
> -	struct intel_plane *cursor = NULL;
> -	int sprite, ret;
>  
>  	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
>  	if (!crtc)
> -		return -ENOMEM;
> +		return ERR_PTR(-ENOMEM);
>  
>  	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
>  	if (!crtc_state) {
> -		ret = -ENOMEM;
> -		goto fail;
> +		kfree(crtc);
> +		return ERR_PTR(-ENOMEM);
>  	}
> +
>  	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> +	intel_crtc_init_scalers(crtc_state);
> +
>  	crtc->config = crtc_state;
>  
> +	return crtc;
> +}
> +
> +static void intel_crtc_free(struct intel_crtc *crtc)
> +{
> +	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
> +	kfree(crtc);
> +}
> +
> +static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
> +{
> +	struct intel_plane *primary, *cursor;
> +	const struct drm_crtc_funcs *funcs;
> +	struct intel_crtc *crtc;
> +	int sprite, ret;
> +
> +	crtc = intel_crtc_alloc();
> +	if (IS_ERR(crtc))
> +		return PTR_ERR(crtc);
> +
> +	crtc->pipe = pipe;
> +	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[pipe];
> +
>  	primary = intel_primary_plane_create(dev_priv, pipe);
>  	if (IS_ERR(primary)) {
>  		ret = PTR_ERR(primary);
> @@ -15906,11 +15914,6 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	if (ret)
>  		goto fail;
>  
> -	crtc->pipe = pipe;
> -
> -	/* initialize shared scalers */
> -	intel_crtc_init_scalers(crtc, crtc_state);
> -
>  	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
>  	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
>  	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
> @@ -15930,12 +15933,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	return 0;
>  
>  fail:
> -	/*
> -	 * drm_mode_config_cleanup() will free up any
> -	 * crtcs/planes already initialized.
> -	 */
> -	kfree(crtc_state);
> -	kfree(crtc);
> +	intel_crtc_free(crtc);
>  
>  	return ret;
>  }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc, free}()
@ 2019-12-10  2:09     ` Souza, Jose
  0 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:09 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We already have alloc/free helpers for planes, add the same for
> crtcs. The main benefit is we get to move all the annoying state
> initialization out of the main crtc_init() flow.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 74 ++++++++++------
> ----
>  1 file changed, 36 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 8b889c9f29b5..e6291841053f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -164,8 +164,7 @@ static void vlv_prepare_pll(struct intel_crtc
> *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
>  static void chv_prepare_pll(struct intel_crtc *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
> -static void intel_crtc_init_scalers(struct intel_crtc *crtc,
> -				    struct intel_crtc_state
> *crtc_state);
> +static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state);
>  static void skylake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
>  static void ironlake_pfit_disable(const struct intel_crtc_state
> *old_crtc_state);
>  static void ironlake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
> @@ -10656,7 +10655,7 @@ static bool haswell_get_pipe_config(struct
> intel_crtc *crtc,
>  	u64 power_domain_mask;
>  	bool active;
>  
> -	intel_crtc_init_scalers(crtc, pipe_config);
> +	intel_crtc_init_scalers(pipe_config);
>  
>  	pipe_config->master_transcoder = INVALID_TRANSCODER;
>  
> @@ -15746,25 +15745,12 @@ intel_cursor_plane_create(struct
> drm_i915_private *dev_priv,
>  	return ERR_PTR(ret);
>  }
>  
> -static void intel_crtc_init_scalers(struct intel_crtc *crtc,
> -				    struct intel_crtc_state
> *crtc_state)
> +static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state)
>  {
>  	struct intel_crtc_scaler_state *scaler_state =
>  		&crtc_state->scaler_state;
> -	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> -	int i;
> -
> -	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[crtc-
> >pipe];
> -	if (!crtc->num_scalers)
> -		return;
> -
> -	for (i = 0; i < crtc->num_scalers; i++) {
> -		struct intel_scaler *scaler = &scaler_state-
> >scalers[i];
> -
> -		scaler->in_use = 0;
> -		scaler->mode = 0;
> -	}
>  
> +	memset(scaler_state, 0, sizeof(*scaler_state));
>  	scaler_state->scaler_id = -1;
>  }
>  
> @@ -15835,27 +15821,49 @@ static const struct drm_crtc_funcs
> i8xx_crtc_funcs = {
>  	.disable_vblank = i8xx_disable_vblank,
>  };
>  
> -static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
> +static struct intel_crtc *intel_crtc_alloc(void)
>  {
> -	const struct drm_crtc_funcs *funcs;
> +	struct intel_crtc_state *crtc_state;
>  	struct intel_crtc *crtc;
> -	struct intel_crtc_state *crtc_state = NULL;
> -	struct intel_plane *primary = NULL;
> -	struct intel_plane *cursor = NULL;
> -	int sprite, ret;
>  
>  	crtc = kzalloc(sizeof(*crtc), GFP_KERNEL);
>  	if (!crtc)
> -		return -ENOMEM;
> +		return ERR_PTR(-ENOMEM);
>  
>  	crtc_state = kzalloc(sizeof(*crtc_state), GFP_KERNEL);
>  	if (!crtc_state) {
> -		ret = -ENOMEM;
> -		goto fail;
> +		kfree(crtc);
> +		return ERR_PTR(-ENOMEM);
>  	}
> +
>  	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> +	intel_crtc_init_scalers(crtc_state);
> +
>  	crtc->config = crtc_state;
>  
> +	return crtc;
> +}
> +
> +static void intel_crtc_free(struct intel_crtc *crtc)
> +{
> +	intel_crtc_destroy_state(&crtc->base, crtc->base.state);
> +	kfree(crtc);
> +}
> +
> +static int intel_crtc_init(struct drm_i915_private *dev_priv, enum
> pipe pipe)
> +{
> +	struct intel_plane *primary, *cursor;
> +	const struct drm_crtc_funcs *funcs;
> +	struct intel_crtc *crtc;
> +	int sprite, ret;
> +
> +	crtc = intel_crtc_alloc();
> +	if (IS_ERR(crtc))
> +		return PTR_ERR(crtc);
> +
> +	crtc->pipe = pipe;
> +	crtc->num_scalers = RUNTIME_INFO(dev_priv)->num_scalers[pipe];
> +
>  	primary = intel_primary_plane_create(dev_priv, pipe);
>  	if (IS_ERR(primary)) {
>  		ret = PTR_ERR(primary);
> @@ -15906,11 +15914,6 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	if (ret)
>  		goto fail;
>  
> -	crtc->pipe = pipe;
> -
> -	/* initialize shared scalers */
> -	intel_crtc_init_scalers(crtc, crtc_state);
> -
>  	BUG_ON(pipe >= ARRAY_SIZE(dev_priv->pipe_to_crtc_mapping) ||
>  	       dev_priv->pipe_to_crtc_mapping[pipe] != NULL);
>  	dev_priv->pipe_to_crtc_mapping[pipe] = crtc;
> @@ -15930,12 +15933,7 @@ static int intel_crtc_init(struct
> drm_i915_private *dev_priv, enum pipe pipe)
>  	return 0;
>  
>  fail:
> -	/*
> -	 * drm_mode_config_cleanup() will free up any
> -	 * crtcs/planes already initialized.
> -	 */
> -	kfree(crtc_state);
> -	kfree(crtc);
> +	intel_crtc_free(crtc);
>  
>  	return ret;
>  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset()
  2019-11-07 14:24   ` [Intel-gfx] " Ville Syrjala
@ 2019-12-10  2:12     ` Souza, Jose
  -1 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:12 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We have a few places where we want to reset a crtc state to its
> default values. Let's add a helper for that. We'll need the new
> __drm_atomic_helper_crtc_state_reset() helper for this to allow
> us to just reset the state itself without clobbering the
> crtc->state pointer.
> 
> And while at it let's zero out the whole thing, except a few
> choice member which we'll mark as "invalid". And thanks to this
> we can now nuke intel_crtc_init_scalers().
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 47 +++++++++---------
> --
>  1 file changed, 22 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index e6291841053f..fd4120533c3f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -164,7 +164,6 @@ static void vlv_prepare_pll(struct intel_crtc
> *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
>  static void chv_prepare_pll(struct intel_crtc *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
> -static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state);
>  static void skylake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
>  static void ironlake_pfit_disable(const struct intel_crtc_state
> *old_crtc_state);
>  static void ironlake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
> @@ -10655,8 +10654,6 @@ static bool haswell_get_pipe_config(struct
> intel_crtc *crtc,
>  	u64 power_domain_mask;
>  	bool active;
>  
> -	intel_crtc_init_scalers(pipe_config);
> -
>  	pipe_config->master_transcoder = INVALID_TRANSCODER;
>  
>  	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
> @@ -11704,6 +11701,20 @@ static void ironlake_pch_clock_get(struct
> intel_crtc *crtc,
>  					 &pipe_config->fdi_m_n);
>  }
>  
> +static void intel_crtc_state_reset(struct intel_crtc_state
> *crtc_state,
> +				   struct intel_crtc *crtc)
> +{
> +	memset(crtc_state, 0, sizeof(*crtc_state));
> +
> +	__drm_atomic_helper_crtc_state_reset(&crtc_state->uapi, &crtc-
> >base);
> +
> +	crtc_state->cpu_transcoder = INVALID_TRANSCODER;
> +	crtc_state->master_transcoder = INVALID_TRANSCODER;

At least master_transcoder is set to invalid again but we can remove
the redundant sets later

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> +	crtc_state->hsw_workaround_pipe = INVALID_PIPE;
> +	crtc_state->output_format = INTEL_OUTPUT_FORMAT_INVALID;
> +	crtc_state->scaler_state.scaler_id = -1;
> +}
> +
>  /* Returns the currently programmed mode of the given encoder. */
>  struct drm_display_mode *
>  intel_encoder_current_mode(struct intel_encoder *encoder)
> @@ -11729,7 +11740,7 @@ intel_encoder_current_mode(struct
> intel_encoder *encoder)
>  		return NULL;
>  	}
>  
> -	crtc_state->uapi.crtc = &crtc->base;
> +	intel_crtc_state_reset(crtc_state, crtc);
>  
>  	if (!dev_priv->display.get_pipe_config(crtc, crtc_state)) {
>  		kfree(crtc_state);
> @@ -13577,18 +13588,14 @@ verify_crtc_state(struct intel_crtc *crtc,
>  	struct drm_device *dev = crtc->base.dev;
>  	struct drm_i915_private *dev_priv = to_i915(dev);
>  	struct intel_encoder *encoder;
> -	struct intel_crtc_state *pipe_config;
> -	struct drm_atomic_state *state;
> +	struct intel_crtc_state *pipe_config = old_crtc_state;
> +	struct drm_atomic_state *state = old_crtc_state->uapi.state;
>  	bool active;
>  
> -	state = old_crtc_state->uapi.state;
>  	__drm_atomic_helper_crtc_destroy_state(&old_crtc_state->uapi);
>  	intel_crtc_free_hw_state(old_crtc_state);
> -
> -	pipe_config = old_crtc_state;
> -	memset(pipe_config, 0, sizeof(*pipe_config));
> -	pipe_config->uapi.crtc = &crtc->base;
> -	pipe_config->uapi.state = state;
> +	intel_crtc_state_reset(old_crtc_state, crtc);
> +	old_crtc_state->uapi.state = state;
>  
>  	DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.base.id, crtc-
> >base.name);
>  
> @@ -15745,15 +15752,6 @@ intel_cursor_plane_create(struct
> drm_i915_private *dev_priv,
>  	return ERR_PTR(ret);
>  }
>  
> -static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state)
> -{
> -	struct intel_crtc_scaler_state *scaler_state =
> -		&crtc_state->scaler_state;
> -
> -	memset(scaler_state, 0, sizeof(*scaler_state));
> -	scaler_state->scaler_id = -1;
> -}
> -
>  #define INTEL_CRTC_FUNCS \
>  	.gamma_set = drm_atomic_helper_legacy_gamma_set, \
>  	.set_config = drm_atomic_helper_set_config, \
> @@ -15836,9 +15834,9 @@ static struct intel_crtc
> *intel_crtc_alloc(void)
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> -	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> -	intel_crtc_init_scalers(crtc_state);
> +	intel_crtc_state_reset(crtc_state, crtc);
>  
> +	crtc->base.state = &crtc_state->uapi;
>  	crtc->config = crtc_state;
>  
>  	return crtc;
> @@ -17414,8 +17412,7 @@ static void
> intel_modeset_readout_hw_state(struct drm_device *dev)
>  
>  		__drm_atomic_helper_crtc_destroy_state(&crtc_state-
> >uapi);
>  		intel_crtc_free_hw_state(crtc_state);
> -		memset(crtc_state, 0, sizeof(*crtc_state));
> -		__drm_atomic_helper_crtc_reset(&crtc->base,
> &crtc_state->uapi);
> +		intel_crtc_state_reset(crtc_state, crtc);
>  
>  		crtc_state->hw.active = crtc_state->hw.enable =
>  			dev_priv->display.get_pipe_config(crtc,
> crtc_state);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset()
@ 2019-12-10  2:12     ` Souza, Jose
  0 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:12 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We have a few places where we want to reset a crtc state to its
> default values. Let's add a helper for that. We'll need the new
> __drm_atomic_helper_crtc_state_reset() helper for this to allow
> us to just reset the state itself without clobbering the
> crtc->state pointer.
> 
> And while at it let's zero out the whole thing, except a few
> choice member which we'll mark as "invalid". And thanks to this
> we can now nuke intel_crtc_init_scalers().
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 47 +++++++++---------
> --
>  1 file changed, 22 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index e6291841053f..fd4120533c3f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -164,7 +164,6 @@ static void vlv_prepare_pll(struct intel_crtc
> *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
>  static void chv_prepare_pll(struct intel_crtc *crtc,
>  			    const struct intel_crtc_state
> *pipe_config);
> -static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state);
>  static void skylake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
>  static void ironlake_pfit_disable(const struct intel_crtc_state
> *old_crtc_state);
>  static void ironlake_pfit_enable(const struct intel_crtc_state
> *crtc_state);
> @@ -10655,8 +10654,6 @@ static bool haswell_get_pipe_config(struct
> intel_crtc *crtc,
>  	u64 power_domain_mask;
>  	bool active;
>  
> -	intel_crtc_init_scalers(pipe_config);
> -
>  	pipe_config->master_transcoder = INVALID_TRANSCODER;
>  
>  	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
> @@ -11704,6 +11701,20 @@ static void ironlake_pch_clock_get(struct
> intel_crtc *crtc,
>  					 &pipe_config->fdi_m_n);
>  }
>  
> +static void intel_crtc_state_reset(struct intel_crtc_state
> *crtc_state,
> +				   struct intel_crtc *crtc)
> +{
> +	memset(crtc_state, 0, sizeof(*crtc_state));
> +
> +	__drm_atomic_helper_crtc_state_reset(&crtc_state->uapi, &crtc-
> >base);
> +
> +	crtc_state->cpu_transcoder = INVALID_TRANSCODER;
> +	crtc_state->master_transcoder = INVALID_TRANSCODER;

At least master_transcoder is set to invalid again but we can remove
the redundant sets later

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> +	crtc_state->hsw_workaround_pipe = INVALID_PIPE;
> +	crtc_state->output_format = INTEL_OUTPUT_FORMAT_INVALID;
> +	crtc_state->scaler_state.scaler_id = -1;
> +}
> +
>  /* Returns the currently programmed mode of the given encoder. */
>  struct drm_display_mode *
>  intel_encoder_current_mode(struct intel_encoder *encoder)
> @@ -11729,7 +11740,7 @@ intel_encoder_current_mode(struct
> intel_encoder *encoder)
>  		return NULL;
>  	}
>  
> -	crtc_state->uapi.crtc = &crtc->base;
> +	intel_crtc_state_reset(crtc_state, crtc);
>  
>  	if (!dev_priv->display.get_pipe_config(crtc, crtc_state)) {
>  		kfree(crtc_state);
> @@ -13577,18 +13588,14 @@ verify_crtc_state(struct intel_crtc *crtc,
>  	struct drm_device *dev = crtc->base.dev;
>  	struct drm_i915_private *dev_priv = to_i915(dev);
>  	struct intel_encoder *encoder;
> -	struct intel_crtc_state *pipe_config;
> -	struct drm_atomic_state *state;
> +	struct intel_crtc_state *pipe_config = old_crtc_state;
> +	struct drm_atomic_state *state = old_crtc_state->uapi.state;
>  	bool active;
>  
> -	state = old_crtc_state->uapi.state;
>  	__drm_atomic_helper_crtc_destroy_state(&old_crtc_state->uapi);
>  	intel_crtc_free_hw_state(old_crtc_state);
> -
> -	pipe_config = old_crtc_state;
> -	memset(pipe_config, 0, sizeof(*pipe_config));
> -	pipe_config->uapi.crtc = &crtc->base;
> -	pipe_config->uapi.state = state;
> +	intel_crtc_state_reset(old_crtc_state, crtc);
> +	old_crtc_state->uapi.state = state;
>  
>  	DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.base.id, crtc-
> >base.name);
>  
> @@ -15745,15 +15752,6 @@ intel_cursor_plane_create(struct
> drm_i915_private *dev_priv,
>  	return ERR_PTR(ret);
>  }
>  
> -static void intel_crtc_init_scalers(struct intel_crtc_state
> *crtc_state)
> -{
> -	struct intel_crtc_scaler_state *scaler_state =
> -		&crtc_state->scaler_state;
> -
> -	memset(scaler_state, 0, sizeof(*scaler_state));
> -	scaler_state->scaler_id = -1;
> -}
> -
>  #define INTEL_CRTC_FUNCS \
>  	.gamma_set = drm_atomic_helper_legacy_gamma_set, \
>  	.set_config = drm_atomic_helper_set_config, \
> @@ -15836,9 +15834,9 @@ static struct intel_crtc
> *intel_crtc_alloc(void)
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> -	__drm_atomic_helper_crtc_reset(&crtc->base, &crtc_state->uapi);
> -	intel_crtc_init_scalers(crtc_state);
> +	intel_crtc_state_reset(crtc_state, crtc);
>  
> +	crtc->base.state = &crtc_state->uapi;
>  	crtc->config = crtc_state;
>  
>  	return crtc;
> @@ -17414,8 +17412,7 @@ static void
> intel_modeset_readout_hw_state(struct drm_device *dev)
>  
>  		__drm_atomic_helper_crtc_destroy_state(&crtc_state-
> >uapi);
>  		intel_crtc_free_hw_state(crtc_state);
> -		memset(crtc_state, 0, sizeof(*crtc_state));
> -		__drm_atomic_helper_crtc_reset(&crtc->base,
> &crtc_state->uapi);
> +		intel_crtc_state_reset(crtc_state, crtc);
>  
>  		crtc_state->hw.active = crtc_state->hw.enable =
>  			dev_priv->display.get_pipe_config(crtc,
> crtc_state);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 5/5] drm/i915: Introduce intel_plane_state_reset()
  2019-11-07 14:24   ` [Intel-gfx] " Ville Syrjala
@ 2019-12-10  2:12     ` Souza, Jose
  -1 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:12 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> For the sake of symmetry with the crtc stuff let's add
> a helper to reset the plane state to sane default values.
> For the moment this only gets caller from the plane init.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 15
> +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index 42b3b3449d2e..9429b8e17270 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -41,6 +41,16 @@
>  #include "intel_pm.h"
>  #include "intel_sprite.h"
>  
> +static void intel_plane_state_reset(struct intel_plane_state
> *plane_state,
> +				    struct intel_plane *plane)
> +{
> +	memset(plane_state, 0, sizeof(*plane_state));
> +
> +	__drm_atomic_helper_plane_state_reset(&plane_state->uapi,
> &plane->base);
> +
> +	plane_state->scaler_id = -1;
> +}
> +
>  struct intel_plane *intel_plane_alloc(void)
>  {
>  	struct intel_plane_state *plane_state;
> @@ -56,8 +66,9 @@ struct intel_plane *intel_plane_alloc(void)
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> -	__drm_atomic_helper_plane_reset(&plane->base, &plane_state-
> >uapi);
> -	plane_state->scaler_id = -1;
> +	intel_plane_state_reset(plane_state, plane);
> +
> +	plane->base.state = &plane_state->uapi;
>  
>  	return plane;
>  }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 5/5] drm/i915: Introduce intel_plane_state_reset()
@ 2019-12-10  2:12     ` Souza, Jose
  0 siblings, 0 replies; 37+ messages in thread
From: Souza, Jose @ 2019-12-10  2:12 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx; +Cc: dri-devel

On Thu, 2019-11-07 at 16:24 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> For the sake of symmetry with the crtc stuff let's add
> a helper to reset the plane state to sane default values.
> For the moment this only gets caller from the plane init.
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_atomic_plane.c | 15
> +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index 42b3b3449d2e..9429b8e17270 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -41,6 +41,16 @@
>  #include "intel_pm.h"
>  #include "intel_sprite.h"
>  
> +static void intel_plane_state_reset(struct intel_plane_state
> *plane_state,
> +				    struct intel_plane *plane)
> +{
> +	memset(plane_state, 0, sizeof(*plane_state));
> +
> +	__drm_atomic_helper_plane_state_reset(&plane_state->uapi,
> &plane->base);
> +
> +	plane_state->scaler_id = -1;
> +}
> +
>  struct intel_plane *intel_plane_alloc(void)
>  {
>  	struct intel_plane_state *plane_state;
> @@ -56,8 +66,9 @@ struct intel_plane *intel_plane_alloc(void)
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> -	__drm_atomic_helper_plane_reset(&plane->base, &plane_state-
> >uapi);
> -	plane_state->scaler_id = -1;
> +	intel_plane_state_reset(plane_state, plane);
> +
> +	plane->base.state = &plane_state->uapi;
>  
>  	return plane;
>  }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)
  2019-11-07 14:24 ` Ville Syrjala
                   ` (7 preceding siblings ...)
  (?)
@ 2019-12-12 17:14 ` Patchwork
  -1 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-12-12 17:14 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2)
URL   : https://patchwork.freedesktop.org/series/69129/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7551 -> Patchwork_15718
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/index.html

Known issues
------------

  Here are the changes found in Patchwork_15718 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-j1900:       [PASS][1] -> [DMESG-FAIL][2] ([i915#722])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          [PASS][3] -> [FAIL][4] ([i915#217])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_sync@basic-each:
    - {fi-tgl-u}:         [INCOMPLETE][5] ([i915#472] / [i915#707]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-tgl-u/igt@gem_sync@basic-each.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-tgl-u/igt@gem_sync@basic-each.html

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-kbl-7500u:       [FAIL][7] ([i915#217]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][9] ([fdo#111096] / [i915#323]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-x1275:       [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-kbl-x1275/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][15] ([i915#553] / [i915#725]) -> [DMESG-FAIL][16] ([i915#770])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-hsw-peppy:       [DMESG-FAIL][17] ([i915#722]) -> [INCOMPLETE][18] ([i915#694])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7551/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#707]: https://gitlab.freedesktop.org/drm/intel/issues/707
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (52 -> 45)
------------------------------

  Additional (1): fi-gdg-551 
  Missing    (8): fi-icl-1065g7 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-ivb-3770 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7551 -> Patchwork_15718

  CI-20190529: 20190529
  CI_DRM_7551: e60aa4ffc106f910452d28f2ea49ae2ff44d85d5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5346: 466b0e6cbcbaccff012b484d1fd7676364b37b93 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15718: 0a8377e9b305889880170bac8941ee0fb091774a @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

0a8377e9b305 drm/i915: Introduce intel_plane_state_reset()
82b3597288bd drm/i915: Introduce intel_crtc_state_reset()
be565963b13d drm/i915: Introduce intel_crtc_{alloc, free}()
1e02e7ceee83 drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
65ffde2144e1 drm: Add __drm_atomic_helper_crtc_state_reset() & co.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15718/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
  2019-11-07 14:24 ` Ville Syrjala
@ 2019-12-13 23:38   ` Lucas De Marchi
  -1 siblings, 0 replies; 37+ messages in thread
From: Lucas De Marchi @ 2019-12-13 23:38 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: intel-gfx, dri-devel

On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>Annoyingly __drm_atomic_helper_crtc_reset() does two
>totally separate things:
>a) reset the state to defaults values
>b) assign the crtc->state pointer
>
>I just want a) without the b) so let's split out part
>a) into __drm_atomic_helper_crtc_state_reset(). And
>of course we'll do the same thing for planes and connectors.
>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
> include/drm/drm_atomic_state_helper.h     |  6 ++
> 2 files changed, 67 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
>index d0a937fb0c56..a972068d58cf 100644
>--- a/drivers/gpu/drm/drm_atomic_state_helper.c
>+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
>@@ -57,6 +57,22 @@
>  * for these functions.
>  */
>
>+/**
>+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
>+ * @crtc_state: atomic CRTC state, must not be NULL
>+ * @crtc: CRTC object, must not be NULL
>+ *
>+ * Initializes the newly allocated @crtc_state with default
>+ * values. This is useful for drivers that subclass the CRTC state.
>+ */
>+void
>+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
>+				     struct drm_crtc *crtc)
>+{
>+	crtc_state->crtc = crtc;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
>+
> /**
>  * __drm_atomic_helper_crtc_reset - reset state on CRTC
>  * @crtc: drm CRTC
>@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> 			       struct drm_crtc_state *crtc_state)
> {
> 	if (crtc_state)
>-		crtc_state->crtc = crtc;
>+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
>
> 	crtc->state = crtc_state;
> }
>@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
>
> /**
>- * __drm_atomic_helper_plane_reset - resets planes state to default values
>+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
>+ * @plane_state: atomic plane state, must not be NULL
>  * @plane: plane object, must not be NULL
>- * @state: atomic plane state, must not be NULL
>  *
>- * Initializes plane state to default. This is useful for drivers that subclass
>- * the plane state.
>+ * Initializes the newly allocated @plane_state with default
>+ * values. This is useful for drivers that subclass the CRTC state.
>  */
>-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>-				     struct drm_plane_state *state)
>+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
>+					   struct drm_plane *plane)
> {
> 	state->plane = plane;
> 	state->rotation = DRM_MODE_ROTATE_0;
>
> 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
>
>-	plane->state = state;
>+/**
>+ * __drm_atomic_helper_plane_reset - reset state on plane
>+ * @plane: drm plane
>+ * @plane_state: plane state to assign
>+ *
>+ * Initializes the newly allocated @plane_state and assigns it to
>+ * the &drm_crtc->state pointer of @plane, usually required when
>+ * initializing the drivers or when called from the &drm_plane_funcs.reset
>+ * hook.
>+ *
>+ * This is useful for drivers that subclass the plane state.
>+ */
>+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>+				     struct drm_plane_state *plane_state)
>+{
>+	if (plane_state)
>+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
>+
>+	plane->state = plane_state;
> }
> EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
>
>@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> }
> EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
>
>+/**
>+ * __drm_atomic_helper_connector_state_reset - reset the connector state
>+ * @conn__state: atomic connector state, must not be NULL

typo here, otherwise


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>+ * @connector: connectotr object, must not be NULL
>+ *
>+ * Initializes the newly allocated @conn_state with default
>+ * values. This is useful for drivers that subclass the connector state.
>+ */
>+void
>+__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
>+					  struct drm_connector *connector)
>+{
>+	conn_state->connector = connector;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
>+
> /**
>  * __drm_atomic_helper_connector_reset - reset state on connector
>  * @connector: drm connector
>@@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
> 				    struct drm_connector_state *conn_state)
> {
> 	if (conn_state)
>-		conn_state->connector = connector;
>+		__drm_atomic_helper_connector_state_reset(conn_state, connector);
>
> 	connector->state = conn_state;
> }
>diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
>index e4577cc11689..8171dea4cc22 100644
>--- a/include/drm/drm_atomic_state_helper.h
>+++ b/include/drm/drm_atomic_state_helper.h
>@@ -37,6 +37,8 @@ struct drm_private_state;
> struct drm_modeset_acquire_ctx;
> struct drm_device;
>
>+void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
>+					  struct drm_crtc *crtc);
> void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> 				    struct drm_crtc_state *state);
> void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
>@@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
> void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> 					  struct drm_crtc_state *state);
>
>+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
>+					   struct drm_plane *plane);
> void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> 				     struct drm_plane_state *state);
> void drm_atomic_helper_plane_reset(struct drm_plane *plane);
>@@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
> void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> 					  struct drm_plane_state *state);
>
>+void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
>+					       struct drm_connector *connector);
> void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
> 					 struct drm_connector_state *conn_state);
> void drm_atomic_helper_connector_reset(struct drm_connector *connector);
>-- 
>2.23.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-12-13 23:38   ` Lucas De Marchi
  0 siblings, 0 replies; 37+ messages in thread
From: Lucas De Marchi @ 2019-12-13 23:38 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: intel-gfx, dri-devel

On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>Annoyingly __drm_atomic_helper_crtc_reset() does two
>totally separate things:
>a) reset the state to defaults values
>b) assign the crtc->state pointer
>
>I just want a) without the b) so let's split out part
>a) into __drm_atomic_helper_crtc_state_reset(). And
>of course we'll do the same thing for planes and connectors.
>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
> include/drm/drm_atomic_state_helper.h     |  6 ++
> 2 files changed, 67 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
>index d0a937fb0c56..a972068d58cf 100644
>--- a/drivers/gpu/drm/drm_atomic_state_helper.c
>+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
>@@ -57,6 +57,22 @@
>  * for these functions.
>  */
>
>+/**
>+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
>+ * @crtc_state: atomic CRTC state, must not be NULL
>+ * @crtc: CRTC object, must not be NULL
>+ *
>+ * Initializes the newly allocated @crtc_state with default
>+ * values. This is useful for drivers that subclass the CRTC state.
>+ */
>+void
>+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
>+				     struct drm_crtc *crtc)
>+{
>+	crtc_state->crtc = crtc;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
>+
> /**
>  * __drm_atomic_helper_crtc_reset - reset state on CRTC
>  * @crtc: drm CRTC
>@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> 			       struct drm_crtc_state *crtc_state)
> {
> 	if (crtc_state)
>-		crtc_state->crtc = crtc;
>+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
>
> 	crtc->state = crtc_state;
> }
>@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
>
> /**
>- * __drm_atomic_helper_plane_reset - resets planes state to default values
>+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
>+ * @plane_state: atomic plane state, must not be NULL
>  * @plane: plane object, must not be NULL
>- * @state: atomic plane state, must not be NULL
>  *
>- * Initializes plane state to default. This is useful for drivers that subclass
>- * the plane state.
>+ * Initializes the newly allocated @plane_state with default
>+ * values. This is useful for drivers that subclass the CRTC state.
>  */
>-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>-				     struct drm_plane_state *state)
>+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
>+					   struct drm_plane *plane)
> {
> 	state->plane = plane;
> 	state->rotation = DRM_MODE_ROTATE_0;
>
> 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
>
>-	plane->state = state;
>+/**
>+ * __drm_atomic_helper_plane_reset - reset state on plane
>+ * @plane: drm plane
>+ * @plane_state: plane state to assign
>+ *
>+ * Initializes the newly allocated @plane_state and assigns it to
>+ * the &drm_crtc->state pointer of @plane, usually required when
>+ * initializing the drivers or when called from the &drm_plane_funcs.reset
>+ * hook.
>+ *
>+ * This is useful for drivers that subclass the plane state.
>+ */
>+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
>+				     struct drm_plane_state *plane_state)
>+{
>+	if (plane_state)
>+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
>+
>+	plane->state = plane_state;
> }
> EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
>
>@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> }
> EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
>
>+/**
>+ * __drm_atomic_helper_connector_state_reset - reset the connector state
>+ * @conn__state: atomic connector state, must not be NULL

typo here, otherwise


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>+ * @connector: connectotr object, must not be NULL
>+ *
>+ * Initializes the newly allocated @conn_state with default
>+ * values. This is useful for drivers that subclass the connector state.
>+ */
>+void
>+__drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
>+					  struct drm_connector *connector)
>+{
>+	conn_state->connector = connector;
>+}
>+EXPORT_SYMBOL(__drm_atomic_helper_connector_state_reset);
>+
> /**
>  * __drm_atomic_helper_connector_reset - reset state on connector
>  * @connector: drm connector
>@@ -352,7 +404,7 @@ __drm_atomic_helper_connector_reset(struct drm_connector *connector,
> 				    struct drm_connector_state *conn_state)
> {
> 	if (conn_state)
>-		conn_state->connector = connector;
>+		__drm_atomic_helper_connector_state_reset(conn_state, connector);
>
> 	connector->state = conn_state;
> }
>diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic_state_helper.h
>index e4577cc11689..8171dea4cc22 100644
>--- a/include/drm/drm_atomic_state_helper.h
>+++ b/include/drm/drm_atomic_state_helper.h
>@@ -37,6 +37,8 @@ struct drm_private_state;
> struct drm_modeset_acquire_ctx;
> struct drm_device;
>
>+void __drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *state,
>+					  struct drm_crtc *crtc);
> void __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> 				    struct drm_crtc_state *state);
> void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc);
>@@ -48,6 +50,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state);
> void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> 					  struct drm_crtc_state *state);
>
>+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
>+					   struct drm_plane *plane);
> void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> 				     struct drm_plane_state *state);
> void drm_atomic_helper_plane_reset(struct drm_plane *plane);
>@@ -59,6 +63,8 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state);
> void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> 					  struct drm_plane_state *state);
>
>+void __drm_atomic_helper_connector_state_reset(struct drm_connector_state *conn_state,
>+					       struct drm_connector *connector);
> void __drm_atomic_helper_connector_reset(struct drm_connector *connector,
> 					 struct drm_connector_state *conn_state);
> void drm_atomic_helper_connector_reset(struct drm_connector *connector);
>-- 
>2.23.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-11-07 14:24 ` Ville Syrjala
                   ` (9 preceding siblings ...)
  (?)
@ 2019-12-17  1:40 ` Patchwork
  -1 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-12-17  1:40 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
URL   : https://patchwork.freedesktop.org/series/69129/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15797
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15797 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15797, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15797:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_execlists:
    - fi-whl-u:           [PASS][1] -> [DMESG-FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-whl-u/igt@i915_selftest@live_execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-whl-u/igt@i915_selftest@live_execlists.html

  * igt@runner@aborted:
    - fi-whl-u:           NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-whl-u/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_15797 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-byt-j1900:       [PASS][4] -> [DMESG-FAIL][5] ([i915#725])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-j1900/igt@i915_selftest@live_blt.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-byt-j1900/igt@i915_selftest@live_blt.html
    - fi-hsw-4770r:       [PASS][6] -> [DMESG-FAIL][7] ([i915#553] / [i915#725])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8700k:       [PASS][8] -> [INCOMPLETE][9] ([i915#424])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
    - fi-hsw-peppy:       [PASS][10] -> [INCOMPLETE][11] ([i915#694])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          [FAIL][12] ([fdo#103375]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-icl-u2:          [FAIL][14] ([fdo#111550]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [DMESG-FAIL][16] ([i915#725]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-ivb-3770/igt@i915_selftest@live_blt.html
    - fi-hsw-4770:        [DMESG-FAIL][18] ([i915#553] / [i915#725]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-guc:         [DMESG-FAIL][20] ([i915#730]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-icl-u2:          [INCOMPLETE][22] ([i915#140]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][24] ([fdo#109635] / [i915#217]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][26] ([i915#62] / [i915#92]) -> [DMESG-WARN][27] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][28] ([i915#722]) -> [INCOMPLETE][29] ([i915#45])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][30] ([fdo#111096] / [i915#323]) -> [FAIL][31] ([fdo#111407])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][32] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][33] ([i915#62] / [i915#92]) +8 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
  [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (51 -> 45)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7578 -> Patchwork_15797

  CI-20190529: 20190529
  CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15797: c9ce87cc69c02a0b54e20631bc629e0414d56074 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

c9ce87cc69c0 drm/i915: Introduce intel_plane_state_reset()
d1454f4df0f9 drm/i915: Introduce intel_crtc_state_reset()
c43cffc7f3ae drm/i915: Introduce intel_crtc_{alloc, free}()
05aa123de7bc drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
99fa86ded6f9 drm: Add __drm_atomic_helper_crtc_state_reset() & co.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-11-07 14:24 ` Ville Syrjala
                   ` (10 preceding siblings ...)
  (?)
@ 2019-12-17 11:46 ` Patchwork
  -1 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-12-17 11:46 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
URL   : https://patchwork.freedesktop.org/series/69129/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7578 -> Patchwork_15797
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html

Known issues
------------

  Here are the changes found in Patchwork_15797 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_blt:
    - fi-byt-j1900:       [PASS][1] -> [DMESG-FAIL][2] ([i915#725])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-j1900/igt@i915_selftest@live_blt.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-byt-j1900/igt@i915_selftest@live_blt.html
    - fi-hsw-4770r:       [PASS][3] -> [DMESG-FAIL][4] ([i915#553] / [i915#725])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770r/igt@i915_selftest@live_blt.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-4770r/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_execlists:
    - fi-whl-u:           [PASS][5] -> [DMESG-FAIL][6] ([i915#841])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-whl-u/igt@i915_selftest@live_execlists.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-whl-u/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8700k:       [PASS][7] -> [INCOMPLETE][8] ([i915#424])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
    - fi-hsw-peppy:       [PASS][9] -> [INCOMPLETE][10] ([i915#694])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-icl-u2:          [FAIL][11] ([fdo#103375]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-icl-u2:          [FAIL][13] ([fdo#111550]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [DMESG-FAIL][15] ([i915#725]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-ivb-3770/igt@i915_selftest@live_blt.html
    - fi-hsw-4770:        [DMESG-FAIL][17] ([i915#553] / [i915#725]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-guc:         [DMESG-FAIL][19] ([i915#730]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_busy@basic-flip-pipe-a:
    - fi-icl-u2:          [INCOMPLETE][21] ([i915#140]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-icl-u2/igt@kms_busy@basic-flip-pipe-a.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-kbl-7500u:       [FAIL][23] ([fdo#109635] / [i915#217]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][25] ([i915#62] / [i915#92]) -> [DMESG-WARN][26] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-byt-n2820:       [DMESG-FAIL][27] ([i915#722]) -> [INCOMPLETE][28] ([i915#45])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][29] ([fdo#111096] / [i915#323]) -> [FAIL][30] ([fdo#111407])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-kbl-x1275:       [DMESG-WARN][31] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][32] ([i915#62] / [i915#92]) +8 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
  [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#730]: https://gitlab.freedesktop.org/drm/intel/issues/730
  [i915#841]: https://gitlab.freedesktop.org/drm/intel/issues/841
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (51 -> 45)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7578 -> Patchwork_15797

  CI-20190529: 20190529
  CI_DRM_7578: cc329d389f5609d2969d0797bc96f754adb26d62 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15797: c9ce87cc69c02a0b54e20631bc629e0414d56074 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

c9ce87cc69c0 drm/i915: Introduce intel_plane_state_reset()
d1454f4df0f9 drm/i915: Introduce intel_crtc_state_reset()
c43cffc7f3ae drm/i915: Introduce intel_crtc_{alloc, free}()
05aa123de7bc drm/i915: s/intel_crtc/crtc/ in intel_crtc_init()
99fa86ded6f9 drm: Add __drm_atomic_helper_crtc_state_reset() & co.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-11-07 14:24 ` Ville Syrjala
                   ` (11 preceding siblings ...)
  (?)
@ 2019-12-17 18:10 ` Patchwork
  2019-12-17 18:33   ` Souza, Jose
  -1 siblings, 1 reply; 37+ messages in thread
From: Patchwork @ 2019-12-17 18:10 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
URL   : https://patchwork.freedesktop.org/series/69129/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15797_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15797_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15797_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_big_fb@linear-16bpp-rotate-180:
    - shard-tglb:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-180.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-180.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-skl:          [PASS][3] -> ([INCOMPLETE][4], [PASS][5])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_frontbuffer_tracking@basic.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_frontbuffer_tracking@basic.html

  

### Piglit changes ###

#### Possible regressions ####

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 3 (NEW):
    - {pig-hsw-4770r}:    NOTRUN -> [FAIL][6] +20 similar issues
   [6]: None

  
New tests
---------

  New tests have been introduced between CI_DRM_7578_full and Patchwork_15797_full:

### New Piglit tests (21) ###

  * object namespace pollution@texture with glgetteximage-compressed:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * object namespace pollution@texture with gltexsubimage2d:
    - Statuses : 1 fail(s)
    - Exec time: [0.15] s

  * spec@arb_gpu_shader5@texturegather@vs-rgb-0-float-cube:
    - Statuses : 1 fail(s)
    - Exec time: [1.83] s

  * spec@arb_query_buffer_object@coherency:
    - Statuses : 1 fail(s)
    - Exec time: [0.22] s

  * spec@arb_shader_image_load_store@host-mem-barrier:
    - Statuses : 1 fail(s)
    - Exec time: [5.66] s

  * spec@arb_shader_image_load_store@layer:
    - Statuses : 1 fail(s)
    - Exec time: [0.31] s

  * spec@arb_shader_image_load_store@level:
    - Statuses : 1 fail(s)
    - Exec time: [0.27] s

  * spec@arb_shader_image_load_store@semantics:
    - Statuses : 1 fail(s)
    - Exec time: [0.53] s

  * spec@arb_shader_image_load_store@unused:
    - Statuses : 1 fail(s)
    - Exec time: [0.16] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 1 8 128 2:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 1 128 4:
    - Statuses : 1 fail(s)
    - Exec time: [0.08] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 128 2:
    - Statuses : 1 fail(s)
    - Exec time: [0.10] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 128 3:
    - Statuses : 1 fail(s)
    - Exec time: [0.12] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 3:
    - Statuses : 1 fail(s)
    - Exec time: [0.24] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 4:
    - Statuses : 1 fail(s)
    - Exec time: [0.27] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.26] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 128 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.19] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.17] s

  * spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat3-float_mat3x2_array3:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * spec@arb_vertex_type_2_10_10_10_rev@attribs:
    - Statuses : 1 fail(s)
    - Exec time: [0.95] s

  * spec@glsl-4.20@execution@vs_in@vs-input-int_ivec3_array3-position-double_dmat3_array2:
    - Statuses : 1 fail(s)
    - Exec time: [0.18] s

  

Known issues
------------

  Here are the changes found in Patchwork_15797_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vcs1-none:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html

  * igt@gem_ctx_persistence@bcs0-mixed-process:
    - shard-apl:          [PASS][9] -> ([FAIL][10], [PASS][11]) ([i915#679])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ctx_persistence@bcs0-mixed-process.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_ctx_persistence@bcs0-mixed-process.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@gem_ctx_persistence@bcs0-mixed-process.html

  * igt@gem_ctx_persistence@vecs0-mixed-process:
    - shard-glk:          [PASS][12] -> ([PASS][13], [FAIL][14]) ([i915#679])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gem_ctx_persistence@vecs0-mixed-process.html

  * igt@gem_exec_async@concurrent-writes-bsd2:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd2.html

  * igt@gem_exec_gttfill@basic:
    - shard-tglb:         [PASS][17] -> [INCOMPLETE][18] ([fdo#111593])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#112146]) +5 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
    - shard-tglb:         [PASS][21] -> [INCOMPLETE][22] ([fdo#111606] / [fdo#111677])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-tglb:         [PASS][23] -> [TIMEOUT][24] ([fdo#112126] / [i915#530])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][25] -> ([FAIL][26], [PASS][27]) ([i915#644])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
    - shard-apl:          [PASS][28] -> ([FAIL][29], [PASS][30]) ([i915#644])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][31] -> ([DMESG-WARN][32], [PASS][33]) ([i915#180]) +4 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_hangman@error-state-capture-vcs1:
    - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#112080])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@i915_hangman@error-state-capture-vcs1.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-skl:          [PASS][36] -> ([PASS][37], [INCOMPLETE][38]) ([i915#198])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@i915_pm_dc@dc5-psr.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@i915_pm_dc@dc5-psr.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_selftest@mock_sanitycheck:
    - shard-skl:          [PASS][39] -> ([PASS][40], [DMESG-WARN][41]) ([i915#747])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl5/igt@i915_selftest@mock_sanitycheck.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_selftest@mock_sanitycheck.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@i915_selftest@mock_sanitycheck.html

  * igt@i915_suspend@forcewake:
    - shard-skl:          [PASS][42] -> ([INCOMPLETE][43], [PASS][44]) ([i915#69])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl9/igt@i915_suspend@forcewake.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_suspend@forcewake.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@i915_suspend@forcewake.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_suspend@sysfs-reader.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@i915_suspend@sysfs-reader.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - shard-skl:          [PASS][47] -> ([DMESG-WARN][48], [PASS][49]) ([i915#109])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +2 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
    - shard-hsw:          [PASS][52] -> ([DMESG-WARN][53], [PASS][54]) ([IGT#6] / [i915#435])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw6/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
    - shard-skl:          [PASS][55] -> ([FAIL][56], [PASS][57]) ([i915#54]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html

  * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
    - shard-skl:          [PASS][58] -> ([INCOMPLETE][59], [PASS][60]) ([fdo#112347] / [i915#646] / [i915#667])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][61] -> ([FAIL][62], [PASS][63]) ([i915#46])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
    - shard-iclb:         [PASS][64] -> [INCOMPLETE][65] ([i915#140])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][66] -> [INCOMPLETE][67] ([i915#123] / [i915#140])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
    - shard-tglb:         [PASS][68] -> [INCOMPLETE][69] ([i915#474] / [i915#667])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
    - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72]) ([i915#49])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [PASS][73] -> [INCOMPLETE][74] ([i915#456] / [i915#460]) +1 similar issue
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][75] -> ([FAIL][76], [FAIL][77]) ([fdo#108145] / [i915#265])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_psr@psr2_suspend:
    - shard-tglb:         [PASS][78] -> [DMESG-WARN][79] ([i915#402])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_psr@psr2_suspend.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_psr@psr2_suspend.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][80] -> ([FAIL][81], [FAIL][82]) ([i915#31])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@kms_setmode@basic.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_busy@close-race:
    - shard-tglb:         [INCOMPLETE][83] ([i915#435]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb2/igt@gem_busy@close-race.html

  * igt@gem_ctx_persistence@vcs0-mixed-process:
    - shard-apl:          [FAIL][85] ([i915#679]) -> ([PASS][86], [PASS][87])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-iclb:         [SKIP][88] ([fdo#109276] / [fdo#112080]) -> [PASS][89] +1 similar issue
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html

  * igt@gem_eio@banned:
    - shard-tglb:         [INCOMPLETE][90] ([i915#476]) -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@gem_eio@banned.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][92] ([fdo#110854]) -> [PASS][93]
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_balancer@smoke.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_reloc@basic-wc-active:
    - shard-skl:          [DMESG-WARN][94] ([i915#109]) -> ([PASS][95], [PASS][96])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@gem_exec_reloc@basic-wc-active.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@gem_exec_reloc@basic-wc-active.html

  * igt@gem_exec_schedule@preempt-queue-bsd2:
    - shard-iclb:         [SKIP][97] ([fdo#109276]) -> [PASS][98] +10 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html

  * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
    - shard-tglb:         [INCOMPLETE][99] ([fdo#111677]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [SKIP][101] ([fdo#112146]) -> [PASS][102] +2 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * igt@gem_exec_schedule@smoketest-bsd2:
    - shard-tglb:         [INCOMPLETE][103] ([i915#707]) -> [PASS][104]
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb1/igt@gem_exec_schedule@smoketest-bsd2.html

  * igt@gem_softpin@noreloc-s3:
    - shard-tglb:         [INCOMPLETE][105] ([i915#456]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_softpin@noreloc-s3.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_softpin@noreloc-s3.html

  * {igt@gen9_exec_parse@allowed-single}:
    - shard-glk:          [DMESG-WARN][107] ([i915#716]) -> ([PASS][108], [PASS][109])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gen9_exec_parse@allowed-single.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gen9_exec_parse@allowed-single.html
    - shard-apl:          [DMESG-WARN][110] ([i915#716]) -> [PASS][111]
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][112] ([i915#180]) -> ([PASS][113], [PASS][114])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
    - shard-skl:          [FAIL][115] ([i915#54]) -> [PASS][116]
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
    - shard-hsw:          [DMESG-WARN][117] ([IGT#6]) -> ([PASS][118], [PASS][119])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw5/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-tglb:         [INCOMPLETE][120] ([i915#456] / [i915#460]) -> [PASS][121]
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][122] ([i915#79]) -> ([PASS][123], [PASS][124])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [FAIL][125] ([i915#79]) -> ([PASS][126], [PASS][127])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-skl:          [INCOMPLETE][128] ([i915#221]) -> ([PASS][129], [PASS][130])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_flip@flip-vs-suspend.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_flip@flip-vs-suspend.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
    - shard-tglb:         [FAIL][131] ([i915#49]) -> [PASS][132]
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-tglb:         [INCOMPLETE][133] ([i915#456] / [i915#460] / [i915#474]) -> [PASS][134]
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-iclb:         [INCOMPLETE][135] ([i915#140] / [i915#246]) -> [PASS][136]
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][137] ([fdo#109441]) -> [PASS][138] +1 similar issue
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][139] ([i915#180]) -> [PASS][140] +1 similar issue
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [SKIP][141] ([fdo#112080]) -> [PASS][142] +5 similar issues
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs2-s3:
    - shard-tglb:         [SKIP][143] ([fdo#111912] / [fdo#112080]) -> [SKIP][144] ([fdo#112080])
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html

  * igt@gem_tiled_blits@normal:
    - shard-hsw:          [FAIL][145] ([i915#818]) -> ([FAIL][146], [DMESG-FAIL][147]) ([i915#44] / [i915#818])
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_tiled_blits@normal.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw2/igt@gem_tiled_blits@normal.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@gem_tiled_blits@normal.html

  * igt@kms_atomic_transition@6x-modeset-transitions:
    - shard-tglb:         [SKIP][148] ([fdo#112021]) -> [SKIP][149] ([fdo#112016] / [fdo#112021])
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-apl:          [DMESG-WARN][150] ([i915#180]) -> ([PASS][151], [DMESG-WARN][152]) ([i915#180])
   [150]: https://intel-gfx-ci.01.org

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx]  ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-12-17 18:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-12-17 18:33   ` Souza, Jose
  2019-12-17 18:42     ` James Ausmus
  0 siblings, 1 reply; 37+ messages in thread
From: Souza, Jose @ 2019-12-17 18:33 UTC (permalink / raw)
  To: ville.syrjala, intel-gfx

On Tue, 2019-12-17 at 18:10 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/5] drm: Add
> __drm_atomic_helper_crtc_state_reset() & co. (rev3)
> URL   : https://patchwork.freedesktop.org/series/69129/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_15797_full absolutely
> need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the
> changes
>   introduced in Patchwork_15797_full, please notify your bug team to
> allow them
>   to document this new failure mode, which will reduce false
> positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_15797_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_big_fb@linear-16bpp-rotate-180:
>     - shard-tglb:         [PASS][1] -> [DMESG-WARN][2]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-180.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-180.html

This one is not related to the changes in this series

> 
>   * igt@kms_frontbuffer_tracking@basic:
>     - shard-skl:          [PASS][3] -> ([INCOMPLETE][4], [PASS][5])
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_frontbuffer_tracking@basic.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_frontbuffer_tracking@basic.html
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_frontbuffer_tracking@basic.html
> 

Getting AccessDenied when trying to access the error reports

>   
> 
> ### Piglit changes ###
> 
> #### Possible regressions ####
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 1 8 128 3 (NEW):
>     - {pig-hsw-4770r}:    NOTRUN -> [FAIL][6] +20 similar issues
>    [6]: None
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_7578_full and
> Patchwork_15797_full:
> 
> ### New Piglit tests (21) ###
> 
>   * object namespace pollution@texture with glgetteximage-compressed:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.13] s
> 
>   * object namespace pollution@texture with gltexsubimage2d:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.15] s
> 
>   * spec@arb_gpu_shader5@texturegather@vs-rgb-0-float-cube:
>     - Statuses : 1 fail(s)
>     - Exec time: [1.83] s
> 
>   * spec@arb_query_buffer_object@coherency:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.22] s
> 
>   * spec@arb_shader_image_load_store@host-mem-barrier:
>     - Statuses : 1 fail(s)
>     - Exec time: [5.66] s
> 
>   * spec@arb_shader_image_load_store@layer:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.31] s
> 
>   * spec@arb_shader_image_load_store@level:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.27] s
> 
>   * spec@arb_shader_image_load_store@semantics:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.53] s
> 
>   * spec@arb_shader_image_load_store@unused:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.16] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 32 1 8 128 2:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.13] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 32 42 1 128 4:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.08] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 32 42 8 128 2:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.10] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 32 42 8 128 3:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.12] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 1 8 128 3:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.24] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 1 8 128 4:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.27] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 1 8 128 8:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.26] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 42 1 128 8:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.19] s
> 
>   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> 512 42 1 8 8:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.17] s
> 
>   * spec@arb_vertex_attrib_64bit@execution@
> vs_in@vs-input-position-double_dmat3-float_mat3x2_array3:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.13] s
> 
>   * spec@arb_vertex_type_2_10_10_10_rev@attribs:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.95] s
> 
>   * spec@glsl-4.20@execution@vs_in@vs-input-int_ivec3_array3-
> position-double_dmat3_array2:
>     - Statuses : 1 fail(s)
>     - Exec time: [0.18] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_15797_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_isolation@vcs1-none:
>     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] /
> [fdo#112080])
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
> 
>   * igt@gem_ctx_persistence@bcs0-mixed-process:
>     - shard-apl:          [PASS][9] -> ([FAIL][10], [PASS][11])
> ([i915#679])
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ctx_persistence@bcs0-mixed-process.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_ctx_persistence@bcs0-mixed-process.html
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@gem_ctx_persistence@bcs0-mixed-process.html
> 
>   * igt@gem_ctx_persistence@vecs0-mixed-process:
>     - shard-glk:          [PASS][12] -> ([PASS][13], [FAIL][14])
> ([i915#679])
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gem_ctx_persistence@vecs0-mixed-process.html
> 
>   * igt@gem_exec_async@concurrent-writes-bsd2:
>     - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276])
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd2.html
> 
>   * igt@gem_exec_gttfill@basic:
>     - shard-tglb:         [PASS][17] -> [INCOMPLETE][18]
> ([fdo#111593])
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_gttfill@basic.html
> 
>   * igt@gem_exec_schedule@preempt-other-chain-bsd:
>     - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#112146]) +5
> similar issues
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> 
>   * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
>     - shard-tglb:         [PASS][21] -> [INCOMPLETE][22]
> ([fdo#111606] / [fdo#111677])
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
> 
>   * igt@gem
> _persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive
> :
>     - shard-tglb:         [PASS][23] -> [TIMEOUT][24] ([fdo#112126] /
> [i915#530])
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][25] -> ([FAIL][26], [PASS][27])
> ([i915#644])
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
>     - shard-apl:          [PASS][28] -> ([FAIL][29], [PASS][30])
> ([i915#644])
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@gem_workarounds@suspend-resume-context:
>     - shard-apl:          [PASS][31] -> ([DMESG-WARN][32],
> [PASS][33]) ([i915#180]) +4 similar issues
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
> 
>   * igt@i915_hangman@error-state-capture-vcs1:
>     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#112080])
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@i915_hangman@error-state-capture-vcs1.html
> 
>   * igt@i915_pm_dc@dc5-psr:
>     - shard-skl:          [PASS][36] -> ([PASS][37],
> [INCOMPLETE][38]) ([i915#198])
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@i915_pm_dc@dc5-psr.html
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@i915_pm_dc@dc5-psr.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@i915_pm_dc@dc5-psr.html
> 
>   * igt@i915_selftest@mock_sanitycheck:
>     - shard-skl:          [PASS][39] -> ([PASS][40], [DMESG-
> WARN][41]) ([i915#747])
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl5/igt@i915_selftest@mock_sanitycheck.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_selftest@mock_sanitycheck.html
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@i915_selftest@mock_sanitycheck.html
> 
>   * igt@i915_suspend@forcewake:
>     - shard-skl:          [PASS][42] -> ([INCOMPLETE][43],
> [PASS][44]) ([i915#69])
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl9/igt@i915_suspend@forcewake.html
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_suspend@forcewake.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@i915_suspend@forcewake.html
> 
>   * igt@i915_suspend@sysfs-reader:
>     - shard-apl:          [PASS][45] -> [DMESG-WARN][46] ([i915#180])
> +1 similar issue
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_suspend@sysfs-reader.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@i915_suspend@sysfs-reader.html
> 
>   * igt@kms_color@pipe-a-ctm-0-75:
>     - shard-skl:          [PASS][47] -> ([DMESG-WARN][48],
> [PASS][49]) ([i915#109])
>    [47]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-kbl:          [PASS][50] -> [DMESG-WARN][51] ([i915#180])
> +2 similar issues
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
>     - shard-hsw:          [PASS][52] -> ([DMESG-WARN][53],
> [PASS][54]) ([IGT#6] / [i915#435])
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw6/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
>     - shard-skl:          [PASS][55] -> ([FAIL][56], [PASS][57])
> ([i915#54]) +1 similar issue
>    [55]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
>     - shard-skl:          [PASS][58] -> ([INCOMPLETE][59],
> [PASS][60]) ([fdo#112347] / [i915#646] / [i915#667])
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
>    [59]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [PASS][61] -> ([FAIL][62], [PASS][63])
> ([i915#46])
>    [61]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
>    [63]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
>     - shard-iclb:         [PASS][64] -> [INCOMPLETE][65] ([i915#140])
>    [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
>    [65]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [PASS][66] -> [INCOMPLETE][67] ([i915#123]
> / [i915#140])
>    [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>    [67]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][68] -> [INCOMPLETE][69] ([i915#474]
> / [i915#667])
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
>    [69]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
> 
>   * igt@kms
> _frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
>     - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72])
> ([i915#49])
>    [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
>    [71]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
>    [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> 
>   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
>     - shard-tglb:         [PASS][73] -> [INCOMPLETE][74] ([i915#456]
> / [i915#460]) +1 similar issue
>    [73]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [PASS][75] -> ([FAIL][76], [FAIL][77])
> ([fdo#108145] / [i915#265])
>    [75]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>    [77]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> 
>   * igt@kms_psr@psr2_suspend:
>     - shard-tglb:         [PASS][78] -> [DMESG-WARN][79] ([i915#402])
>    [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_psr@psr2_suspend.html
>    [79]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_psr@psr2_suspend.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [PASS][80] -> ([FAIL][81], [FAIL][82])
> ([i915#31])
>    [80]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
>    [81]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@kms_setmode@basic.html
>    [82]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@kms_setmode@basic.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_busy@close-race:
>     - shard-tglb:         [INCOMPLETE][83] ([i915#435]) -> [PASS][84]
>    [83]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
>    [84]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb2/igt@gem_busy@close-race.html
> 
>   * igt@gem_ctx_persistence@vcs0-mixed-process:
>     - shard-apl:          [FAIL][85] ([i915#679]) -> ([PASS][86],
> [PASS][87])
>    [85]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
>    [86]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@gem_ctx_persistence@vcs0-mixed-process.html
>    [87]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> 
>   * igt@gem_ctx_persistence@vcs1-mixed-process:
>     - shard-iclb:         [SKIP][88] ([fdo#109276] / [fdo#112080]) ->
> [PASS][89] +1 similar issue
>    [88]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
>    [89]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html
> 
>   * igt@gem_eio@banned:
>     - shard-tglb:         [INCOMPLETE][90] ([i915#476]) -> [PASS][91]
>    [90]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
>    [91]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@gem_eio@banned.html
> 
>   * igt@gem_exec_balancer@smoke:
>     - shard-iclb:         [SKIP][92] ([fdo#110854]) -> [PASS][93]
>    [92]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_balancer@smoke.html
>    [93]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_balancer@smoke.html
> 
>   * igt@gem_exec_reloc@basic-wc-active:
>     - shard-skl:          [DMESG-WARN][94] ([i915#109]) ->
> ([PASS][95], [PASS][96])
>    [94]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@gem_exec_reloc@basic-wc-active.html
>    [95]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html
>    [96]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@gem_exec_reloc@basic-wc-active.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd2:
>     - shard-iclb:         [SKIP][97] ([fdo#109276]) -> [PASS][98] +10
> similar issues
>    [97]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
>    [98]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html
> 
>   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
>     - shard-tglb:         [INCOMPLETE][99] ([fdo#111677]) ->
> [PASS][100]
>    [99]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
>    [100]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> 
>   * igt@gem_exec_schedule@preemptive-hang-bsd:
>     - shard-iclb:         [SKIP][101] ([fdo#112146]) -> [PASS][102]
> +2 similar issues
>    [101]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
>    [102]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
> 
>   * igt@gem_exec_schedule@smoketest-bsd2:
>     - shard-tglb:         [INCOMPLETE][103] ([i915#707]) ->
> [PASS][104]
>    [103]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
>    [104]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb1/igt@gem_exec_schedule@smoketest-bsd2.html
> 
>   * igt@gem_softpin@noreloc-s3:
>     - shard-tglb:         [INCOMPLETE][105] ([i915#456]) ->
> [PASS][106]
>    [105]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_softpin@noreloc-s3.html
>    [106]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_softpin@noreloc-s3.html
> 
>   * {igt@gen9_exec_parse@allowed-single}:
>     - shard-glk:          [DMESG-WARN][107] ([i915#716]) ->
> ([PASS][108], [PASS][109])
>    [107]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
>    [108]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gen9_exec_parse@allowed-single.html
>    [109]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gen9_exec_parse@allowed-single.html
>     - shard-apl:          [DMESG-WARN][110] ([i915#716]) ->
> [PASS][111]
>    [110]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
>    [111]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gen9_exec_parse@allowed-single.html
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-apl:          [DMESG-WARN][112] ([i915#180]) ->
> ([PASS][113], [PASS][114])
>    [112]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [113]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
>    [114]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
>     - shard-skl:          [FAIL][115] ([i915#54]) -> [PASS][116]
>    [115]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
>    [116]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
>     - shard-hsw:          [DMESG-WARN][117] ([IGT#6]) ->
> ([PASS][118], [PASS][119])
>    [117]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>    [118]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>    [119]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw5/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>     - shard-tglb:         [INCOMPLETE][120] ([i915#456] / [i915#460])
> -> [PASS][121]
>    [120]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>    [121]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          [FAIL][122] ([i915#79]) -> ([PASS][123],
> [PASS][124])
>    [122]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
>    [123]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
>    [124]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-apl:          [FAIL][125] ([i915#79]) -> ([PASS][126],
> [PASS][127])
>    [125]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [126]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [127]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-skl:          [INCOMPLETE][128] ([i915#221]) ->
> ([PASS][129], [PASS][130])
>    [128]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_flip@flip-vs-suspend.html
>    [129]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_flip@flip-vs-suspend.html
>    [130]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_flip@flip-vs-suspend.html
> 
>   * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
>     - shard-tglb:         [FAIL][131] ([i915#49]) -> [PASS][132]
>    [131]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
>    [132]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
>     - shard-tglb:         [INCOMPLETE][133] ([i915#456] / [i915#460]
> / [i915#474]) -> [PASS][134]
>    [133]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
>    [134]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> 
>   * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
>     - shard-iclb:         [INCOMPLETE][135] ([i915#140] / [i915#246])
> -> [PASS][136]
>    [135]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
>    [136]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
> 
>   * igt@kms_psr@psr2_cursor_mmap_cpu:
>     - shard-iclb:         [SKIP][137] ([fdo#109441]) -> [PASS][138]
> +1 similar issue
>    [137]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
>    [138]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> 
>   * igt@kms_vblank@pipe-b-ts-continuation-suspend:
>     - shard-apl:          [DMESG-WARN][139] ([i915#180]) ->
> [PASS][140] +1 similar issue
>    [139]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
>    [140]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
> 
>   * igt@perf_pmu@busy-check-all-vcs1:
>     - shard-iclb:         [SKIP][141] ([fdo#112080]) -> [PASS][142]
> +5 similar issues
>    [141]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
>    [142]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs2-s3:
>     - shard-tglb:         [SKIP][143] ([fdo#111912] / [fdo#112080])
> -> [SKIP][144] ([fdo#112080])
>    [143]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
>    [144]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
> 
>   * igt@gem_tiled_blits@normal:
>     - shard-hsw:          [FAIL][145] ([i915#818]) -> ([FAIL][146],
> [DMESG-FAIL][147]) ([i915#44] / [i915#818])
>    [145]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_tiled_blits@normal.html
>    [146]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw2/igt@gem_tiled_blits@normal.html
>    [147]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@gem_tiled_blits@normal.html
> 
>   * igt@kms_atomic_transition@6x-modeset-transitions:
>     - shard-tglb:         [SKIP][148] ([fdo#112021]) -> [SKIP][149]
> ([fdo#112016] / [fdo#112021])
>    [148]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
>    [149]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-apl:          [DMESG-WARN][150] ([i915#180]) ->
> ([PASS][151], [DMESG-WARN][152]) ([i915#180])
>    [150]: https://intel-gfx-ci.01.org
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx]  ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-12-17 18:33   ` Souza, Jose
@ 2019-12-17 18:42     ` James Ausmus
  2019-12-18  9:33       ` Vudum, Lakshminarayana
  0 siblings, 1 reply; 37+ messages in thread
From: James Ausmus @ 2019-12-17 18:42 UTC (permalink / raw)
  To: Souza, Jose, Vudum, Lakshminarayana; +Cc: intel-gfx

(+Lakshmi)

On Tue, Dec 17, 2019 at 06:33:58PM +0000, Souza, Jose wrote:
> On Tue, 2019-12-17 at 18:10 +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [1/5] drm: Add
> > __drm_atomic_helper_crtc_state_reset() & co. (rev3)
> > URL   : https://patchwork.freedesktop.org/series/69129/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_15797_full absolutely
> > need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the
> > changes
> >   introduced in Patchwork_15797_full, please notify your bug team to
> > allow them
> >   to document this new failure mode, which will reduce false
> > positives in CI.
> > 
> >   
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in
> > Patchwork_15797_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@kms_big_fb@linear-16bpp-rotate-180:
> >     - shard-tglb:         [PASS][1] -> [DMESG-WARN][2]
> >    [1]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-180.html
> >    [2]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-180.html
> 
> This one is not related to the changes in this series
> 
> > 
> >   * igt@kms_frontbuffer_tracking@basic:
> >     - shard-skl:          [PASS][3] -> ([INCOMPLETE][4], [PASS][5])
> >    [3]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_frontbuffer_tracking@basic.html
> >    [4]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_frontbuffer_tracking@basic.html
> >    [5]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_frontbuffer_tracking@basic.html
> > 
> 
> Getting AccessDenied when trying to access the error reports
> 
> >   
> > 
> > ### Piglit changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 3 (NEW):
> >     - {pig-hsw-4770r}:    NOTRUN -> [FAIL][6] +20 similar issues
> >    [6]: None
> > 
> >   
> > New tests
> > ---------
> > 
> >   New tests have been introduced between CI_DRM_7578_full and
> > Patchwork_15797_full:
> > 
> > ### New Piglit tests (21) ###
> > 
> >   * object namespace pollution@texture with glgetteximage-compressed:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * object namespace pollution@texture with gltexsubimage2d:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.15] s
> > 
> >   * spec@arb_gpu_shader5@texturegather@vs-rgb-0-float-cube:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [1.83] s
> > 
> >   * spec@arb_query_buffer_object@coherency:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.22] s
> > 
> >   * spec@arb_shader_image_load_store@host-mem-barrier:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [5.66] s
> > 
> >   * spec@arb_shader_image_load_store@layer:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.31] s
> > 
> >   * spec@arb_shader_image_load_store@level:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.27] s
> > 
> >   * spec@arb_shader_image_load_store@semantics:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.53] s
> > 
> >   * spec@arb_shader_image_load_store@unused:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.16] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 1 8 128 2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 1 128 4:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.08] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 8 128 2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.10] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 8 128 3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.12] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.24] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 4:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.27] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.26] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 42 1 128 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.19] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 42 1 8 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.17] s
> > 
> >   * spec@arb_vertex_attrib_64bit@execution@
> > vs_in@vs-input-position-double_dmat3-float_mat3x2_array3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * spec@arb_vertex_type_2_10_10_10_rev@attribs:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.95] s
> > 
> >   * spec@glsl-4.20@execution@vs_in@vs-input-int_ivec3_array3-
> > position-double_dmat3_array2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.18] s
> > 
> >   
> > 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_15797_full that come from
> > known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@gem_ctx_isolation@vcs1-none:
> >     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] /
> > [fdo#112080])
> >    [7]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
> >    [8]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
> > 
> >   * igt@gem_ctx_persistence@bcs0-mixed-process:
> >     - shard-apl:          [PASS][9] -> ([FAIL][10], [PASS][11])
> > ([i915#679])
> >    [9]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ctx_persistence@bcs0-mixed-process.html
> >    [10]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_ctx_persistence@bcs0-mixed-process.html
> >    [11]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@gem_ctx_persistence@bcs0-mixed-process.html
> > 
> >   * igt@gem_ctx_persistence@vecs0-mixed-process:
> >     - shard-glk:          [PASS][12] -> ([PASS][13], [FAIL][14])
> > ([i915#679])
> >    [12]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
> >    [13]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html
> >    [14]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gem_ctx_persistence@vecs0-mixed-process.html
> > 
> >   * igt@gem_exec_async@concurrent-writes-bsd2:
> >     - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276])
> >    [15]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html
> >    [16]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd2.html
> > 
> >   * igt@gem_exec_gttfill@basic:
> >     - shard-tglb:         [PASS][17] -> [INCOMPLETE][18]
> > ([fdo#111593])
> >    [17]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
> >    [18]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_gttfill@basic.html
> > 
> >   * igt@gem_exec_schedule@preempt-other-chain-bsd:
> >     - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#112146]) +5
> > similar issues
> >    [19]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> >    [20]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
> >     - shard-tglb:         [PASS][21] -> [INCOMPLETE][22]
> > ([fdo#111606] / [fdo#111677])
> >    [21]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
> >    [22]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
> > 
> >   * igt@gem
> > _persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive
> > :
> >     - shard-tglb:         [PASS][23] -> [TIMEOUT][24] ([fdo#112126] /
> > [i915#530])
> >    [23]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
> >    [24]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
> > 
> >   * igt@gem_ppgtt@flink-and-close-vma-leak:
> >     - shard-glk:          [PASS][25] -> ([FAIL][26], [PASS][27])
> > ([i915#644])
> >    [25]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [26]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [27]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >     - shard-apl:          [PASS][28] -> ([FAIL][29], [PASS][30])
> > ([i915#644])
> >    [28]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [29]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [30]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
> > 
> >   * igt@gem_workarounds@suspend-resume-context:
> >     - shard-apl:          [PASS][31] -> ([DMESG-WARN][32],
> > [PASS][33]) ([i915#180]) +4 similar issues
> >    [31]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
> >    [32]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
> >    [33]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
> > 
> >   * igt@i915_hangman@error-state-capture-vcs1:
> >     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#112080])
> >    [34]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
> >    [35]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@i915_hangman@error-state-capture-vcs1.html
> > 
> >   * igt@i915_pm_dc@dc5-psr:
> >     - shard-skl:          [PASS][36] -> ([PASS][37],
> > [INCOMPLETE][38]) ([i915#198])
> >    [36]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@i915_pm_dc@dc5-psr.html
> >    [37]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@i915_pm_dc@dc5-psr.html
> >    [38]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@i915_pm_dc@dc5-psr.html
> > 
> >   * igt@i915_selftest@mock_sanitycheck:
> >     - shard-skl:          [PASS][39] -> ([PASS][40], [DMESG-
> > WARN][41]) ([i915#747])
> >    [39]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl5/igt@i915_selftest@mock_sanitycheck.html
> >    [40]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_selftest@mock_sanitycheck.html
> >    [41]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@i915_selftest@mock_sanitycheck.html
> > 
> >   * igt@i915_suspend@forcewake:
> >     - shard-skl:          [PASS][42] -> ([INCOMPLETE][43],
> > [PASS][44]) ([i915#69])
> >    [42]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl9/igt@i915_suspend@forcewake.html
> >    [43]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_suspend@forcewake.html
> >    [44]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@i915_suspend@forcewake.html
> > 
> >   * igt@i915_suspend@sysfs-reader:
> >     - shard-apl:          [PASS][45] -> [DMESG-WARN][46] ([i915#180])
> > +1 similar issue
> >    [45]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_suspend@sysfs-reader.html
> >    [46]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@i915_suspend@sysfs-reader.html
> > 
> >   * igt@kms_color@pipe-a-ctm-0-75:
> >     - shard-skl:          [PASS][47] -> ([DMESG-WARN][48],
> > [PASS][49]) ([i915#109])
> >    [47]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
> >    [48]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html
> >    [49]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> >     - shard-kbl:          [PASS][50] -> [DMESG-WARN][51] ([i915#180])
> > +2 similar issues
> >    [50]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> >    [51]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
> >     - shard-hsw:          [PASS][52] -> ([DMESG-WARN][53],
> > [PASS][54]) ([IGT#6] / [i915#435])
> >    [52]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> >    [53]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw6/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> >    [54]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
> >     - shard-skl:          [PASS][55] -> ([FAIL][56], [PASS][57])
> > ([i915#54]) +1 similar issue
> >    [55]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> >    [56]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> >    [57]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> > 
> >   * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
> >     - shard-skl:          [PASS][58] -> ([INCOMPLETE][59],
> > [PASS][60]) ([fdo#112347] / [i915#646] / [i915#667])
> >    [58]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> >    [59]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> >    [60]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank:
> >     - shard-skl:          [PASS][61] -> ([FAIL][62], [PASS][63])
> > ([i915#46])
> >    [61]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
> >    [62]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
> >    [63]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
> >     - shard-iclb:         [PASS][64] -> [INCOMPLETE][65] ([i915#140])
> >    [64]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
> >    [65]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> >     - shard-iclb:         [PASS][66] -> [INCOMPLETE][67] ([i915#123]
> > / [i915#140])
> >    [66]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> >    [67]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
> >     - shard-tglb:         [PASS][68] -> [INCOMPLETE][69] ([i915#474]
> > / [i915#667])
> >    [68]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
> >    [69]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
> >     - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72])
> > ([i915#49])
> >    [70]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> >    [71]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> >    [72]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> > 
> >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
> >     - shard-tglb:         [PASS][73] -> [INCOMPLETE][74] ([i915#456]
> > / [i915#460]) +1 similar issue
> >    [73]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
> >    [74]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
> > 
> >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> >     - shard-skl:          [PASS][75] -> ([FAIL][76], [FAIL][77])
> > ([fdo#108145] / [i915#265])
> >    [75]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >    [76]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >    [77]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > 
> >   * igt@kms_psr@psr2_suspend:
> >     - shard-tglb:         [PASS][78] -> [DMESG-WARN][79] ([i915#402])
> >    [78]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_psr@psr2_suspend.html
> >    [79]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_psr@psr2_suspend.html
> > 
> >   * igt@kms_setmode@basic:
> >     - shard-apl:          [PASS][80] -> ([FAIL][81], [FAIL][82])
> > ([i915#31])
> >    [80]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
> >    [81]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@kms_setmode@basic.html
> >    [82]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@kms_setmode@basic.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@gem_busy@close-race:
> >     - shard-tglb:         [INCOMPLETE][83] ([i915#435]) -> [PASS][84]
> >    [83]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
> >    [84]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb2/igt@gem_busy@close-race.html
> > 
> >   * igt@gem_ctx_persistence@vcs0-mixed-process:
> >     - shard-apl:          [FAIL][85] ([i915#679]) -> ([PASS][86],
> > [PASS][87])
> >    [85]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> >    [86]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@gem_ctx_persistence@vcs0-mixed-process.html
> >    [87]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> > 
> >   * igt@gem_ctx_persistence@vcs1-mixed-process:
> >     - shard-iclb:         [SKIP][88] ([fdo#109276] / [fdo#112080]) ->
> > [PASS][89] +1 similar issue
> >    [88]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
> >    [89]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html
> > 
> >   * igt@gem_eio@banned:
> >     - shard-tglb:         [INCOMPLETE][90] ([i915#476]) -> [PASS][91]
> >    [90]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
> >    [91]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@gem_eio@banned.html
> > 
> >   * igt@gem_exec_balancer@smoke:
> >     - shard-iclb:         [SKIP][92] ([fdo#110854]) -> [PASS][93]
> >    [92]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_balancer@smoke.html
> >    [93]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_balancer@smoke.html
> > 
> >   * igt@gem_exec_reloc@basic-wc-active:
> >     - shard-skl:          [DMESG-WARN][94] ([i915#109]) ->
> > ([PASS][95], [PASS][96])
> >    [94]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@gem_exec_reloc@basic-wc-active.html
> >    [95]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html
> >    [96]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@gem_exec_reloc@basic-wc-active.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-bsd2:
> >     - shard-iclb:         [SKIP][97] ([fdo#109276]) -> [PASS][98] +10
> > similar issues
> >    [97]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
> >    [98]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
> >     - shard-tglb:         [INCOMPLETE][99] ([fdo#111677]) ->
> > [PASS][100]
> >    [99]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> >    [100]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> > 
> >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> >     - shard-iclb:         [SKIP][101] ([fdo#112146]) -> [PASS][102]
> > +2 similar issues
> >    [101]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
> >    [102]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
> > 
> >   * igt@gem_exec_schedule@smoketest-bsd2:
> >     - shard-tglb:         [INCOMPLETE][103] ([i915#707]) ->
> > [PASS][104]
> >    [103]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
> >    [104]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb1/igt@gem_exec_schedule@smoketest-bsd2.html
> > 
> >   * igt@gem_softpin@noreloc-s3:
> >     - shard-tglb:         [INCOMPLETE][105] ([i915#456]) ->
> > [PASS][106]
> >    [105]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_softpin@noreloc-s3.html
> >    [106]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_softpin@noreloc-s3.html
> > 
> >   * {igt@gen9_exec_parse@allowed-single}:
> >     - shard-glk:          [DMESG-WARN][107] ([i915#716]) ->
> > ([PASS][108], [PASS][109])
> >    [107]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
> >    [108]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gen9_exec_parse@allowed-single.html
> >    [109]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gen9_exec_parse@allowed-single.html
> >     - shard-apl:          [DMESG-WARN][110] ([i915#716]) ->
> > [PASS][111]
> >    [110]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
> >    [111]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gen9_exec_parse@allowed-single.html
> > 
> >   * igt@i915_suspend@fence-restore-tiled2untiled:
> >     - shard-apl:          [DMESG-WARN][112] ([i915#180]) ->
> > ([PASS][113], [PASS][114])
> >    [112]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [113]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [114]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
> >     - shard-skl:          [FAIL][115] ([i915#54]) -> [PASS][116]
> >    [115]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
> >    [116]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
> >     - shard-hsw:          [DMESG-WARN][117] ([IGT#6]) ->
> > ([PASS][118], [PASS][119])
> >    [117]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> >    [118]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> >    [119]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw5/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
> >     - shard-tglb:         [INCOMPLETE][120] ([i915#456] / [i915#460])
> > -> [PASS][121]
> >    [120]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> >    [121]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> > 
> >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> >     - shard-glk:          [FAIL][122] ([i915#79]) -> ([PASS][123],
> > [PASS][124])
> >    [122]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [123]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [124]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-apl:          [FAIL][125] ([i915#79]) -> ([PASS][126],
> > [PASS][127])
> >    [125]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [126]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [127]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-skl:          [INCOMPLETE][128] ([i915#221]) ->
> > ([PASS][129], [PASS][130])
> >    [128]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_flip@flip-vs-suspend.html
> >    [129]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_flip@flip-vs-suspend.html
> >    [130]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_flip@flip-vs-suspend.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
> >     - shard-tglb:         [FAIL][131] ([i915#49]) -> [PASS][132]
> >    [131]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> >    [132]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
> >     - shard-tglb:         [INCOMPLETE][133] ([i915#456] / [i915#460]
> > / [i915#474]) -> [PASS][134]
> >    [133]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> >    [134]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> > 
> >   * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> >     - shard-iclb:         [INCOMPLETE][135] ([i915#140] / [i915#246])
> > -> [PASS][136]
> >    [135]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
> >    [136]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
> > 
> >   * igt@kms_psr@psr2_cursor_mmap_cpu:
> >     - shard-iclb:         [SKIP][137] ([fdo#109441]) -> [PASS][138]
> > +1 similar issue
> >    [137]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >    [138]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> > 
> >   * igt@kms_vblank@pipe-b-ts-continuation-suspend:
> >     - shard-apl:          [DMESG-WARN][139] ([i915#180]) ->
> > [PASS][140] +1 similar issue
> >    [139]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
> >    [140]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
> > 
> >   * igt@perf_pmu@busy-check-all-vcs1:
> >     - shard-iclb:         [SKIP][141] ([fdo#112080]) -> [PASS][142]
> > +5 similar issues
> >    [141]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
> >    [142]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html
> > 
> >   
> > #### Warnings ####
> > 
> >   * igt@gem_ctx_isolation@vcs2-s3:
> >     - shard-tglb:         [SKIP][143] ([fdo#111912] / [fdo#112080])
> > -> [SKIP][144] ([fdo#112080])
> >    [143]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
> >    [144]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html
> > 
> >   * igt@gem_tiled_blits@normal:
> >     - shard-hsw:          [FAIL][145] ([i915#818]) -> ([FAIL][146],
> > [DMESG-FAIL][147]) ([i915#44] / [i915#818])
> >    [145]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_tiled_blits@normal.html
> >    [146]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw2/igt@gem_tiled_blits@normal.html
> >    [147]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@gem_tiled_blits@normal.html
> > 
> >   * igt@kms_atomic_transition@6x-modeset-transitions:
> >     - shard-tglb:         [SKIP][148] ([fdo#112021]) -> [SKIP][149]
> > ([fdo#112016] / [fdo#112021])
> >    [148]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
> >    [149]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html
> > 
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-apl:          [DMESG-WARN][150] ([i915#180]) ->
> > ([PASS][151], [DMESG-WARN][152]) ([i915#180])
> >    [150]: https://intel-gfx-ci.01.org
> > 
> > == Logs ==
> > 
> > For more details see: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-11-07 14:24 ` Ville Syrjala
                   ` (12 preceding siblings ...)
  (?)
@ 2019-12-18  8:10 ` Patchwork
  -1 siblings, 0 replies; 37+ messages in thread
From: Patchwork @ 2019-12-18  8:10 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
URL   : https://patchwork.freedesktop.org/series/69129/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15797_full:

### Piglit changes ###

#### Possible regressions ####

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 3 (NEW):
    - {pig-hsw-4770r}:    NOTRUN -> [FAIL][1] +18 similar issues
   [1]: None

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * spec@arb_shader_image_load_store@semantics:
    - {pig-hsw-4770r}:    NOTRUN -> [FAIL][2] +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/pig-hsw-4770r/spec@arb_shader_image_load_store@semantics.html

  
New tests
---------

  New tests have been introduced between CI_DRM_7578_full and Patchwork_15797_full:

### New Piglit tests (19) ###

  * object namespace pollution@texture with glgetteximage-compressed:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * object namespace pollution@texture with gltexsubimage2d:
    - Statuses : 1 fail(s)
    - Exec time: [0.15] s

  * spec@arb_gpu_shader5@texturegather@vs-rgb-0-float-cube:
    - Statuses : 1 fail(s)
    - Exec time: [1.83] s

  * spec@arb_query_buffer_object@coherency:
    - Statuses : 1 fail(s)
    - Exec time: [0.22] s

  * spec@arb_shader_image_load_store@host-mem-barrier:
    - Statuses : 1 fail(s)
    - Exec time: [5.66] s

  * spec@arb_shader_image_load_store@layer:
    - Statuses : 1 fail(s)
    - Exec time: [0.31] s

  * spec@arb_shader_image_load_store@level:
    - Statuses : 1 fail(s)
    - Exec time: [0.27] s

  * spec@arb_shader_image_load_store@unused:
    - Statuses : 1 fail(s)
    - Exec time: [0.16] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 1 8 128 2:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 128 2:
    - Statuses : 1 fail(s)
    - Exec time: [0.10] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 128 3:
    - Statuses : 1 fail(s)
    - Exec time: [0.12] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 3:
    - Statuses : 1 fail(s)
    - Exec time: [0.24] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 4:
    - Statuses : 1 fail(s)
    - Exec time: [0.27] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.26] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 128 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.19] s

  * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 8:
    - Statuses : 1 fail(s)
    - Exec time: [0.17] s

  * spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-double_dmat3-float_mat3x2_array3:
    - Statuses : 1 fail(s)
    - Exec time: [0.13] s

  * spec@arb_vertex_type_2_10_10_10_rev@attribs:
    - Statuses : 1 fail(s)
    - Exec time: [0.95] s

  * spec@glsl-4.20@execution@vs_in@vs-input-int_ivec3_array3-position-double_dmat3_array2:
    - Statuses : 1 fail(s)
    - Exec time: [0.18] s

  

Known issues
------------

  Here are the changes found in Patchwork_15797_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vcs1-none:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html

  * igt@gem_ctx_persistence@bcs0-mixed-process:
    - shard-apl:          [PASS][5] -> ([PASS][6], [FAIL][7]) ([i915#679])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ctx_persistence@bcs0-mixed-process.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@gem_ctx_persistence@bcs0-mixed-process.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_ctx_persistence@bcs0-mixed-process.html

  * igt@gem_ctx_persistence@vecs0-mixed-process:
    - shard-glk:          [PASS][8] -> ([FAIL][9], [PASS][10]) ([i915#679])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gem_ctx_persistence@vecs0-mixed-process.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html

  * igt@gem_exec_async@concurrent-writes-bsd2:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109276])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd2.html

  * igt@gem_exec_gttfill@basic:
    - shard-tglb:         [PASS][13] -> [INCOMPLETE][14] ([fdo#111593])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_gttfill@basic.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#112146]) +5 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
    - shard-tglb:         [PASS][17] -> [INCOMPLETE][18] ([fdo#111606] / [fdo#111677])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-tglb:         [PASS][19] -> [TIMEOUT][20] ([fdo#112126] / [i915#530])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-glk:          [PASS][21] -> ([FAIL][22], [PASS][23]) ([i915#644])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
    - shard-apl:          [PASS][24] -> ([PASS][25], [FAIL][26]) ([i915#644])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][27] -> ([DMESG-WARN][28], [PASS][29]) ([i915#180]) +4 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_hangman@error-state-capture-vcs1:
    - shard-iclb:         [PASS][30] -> [SKIP][31] ([fdo#112080])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@i915_hangman@error-state-capture-vcs1.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-skl:          [PASS][32] -> ([INCOMPLETE][33], [PASS][34]) ([i915#198])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@i915_pm_dc@dc5-psr.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@i915_pm_dc@dc5-psr.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_selftest@mock_sanitycheck:
    - shard-skl:          [PASS][35] -> ([PASS][36], [DMESG-WARN][37]) ([i915#747])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl5/igt@i915_selftest@mock_sanitycheck.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_selftest@mock_sanitycheck.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@i915_selftest@mock_sanitycheck.html

  * igt@i915_suspend@forcewake:
    - shard-skl:          [PASS][38] -> ([INCOMPLETE][39], [PASS][40]) ([i915#69])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl9/igt@i915_suspend@forcewake.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_suspend@forcewake.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@i915_suspend@forcewake.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_suspend@sysfs-reader.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@i915_suspend@sysfs-reader.html

  * igt@kms_big_fb@linear-16bpp-rotate-180:
    - shard-tglb:         [PASS][43] -> [DMESG-WARN][44] ([i915#851])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-180.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-180.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - shard-skl:          [PASS][45] -> ([PASS][46], [DMESG-WARN][47]) ([i915#109])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][48] -> [DMESG-WARN][49] ([i915#180]) +2 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
    - shard-hsw:          [PASS][50] -> ([DMESG-WARN][51], [PASS][52]) ([IGT#6] / [i915#435])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw6/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
    - shard-skl:          [PASS][53] -> ([PASS][54], [FAIL][55]) ([i915#54]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html

  * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
    - shard-skl:          [PASS][56] -> ([INCOMPLETE][57], [PASS][58]) ([fdo#112347] / [i915#646] / [i915#667])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][59] -> ([FAIL][60], [PASS][61]) ([i915#46])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-skl:          [PASS][62] -> ([INCOMPLETE][63], [PASS][64]) ([i915#435])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_frontbuffer_tracking@basic.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_frontbuffer_tracking@basic.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
    - shard-iclb:         [PASS][65] -> [INCOMPLETE][66] ([i915#140])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][67] -> [INCOMPLETE][68] ([i915#123] / [i915#140])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
    - shard-tglb:         [PASS][69] -> [INCOMPLETE][70] ([i915#474] / [i915#667])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
    - shard-skl:          [PASS][71] -> ([PASS][72], [FAIL][73]) ([i915#49])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [PASS][74] -> [INCOMPLETE][75] ([i915#456] / [i915#460]) +1 similar issue
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [PASS][76] -> ([FAIL][77], [FAIL][78]) ([fdo#108145] / [i915#265])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_psr@psr2_suspend:
    - shard-tglb:         [PASS][79] -> [DMESG-WARN][80] ([i915#402])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_psr@psr2_suspend.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_psr@psr2_suspend.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][81] -> ([FAIL][82], [FAIL][83]) ([i915#31])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@kms_setmode@basic.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_busy@close-race:
    - shard-tglb:         [INCOMPLETE][84] ([i915#435]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb2/igt@gem_busy@close-race.html

  * igt@gem_ctx_persistence@vcs0-mixed-process:
    - shard-apl:          [FAIL][86] ([i915#679]) -> ([PASS][87], [PASS][88])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@gem_ctx_persistence@vcs0-mixed-process.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-iclb:         [SKIP][89] ([fdo#109276] / [fdo#112080]) -> [PASS][90] +1 similar issue
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed-process.html

  * igt@gem_eio@banned:
    - shard-tglb:         [INCOMPLETE][91] ([i915#476]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@gem_eio@banned.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][93] ([fdo#110854]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_balancer@smoke.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_reloc@basic-wc-active:
    - shard-skl:          [DMESG-WARN][95] ([i915#109]) -> ([PASS][96], [PASS][97])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@gem_exec_reloc@basic-wc-active.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@gem_exec_reloc@basic-wc-active.html

  * igt@gem_exec_schedule@preempt-queue-bsd2:
    - shard-iclb:         [SKIP][98] ([fdo#109276]) -> [PASS][99] +10 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1/igt@gem_exec_schedule@preempt-queue-bsd2.html

  * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
    - shard-tglb:         [INCOMPLETE][100] ([fdo#111677]) -> [PASS][101]
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [SKIP][102] ([fdo#112146]) -> [PASS][103] +2 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * igt@gem_exec_schedule@smoketest-bsd2:
    - shard-tglb:         [INCOMPLETE][104] ([i915#707]) -> [PASS][105]
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb1/igt@gem_exec_schedule@smoketest-bsd2.html

  * igt@gem_softpin@noreloc-s3:
    - shard-tglb:         [INCOMPLETE][106] ([i915#456]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_softpin@noreloc-s3.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@gem_softpin@noreloc-s3.html

  * {igt@gen9_exec_parse@allowed-single}:
    - shard-glk:          [DMESG-WARN][108] ([i915#716]) -> ([PASS][109], [PASS][110])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gen9_exec_parse@allowed-single.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gen9_exec_parse@allowed-single.html
    - shard-apl:          [DMESG-WARN][111] ([i915#716]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][113] ([i915#180]) -> ([PASS][114], [PASS][115])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
    - shard-skl:          [FAIL][116] ([i915#54]) -> [PASS][117]
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
    - shard-hsw:          [DMESG-WARN][118] ([IGT#6]) -> ([PASS][119], [PASS][120])
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw5/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-tglb:         [INCOMPLETE][121] ([i915#456] / [i915#460]) -> [PASS][122]
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][123] ([i915#79]) -> ([PASS][124], [PASS][125])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [FAIL][126] ([i915#79]) -> ([PASS][127], [PASS][128])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-skl:          [INCOMPLETE][129] ([i915#221]) -> ([PASS][130], [PASS][131])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_flip@flip-vs-suspend.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_flip@flip-vs-suspend.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
    - shard-tglb:         [FAIL][132] ([i915#49]) -> [PASS][133]
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-tglb:         [INCOMPLETE][134] ([i915#456] / [i915#460] / [i915#474]) -> [PASS][135]
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-iclb:         [INCOMPLETE][136] ([i915#140] / [i915#246]) -> [PASS][137]
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [SKIP][138] ([fdo#109441]) -> [PASS][139] +1 similar issue
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][140] ([i915#180]) -> [PASS][141] +1 similar issue
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * igt@perf_pmu@busy-check-all-vcs1:
    - shard-iclb:         [SKIP][142] ([fdo#112080]) -> [PASS][143] +5 similar issues
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs2-s3:
    - shard-tglb:         [SKIP][144] ([fdo#111912] / [fdo#112080]) -> [SKIP][145] ([fdo#112080])
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9/igt@gem_ctx_isolation@vcs2-s3.html

  * igt@gem_tiled_blits@normal:
    - shard-hsw:          [FAIL][146] ([i915#818]) -> ([DMESG-FAIL][147], [FAIL][148]) ([i915#44] / [i915#818])
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_tiled_blits@normal.html
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@gem_tiled_blits@normal.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw2/igt@gem_tiled_blits@normal.html

  * igt@kms_atomic_transition@6x-modeset-transitions:
    - shard-tglb:         [SKIP][149] ([fdo#112021]) -> [SKIP][150] ([fdo#112016] / [fdo#112021])
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8/igt@kms_atomic_transition@6x-modeset-transitions.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-apl:          [DMESG-WARN][151] ([i915#180]) -> ([PASS][152], [DMESG-WARN][153]) ([i915#180])
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl6/igt@kms_flip@flip-vs-suspend.html
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-suspend.html
   [153]: http

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx]  ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)
  2019-12-17 18:42     ` James Ausmus
@ 2019-12-18  9:33       ` Vudum, Lakshminarayana
  0 siblings, 0 replies; 37+ messages in thread
From: Vudum, Lakshminarayana @ 2019-12-18  9:33 UTC (permalink / raw)
  To: Ausmus, James, Souza, Jose; +Cc: intel-gfx

Acknowledged.
Results look good at the moment after filing and re-reporting.

Lakshmi.
-----Original Message-----
From: Ausmus, James <james.ausmus@intel.com> 
Sent: Tuesday, December 17, 2019 8:43 PM
To: Souza, Jose <jose.souza@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Cc: ville.syrjala@linux.intel.com; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3)

(+Lakshmi)

On Tue, Dec 17, 2019 at 06:33:58PM +0000, Souza, Jose wrote:
> On Tue, 2019-12-17 at 18:10 +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [1/5] drm: Add
> > __drm_atomic_helper_crtc_state_reset() & co. (rev3)
> > URL   : https://patchwork.freedesktop.org/series/69129/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7578_full -> Patchwork_15797_full 
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_15797_full 
> > absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the 
> > changes
> >   introduced in Patchwork_15797_full, please notify your bug team to 
> > allow them
> >   to document this new failure mode, which will reduce false 
> > positives in CI.
> > 
> >   
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in
> > Patchwork_15797_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@kms_big_fb@linear-16bpp-rotate-180:
> >     - shard-tglb:         [PASS][1] -> [DMESG-WARN][2]
> >    [1]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-180.html
> >    [2]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3
> > /igt@kms_big_fb@linear-16bpp-rotate-180.html
> 
> This one is not related to the changes in this series
> 
> > 
> >   * igt@kms_frontbuffer_tracking@basic:
> >     - shard-skl:          [PASS][3] -> ([INCOMPLETE][4], [PASS][5])
> >    [3]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_frontbuffer_tracking@basic.html
> >    [4]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_frontbuffer_tracking@basic.html
> >    [5]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/
> > igt@kms_frontbuffer_tracking@basic.html
> > 
> 
> Getting AccessDenied when trying to access the error reports
> 
> >   
> > 
> > ### Piglit changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 3 (NEW):
> >     - {pig-hsw-4770r}:    NOTRUN -> [FAIL][6] +20 similar issues
> >    [6]: None
> > 
> >   
> > New tests
> > ---------
> > 
> >   New tests have been introduced between CI_DRM_7578_full and
> > Patchwork_15797_full:
> > 
> > ### New Piglit tests (21) ###
> > 
> >   * object namespace pollution@texture with glgetteximage-compressed:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * object namespace pollution@texture with gltexsubimage2d:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.15] s
> > 
> >   * spec@arb_gpu_shader5@texturegather@vs-rgb-0-float-cube:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [1.83] s
> > 
> >   * spec@arb_query_buffer_object@coherency:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.22] s
> > 
> >   * spec@arb_shader_image_load_store@host-mem-barrier:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [5.66] s
> > 
> >   * spec@arb_shader_image_load_store@layer:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.31] s
> > 
> >   * spec@arb_shader_image_load_store@level:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.27] s
> > 
> >   * spec@arb_shader_image_load_store@semantics:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.53] s
> > 
> >   * spec@arb_shader_image_load_store@unused:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.16] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 1 8 128 2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 1 128 4:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.08] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 8 128 2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.10] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 32 42 8 128 3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.12] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.24] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 4:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.27] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 1 8 128 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.26] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 42 1 128 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.19] s
> > 
> >   * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader
> > 512 42 1 8 8:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.17] s
> > 
> >   * spec@arb_vertex_attrib_64bit@execution@
> > vs_in@vs-input-position-double_dmat3-float_mat3x2_array3:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.13] s
> > 
> >   * spec@arb_vertex_type_2_10_10_10_rev@attribs:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.95] s
> > 
> >   * spec@glsl-4.20@execution@vs_in@vs-input-int_ivec3_array3-
> > position-double_dmat3_array2:
> >     - Statuses : 1 fail(s)
> >     - Exec time: [0.18] s
> > 
> >   
> > 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_15797_full that come from 
> > known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@gem_ctx_isolation@vcs1-none:
> >     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] /
> > [fdo#112080])
> >    [7]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
> >    [8]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8
> > /igt@gem_ctx_isolation@vcs1-none.html
> > 
> >   * igt@gem_ctx_persistence@bcs0-mixed-process:
> >     - shard-apl:          [PASS][9] -> ([FAIL][10], [PASS][11])
> > ([i915#679])
> >    [9]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ctx_persistence@bcs0-mixed-process.html
> >    [10]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_ctx_persistence@bcs0-mixed-process.html
> >    [11]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/
> > igt@gem_ctx_persistence@bcs0-mixed-process.html
> > 
> >   * igt@gem_ctx_persistence@vecs0-mixed-process:
> >     - shard-glk:          [PASS][12] -> ([PASS][13], [FAIL][14])
> > ([i915#679])
> >    [12]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk4/igt@gem_ctx_persistence@vecs0-mixed-process.html
> >    [13]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html
> >    [14]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/
> > igt@gem_ctx_persistence@vecs0-mixed-process.html
> > 
> >   * igt@gem_exec_async@concurrent-writes-bsd2:
> >     - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#109276])
> >    [15]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd2.html
> >    [16]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8
> > /igt@gem_exec_async@concurrent-writes-bsd2.html
> > 
> >   * igt@gem_exec_gttfill@basic:
> >     - shard-tglb:         [PASS][17] -> [INCOMPLETE][18]
> > ([fdo#111593])
> >    [17]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@gem_exec_gttfill@basic.html
> >    [18]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6
> > /igt@gem_exec_gttfill@basic.html
> > 
> >   * igt@gem_exec_schedule@preempt-other-chain-bsd:
> >     - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#112146]) +5
> > similar issues
> >    [19]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> >    [20]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4
> > /igt@gem_exec_schedule@preempt-other-chain-bsd.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox:
> >     - shard-tglb:         [PASS][21] -> [INCOMPLETE][22]
> > ([fdo#111606] / [fdo#111677])
> >    [21]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
> >    [22]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6
> > /igt@gem_exec_schedule@preempt-queue-contexts-chain-vebox.html
> > 
> >   * igt@gem
> > _persistent_relocs@forked-interruptible-faulting-reloc-thrash-inacti
> > ve
> > :
> >     - shard-tglb:         [PASS][23] -> [TIMEOUT][24] ([fdo#112126] /
> > [i915#530])
> >    [23]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
> >    [24]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb5
> > /igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thras
> > h-inactive.html
> > 
> >   * igt@gem_ppgtt@flink-and-close-vma-leak:
> >     - shard-glk:          [PASS][25] -> ([FAIL][26], [PASS][27])
> > ([i915#644])
> >    [25]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [26]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [27]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >     - shard-apl:          [PASS][28] -> ([FAIL][29], [PASS][30])
> > ([i915#644])
> >    [28]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [29]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
> >    [30]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/
> > igt@gem_ppgtt@flink-and-close-vma-leak.html
> > 
> >   * igt@gem_workarounds@suspend-resume-context:
> >     - shard-apl:          [PASS][31] -> ([DMESG-WARN][32],
> > [PASS][33]) ([i915#180]) +4 similar issues
> >    [31]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
> >    [32]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
> >    [33]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/
> > igt@gem_workarounds@suspend-resume-context.html
> > 
> >   * igt@i915_hangman@error-state-capture-vcs1:
> >     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#112080])
> >    [34]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@i915_hangman@error-state-capture-vcs1.html
> >    [35]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8
> > /igt@i915_hangman@error-state-capture-vcs1.html
> > 
> >   * igt@i915_pm_dc@dc5-psr:
> >     - shard-skl:          [PASS][36] -> ([PASS][37],
> > [INCOMPLETE][38]) ([i915#198])
> >    [36]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@i915_pm_dc@dc5-psr.html
> >    [37]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@i915_pm_dc@dc5-psr.html
> >    [38]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/
> > igt@i915_pm_dc@dc5-psr.html
> > 
> >   * igt@i915_selftest@mock_sanitycheck:
> >     - shard-skl:          [PASS][39] -> ([PASS][40], [DMESG-
> > WARN][41]) ([i915#747])
> >    [39]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl5/igt@i915_selftest@mock_sanitycheck.html
> >    [40]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_selftest@mock_sanitycheck.html
> >    [41]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10
> > /igt@i915_selftest@mock_sanitycheck.html
> > 
> >   * igt@i915_suspend@forcewake:
> >     - shard-skl:          [PASS][42] -> ([INCOMPLETE][43],
> > [PASS][44]) ([i915#69])
> >    [42]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl9/igt@i915_suspend@forcewake.html
> >    [43]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl6/igt@i915_suspend@forcewake.html
> >    [44]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/
> > igt@i915_suspend@forcewake.html
> > 
> >   * igt@i915_suspend@sysfs-reader:
> >     - shard-apl:          [PASS][45] -> [DMESG-WARN][46] ([i915#180])
> > +1 similar issue
> >    [45]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@i915_suspend@sysfs-reader.html
> >    [46]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/
> > igt@i915_suspend@sysfs-reader.html
> > 
> >   * igt@kms_color@pipe-a-ctm-0-75:
> >     - shard-skl:          [PASS][47] -> ([DMESG-WARN][48],
> > [PASS][49]) ([i915#109])
> >    [47]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
> >    [48]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10/igt@kms_color@pipe-a-ctm-0-75.html
> >    [49]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl7/
> > igt@kms_color@pipe-a-ctm-0-75.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> >     - shard-kbl:          [PASS][50] -> [DMESG-WARN][51] ([i915#180])
> > +2 similar issues
> >    [50]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> >    [51]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-kbl6/
> > igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
> >     - shard-hsw:          [PASS][52] -> ([DMESG-WARN][53],
> > [PASS][54]) ([IGT#6] / [i915#435])
> >    [52]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw4/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> >    [53]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw6/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> >    [54]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw4/
> > igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
> >     - shard-skl:          [PASS][55] -> ([FAIL][56], [PASS][57])
> > ([i915#54]) +1 similar issue
> >    [55]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> >    [56]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> >    [57]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl4/
> > igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> > 
> >   * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
> >     - shard-skl:          [PASS][58] -> ([INCOMPLETE][59],
> > [PASS][60]) ([fdo#112347] / [i915#646] / [i915#667])
> >    [58]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> >    [59]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> >    [60]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/
> > igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank:
> >     - shard-skl:          [PASS][61] -> ([FAIL][62], [PASS][63])
> > ([i915#46])
> >    [61]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
> >    [62]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/igt@kms_flip@flip-vs-expired-vblank.html
> >    [63]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/
> > igt@kms_flip@flip-vs-expired-vblank.html
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
> >     - shard-iclb:         [PASS][64] -> [INCOMPLETE][65] ([i915#140])
> >    [64]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
> >    [65]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2
> > /igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> >     - shard-iclb:         [PASS][66] -> [INCOMPLETE][67] ([i915#123]
> > / [i915#140])
> >    [66]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> >    [67]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb3
> > /igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-rend
> > er.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc:
> >     - shard-tglb:         [PASS][68] -> [INCOMPLETE][69] ([i915#474]
> > / [i915#667])
> >    [68]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html
> >    [69]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9
> > /igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap
> > -wc.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
> >     - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72])
> > ([i915#49])
> >    [70]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> >    [71]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
> >    [72]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl8/
> > igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.h
> > tml
> > 
> >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
> >     - shard-tglb:         [PASS][73] -> [INCOMPLETE][74] ([i915#456]
> > / [i915#460]) +1 similar issue
> >    [73]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
> >    [74]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb7
> > /igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
> > 
> >   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> >     - shard-skl:          [PASS][75] -> ([FAIL][76], [FAIL][77])
> > ([fdo#108145] / [i915#265])
> >    [75]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >    [76]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> >    [77]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/
> > igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> > 
> >   * igt@kms_psr@psr2_suspend:
> >     - shard-tglb:         [PASS][78] -> [DMESG-WARN][79] ([i915#402])
> >    [78]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_psr@psr2_suspend.html
> >    [79]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8
> > /igt@kms_psr@psr2_suspend.html
> > 
> >   * igt@kms_setmode@basic:
> >     - shard-apl:          [PASS][80] -> ([FAIL][81], [FAIL][82])
> > ([i915#31])
> >    [80]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_setmode@basic.html
> >    [81]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl7/igt@kms_setmode@basic.html
> >    [82]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/
> > igt@kms_setmode@basic.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@gem_busy@close-race:
> >     - shard-tglb:         [INCOMPLETE][83] ([i915#435]) -> [PASS][84]
> >    [83]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_busy@close-race.html
> >    [84]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb2
> > /igt@gem_busy@close-race.html
> > 
> >   * igt@gem_ctx_persistence@vcs0-mixed-process:
> >     - shard-apl:          [FAIL][85] ([i915#679]) -> ([PASS][86],
> > [PASS][87])
> >    [85]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl3/igt@gem_ctx_persistence@vcs0-mixed-process.html
> >    [86]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/igt@gem_ctx_persistence@vcs0-mixed-process.html
> >    [87]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl3/
> > igt@gem_ctx_persistence@vcs0-mixed-process.html
> > 
> >   * igt@gem_ctx_persistence@vcs1-mixed-process:
> >     - shard-iclb:         [SKIP][88] ([fdo#109276] / [fdo#112080]) ->
> > [PASS][89] +1 similar issue
> >    [88]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html
> >    [89]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1
> > /igt@gem_ctx_persistence@vcs1-mixed-process.html
> > 
> >   * igt@gem_eio@banned:
> >     - shard-tglb:         [INCOMPLETE][90] ([i915#476]) -> [PASS][91]
> >    [90]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_eio@banned.html
> >    [91]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4
> > /igt@gem_eio@banned.html
> > 
> >   * igt@gem_exec_balancer@smoke:
> >     - shard-iclb:         [SKIP][92] ([fdo#110854]) -> [PASS][93]
> >    [92]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@gem_exec_balancer@smoke.html
> >    [93]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4
> > /igt@gem_exec_balancer@smoke.html
> > 
> >   * igt@gem_exec_reloc@basic-wc-active:
> >     - shard-skl:          [DMESG-WARN][94] ([i915#109]) ->
> > ([PASS][95], [PASS][96])
> >    [94]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl8/igt@gem_exec_reloc@basic-wc-active.html
> >    [95]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl2/igt@gem_exec_reloc@basic-wc-active.html
> >    [96]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl9/
> > igt@gem_exec_reloc@basic-wc-active.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-bsd2:
> >     - shard-iclb:         [SKIP][97] ([fdo#109276]) -> [PASS][98] +10
> > similar issues
> >    [97]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd2.html
> >    [98]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb1
> > /igt@gem_exec_schedule@preempt-queue-bsd2.html
> > 
> >   * igt@gem_exec_schedule@preempt-queue-contexts-vebox:
> >     - shard-tglb:         [INCOMPLETE][99] ([fdo#111677]) ->
> > [PASS][100]
> >    [99]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> >    [100]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3
> > /igt@gem_exec_schedule@preempt-queue-contexts-vebox.html
> > 
> >   * igt@gem_exec_schedule@preemptive-hang-bsd:
> >     - shard-iclb:         [SKIP][101] ([fdo#112146]) -> [PASS][102]
> > +2 similar issues
> >    [101]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
> >    [102]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb8
> > /igt@gem_exec_schedule@preemptive-hang-bsd.html
> > 
> >   * igt@gem_exec_schedule@smoketest-bsd2:
> >     - shard-tglb:         [INCOMPLETE][103] ([i915#707]) ->
> > [PASS][104]
> >    [103]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb2/igt@gem_exec_schedule@smoketest-bsd2.html
> >    [104]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb1
> > /igt@gem_exec_schedule@smoketest-bsd2.html
> > 
> >   * igt@gem_softpin@noreloc-s3:
> >     - shard-tglb:         [INCOMPLETE][105] ([i915#456]) ->
> > [PASS][106]
> >    [105]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@gem_softpin@noreloc-s3.html
> >    [106]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6
> > /igt@gem_softpin@noreloc-s3.html
> > 
> >   * {igt@gen9_exec_parse@allowed-single}:
> >     - shard-glk:          [DMESG-WARN][107] ([i915#716]) ->
> > ([PASS][108], [PASS][109])
> >    [107]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@gen9_exec_parse@allowed-single.html
> >    [108]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@gen9_exec_parse@allowed-single.html
> >    [109]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk7/igt@gen9_exec_parse@allowed-single.html
> >     - shard-apl:          [DMESG-WARN][110] ([i915#716]) ->
> > [PASS][111]
> >    [110]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl7/igt@gen9_exec_parse@allowed-single.html
> >    [111]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/
> > igt@gen9_exec_parse@allowed-single.html
> > 
> >   * igt@i915_suspend@fence-restore-tiled2untiled:
> >     - shard-apl:          [DMESG-WARN][112] ([i915#180]) ->
> > ([PASS][113], [PASS][114])
> >    [112]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [113]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
> >    [114]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl1/
> > igt@i915_suspend@fence-restore-tiled2untiled.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
> >     - shard-skl:          [FAIL][115] ([i915#54]) -> [PASS][116]
> >    [115]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
> >    [116]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/
> > igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
> > 
> >   * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
> >     - shard-hsw:          [DMESG-WARN][117] ([IGT#6]) ->
> > ([PASS][118], [PASS][119])
> >    [117]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> >    [118]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> >    [119]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw5/
> > igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> > 
> >   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
> >     - shard-tglb:         [INCOMPLETE][120] ([i915#456] / [i915#460])
> > -> [PASS][121]
> >    [120]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> >    [121]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb6
> > /igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> > 
> >   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
> >     - shard-glk:          [FAIL][122] ([i915#79]) -> ([PASS][123],
> > [PASS][124])
> >    [122]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [123]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> >    [124]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-glk4/
> > igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-apl:          [FAIL][125] ([i915#79]) -> ([PASS][126],
> > [PASS][127])
> >    [125]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [126]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> >    [127]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl4/
> > igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> > 
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-skl:          [INCOMPLETE][128] ([i915#221]) ->
> > ([PASS][129], [PASS][130])
> >    [128]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-skl4/igt@kms_flip@flip-vs-suspend.html
> >    [129]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl1/igt@kms_flip@flip-vs-suspend.html
> >    [130]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-skl10
> > /igt@kms_flip@flip-vs-suspend.html
> > 
> >   * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
> >     - shard-tglb:         [FAIL][131] ([i915#49]) -> [PASS][132]
> >    [131]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
> >    [132]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb3
> > /igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.
> > html
> > 
> >   * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
> >     - shard-tglb:         [INCOMPLETE][133] ([i915#456] / [i915#460]
> > / [i915#474]) -> [PASS][134]
> >    [133]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> >    [134]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb4
> > /igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
> > 
> >   * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> >     - shard-iclb:         [INCOMPLETE][135] ([i915#140] / [i915#246])
> > -> [PASS][136]
> >    [135]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
> >    [136]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2
> > /igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
> > 
> >   * igt@kms_psr@psr2_cursor_mmap_cpu:
> >     - shard-iclb:         [SKIP][137] ([fdo#109441]) -> [PASS][138]
> > +1 similar issue
> >    [137]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >    [138]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb2
> > /igt@kms_psr@psr2_cursor_mmap_cpu.html
> > 
> >   * igt@kms_vblank@pipe-b-ts-continuation-suspend:
> >     - shard-apl:          [DMESG-WARN][139] ([i915#180]) ->
> > [PASS][140] +1 similar issue
> >    [139]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
> >    [140]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-apl2/
> > igt@kms_vblank@pipe-b-ts-continuation-suspend.html
> > 
> >   * igt@perf_pmu@busy-check-all-vcs1:
> >     - shard-iclb:         [SKIP][141] ([fdo#112080]) -> [PASS][142]
> > +5 similar issues
> >    [141]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html
> >    [142]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-iclb4
> > /igt@perf_pmu@busy-check-all-vcs1.html
> > 
> >   
> > #### Warnings ####
> > 
> >   * igt@gem_ctx_isolation@vcs2-s3:
> >     - shard-tglb:         [SKIP][143] ([fdo#111912] / [fdo#112080])
> > -> [SKIP][144] ([fdo#112080])
> >    [143]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb4/igt@gem_ctx_isolation@vcs2-s3.html
> >    [144]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb9
> > /igt@gem_ctx_isolation@vcs2-s3.html
> > 
> >   * igt@gem_tiled_blits@normal:
> >     - shard-hsw:          [FAIL][145] ([i915#818]) -> ([FAIL][146],
> > [DMESG-FAIL][147]) ([i915#44] / [i915#818])
> >    [145]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-hsw7/igt@gem_tiled_blits@normal.html
> >    [146]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw2/igt@gem_tiled_blits@normal.html
> >    [147]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-hsw1/
> > igt@gem_tiled_blits@normal.html
> > 
> >   * igt@kms_atomic_transition@6x-modeset-transitions:
> >     - shard-tglb:         [SKIP][148] ([fdo#112021]) -> [SKIP][149]
> > ([fdo#112016] / [fdo#112021])
> >    [148]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7578/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions.html
> >    [149]: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/shard-tglb8
> > /igt@kms_atomic_transition@6x-modeset-transitions.html
> > 
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-apl:          [DMESG-WARN][150] ([i915#180]) ->
> > ([PASS][151], [DMESG-WARN][152]) ([i915#180])
> >    [150]: https://intel-gfx-ci.01.org
> > 
> > == Logs ==
> > 
> > For more details see: 
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15797/index.html
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
  2019-12-13 23:38   ` Lucas De Marchi
@ 2019-12-18 14:53     ` Ville Syrjälä
  -1 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjälä @ 2019-12-18 14:53 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx, dri-devel

On Fri, Dec 13, 2019 at 03:38:53PM -0800, Lucas De Marchi wrote:
> On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote:
> >From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> >Annoyingly __drm_atomic_helper_crtc_reset() does two
> >totally separate things:
> >a) reset the state to defaults values
> >b) assign the crtc->state pointer
> >
> >I just want a) without the b) so let's split out part
> >a) into __drm_atomic_helper_crtc_state_reset(). And
> >of course we'll do the same thing for planes and connectors.
> >
> >Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >---
> > drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
> > include/drm/drm_atomic_state_helper.h     |  6 ++
> > 2 files changed, 67 insertions(+), 9 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> >index d0a937fb0c56..a972068d58cf 100644
> >--- a/drivers/gpu/drm/drm_atomic_state_helper.c
> >+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> >@@ -57,6 +57,22 @@
> >  * for these functions.
> >  */
> >
> >+/**
> >+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
> >+ * @crtc_state: atomic CRTC state, must not be NULL
> >+ * @crtc: CRTC object, must not be NULL
> >+ *
> >+ * Initializes the newly allocated @crtc_state with default
> >+ * values. This is useful for drivers that subclass the CRTC state.
> >+ */
> >+void
> >+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
> >+				     struct drm_crtc *crtc)
> >+{
> >+	crtc_state->crtc = crtc;
> >+}
> >+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
> >+
> > /**
> >  * __drm_atomic_helper_crtc_reset - reset state on CRTC
> >  * @crtc: drm CRTC
> >@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> > 			       struct drm_crtc_state *crtc_state)
> > {
> > 	if (crtc_state)
> >-		crtc_state->crtc = crtc;
> >+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
> >
> > 	crtc->state = crtc_state;
> > }
> >@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> > EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
> >
> > /**
> >- * __drm_atomic_helper_plane_reset - resets planes state to default values
> >+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
> >+ * @plane_state: atomic plane state, must not be NULL
> >  * @plane: plane object, must not be NULL
> >- * @state: atomic plane state, must not be NULL
> >  *
> >- * Initializes plane state to default. This is useful for drivers that subclass
> >- * the plane state.
> >+ * Initializes the newly allocated @plane_state with default
> >+ * values. This is useful for drivers that subclass the CRTC state.
> >  */
> >-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> >-				     struct drm_plane_state *state)
> >+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> >+					   struct drm_plane *plane)
> > {
> > 	state->plane = plane;
> > 	state->rotation = DRM_MODE_ROTATE_0;
> >
> > 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> > 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> >+}
> >+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
> >
> >-	plane->state = state;
> >+/**
> >+ * __drm_atomic_helper_plane_reset - reset state on plane
> >+ * @plane: drm plane
> >+ * @plane_state: plane state to assign
> >+ *
> >+ * Initializes the newly allocated @plane_state and assigns it to
> >+ * the &drm_crtc->state pointer of @plane, usually required when
> >+ * initializing the drivers or when called from the &drm_plane_funcs.reset
> >+ * hook.
> >+ *
> >+ * This is useful for drivers that subclass the plane state.
> >+ */
> >+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> >+				     struct drm_plane_state *plane_state)
> >+{
> >+	if (plane_state)
> >+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
> >+
> >+	plane->state = plane_state;
> > }
> > EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
> >
> >@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> > }
> > EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
> >
> >+/**
> >+ * __drm_atomic_helper_connector_state_reset - reset the connector state
> >+ * @conn__state: atomic connector state, must not be NULL
> 
> typo here, otherwise

Thanks for catching that. Made me run a doc build that found a mismatch
between kerneldoc vs. code for the plane function, so I fixed that up
while pushing.

Entire series pushed to dinq with Daniel's ack for the first patch.
Though in hindsight I could have just pushed that one to drm-misc eons
ago. Oh well.

Thanks for the reviews.

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.
@ 2019-12-18 14:53     ` Ville Syrjälä
  0 siblings, 0 replies; 37+ messages in thread
From: Ville Syrjälä @ 2019-12-18 14:53 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx, dri-devel

On Fri, Dec 13, 2019 at 03:38:53PM -0800, Lucas De Marchi wrote:
> On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote:
> >From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> >Annoyingly __drm_atomic_helper_crtc_reset() does two
> >totally separate things:
> >a) reset the state to defaults values
> >b) assign the crtc->state pointer
> >
> >I just want a) without the b) so let's split out part
> >a) into __drm_atomic_helper_crtc_state_reset(). And
> >of course we'll do the same thing for planes and connectors.
> >
> >Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >---
> > drivers/gpu/drm/drm_atomic_state_helper.c | 70 ++++++++++++++++++++---
> > include/drm/drm_atomic_state_helper.h     |  6 ++
> > 2 files changed, 67 insertions(+), 9 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
> >index d0a937fb0c56..a972068d58cf 100644
> >--- a/drivers/gpu/drm/drm_atomic_state_helper.c
> >+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
> >@@ -57,6 +57,22 @@
> >  * for these functions.
> >  */
> >
> >+/**
> >+ * __drm_atomic_helper_crtc_state_reset - reset the CRTC state
> >+ * @crtc_state: atomic CRTC state, must not be NULL
> >+ * @crtc: CRTC object, must not be NULL
> >+ *
> >+ * Initializes the newly allocated @crtc_state with default
> >+ * values. This is useful for drivers that subclass the CRTC state.
> >+ */
> >+void
> >+__drm_atomic_helper_crtc_state_reset(struct drm_crtc_state *crtc_state,
> >+				     struct drm_crtc *crtc)
> >+{
> >+	crtc_state->crtc = crtc;
> >+}
> >+EXPORT_SYMBOL(__drm_atomic_helper_crtc_state_reset);
> >+
> > /**
> >  * __drm_atomic_helper_crtc_reset - reset state on CRTC
> >  * @crtc: drm CRTC
> >@@ -74,7 +90,7 @@ __drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
> > 			       struct drm_crtc_state *crtc_state)
> > {
> > 	if (crtc_state)
> >-		crtc_state->crtc = crtc;
> >+		__drm_atomic_helper_crtc_state_reset(crtc_state, crtc);
> >
> > 	crtc->state = crtc_state;
> > }
> >@@ -212,23 +228,43 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> > EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
> >
> > /**
> >- * __drm_atomic_helper_plane_reset - resets planes state to default values
> >+ * __drm_atomic_helper_plane_state_reset - resets plane state to default values
> >+ * @plane_state: atomic plane state, must not be NULL
> >  * @plane: plane object, must not be NULL
> >- * @state: atomic plane state, must not be NULL
> >  *
> >- * Initializes plane state to default. This is useful for drivers that subclass
> >- * the plane state.
> >+ * Initializes the newly allocated @plane_state with default
> >+ * values. This is useful for drivers that subclass the CRTC state.
> >  */
> >-void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> >-				     struct drm_plane_state *state)
> >+void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *state,
> >+					   struct drm_plane *plane)
> > {
> > 	state->plane = plane;
> > 	state->rotation = DRM_MODE_ROTATE_0;
> >
> > 	state->alpha = DRM_BLEND_ALPHA_OPAQUE;
> > 	state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
> >+}
> >+EXPORT_SYMBOL(__drm_atomic_helper_plane_state_reset);
> >
> >-	plane->state = state;
> >+/**
> >+ * __drm_atomic_helper_plane_reset - reset state on plane
> >+ * @plane: drm plane
> >+ * @plane_state: plane state to assign
> >+ *
> >+ * Initializes the newly allocated @plane_state and assigns it to
> >+ * the &drm_crtc->state pointer of @plane, usually required when
> >+ * initializing the drivers or when called from the &drm_plane_funcs.reset
> >+ * hook.
> >+ *
> >+ * This is useful for drivers that subclass the plane state.
> >+ */
> >+void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> >+				     struct drm_plane_state *plane_state)
> >+{
> >+	if (plane_state)
> >+		__drm_atomic_helper_plane_state_reset(plane_state, plane);
> >+
> >+	plane->state = plane_state;
> > }
> > EXPORT_SYMBOL(__drm_atomic_helper_plane_reset);
> >
> >@@ -335,6 +371,22 @@ void drm_atomic_helper_plane_destroy_state(struct drm_plane *plane,
> > }
> > EXPORT_SYMBOL(drm_atomic_helper_plane_destroy_state);
> >
> >+/**
> >+ * __drm_atomic_helper_connector_state_reset - reset the connector state
> >+ * @conn__state: atomic connector state, must not be NULL
> 
> typo here, otherwise

Thanks for catching that. Made me run a doc build that found a mismatch
between kerneldoc vs. code for the plane function, so I fixed that up
while pushing.

Entire series pushed to dinq with Daniel's ack for the first patch.
Though in hindsight I could have just pushed that one to drm-misc eons
ago. Oh well.

Thanks for the reviews.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 37+ messages in thread

end of thread, other threads:[~2019-12-18 14:53 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 14:24 [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co Ville Syrjala
2019-11-07 14:24 ` [Intel-gfx] " Ville Syrjala
2019-11-07 14:24 ` Ville Syrjala
2019-11-07 14:24 ` [PATCH 2/5] drm/i915: s/intel_crtc/crtc/ in intel_crtc_init() Ville Syrjala
2019-11-07 14:24   ` [Intel-gfx] " Ville Syrjala
2019-11-07 14:24   ` Ville Syrjala
2019-12-10  2:06   ` [Intel-gfx] " Souza, Jose
2019-12-10  2:06     ` Souza, Jose
2019-11-07 14:24 ` [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc,free}() Ville Syrjala
2019-11-07 14:24   ` [Intel-gfx] [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc, free}() Ville Syrjala
2019-12-10  2:09   ` [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc,free}() Souza, Jose
2019-12-10  2:09     ` [Intel-gfx] [PATCH 3/5] drm/i915: Introduce intel_crtc_{alloc, free}() Souza, Jose
2019-11-07 14:24 ` [PATCH 4/5] drm/i915: Introduce intel_crtc_state_reset() Ville Syrjala
2019-11-07 14:24   ` [Intel-gfx] " Ville Syrjala
2019-12-10  2:12   ` Souza, Jose
2019-12-10  2:12     ` Souza, Jose
2019-11-07 14:24 ` [PATCH 5/5] drm/i915: Introduce intel_plane_state_reset() Ville Syrjala
2019-11-07 14:24   ` [Intel-gfx] " Ville Syrjala
2019-12-10  2:12   ` Souza, Jose
2019-12-10  2:12     ` Souza, Jose
2019-11-07 17:38 ` [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co Daniel Vetter
2019-11-07 17:38   ` [Intel-gfx] " Daniel Vetter
2019-11-07 17:38   ` Daniel Vetter
2019-11-07 18:28 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] " Patchwork
2019-11-07 18:28   ` [Intel-gfx] " Patchwork
2019-12-12 17:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev2) Patchwork
2019-12-13 23:38 ` [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co Lucas De Marchi
2019-12-13 23:38   ` Lucas De Marchi
2019-12-18 14:53   ` Ville Syrjälä
2019-12-18 14:53     ` Ville Syrjälä
2019-12-17  1:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co. (rev3) Patchwork
2019-12-17 11:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-17 18:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-17 18:33   ` Souza, Jose
2019-12-17 18:42     ` James Ausmus
2019-12-18  9:33       ` Vudum, Lakshminarayana
2019-12-18  8:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.