From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1igo1I-0001Tj-Vh for mharc-grub-devel@gnu.org; Mon, 16 Dec 2019 05:54:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46080) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igo1G-0001TR-Qy for grub-devel@gnu.org; Mon, 16 Dec 2019 05:54:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igo1E-0007da-OQ for grub-devel@gnu.org; Mon, 16 Dec 2019 05:54:30 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:54064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1igo1E-0007cj-B2 for grub-devel@gnu.org; Mon, 16 Dec 2019 05:54:28 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBGAmjH4069307; Mon, 16 Dec 2019 10:54:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=eBfyUGoYI57n+1seFnHmlAIuxWU9RdceY0cEDjDSZQc=; b=KqAKA452LmvZm1XSlOqpotI3rbcL/woW4+EEhTA9CvsfrrmV9bdOWrHi+OIKlPteEFCL GiKspHshtR5qzxdFdR/Fql0zzkT0eDUjWSoYz7UkKqHY1fSli2MnVfWyZ+K8KpW7zDsc JCP2T7a525Yy+efmdFLsxoR0xSZXkmOy1/NTzTayMO47BdubcefORlg0PmS89ahTeo1Z pgeJdI6RCIWyHSSYBD7tCpiQvbAAtYkwB23XxWH1+9S4P5XBzzztOd5+FNYZQizTB/AL Oy0dEfEyoNtn3KBirVcDtmTKWVkKJIbq2MO0vFv3sFvHGqaYn1n5/XHC/xIP8upFoMeW 0A== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2wvqppxt5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Dec 2019 10:54:24 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBGAmVcq016503; Mon, 16 Dec 2019 10:54:23 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ww9vp5jp4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Dec 2019 10:54:23 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBGAsMiD015251; Mon, 16 Dec 2019 10:54:22 GMT Received: from tomti.i.net-space.pl (/10.175.219.226) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Dec 2019 02:54:21 -0800 Date: Mon, 16 Dec 2019 11:54:18 +0100 From: Daniel Kiper To: Lukasz Hawrylko Cc: grub-devel@gnu.org Subject: Re: [PATCH v2] multiboot2: set min address for mbi allocation to 0x1000 Message-ID: <20191216105418.sm7lv2u24uiow5bg@tomti.i.net-space.pl> References: <20191216101555.30362-1-lukasz.hawrylko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191216101555.30362-1-lukasz.hawrylko@linux.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9472 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=920 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912160096 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9472 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912160096 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 10:54:32 -0000 On Mon, Dec 16, 2019 at 11:15:55AM +0100, Lukasz Hawrylko wrote: > In some cases GRUB2 allocates multiboot2 structure at 0 address, that is > a confusing behavior. Consumers of that structure can have internal NULL-checks > that will throw an error when get a pointer to data allocated at address 0. > To prevent that, define min address for mbi allocation in x86 and x86_64 > platforms. > > Signed-off-by: Lukasz Hawrylko > Reviewed-by: Daniel Kiper LGTM. If there are no objections I will commit it by the end of this week. Thanks, Daniel