From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1igq3m-00051T-W3
	for mharc-grub-devel@gnu.org; Mon, 16 Dec 2019 08:05:15 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38537)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <dkiper@net-space.pl>) id 1igq3k-0004xY-AE
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:05:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <dkiper@net-space.pl>) id 1igq3j-0003yC-4P
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:05:12 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:39238)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24)
 (Exim 4.71) (envelope-from <dkiper@net-space.pl>) id 1igq3i-0003vZ-Po
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:05:11 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:58156 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S1936036AbfLPNFF (ORCPT <rfc822;grub-devel@gnu.org>);
 Mon, 16 Dec 2019 14:05:05 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Mon, 16 Dec 2019 14:05:00 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Patrick Steinhardt <ps@pks.im>
Cc: grub-devel@gnu.org, Max Tottenham <mtottenh@akamai.com>
Subject: Re: [PATCH v6 6/6] disk: Implement support for LUKS2
Message-ID: <20191216130500.pbeae45waxjfz7ph@tomti.i.net-space.pl>
References: <cover.1572717208.git.ps@pks.im> <cover.1575969933.git.ps@pks.im>
 <f9b5784875e96c66e8d8b7dc666f5b701f4a423f.1575969933.git.ps@pks.im>
 <20191216122501.kt4f2jzjk3h4r3la@tomti.i.net-space.pl>
 <20191216123733.GA5832@ncase>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191216123733.GA5832@ncase>
User-Agent: NeoMutt/20170113 (1.7.2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 84.10.22.86
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Dec 2019 13:05:13 -0000

On Mon, Dec 16, 2019 at 01:37:33PM +0100, Patrick Steinhardt wrote:
> On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote:
> > On Tue, Dec 10, 2019 at 10:26:21AM +0100, Patrick Steinhardt wrote:
> [snip]
> > > +  /* Get the passphrase from the user. */
> > > +  if (disk->partition)
> > > +    part = grub_partition_get_name (disk->partition);
> > > +  grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), disk->name,
> > > +		disk->partition ? "," : "", part ? : "",
> > > +		crypt->uuid);
> >
> > Why do you use grub_printf() instead of grub_printf()?
>
> I guess you mean grub_printf_() instead of grub_printf(). The

Err... Right...

> answer to that is simple: I copied it from "luks.c", and I saw it
> being used in various other modules for output that is
> user-facing and should thus be translated. Is there are more
> modern alternative that should be used instead? If so then I'm
> happy to use it instead.

I am not sure about this underscore at the end. And there is no good
explanation around grub_printf_() and grub_printf() why they are both
different. So, if you copied this from "luks.c" let's leave it as is
for time being.

Anyway, if there are no objections I will push this patch series by the
end of this week.

Thank you for doing the work!

Daniel