From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1igq9F-0000v8-Ak
	for mharc-grub-devel@gnu.org; Mon, 16 Dec 2019 08:10:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:40570)
 by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <ps@pks.im>)
 id 1igq9D-0000t4-7k
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:10:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ps@pks.im>) id 1igq9B-00055Q-V3
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:10:51 -0500
Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:34755)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ps@pks.im>) id 1igq9B-00050N-BZ
 for grub-devel@gnu.org; Mon, 16 Dec 2019 08:10:49 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id A237E7A0;
 Mon, 16 Dec 2019 08:10:47 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 16 Dec 2019 08:10:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date
 :from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=fm2; bh=8K6DjziZziiaQfO5rr1/awNQkrD
 pKUvbegA4aWyMQNs=; b=r7rkJ1nmUWLFdRTPz97gZjllricxesp8MKYYOzhpzwr
 JsiiXBbGGsFKO9kixfm+Wx3lUQnt0XJyCYF/jwHRMRZoMlkq/ANXoHK9/OrEEWE8
 WxLQgNda9doPWtCUJwN2w4l4TquRLeb+5dDOl5wR/yvzAa6PDUT7T7fy2dyd0TeX
 Yd0GRFP8gqRqWbau5YYcPDEwru+jcM0pWMGMOFYj0w/6NaM5olCPEtxTMXKQRJY/
 rSIXrsxApiVI/Vw5CiDSuvqRAbfRlXI+CJ5uxxzP0ywCfQFlZcFgEx0TMsUI2BoG
 XzpvPkvkFupCe3EnMYpkEjhwQILDrqzwJAyGT2muLvg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8K6Djz
 iZziiaQfO5rr1/awNQkrDpKUvbegA4aWyMQNs=; b=RUHJsgyJ8vichVekGNMBOg
 8Rto8rkf8b7SX93q/tijaQZj9c4Fvb499eJfFFHq4Yjno5wUgZZ7rYTE+tzxYSMt
 CNhCm8nR4at3zleBWCHMxRQXVrjNGMBcQCRBwhT4cS2Nn8r84DeYETj34oSJGkj8
 7Ae3LJWKMpRiMe3/KgVtf+ds8OFIaj4+XRhvedm1w7rruboI9RDO8+59BLKAqjCP
 kOsv7t5eIwcgJF3BAC+G1uvBZsca4UocPAeNDTQOTSqxrfe+0D+P1JOzmt8FlcIG
 SOxSQ3fXHcfGyJaX9VyNkjYWASJyR/aCEMGhcWvP7tAH+Uke18ttF7jxNCHH3cZA
 ==
X-ME-Sender: <xms:VoL3XRIugdPECvQe6rMOkUsCVIk7P-5ZhhKQIlifnzjbiueSLEoyeQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddthedggeelucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi
 tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepjeejrdduke
 efrdegvddrvddvgeenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimhen
 ucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:VoL3Xajadpf9iuDrZOpszwro7ryWkXye0GizEsghk-MBs9BRhvUukQ>
 <xmx:VoL3XYlVMA5_sG859ZjBMmJh_i8ROItDmWSXF4GEJPjormWGMVjEdA>
 <xmx:VoL3XbmSTrfNh-BIRuOlu_OaicutqiApVXlXlzI-DoE9O7hJUznB6Q>
 <xmx:V4L3XUUFZt04PzqbMWNf4qO6nu1IqeNKAiLuR7jbk8CndQaslAEV9w>
Received: from vm-mail (x4db72ae0.dyn.telefonica.de [77.183.42.224])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6A2B980063;
 Mon, 16 Dec 2019 08:10:46 -0500 (EST)
Received: from localhost (<unknown> [10.192.0.11])
 by vm-mail (OpenSMTPD) with ESMTPSA id 9e0f21d2
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Mon, 16 Dec 2019 13:10:44 +0000 (UTC)
Date: Mon, 16 Dec 2019 14:10:55 +0100
From: Patrick Steinhardt <ps@pks.im>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org, Max Tottenham <mtottenh@akamai.com>
Subject: Re: [PATCH v6 6/6] disk: Implement support for LUKS2
Message-ID: <20191216131055.GA4794@ncase>
References: <cover.1572717208.git.ps@pks.im> <cover.1575969933.git.ps@pks.im>
 <f9b5784875e96c66e8d8b7dc666f5b701f4a423f.1575969933.git.ps@pks.im>
 <20191216122501.kt4f2jzjk3h4r3la@tomti.i.net-space.pl>
 <20191216123733.GA5832@ncase>
 <20191216130500.pbeae45waxjfz7ph@tomti.i.net-space.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
In-Reply-To: <20191216130500.pbeae45waxjfz7ph@tomti.i.net-space.pl>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 64.147.123.21
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Dec 2019 13:10:52 -0000


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 16, 2019 at 02:05:00PM +0100, Daniel Kiper wrote:
> On Mon, Dec 16, 2019 at 01:37:33PM +0100, Patrick Steinhardt wrote:
> > On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote:
> > > On Tue, Dec 10, 2019 at 10:26:21AM +0100, Patrick Steinhardt wrote:
> > [snip]
> > > > +  /* Get the passphrase from the user. */
> > > > +  if (disk->partition)
> > > > +    part =3D grub_partition_get_name (disk->partition);
> > > > +  grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), disk->na=
me,
> > > > +		disk->partition ? "," : "", part ? : "",
> > > > +		crypt->uuid);
> > >
> > > Why do you use grub_printf() instead of grub_printf()?
> >
> > I guess you mean grub_printf_() instead of grub_printf(). The
>=20
> Err... Right...
>=20
> > answer to that is simple: I copied it from "luks.c", and I saw it
> > being used in various other modules for output that is
> > user-facing and should thus be translated. Is there are more
> > modern alternative that should be used instead? If so then I'm
> > happy to use it instead.
>=20
> I am not sure about this underscore at the end. And there is no good
> explanation around grub_printf_() and grub_printf() why they are both
> different. So, if you copied this from "luks.c" let's leave it as is
> for time being.
>=20
> Anyway, if there are no objections I will push this patch series by the
> end of this week.
>=20
> Thank you for doing the work!
>=20
> Daniel

Cool, great news. Thanks a lot for your reviews!

When this is merged I plan to tackle Argon2 support to make this
more useful in the future. I guess we need support for this in
libgcrypt first, though, so it will probably take some more time.

Patrick

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl33gl8ACgkQEXxntp6r
8Sw+xA/6A56rXI02k1hrfWdJfV2ZLjXiKBM44zaNBWSAQwUI0F9dwd3niGBC3ISz
lJhFuuaciD1PhIeDPfzSzEz6PdMN4WwQSl6oXYGOHtt1H61sm8LxadZ5QN42LqPt
XUxOZT5UMbYx9TgytuIgQfkiOkZanezpoqRlcsOWFn+UwfW/nOHH+oeGpx79tVgW
qMBDzSQfUhj6cZSB62DUXLJFtSUuIEphmsiiASC8WWxfU1EM2FZQNNQ0fGHcNTtL
PMnGYgv15YuOtZDgtC44qAgLoMe1zjznrSdAjqz0jLiYZbTj8njS5G+8k1Di+vuF
ZkK0jAhX4VYRf77nz9US5t4mXlq1j/0dvIbU6g2+uWhtO/iIP24r3y/wa/Mt7G2v
SHiod7AUcFxjCYExx0Sf6cydSVsWYopcle+ylrX1pwZITkZ2nFdO58gnwlm8nk8d
Q6hZPId21Q3Th/XiiY7lF/xsWeMcGTDpKjBPGH4NQ5aajWTi1XXVDBu4unVa4w6W
YwtKh1Rwonjjc+8BU1iCz8s8wIHF63Ce6/E+2UUlXxrTroMIdmVCwz6i4+Bv3big
Ut82fP37i0kUG+zkmszPuvuX1LGAka9uKJQEAc8ocpqhFLU+LxR44an07IRnB+3K
aTsHAzFtlu+5YyRaVyZdnV70BEP/U/Skd4nZQAkji7VBkH4O7SM=
=j/1W
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--