From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C461BC43603 for ; Tue, 17 Dec 2019 00:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 911BD2176D for ; Tue, 17 Dec 2019 00:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="LlZOOR9c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfLQALZ (ORCPT ); Mon, 16 Dec 2019 19:11:25 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39568 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfLQALZ (ORCPT ); Mon, 16 Dec 2019 19:11:25 -0500 Received: by mail-lj1-f193.google.com with SMTP id e10so8807012ljj.6 for ; Mon, 16 Dec 2019 16:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=mgdbNsb2U5szXT98Luh3Bo8MJcnyi91BccDx4009UHE=; b=LlZOOR9cNxBNM4lljL4PWV6m5lhlUA0UqAWkEVPbwfbEurMkEFzYiOEaHfO91gU2uI xjMktLJxGyZ4PgLHjTRIs4URVbpg8C8ESOjdF7giaahBuCRVv3HHk/O9535icb2WfNS1 yCGYfmHyCrDjp0q29VuuicGEtKv5yiGXHJOIizZUdjP2HX+V16JiPug8AOgXQTf6iPvc CmFlTKqqwiL7fsQGFz5zUB7sjhFX+Ssi9INqeKv1/ueEJAgg53AHWSlHZG1QnSZzN23V CVVUlGhcikgB6I9qGI6Ofr4F3nFd5fikCeXS/oqGSpTe0GG2MEYK7DgOhD6CMVSe53lb vKLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=mgdbNsb2U5szXT98Luh3Bo8MJcnyi91BccDx4009UHE=; b=LGP9C4pPFA9xmvBRUU7742l/8H92Z+urQWSD7S5y30SA4NkpVgkTyn/Q1PhjNS1dKp i9RzE53XZOQPsgQTv6etnl4jtf3f+wGAfd784v/QdAr12jOshMBJzOOzFMlGTylz05wx 4czwKW8lPEVAY24io6sT1LuWwGU5EUrtTys1Ipgv/BOpeYWfceMwrhPc3F+BuDcj0BAE jExUstH78yYmRsomentMbKdK6Lbth4krcmeEJ617NYCbJkfcAArdErP0SCvCOf0KwIEn XogVF19dAdQz5JJ5stD4TFqgTVF1TLylgIPFQ1JvvURvWjJ1E85R+SVoHD9Rv6CdizmE yfUA== X-Gm-Message-State: APjAAAUIQiAqXWOsa4bNVEEtTquyLNU7jsMHpGeSWaKbYold7Lgk+r5V gIxrQ+90F80liCPJLWubu45O+A== X-Google-Smtp-Source: APXvYqz3Im0Fgkkiyr2JZbkmyo8my7bPlxXPgPfqc89lQKgQjaIKkN27ALt6zcR5Szea7m3ErnAVNg== X-Received: by 2002:a2e:b60d:: with SMTP id r13mr1257632ljn.40.1576541483323; Mon, 16 Dec 2019 16:11:23 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id u25sm9853720lfk.46.2019.12.16.16.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 16:11:22 -0800 (PST) Date: Mon, 16 Dec 2019 16:11:14 -0800 From: Jakub Kicinski To: Richard Cochran Cc: netdev@vger.kernel.org, David Miller , devicetree@vger.kernel.org, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Jacob Keller , Mark Rutland , Miroslav Lichvar , Murali Karicheri , Rob Herring , Willem de Bruijn , Wingman Kwok Subject: Re: [PATCH V6 net-next 11/11] ptp: Add a driver for InES time stamping IP core. Message-ID: <20191216161114.3604d45d@cakuba.netronome.com> In-Reply-To: <33afc113fa0b301d289522971c83dbbf0d36c8ba.1576511937.git.richardcochran@gmail.com> References: <33afc113fa0b301d289522971c83dbbf0d36c8ba.1576511937.git.richardcochran@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 16 Dec 2019 08:13:26 -0800, Richard Cochran wrote: > + clkid = (u64 *)(data + offset + OFF_PTP_CLOCK_ID); > + portn = (u16 *)(data + offset + OFF_PTP_PORT_NUM); > + seqid = (u16 *)(data + offset + OFF_PTP_SEQUENCE_ID); These should perhaps be __be types? Looks like there is a few other sparse warnings in ptp_ines.c, would you mind addressing those? > + if (tag_to_msgtype(ts->tag & 0x7) != (*msgtype & 0xf)) { > + pr_debug("msgtype mismatch ts %hhu != skb %hhu\n", > + tag_to_msgtype(ts->tag & 0x7), *msgtype & 0xf); > + return false; > + } > + if (cpu_to_be64(ts->clkid) != *clkid) { > + pr_debug("clkid mismatch ts %llx != skb %llx\n", > + cpu_to_be64(ts->clkid), *clkid); > + return false; > + } > + if (ts->portnum != ntohs(*portn)) { > + pr_debug("portn mismatch ts %hu != skb %hu\n", > + ts->portnum, ntohs(*portn)); > + return false; > + } > + if (ts->seqid != ntohs(*seqid)) { > + pr_debug("seqid mismatch ts %hu != skb %hu\n", > + ts->seqid, ntohs(*seqid)); > + return false; > + }