From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99D5C43603 for ; Mon, 16 Dec 2019 18:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1BC220700 for ; Mon, 16 Dec 2019 18:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519476; bh=5fUVMK8lM38GtgNfl95ndPnU9/CVLhMujqLgWV6OkpE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=J1fLnLYwLOKsn7/0odDFmapkF1zz6GNB8c6gfeoAXtmwp8NesUUVnKtLI54Y/56JH DLHdNowNAm2zZUcEtA21B1RVugtReeKZC/m5TWNVFD6+iCcW7jQ4mevn4boj+9H6C3 CELcthMF9Dnzf06UGU4rx6hU6hfISKqnE845V4hU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729680AbfLPSEg (ORCPT ); Mon, 16 Dec 2019 13:04:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:41912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729474AbfLPSEd (ORCPT ); Mon, 16 Dec 2019 13:04:33 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73B9520700; Mon, 16 Dec 2019 18:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519472; bh=5fUVMK8lM38GtgNfl95ndPnU9/CVLhMujqLgWV6OkpE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TAdPIujFY0AVn5WE73BfyEfROy6RIXxpI09S8XVbRQEf+yWtgKgj7cHM/GBvXtIKE HT9lXt4AFg5aPtLn6Sy+jsDFx23U+jNKeN5mPjgaHJUYLXczrs0E1+u6NXwZGNEPgC BqZbrWut83Oj9YCjmtKvObL3b7Rd7Jq1JvPYnQiQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH 4.19 079/140] pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init Date: Mon, 16 Dec 2019 18:49:07 +0100 Message-Id: <20191216174808.616542721@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174747.111154704@linuxfoundation.org> References: <20191216174747.111154704@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski commit 5c7f48dd14e892e3e920dd6bbbd52df79e1b3b41 upstream. In exynos_eint_wkup_init() the for_each_child_of_node() loop is used with a break to find a matching child node. Although each iteration of for_each_child_of_node puts the previous node, but early exit from loop misses it. This leads to leak of device node. Cc: Fixes: 43b169db1841 ("pinctrl: add exynos4210 specific extensions for samsung pinctrl driver") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/samsung/pinctrl-exynos.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -514,6 +514,7 @@ int exynos_eint_wkup_init(struct samsung bank->nr_pins, &exynos_eint_irqd_ops, bank); if (!bank->irq_domain) { dev_err(dev, "wkup irq domain add failed\n"); + of_node_put(wkup_np); return -ENXIO; } @@ -528,8 +529,10 @@ int exynos_eint_wkup_init(struct samsung weint_data = devm_kcalloc(dev, bank->nr_pins, sizeof(*weint_data), GFP_KERNEL); - if (!weint_data) + if (!weint_data) { + of_node_put(wkup_np); return -ENOMEM; + } for (idx = 0; idx < bank->nr_pins; ++idx) { irq = irq_of_parse_and_map(bank->of_node, idx); @@ -546,10 +549,13 @@ int exynos_eint_wkup_init(struct samsung } } - if (!muxed_banks) + if (!muxed_banks) { + of_node_put(wkup_np); return 0; + } irq = irq_of_parse_and_map(wkup_np, 0); + of_node_put(wkup_np); if (!irq) { dev_err(dev, "irq number for muxed EINTs not found\n"); return 0;