From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE6D6C43603 for ; Mon, 16 Dec 2019 18:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79F142082E for ; Mon, 16 Dec 2019 18:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521961; bh=3UOo2nzTK/HKra1hB3D6Q1ldASbnw37qIKyf5VpvXFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QyQbKO7A3x7gYTMo0sHWZ7/+Sq7P/+AceJpl9k7Dekd+In69b9/B1dWWd2y2AlWKT ZGTNDTL83LFKquCM50NlX8OWAygejU/EEjDUhiqjP9Q6kojCVUsfkMjwKGXzI8+ilv WqZD2Ip8g5B+E8vM047CHJP/dY4kT6gxSTayU4q4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728431AbfLPSqA (ORCPT ); Mon, 16 Dec 2019 13:46:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:55140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727921AbfLPR4q (ORCPT ); Mon, 16 Dec 2019 12:56:46 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CDFE205ED; Mon, 16 Dec 2019 17:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519005; bh=3UOo2nzTK/HKra1hB3D6Q1ldASbnw37qIKyf5VpvXFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JI5P8gI+8TEnTEKbPLY9OGfPnMICyxuT6mosF00y01GMJ+d3PP63OOjBL9HKkTUuL R2IYyct2uvDD47kF9YX0KXsp/OQlZP9Ml7w31Oxu5OmGl7F/xffWP8C9P2cfMukeT4 hBn6wdm028Qf7VSM7J+lWXWPPn+ys+ZscXXiPrg0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Yongjun , Peter Chen Subject: [PATCH 4.14 157/267] usb: gadget: configfs: Fix missing spin_lock_init() Date: Mon, 16 Dec 2019 18:48:03 +0100 Message-Id: <20191216174911.106775624@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun commit 093edc2baad2c258b1f55d1ab9c63c2b5ae67e42 upstream. The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Fixes: 1a1c851bbd70 ("usb: gadget: configfs: fix concurrent issue between composite APIs") Signed-off-by: Wei Yongjun Cc: stable Reviewed-by: Peter Chen Link: https://lore.kernel.org/r/20191030034046.188808-1-weiyongjun1@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/gadget/configfs.c +++ b/drivers/usb/gadget/configfs.c @@ -1543,6 +1543,7 @@ static struct config_group *gadgets_make gi->composite.resume = NULL; gi->composite.max_speed = USB_SPEED_SUPER; + spin_lock_init(&gi->spinlock); mutex_init(&gi->lock); INIT_LIST_HEAD(&gi->string_list); INIT_LIST_HEAD(&gi->available_func);