From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068ACC43603 for ; Mon, 16 Dec 2019 17:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF87821582 for ; Mon, 16 Dec 2019 17:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519011; bh=7v9Nt0umS3gM455BPNBm91enprq0zUj3UrK0FBst+OI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y2ys9serFNGzfxws5cCGDhLxcxkesLeRig8wjWCwBxZ5kIKbKlIni1TOpItlYOEpW M8DbpRaw+jo5UVxdxIM5evJAB+mL0rP5eeR+KVFliwlpxCeey0yNQRbP7dpHzbaaUa TNhT9iz6ArKqQukCZcUOwahEVBstJJ6qBvkt8kyM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbfLPR4u (ORCPT ); Mon, 16 Dec 2019 12:56:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:55186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727908AbfLPR4s (ORCPT ); Mon, 16 Dec 2019 12:56:48 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76007206B7; Mon, 16 Dec 2019 17:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519007; bh=7v9Nt0umS3gM455BPNBm91enprq0zUj3UrK0FBst+OI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WqyDlvGC0mIbNCsGG/SBjzSDfDREAQxgSY76GMDKmuzNlB67TtqzThx/JO9i/IwYI wBepGAsRiUmRknYCOxVdRZ5XQ8jCWTVLbAGK2175gKZDa7mOnItOaGurT6Ed/v8phd OuThhuYoynOe7gICrS+qarHlim3pO5HJbvJBuNew= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Nazarewicz , "Gustavo A. R. Silva" Subject: [PATCH 4.14 158/267] usb: gadget: pch_udc: fix use after free Date: Mon, 16 Dec 2019 18:48:04 +0100 Message-Id: <20191216174911.161361692@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo A. R. Silva commit 66d1b0c0580b7f1b1850ee4423f32ac42afa2e92 upstream. Remove pointer dereference after free. pci_pool_free doesn't care about contents of td. It's just a void* for it Addresses-Coverity-ID: 1091173 ("Use after free") Cc: stable@vger.kernel.org Acked-by: Michal Nazarewicz Signed-off-by: Gustavo A. R. Silva Link: https://lore.kernel.org/r/20191106202821.GA20347@embeddedor Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/pch_udc.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struc td = phys_to_virt(addr); addr2 = (dma_addr_t)td->next; dma_pool_free(dev->data_requests, td, addr); - td->next = 0x00; addr = addr2; } req->chain_len = 1;