From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 483A3C2D0C3 for ; Mon, 16 Dec 2019 17:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FF8B21739 for ; Mon, 16 Dec 2019 17:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519168; bh=t2m+N/pplm3UTCqE2QjWfa/alRkJ43sG3Sm3TC3QPDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tTIjM1fpTijH0jHfSuHt+nT762UHObrUida3ER/q3sBldO7xVxCufs4SNfbd0wawN uu1L3P5bQ7BTiRzW92ZjAukPC9vQSCI4JuOTz+GI/Ph0sgR9WOMC4nzgLD09eWycRs 7RP5O81JlT2Sx3XTaMP/BdtqGb5clFY1vvFIazQ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbfLPR70 (ORCPT ); Mon, 16 Dec 2019 12:59:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:60246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbfLPR7Y (ORCPT ); Mon, 16 Dec 2019 12:59:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC1C721582; Mon, 16 Dec 2019 17:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519163; bh=t2m+N/pplm3UTCqE2QjWfa/alRkJ43sG3Sm3TC3QPDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y9JYW7ngWKQU197RjgjbhATfbK6HKz5N60iQo8ccEObHbyI+rEjhHwMQvpdaY73zl 21Fc53z0lw1bzTCXAcMXUYGDFRBPQITE6J7Iq/dPP1a+lUQMPrl4NP4SKezDotPR4/ IbbiRMbxmxfgJuQp2snJc1qygCaBvlAx7/PDSJog= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nishka Dasgupta , Krzysztof Kozlowski Subject: [PATCH 4.14 220/267] pinctrl: samsung: Add of_node_put() before return in error path Date: Mon, 16 Dec 2019 18:49:06 +0100 Message-Id: <20191216174914.608036765@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nishka Dasgupta commit 3d2557ab75d4c568c79eefa2e550e0d80348a6bd upstream. Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return of exynos_eint_wkup_init() error path. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Cc: Fixes: 14c255d35b25 ("pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -467,8 +467,10 @@ int exynos_eint_wkup_init(struct samsung if (match) { irq_chip = kmemdup(match->data, sizeof(*irq_chip), GFP_KERNEL); - if (!irq_chip) + if (!irq_chip) { + of_node_put(np); return -ENOMEM; + } wkup_np = np; break; }