From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F44C43603 for ; Mon, 16 Dec 2019 18:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4057206A5 for ; Mon, 16 Dec 2019 18:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521734; bh=WlaGsvSqozUh/F0uCzyw6u/3FTIovZt1FXOX8anM9sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MbHyo89PKbHGB2JukLJfp7vZzsW4Rh+xPQSxLS/dcuk7uO4xDlmryXN+vD84NX4ks mRIEOytzEH3FSiwc45QAqBpoVLRJSYydyv3dLezC12GXPF6vzGTUY7Y1EfRxe1GOBD 2Wb8qyYIyvBvm4VGQmL62SHhWlTBkJ//WeZRsbZc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729292AbfLPSmN (ORCPT ); Mon, 16 Dec 2019 13:42:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:34864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728483AbfLPSAj (ORCPT ); Mon, 16 Dec 2019 13:00:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A8B0205C9; Mon, 16 Dec 2019 18:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519238; bh=WlaGsvSqozUh/F0uCzyw6u/3FTIovZt1FXOX8anM9sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCmXN6Q5z4a5kq5fzlkTTvkA9Z/KufsPdVwzruaA34xZpyWFRqaW+URhWSNr8WFxk UbyUB9D5xzNZqJSDDcbhc98XrVwfJeinL3jJNoln6q83xP9EuTLWDKwTA5GTaCKYav DKLdLtvPTHUwUBB5MBq0YWs3OT9SBnRf96QT4n7c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Aaron Brown , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.14 252/267] e100: Fix passing zero to PTR_ERR warning in e100_load_ucode_wait Date: Mon, 16 Dec 2019 18:49:38 +0100 Message-Id: <20191216174916.446817992@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174848.701533383@linuxfoundation.org> References: <20191216174848.701533383@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit cd0d465bb697a9c7bf66a9fe940f7981232f1676 ] Fix a static code checker warning: drivers/net/ethernet/intel/e100.c:1349 e100_load_ucode_wait() warn: passing zero to 'PTR_ERR' Signed-off-by: YueHaibing Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/e100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 4d10270ddf8fb..90974462743b5 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -1370,8 +1370,8 @@ static inline int e100_load_ucode_wait(struct nic *nic) fw = e100_request_firmware(nic); /* If it's NULL, then no ucode is required */ - if (!fw || IS_ERR(fw)) - return PTR_ERR(fw); + if (IS_ERR_OR_NULL(fw)) + return PTR_ERR_OR_ZERO(fw); if ((err = e100_exec_cb(nic, (void *)fw, e100_setup_ucode))) netif_err(nic, probe, nic->netdev, -- 2.20.1