From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C04BC43603 for ; Tue, 17 Dec 2019 00:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44C8621D7D for ; Tue, 17 Dec 2019 00:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727777AbfLQAoV (ORCPT ); Mon, 16 Dec 2019 19:44:21 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:35220 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbfLQAoV (ORCPT ); Mon, 16 Dec 2019 19:44:21 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ih0yJ-00022g-O0; Tue, 17 Dec 2019 00:44:20 +0000 Date: Tue, 17 Dec 2019 00:44:19 +0000 From: Al Viro To: Lukas Czerner Cc: linux-ext4@vger.kernel.org, Theodore Ts'o , David Howells Subject: Re: [PATCH 02/17] ext4: Add fs parameter description Message-ID: <20191217004419.GA6833@ZenIV.linux.org.uk> References: <20191106101457.11237-1-lczerner@redhat.com> <20191106101457.11237-3-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106101457.11237-3-lczerner@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Nov 06, 2019 at 11:14:42AM +0100, Lukas Czerner wrote: > + fsparam_string_empty > + ("usrjquota", Opt_usrjquota), > + fsparam_string_empty > + ("grpjquota", Opt_grpjquota), Umm... That makes ...,usrjquota,... equivalent to ...,usrjquota=,... unless I'm misreading the series. Different from mainline, right? > + fsparam_bool ("barrier", Opt_barrier), > + fsparam_flag ("nobarrier", Opt_nobarrier), That's even more interesting. Current mainline: barrier OK, sets EXT4_MOUNT_BARRIER barrier=0 OK, sets EXT4_MOUNT_BARRIER barrier=42 OK, sets EXT4_MOUNT_BARRIER barrier=yes error barrier=no error nobarrier OK, clears EXT4_MOUNT_BARRIER Unless I'm misreading your series, you get barrier error barrier=0 OK, sets EXT4_MOUNT_BARRIER barrier=42 error barrier=yes OK, sets EXT4_MOUNT_BARRIER barrier=no OK, sets EXT4_MOUNT_BARRIER nobarrier OK, clears EXT4_MOUNT_BARRIER Granted, mainline behaviour is... unintuitive, to put it mildly, but the replacement is just as strange _and_ incompatible with the existing one. Am I missing something subtle there?