From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH] Makefile: drop GEN_HDRS
Date: Tue, 17 Dec 2019 00:28:12 -0500 [thread overview]
Message-ID: <20191217052812.GB2762303@coredump.intra.peff.net> (raw)
In-Reply-To: <20191217014321.GF10734@google.com>
On Mon, Dec 16, 2019 at 05:43:21PM -0800, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > I actually wonder if the whole thing would be simpler if command-list.h
> > was a static tracked file with the declarations, and we generated
> > command-list.c with "extern const char *command_list[]", etc.
>
> Right, or a "command-list.inc" file.
>
> extern-ing it seems like the simplest way to go.
If only. I took a brief look at this. Besides the Makefile chaos (did
you know that the vcxproj rule manually builds and git-adds
command-list.h? No idea what is going on there), it looks like we
dynamically generate the category bitfield, which is then used directly
in help.c. We _could_ declare those bitfields as externs themselves, but
part of the point is that the full list of categories is generated
dynamically from command-list.txt.
So we'd either split the list into two (one list of categories special
enough to be manually declared, and the rest that get generated
automatically) or we'd end up just duplicating the whole list.
Certainly this could all be untangled, but given that the system is
working just fine as it is, it doesn't seem worth anybody's time (and
the risk of weird follow-on problems) to adjust it.
-Peff
next prev parent reply other threads:[~2019-12-17 5:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 23:25 [PATCH] Makefile: drop GEN_HDRS Junio C Hamano
2019-12-14 0:38 ` Jeff King
2019-12-14 1:00 ` Jeff King
2019-12-16 18:55 ` Junio C Hamano
2019-12-16 19:20 ` Jeff King
2019-12-17 1:27 ` Emily Shaffer
2019-12-17 1:40 ` Jonathan Nieder
2019-12-17 5:22 ` Jeff King
2019-12-17 1:43 ` Jonathan Nieder
2019-12-17 5:28 ` Jeff King [this message]
2019-12-17 11:35 ` vcxproj target, was " Johannes Schindelin
2019-12-19 4:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217052812.GB2762303@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.