From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 17 Dec 2019 07:52:04 -0500 Subject: [PATCH v3] board_f.c: Insure gd->new_bootstage alignment In-Reply-To: <611198b18f8e404d9c63a3ab2a1410dd@SFHDAG6NODE3.st.com> References: <20191127091138.29223-1-patrice.chotard@st.com> <611198b18f8e404d9c63a3ab2a1410dd@SFHDAG6NODE3.st.com> Message-ID: <20191217125204.GA12668@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 16, 2019 at 11:53:48AM +0000, Patrick DELAUNAY wrote: > Hi Tom, > > > From: Patrice CHOTARD > > Sent: mercredi 27 novembre 2019 10:12 > > > > In reserve_bootstage(), in case size is odd, gd->new_bootstage is not aligned. In > > bootstage_relocate(), the platform hangs when getting access to data- > > >record[i].name. > > To avoid this issue, make gd->new_bootstage 16 byte aligned. > > > > To insure that new_bootstage is 16 byte aligned (at least needed for > > x86_64 and ARMv8) and new_bootstage starts down to get enough space, > > ALIGN_DOWN macro is used. > > > > Fixes: ac9cd4805c8b ("bootstage: Correct relocation algorithm") > > > > Signed-off-by: Patrice Chotard > > Reviewed-by: Vikas MANOCHA > > Reviewed-by: Patrick Delaunay > > Tested-by: Patrick Delaunay > > > > Do you plan to merge this fixe for the next rc for v2020.01 ? > Or do you expect some change / review. > > This patch is mandatory for stm32mp1 (ARM plaform with bootstage > feature activated). > Without this patch, the boot failed (at least for v2020.01-rc3 : crash > has struct pointer new_bootstage is not aligned). > > Or I will deactivate the BOOTSTAGE feature... I think at this point I would prefer dropping BOOTSTAGE from those boards for the release. There's already been more than one "I think this is safe" followed by "this broke ..." changes I've tried. Sorry! -- Tom