All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status
@ 2019-12-18  3:42 ` Nathan Chancellor
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2019-12-18  3:42 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: alsa-devel, linux-kernel, clang-built-linux, Nathan Chancellor

Clang warns:

../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
        info->version = USX2Y_DRIVER_VERSION;
        ^
../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
        if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on this
line. Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

This was introduced before the beginning of git history so no fixes tag.

Link: https://github.com/ClangBuiltLinux/linux/issues/831
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 sound/usb/usx2y/usX2Yhwdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c
index d1caa8ed9e68..9985fc139487 100644
--- a/sound/usb/usx2y/usX2Yhwdep.c
+++ b/sound/usb/usx2y/usX2Yhwdep.c
@@ -119,7 +119,7 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw,
 	info->num_dsps = 2;		// 0: Prepad Data, 1: FPGA Code
 	if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
 		info->chip_ready = 1;
- 	info->version = USX2Y_DRIVER_VERSION; 
+	info->version = USX2Y_DRIVER_VERSION;
 	return 0;
 }
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [alsa-devel] [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status
@ 2019-12-18  3:42 ` Nathan Chancellor
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2019-12-18  3:42 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Nathan Chancellor, clang-built-linux, alsa-devel, linux-kernel

Clang warns:

../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
        info->version = USX2Y_DRIVER_VERSION;
        ^
../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
        if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on this
line. Remove it so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

This was introduced before the beginning of git history so no fixes tag.

Link: https://github.com/ClangBuiltLinux/linux/issues/831
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 sound/usb/usx2y/usX2Yhwdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c
index d1caa8ed9e68..9985fc139487 100644
--- a/sound/usb/usx2y/usX2Yhwdep.c
+++ b/sound/usb/usx2y/usX2Yhwdep.c
@@ -119,7 +119,7 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw,
 	info->num_dsps = 2;		// 0: Prepad Data, 1: FPGA Code
 	if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
 		info->chip_ready = 1;
- 	info->version = USX2Y_DRIVER_VERSION; 
+	info->version = USX2Y_DRIVER_VERSION;
 	return 0;
 }
 
-- 
2.24.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status
  2019-12-18  3:42 ` [alsa-devel] " Nathan Chancellor
@ 2019-12-18  6:33   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-12-18  6:33 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel,
	clang-built-linux

On Wed, 18 Dec 2019 04:42:57 +0100,
Nathan Chancellor wrote:
> 
> Clang warns:
> 
> ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
>         info->version = USX2Y_DRIVER_VERSION;
>         ^
> ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
>         if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
> 
> This was introduced before the beginning of git history so no fixes tag.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/831
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status
@ 2019-12-18  6:33   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2019-12-18  6:33 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: linux-kernel, alsa-devel, Takashi Iwai, clang-built-linux

On Wed, 18 Dec 2019 04:42:57 +0100,
Nathan Chancellor wrote:
> 
> Clang warns:
> 
> ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation;
> statement is not part of the previous 'if' [-Wmisleading-indentation]
>         info->version = USX2Y_DRIVER_VERSION;
>         ^
> ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here
>         if (us428->chip_status & USX2Y_STAT_CHIP_INIT)
>         ^
> 1 warning generated.
> 
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
> 
> This was introduced before the beginning of git history so no fixes tag.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/831
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied, thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-18  6:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18  3:42 [PATCH] ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status Nathan Chancellor
2019-12-18  3:42 ` [alsa-devel] " Nathan Chancellor
2019-12-18  6:33 ` Takashi Iwai
2019-12-18  6:33   ` [alsa-devel] " Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.