From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D437C43603 for ; Wed, 18 Dec 2019 15:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 303FA24676 for ; Wed, 18 Dec 2019 15:19:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d5oAz/Hn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfLRPTZ (ORCPT ); Wed, 18 Dec 2019 10:19:25 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:29857 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726913AbfLRPTY (ORCPT ); Wed, 18 Dec 2019 10:19:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576682364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AvN+er9tSk1nvAa51RyHfekLOaMRSKqcu33jfkq9kqU=; b=d5oAz/HnfqFMWm9tKs7hFDw3TC88MkZ0YeKCEFRGBs69MwVHHmbpGZR72vov4U2L+4fryS iqA1bGH16FqJ6tTzMDFsGlL235wEELP5GM/34iWCQLy1tCbDZWQyfpFQXMshgYHf+ZHadm Q9d5+adzGY0r3WuDKuvp5WzE+XUOpbg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-riyu79fQPeK--2ikhdPqxg-1; Wed, 18 Dec 2019 10:19:18 -0500 X-MC-Unique: riyu79fQPeK--2ikhdPqxg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B18E8C3DD4; Wed, 18 Dec 2019 15:19:16 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.44]) by smtp.corp.redhat.com (Postfix) with SMTP id 235705DDAA; Wed, 18 Dec 2019 15:19:08 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 18 Dec 2019 16:19:12 +0100 (CET) Date: Wed, 18 Dec 2019 16:19:04 +0100 From: Oleg Nesterov To: Andrew Morton Cc: Andy Lutomirski , Borislav Petkov , Ingo Molnar , Jan Kratochvil , Linus Torvalds , Pedro Alves , Peter Anvin , Thomas Gleixner , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 0/4] x86: fix get_nr_restart_syscall() Message-ID: <20191218151904.GA3127@redhat.com> References: <20191126110659.GA14042@redhat.com> <20191203141239.GA30688@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191203141239.GA30688@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy, Linus, do you have any objections? On 12/03, Oleg Nesterov wrote: > > This version follows the latest recommendation from Linus, > arch_set_restart_data() just saves ti->status in restart->arch_data. > > Andy, I can add another patch or change 4/4 to save the syscall number > instead, I am fine either way. > > However, personally I dislike restart->arch_data, imo 3/4 is all we need. > > I agree, set_restart_fn() is better than the ugly ERESTART_RESTARTBLOCK > check in syscall_return_slowpath() added by v1. But to me the x86-only > arch_data field in restart_block is much worse than the sticky TS_ flag. > > To remind, there is another reason for the "transient" 3/4, 4/4 is not > easily backportable. > > Oleg. > --- > arch/x86/include/asm/processor.h | 9 --------- > arch/x86/include/asm/thread_info.h | 15 ++++++++++++++- > arch/x86/kernel/signal.c | 24 +----------------------- > fs/select.c | 10 ++++------ > include/linux/restart_block.h | 1 + > include/linux/thread_info.h | 12 ++++++++++++ > kernel/futex.c | 3 +-- > kernel/time/alarmtimer.c | 2 +- > kernel/time/hrtimer.c | 2 +- > kernel/time/posix-cpu-timers.c | 2 +- > 10 files changed, 36 insertions(+), 44 deletions(-)