From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17A6C2D0D1 for ; Wed, 18 Dec 2019 16:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8BD720717 for ; Wed, 18 Dec 2019 16:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbfLRQnw (ORCPT ); Wed, 18 Dec 2019 11:43:52 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47287 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726955AbfLRQnv (ORCPT ); Wed, 18 Dec 2019 11:43:51 -0500 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D48C5C000E; Wed, 18 Dec 2019 16:43:48 +0000 (UTC) Date: Wed, 18 Dec 2019 17:43:48 +0100 From: Alexandre Belloni To: Eugen.Hristev@microchip.com Cc: jic23@kernel.org, robh+dt@kernel.org, Nicolas.Ferre@microchip.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, a.zummo@towertech.it, Ludovic.Desroches@microchip.com Subject: Re: [PATCH 04/10] rtc: at91rm9200: use of_platform_populate as return value Message-ID: <20191218164348.GN695889@piout.net> References: <1576686157-11939-1-git-send-email-eugen.hristev@microchip.com> <1576686157-11939-5-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1576686157-11939-5-git-send-email-eugen.hristev@microchip.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 18/12/2019 16:24:00+0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > This allows the RTC node to have child nodes in DT. > This allows subnodes to be probed. > > Signed-off-by: Eugen Hristev > --- > drivers/rtc/rtc-at91rm9200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > index 3b833e0..f1b5b3d 100644 > --- a/drivers/rtc/rtc-at91rm9200.c > +++ b/drivers/rtc/rtc-at91rm9200.c > @@ -421,7 +421,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) > at91_rtc_write_ier(AT91_RTC_SECEV); > > dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); > - return 0; > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > You can avoid the DT binding change and DT parsing by using platform_add_device here. I don't think there is any point describing the trigger as a child node (a watchdog functionality wouldn't be described for example). -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28426C43603 for ; Wed, 18 Dec 2019 16:44:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEB3A20717 for ; Wed, 18 Dec 2019 16:44:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e0DmOAGk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB3A20717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VlQmov6DjWm6/8DLUoFbsZ4fRUE8INRNDsYVJ12FJ3s=; b=e0DmOAGkZ5Ir46 iu3VkXoilMq0JZpm4drXH87JGRfQbNnGJWF3wjacpB+lFt7rK14LP3PK3PdQXo3fIVcB6sUKz4YnT uPzUMqyqa322wFEOaOIirYzmSvgfemCUuK6dmG8xmRcYmaBkd5mZsgeP9brUoULyCRkM9vWk+TetI 4cx487mntXEGvDTmzVA4WqccjmHZRJArHKkOjUUKHfdtUsWqHfB3VpkMgP/1ebAOO1Mx7fLeSMnXb iTQ/weF5AOMrQGm+hHN1PfQQjOEy2iWHHGX6EgBz04kgxUbp+Bfgv/4mor4nBhVNkopxOC8kCMav7 SNb5G9imefbf07hNIe8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihcQg-0006xn-HK; Wed, 18 Dec 2019 16:44:06 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihcQd-0006wD-2I for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 16:44:05 +0000 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D48C5C000E; Wed, 18 Dec 2019 16:43:48 +0000 (UTC) Date: Wed, 18 Dec 2019 17:43:48 +0100 From: Alexandre Belloni To: Eugen.Hristev@microchip.com Subject: Re: [PATCH 04/10] rtc: at91rm9200: use of_platform_populate as return value Message-ID: <20191218164348.GN695889@piout.net> References: <1576686157-11939-1-git-send-email-eugen.hristev@microchip.com> <1576686157-11939-5-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1576686157-11939-5-git-send-email-eugen.hristev@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191218_084403_240571_E93911CA X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, a.zummo@towertech.it, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 18/12/2019 16:24:00+0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > This allows the RTC node to have child nodes in DT. > This allows subnodes to be probed. > > Signed-off-by: Eugen Hristev > --- > drivers/rtc/rtc-at91rm9200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > index 3b833e0..f1b5b3d 100644 > --- a/drivers/rtc/rtc-at91rm9200.c > +++ b/drivers/rtc/rtc-at91rm9200.c > @@ -421,7 +421,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) > at91_rtc_write_ier(AT91_RTC_SECEV); > > dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); > - return 0; > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > You can avoid the DT binding change and DT parsing by using platform_add_device here. I don't think there is any point describing the trigger as a child node (a watchdog functionality wouldn't be described for example). -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel