From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18915C2D0BF for ; Wed, 18 Dec 2019 20:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E940924684 for ; Wed, 18 Dec 2019 20:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbfLRU7K (ORCPT ); Wed, 18 Dec 2019 15:59:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:39164 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfLRU7J (ORCPT ); Wed, 18 Dec 2019 15:59:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5AF62AD4A; Wed, 18 Dec 2019 20:59:08 +0000 (UTC) Date: Wed, 18 Dec 2019 21:59:05 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Dave Hansen Cc: Sandipan Das , shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org, linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org, linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, aneesh.kumar@linux.ibm.com, bauerman@linux.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v15 06/23] selftests/vm/pkeys: Typecast the pkey register Message-ID: <20191218205905.GG4113@kitsune.suse.cz> References: <719ec65756a64cc03e8464a9c6da51c4519d2389.1576645161.git.sandipan@linux.ibm.com> <5b6c3f8a-9d2f-2534-c072-89f130ce110f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b6c3f8a-9d2f-2534-c072-89f130ce110f@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Dec 18, 2019 at 12:46:50PM -0800, Dave Hansen wrote: > On 12/17/19 11:51 PM, Sandipan Das wrote: > > write_pkey_reg(pkey_reg); > > - dprintf4("pkey_reg now: %08x\n", read_pkey_reg()); > > + dprintf4("pkey_reg now: "PKEY_REG_FMT"\n", read_pkey_reg()); > > } > > > > #define ARRAY_SIZE(x) (sizeof(x) / sizeof(*(x))) > > diff --git a/tools/testing/selftests/vm/pkey-x86.h b/tools/testing/selftests/vm/pkey-x86.h > > index 2f04ade8ca9c..5f40901219d3 100644 > > --- a/tools/testing/selftests/vm/pkey-x86.h > > +++ b/tools/testing/selftests/vm/pkey-x86.h > > @@ -46,6 +46,8 @@ > > #define HPAGE_SIZE (1UL<<21) > > #define PAGE_SIZE 4096 > > #define MB (1<<20) > > +#define pkey_reg_t u32 > > +#define PKEY_REG_FMT "%016x" > > How big is the ppc one? u64 > > I'd really just rather do %016lx *everywhere* than sprinkle the > PKEY_REG_FMTs around. Does lx work with u32 without warnings? It's likely the size difference that requires a format specifier definition. > > BTW, why are you doing a %016lx for a u32? It's "%016x" without 'l' for x86 and with 'l' for ppc64. Thanks Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal =?iso-8859-1?Q?Such=E1nek?= Subject: Re: [PATCH v15 06/23] selftests/vm/pkeys: Typecast the pkey register Date: Wed, 18 Dec 2019 21:59:05 +0100 Message-ID: <20191218205905.GG4113@kitsune.suse.cz> References: <719ec65756a64cc03e8464a9c6da51c4519d2389.1576645161.git.sandipan@linux.ibm.com> <5b6c3f8a-9d2f-2534-c072-89f130ce110f@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5b6c3f8a-9d2f-2534-c072-89f130ce110f@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Dave Hansen Cc: linux-arch@vger.kernel.org, fweimer@redhat.com, aneesh.kumar@linux.ibm.com, x86@kernel.org, linuxram@us.ibm.com, shuahkh@osg.samsung.com, mhocko@kernel.org, linux-mm@kvack.org, mingo@redhat.com, Sandipan Das , linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com List-Id: linux-arch.vger.kernel.org On Wed, Dec 18, 2019 at 12:46:50PM -0800, Dave Hansen wrote: > On 12/17/19 11:51 PM, Sandipan Das wrote: > > write_pkey_reg(pkey_reg); > > - dprintf4("pkey_reg now: %08x\n", read_pkey_reg()); > > + dprintf4("pkey_reg now: "PKEY_REG_FMT"\n", read_pkey_reg()); > > } > > > > #define ARRAY_SIZE(x) (sizeof(x) / sizeof(*(x))) > > diff --git a/tools/testing/selftests/vm/pkey-x86.h b/tools/testing/selftests/vm/pkey-x86.h > > index 2f04ade8ca9c..5f40901219d3 100644 > > --- a/tools/testing/selftests/vm/pkey-x86.h > > +++ b/tools/testing/selftests/vm/pkey-x86.h > > @@ -46,6 +46,8 @@ > > #define HPAGE_SIZE (1UL<<21) > > #define PAGE_SIZE 4096 > > #define MB (1<<20) > > +#define pkey_reg_t u32 > > +#define PKEY_REG_FMT "%016x" > > How big is the ppc one? u64 > > I'd really just rather do %016lx *everywhere* than sprinkle the > PKEY_REG_FMTs around. Does lx work with u32 without warnings? It's likely the size difference that requires a format specifier definition. > > BTW, why are you doing a %016lx for a u32? It's "%016x" without 'l' for x86 and with 'l' for ppc64. Thanks Michal