From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCE3C3F68F for ; Thu, 19 Dec 2019 23:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75EE824676 for ; Thu, 19 Dec 2019 23:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576798294; bh=hF7FeZOLBAbbbuxHjCzaeZODUTMfWk4z9rlsOrwRQik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ata9sN+0RKiMDwT+FAa0jfMceF2/OgXBg85+C4IU5YenseUtBA/pNCUlOhyMUTB6Z pZXPHXc8VmWO3rw5VAxAezRGZUS0KzhnQslyOfT1P8BmXmdknNz/cErZ2NlFDAjQXJ OneVnD7uUjTfew34aEogOPsi7XV46qwUd9wckx90= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727191AbfLSXbd (ORCPT ); Thu, 19 Dec 2019 18:31:33 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:40302 "EHLO mail-ot1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbfLSXbd (ORCPT ); Thu, 19 Dec 2019 18:31:33 -0500 Received: by mail-ot1-f41.google.com with SMTP id w21so1557869otj.7; Thu, 19 Dec 2019 15:31:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cHN0yTmRtblTpyKmg4iRlUo8Qwlh54zEqesHcqtc4tw=; b=d+jLduKnzyv9knYWRuHHTI8kuyrwaRtTGAzk003ScdHmpph+m0EfL+OAilo7LrwZ/w ZyVvW0kqXeOoG7WqKWWbi4tBY/KDVpPDaaQX2MYATCNp754CVHtxKv4K4O4a2Vfvlw95 XDnRaufSupT1rKdqUyaXW1B2ZUTAAfNzva1D3vb6onhrI+Pprok6Kzo6pKsTX+5u9LZ9 eGUd0gnOYCqAHpM0jOffJ7Y2z897VF3putvc15Oo3EgZh+Pq4afvnG6lK46BEUNpWWg8 TWAJ6LL4E8CWje/6jXWqcgSKHzq+a9WKUqefl0eqGvHfzY6EPX/HKVvceHNPJm5gCJXo 4y1A== X-Gm-Message-State: APjAAAWOx8ClZHYGOPcUv9aPSTs0OMpZe7HcaZOll+RH8ghmZdZ8iMIy OV3Z511TbOSQIl/EA1Ab0Q== X-Google-Smtp-Source: APXvYqyjZvh03uk/NUEQwvqjY4ru5OS3ZB9R5H2+OfsQFZsDDFfjxfktkVMWSrQ5ILJVZfDTUO1a6Q== X-Received: by 2002:a9d:1e4:: with SMTP id e91mr5962233ote.324.1576798292085; Thu, 19 Dec 2019 15:31:32 -0800 (PST) Received: from localhost (ip-184-205-174-147.ftwttx.spcsdns.net. [184.205.174.147]) by smtp.gmail.com with ESMTPSA id n7sm2524611oij.14.2019.12.19.15.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 15:31:31 -0800 (PST) Date: Thu, 19 Dec 2019 17:31:29 -0600 From: Rob Herring To: "Lad, Prabhakar" Cc: Bjorn Helgaas , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , PCI , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Chris Paterson , Frank Rowand , Gustavo Pimentel , Jingoo Han , Simon Horman , Shawn Lin , Tom Joseph , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , "Lad, Prabhakar" Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges Message-ID: <20191219233129.GA5484@bogus> References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2019 at 08:49:23AM +0000, Lad, Prabhakar wrote: > Hi Rob, > > Thank you for the review. > > On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > > wrote: > > > > > > From: "Lad, Prabhakar" > > > > > > this patch adds support to parse PCI outbound-ranges, the > > > outbound-regions are similar to pci ranges except it doesn't > > > have pci address, below is the format for bar-ranges: > > > > > > outbound-ranges = > > upper32_size lower32_size>; > > > > You can't just make up a new ranges property. Especially one that > > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > > translate device to memory addresses. > > > > Explain the problem or feature you need, not the solution you came up > > with. Why do you need this and other endpoint bindings haven't? > > > rcar SoC's supports multiple outbound region for mapping the PCI address > locally to the system. This lead to discussion where there exist controllers > which support regions for high/low priority transfer and similarly regions > for large/small memory allocations, as a result a new ranges property was > added, where we can specify the flags which would indicate how the outbound > region can be used during requests. What are the flags? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges Date: Thu, 19 Dec 2019 17:31:29 -0600 Message-ID: <20191219233129.GA5484@bogus> References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Lad, Prabhakar" Cc: Bjorn Helgaas , Mark Rutland , Geert Uytterhoeven , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , PCI , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , moderated list:ARM/FREESCALE IMX / List-Id: linux-rockchip.vger.kernel.org On Mon, Dec 16, 2019 at 08:49:23AM +0000, Lad, Prabhakar wrote: > Hi Rob, > > Thank you for the review. > > On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > > wrote: > > > > > > From: "Lad, Prabhakar" > > > > > > this patch adds support to parse PCI outbound-ranges, the > > > outbound-regions are similar to pci ranges except it doesn't > > > have pci address, below is the format for bar-ranges: > > > > > > outbound-ranges = > > upper32_size lower32_size>; > > > > You can't just make up a new ranges property. Especially one that > > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > > translate device to memory addresses. > > > > Explain the problem or feature you need, not the solution you came up > > with. Why do you need this and other endpoint bindings haven't? > > > rcar SoC's supports multiple outbound region for mapping the PCI address > locally to the system. This lead to discussion where there exist controllers > which support regions for high/low priority transfer and similarly regions > for large/small memory allocations, as a result a new ranges property was > added, where we can specify the flags which would indicate how the outbound > region can be used during requests. What are the flags? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA41C47409 for ; Thu, 19 Dec 2019 23:31:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBF442467E for ; Thu, 19 Dec 2019 23:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pGdWPkfB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBF442467E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ibg8/5swEN7saFvjqcF1oSFkzpstrQogF4W4Yjozdy0=; b=pGdWPkfBu9U8dn jhUOrT63MZ+W/44106rqcs1h5bzMNI/z4sc+VxTNUuVKuqoKD36/QjCw1ntV95qoIfGdi3GtfYpbf PmtgsY+MKfHEYO30iwkfD71IuWRsPqJ2s+nS+FactYvnztFkSpEB7/B3+q/xPna7bqOlfFsdd5lF5 CTAPEI0HBhcgBAPE7gNdSZOXPxZjeN40y7fd1+1Gs5LHSHGI/+EQkOcL5l+2DIDkTbNJo7NHesMUF nm1kbl74EVpRsVZDrG1ADOmtPn7uWvXfdIGE51DnKdltoFe80oXhE4nEsh3QvzQq7txFgQJirCLDm SuXIalj2ZwioeYZIvfqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii5Gb-0004xX-4m; Thu, 19 Dec 2019 23:31:37 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii5GX-0004wn-EF; Thu, 19 Dec 2019 23:31:35 +0000 Received: by mail-ot1-f44.google.com with SMTP id 59so9295273otp.12; Thu, 19 Dec 2019 15:31:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cHN0yTmRtblTpyKmg4iRlUo8Qwlh54zEqesHcqtc4tw=; b=Awm6U31MoSXzoUS+Rac0SxEkV3KBOEciKBwjT91HLngnnhz07akQzJWJI6pj4vJvbd Nv9jdJ7pWea7mrTSwMzNYZhmRVRO8DUnU6n9AmnEO7qwAE1/rjX73vkr4vZCeXfgP23e 4r1SAKcr1kQpo5kGF+9sJVXAtxQjwaWDAAZshiTqzi0nN90YFGKvxjtiuL2GwBJPaAjL yGE+earbXMlXrCOYh+pTqaTBY/emt+2wHQAM9QomAOUMqXkDABcZW34NlmStGyy0nDdi SkjlBBM+RjYeLlytXn0AxLu3T1dHzos55sYvX9nHxskg1NPa6ukam5H3d6R8XR/1LuX6 dUwg== X-Gm-Message-State: APjAAAXIOHzI1HcKi4b11jOmXm9GkO3h0lM44fmYki+N/CXkMybnuFtq Ljza1yfiDIRsW5hROhw9OA== X-Google-Smtp-Source: APXvYqyjZvh03uk/NUEQwvqjY4ru5OS3ZB9R5H2+OfsQFZsDDFfjxfktkVMWSrQ5ILJVZfDTUO1a6Q== X-Received: by 2002:a9d:1e4:: with SMTP id e91mr5962233ote.324.1576798292085; Thu, 19 Dec 2019 15:31:32 -0800 (PST) Received: from localhost (ip-184-205-174-147.ftwttx.spcsdns.net. [184.205.174.147]) by smtp.gmail.com with ESMTPSA id n7sm2524611oij.14.2019.12.19.15.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 15:31:31 -0800 (PST) Date: Thu, 19 Dec 2019 17:31:29 -0600 From: Rob Herring To: "Lad, Prabhakar" Subject: Re: [v2 3/6] of: address: add support to parse PCI outbound-ranges Message-ID: <20191219233129.GA5484@bogus> References: <20191213084748.11210-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191213084748.11210-4-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191219_153133_478117_48C45D60 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Heiko Stuebner , Geert Uytterhoeven , PCI , Shawn Lin , Frank Rowand , Marek Vasut , Lorenzo Pieralisi , Will Deacon , Magnus Damm , Kishon Vijay Abraham I , "open list:ARM/Rockchip SoC..." , Catalin Marinas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Arnd Bergmann , "Lad, Prabhakar" , Simon Horman , Bjorn Helgaas , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Greg Kroah-Hartman , Yoshihiro Shimoda , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Tom Joseph , Jingoo Han , Andrew Murray , Gustavo Pimentel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 16, 2019 at 08:49:23AM +0000, Lad, Prabhakar wrote: > Hi Rob, > > Thank you for the review. > > On Fri, Dec 13, 2019 at 8:37 PM Rob Herring wrote: > > > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > > wrote: > > > > > > From: "Lad, Prabhakar" > > > > > > this patch adds support to parse PCI outbound-ranges, the > > > outbound-regions are similar to pci ranges except it doesn't > > > have pci address, below is the format for bar-ranges: > > > > > > outbound-ranges = > > upper32_size lower32_size>; > > > > You can't just make up a new ranges property. Especially one that > > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > > translate device to memory addresses. > > > > Explain the problem or feature you need, not the solution you came up > > with. Why do you need this and other endpoint bindings haven't? > > > rcar SoC's supports multiple outbound region for mapping the PCI address > locally to the system. This lead to discussion where there exist controllers > which support regions for high/low priority transfer and similarly regions > for large/small memory allocations, as a result a new ranges property was > added, where we can specify the flags which would indicate how the outbound > region can be used during requests. What are the flags? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel