From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6402C43603 for ; Fri, 20 Dec 2019 22:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BD78206DA for ; Fri, 20 Dec 2019 22:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727517AbfLTWOP (ORCPT ); Fri, 20 Dec 2019 17:14:15 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:54296 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbfLTWOP (ORCPT ); Fri, 20 Dec 2019 17:14:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6DCA91504494F; Fri, 20 Dec 2019 14:14:14 -0800 (PST) Date: Fri, 20 Dec 2019 14:14:11 -0800 (PST) Message-Id: <20191220.141411.1525508525740394923.davem@davemloft.net> To: rahul.lakkireddy@chelsio.com Cc: netdev@vger.kernel.org, nirranjan@chelsio.com, vishal@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net v2] cxgb4: fix refcount init for TC-MQPRIO offload From: David Miller In-Reply-To: <1576640969-15807-1-git-send-email-rahul.lakkireddy@chelsio.com> References: <1576640969-15807-1-git-send-email-rahul.lakkireddy@chelsio.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Dec 2019 14:14:14 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rahul Lakkireddy Date: Wed, 18 Dec 2019 09:19:29 +0530 > Properly initialize refcount to 1 when hardware queue arrays for > TC-MQPRIO offload have been freshly allocated. Otherwise, following > warning is observed. Also fix up error path to only free hardware > queue arrays when refcount reaches 0. ... > v2: > - Move the refcount_set() closer to where the hardware queue arrays > are being allocated. > - Fix up error path to only free hardware queue arrays when refcount > reaches 0. > > Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support") > Signed-off-by: Rahul Lakkireddy Applied, thank you.