From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FC6C3F68F for ; Fri, 20 Dec 2019 03:22:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13EF124687 for ; Fri, 20 Dec 2019 03:22:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eiD5P2Vs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727174AbfLTDWy (ORCPT ); Thu, 19 Dec 2019 22:22:54 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:43036 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbfLTDWy (ORCPT ); Thu, 19 Dec 2019 22:22:54 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3794E97D; Fri, 20 Dec 2019 04:22:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576812171; bh=GbjWOXoHbTc7o/70pzRDyb6harPQRgq/1uJqetbyvEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eiD5P2Vs/QXwTU749YgX3ffncRsvHu/csSN90zm5CA5+AlOF58zlIMNsA70unsJOI eTeBk6rzNvZ3sY8nTxruTgXtU/2o65/rPpx0hz333tRbfP07RPFYLk3YE47zhV77oV Maus3i0cm/+PvRN9WVjB48J3KzFdIMLu27tzAQBE= Date: Fri, 20 Dec 2019 05:22:38 +0200 From: Laurent Pinchart To: Hsin-Yi Wang Cc: Rob Herring , dri-devel , David Airlie , Daniel Vetter , Mark Rutland , Nicolas Boichat , Devicetree List , lkml , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Philipp Zabel , Enric Balletbo i Serra , Matthias Brugger , Russell King Subject: Re: [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding Message-ID: <20191220032238.GA5342@pendragon.ideasonboard.com> References: <20191211061911.238393-1-hsinyi@chromium.org> <20191211061911.238393-2-hsinyi@chromium.org> <20191219204524.GA7841@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hsin-Yi, On Fri, Dec 20, 2019 at 11:20:13AM +0800, Hsin-Yi Wang wrote: > On Fri, Dec 20, 2019 at 4:45 AM Rob Herring wrote: > > On Wed, Dec 11, 2019 at 02:19:08PM +0800, Hsin-Yi Wang wrote: > > > From: Nicolas Boichat > > > > > > Add support for analogix,anx7688 > > > > > > Signed-off-by: Nicolas Boichat > > > Signed-off-by: Hsin-Yi Wang > > > --- > > > Change from RFC to v1: > > > - txt to yaml > > > --- > > > .../bindings/display/bridge/anx7688.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.yaml b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > new file mode 100644 > > > index 000000000000..cf79f7cf8fdf > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/anx7688.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analogix ANX7688 SlimPort (Single-Chip Transmitter for DP over USB-C) > > > + > > > +maintainers: > > > + - Nicolas Boichat > > > + > > > +description: | > > > + The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per > > > + second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video > > > + resolution from a smartphone or tablet with full function USB-C. > > > + > > > + This binding only describes the HDMI to DP display bridge. > > > + > > > +properties: > > > + compatible: > > > + const: analogix,anx7688 > > > + > > > + reg: > > > + maxItems: 1 > > > + description: I2C address of the device > > > + > > > + ports: > > > + type: object > > > + > > > + properties: > > > + port@0: > > > + type: object > > > + description: | > > > + Video port for HDMI input > > > + > > > + port@1: > > > + type: object > > > + description: | > > > + Video port for eDP output > > > + > > > + required: > > > + - port@0 > > > > Sometimes you have no output? > > Yes, only input is required. But what happens in that case ? What's the use of a bridge with a non-connected output ? :-) > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - ports > > > > The example will have errors because it is missing 'ports'. Run 'make > > dt_binding_check'. > > > > Add: > > > > additionalProperties: false > > > > Ack, will fix this. Thanks > > > > + > > > +examples: > > > + - | > > > + anx7688: anx7688@2c { > > > + compatible = "analogix,anx7688"; > > > + reg = <0x2c>; > > > + > > > + port { > > > + anx7688_in: endpoint { > > > + remote-endpoint = <&hdmi0_out>; > > > + }; > > > + }; > > > + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7846BC2D0D1 for ; Fri, 20 Dec 2019 03:22:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E84A2465E for ; Fri, 20 Dec 2019 03:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eiD5P2Vs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E84A2465E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C00F6EBC7; Fri, 20 Dec 2019 03:22:55 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C7B46EBC7 for ; Fri, 20 Dec 2019 03:22:53 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3794E97D; Fri, 20 Dec 2019 04:22:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576812171; bh=GbjWOXoHbTc7o/70pzRDyb6harPQRgq/1uJqetbyvEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eiD5P2Vs/QXwTU749YgX3ffncRsvHu/csSN90zm5CA5+AlOF58zlIMNsA70unsJOI eTeBk6rzNvZ3sY8nTxruTgXtU/2o65/rPpx0hz333tRbfP07RPFYLk3YE47zhV77oV Maus3i0cm/+PvRN9WVjB48J3KzFdIMLu27tzAQBE= Date: Fri, 20 Dec 2019 05:22:38 +0200 From: Laurent Pinchart To: Hsin-Yi Wang Subject: Re: [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding Message-ID: <20191220032238.GA5342@pendragon.ideasonboard.com> References: <20191211061911.238393-1-hsinyi@chromium.org> <20191211061911.238393-2-hsinyi@chromium.org> <20191219204524.GA7841@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jernej Skrabec , Nicolas Boichat , Devicetree List , David Airlie , Neil Armstrong , lkml , dri-devel , Jonas Karlman , Matthias Brugger , Enric Balletbo i Serra , Russell King Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Hsin-Yi, On Fri, Dec 20, 2019 at 11:20:13AM +0800, Hsin-Yi Wang wrote: > On Fri, Dec 20, 2019 at 4:45 AM Rob Herring wrote: > > On Wed, Dec 11, 2019 at 02:19:08PM +0800, Hsin-Yi Wang wrote: > > > From: Nicolas Boichat > > > > > > Add support for analogix,anx7688 > > > > > > Signed-off-by: Nicolas Boichat > > > Signed-off-by: Hsin-Yi Wang > > > --- > > > Change from RFC to v1: > > > - txt to yaml > > > --- > > > .../bindings/display/bridge/anx7688.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.yaml b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > new file mode 100644 > > > index 000000000000..cf79f7cf8fdf > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/anx7688.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analogix ANX7688 SlimPort (Single-Chip Transmitter for DP over USB-C) > > > + > > > +maintainers: > > > + - Nicolas Boichat > > > + > > > +description: | > > > + The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per > > > + second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video > > > + resolution from a smartphone or tablet with full function USB-C. > > > + > > > + This binding only describes the HDMI to DP display bridge. > > > + > > > +properties: > > > + compatible: > > > + const: analogix,anx7688 > > > + > > > + reg: > > > + maxItems: 1 > > > + description: I2C address of the device > > > + > > > + ports: > > > + type: object > > > + > > > + properties: > > > + port@0: > > > + type: object > > > + description: | > > > + Video port for HDMI input > > > + > > > + port@1: > > > + type: object > > > + description: | > > > + Video port for eDP output > > > + > > > + required: > > > + - port@0 > > > > Sometimes you have no output? > > Yes, only input is required. But what happens in that case ? What's the use of a bridge with a non-connected output ? :-) > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - ports > > > > The example will have errors because it is missing 'ports'. Run 'make > > dt_binding_check'. > > > > Add: > > > > additionalProperties: false > > > > Ack, will fix this. Thanks > > > > + > > > +examples: > > > + - | > > > + anx7688: anx7688@2c { > > > + compatible = "analogix,anx7688"; > > > + reg = <0x2c>; > > > + > > > + port { > > > + anx7688_in: endpoint { > > > + remote-endpoint = <&hdmi0_out>; > > > + }; > > > + }; > > > + }; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel