From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7091C43603 for ; Fri, 20 Dec 2019 19:44:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44003206D8 for ; Fri, 20 Dec 2019 19:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rjoI/6PK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44003206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADEB58E01D0; Fri, 20 Dec 2019 14:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F558E019D; Fri, 20 Dec 2019 14:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956B68E01D0; Fri, 20 Dec 2019 14:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 7BC118E019D for ; Fri, 20 Dec 2019 14:44:26 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 3067B82499A8 for ; Fri, 20 Dec 2019 19:44:26 +0000 (UTC) X-FDA: 76286546532.27.brake14_98e2181f042f X-HE-Tag: brake14_98e2181f042f X-Filterd-Recvd-Size: 7275 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Dec 2019 19:44:25 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id az3so4524017plb.11 for ; Fri, 20 Dec 2019 11:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M1TFnPZNzHdVX9ENC27TelQk6pT+qMfbIuQbQz0lyOc=; b=rjoI/6PKIVBnCKWtBYRQAQh7ToaVP+sbDdXbPx6QvstTJvadMvCkfzX94jkQr9jDO6 4vj3y6YKWDpRNCCK3llsX0KHwUcNeulZtcoGZwVLMNE539PC4PfV4ClG4CASQOWu4HEE kz9sBdcJ1pYUADwcMTu1ciIcC0IDcNzr38GoEh8Sjj3aiwMZhhcWhNBmL1fJpgduIA9y xvNxZAoF8kzYCFWcS7wdWJeCysRBaT4EK9uAIr3IkwUzaWETIC13HLwv1ifmhQaLsF2a 0yhBpS+O8Jwkr51i2RZJL6EGWhl3urW4O5AR2bCVZdlgIczPu9gcmmDSCv9YvUSEd4Tx Sh5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M1TFnPZNzHdVX9ENC27TelQk6pT+qMfbIuQbQz0lyOc=; b=UQW1Ube/edGjTTOEb1+fpODM0Pps1G3/cKXvGeAn8KTHXbxLIPOGVh5F4gKvObivak C6nizazSCFFcOmE8/W1UO9mvDGw+eXvJz02xjRJNlUQ0VXAPUQ992DzPr4GAjBG/gYBJ rsLwJ+M/RBfFJdCZxAECibmbvMdwBDH2ijbAR5EYA5wXgBk20HVyBq6x2jdWedokhneW pEDhdYsf3iynflzpWoxhC9KIdXaUgxwREajfKopIULq5PABvR0FJgCpqqliV6Pecruxj dVy3FeH8g2XRe8NKHLpmCxH3of9jvjPp98L+yagd3EfZdvVo1Q3xs/qGFDJD3eIX31gx WtJg== X-Gm-Message-State: APjAAAUtXBC8neqDNt2lV/oygke8JpJMRz2mRCqKrri6wVAVPyGqlh+p KQaikAq+6AKl+oiKsZftrH6jhg== X-Google-Smtp-Source: APXvYqyNeYhRt8xxUpUltEjnOGJZ0/shWt9X/HjFnRvglnLexrw60cKfXZtI6Xl1J/zhy5QHuFM7uQ== X-Received: by 2002:a17:902:b709:: with SMTP id d9mr17177125pls.235.1576871064216; Fri, 20 Dec 2019 11:44:24 -0800 (PST) Received: from google.com ([2620:15c:201:2:765b:31cb:30c4:166]) by smtp.gmail.com with ESMTPSA id z6sm922466pfa.155.2019.12.20.11.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2019 11:44:23 -0800 (PST) Date: Fri, 20 Dec 2019 11:44:18 -0800 From: Eric Biggers To: glider@google.com Cc: Herbert Xu , "David S. Miller" , Vegard Nossum , Dmitry Vyukov , Marco Elver , Andrey Konovalov , linux-mm@kvack.org, viro@zeniv.linux.org.uk, adilger.kernel@dilger.ca, akpm@linux-foundation.org, aryabinin@virtuozzo.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, hch@infradead.org, hch@lst.de, darrick.wong@oracle.com, dmitry.torokhov@gmail.com, edumazet@google.com, ericvh@gmail.com, gregkh@linuxfoundation.org, harry.wentland@amd.com, iii@linux.ibm.com, mingo@elte.hu, jasowang@redhat.com, axboe@kernel.dk, m.szyprowski@samsung.com, mark.rutland@arm.com, martin.petersen@oracle.com, schwidefsky@de.ibm.com, willy@infradead.org, mst@redhat.com, mhocko@suse.com, monstr@monstr.eu, pmladek@suse.com, cai@lca.pw, rdunlap@infradead.org, robin.murphy@arm.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, tiwai@suse.com, tytso@mit.edu, tglx@linutronix.de, gor@linux.ibm.com, wsa@the-dreams.de Subject: Re: [PATCH RFC v4 17/42] crypto: kmsan: disable accelerated configs under KMSAN Message-ID: <20191220194418.GB11160@google.com> References: <20191220184955.223741-1-glider@google.com> <20191220184955.223741-18-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191220184955.223741-18-glider@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 20, 2019 at 07:49:30PM +0100, glider@google.com wrote: > KMSAN is unable to understand when initialized values come from assembly. > Disable accelerated configs in KMSAN builds to prevent false positive > reports. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org > > --- > > v4: > - shorten comments as requested by Marco Elver > > Change-Id: Iddc71a2a27360e036d719c0940ebf15553cf8de8 > --- > crypto/Kconfig | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 5575d48473bd..9c8074ed0f27 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -321,11 +321,13 @@ config CRYPTO_AEGIS128_SIMD > bool "Support SIMD acceleration for AEGIS-128" > depends on CRYPTO_AEGIS128 && ((ARM || ARM64) && KERNEL_MODE_NEON) > depends on !ARM || CC_IS_CLANG || GCC_VERSION >= 40800 > + depends on !KMSAN # avoid false positives from assembly > default y > > config CRYPTO_AEGIS128_AESNI_SSE2 > tristate "AEGIS-128 AEAD algorithm (x86_64 AESNI+SSE2 implementation)" > depends on X86 && 64BIT > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_AEAD > select CRYPTO_SIMD > help > @@ -583,6 +585,7 @@ config CRYPTO_CRC32C > config CRYPTO_CRC32C_INTEL > tristate "CRC32c INTEL hardware acceleration" > depends on X86 > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > help > In Intel processor with SSE4.2 supported, the processor will > @@ -623,6 +626,7 @@ config CRYPTO_CRC32 > config CRYPTO_CRC32_PCLMUL > tristate "CRC32 PCLMULQDQ hardware acceleration" > depends on X86 > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > select CRC32 > help > @@ -702,6 +706,7 @@ config CRYPTO_CRCT10DIF > config CRYPTO_CRCT10DIF_PCLMUL > tristate "CRCT10DIF PCLMULQDQ hardware acceleration" > depends on X86 && 64BIT && CRC_T10DIF > + depends on !KMSAN # avoid false positives from assembly > select CRYPTO_HASH > help > For x86_64 processors with SSE4.2 and PCLMULQDQ supported, > @@ -751,6 +756,7 @@ config CRYPTO_POLY1305_X86_64 > depends on X86 && 64BIT > select CRYPTO_LIB_POLY1305_GENERIC > select CRYPTO_ARCH_HAVE_LIB_POLY1305 > + depends on !KMSAN # avoid false positives from assembly > help > Poly1305 authenticator algorithm, RFC7539. Many of these 'depends on !KMSAN' lines are mixed in among 'select' lines. They should go immediately after any existing 'depends on' lines. E.g. depends on X86 && 64BIT + depends on !KMSAN # avoid false positives from assembly select CRYPTO_LIB_POLY1305_GENERIC select CRYPTO_ARCH_HAVE_LIB_POLY1305 Also, there are some options that were missed: CRYPTO_CURVE25519_X86 CRYPTO_NHPOLY1305_SSE2 CRYPTO_NHPOLY1305_AVX2 CRYPTO_BLAKE2S_X86 - Eric