From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADAA3C2D0C0 for ; Mon, 23 Dec 2019 16:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F08E2073A for ; Mon, 23 Dec 2019 16:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbfLWQki (ORCPT ); Mon, 23 Dec 2019 11:40:38 -0500 Received: from saturn.retrosnub.co.uk ([46.235.226.198]:34676 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbfLWQkg (ORCPT ); Mon, 23 Dec 2019 11:40:36 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 149DC9E73DD; Mon, 23 Dec 2019 16:40:34 +0000 (GMT) Date: Mon, 23 Dec 2019 16:40:32 +0000 From: Jonathan Cameron To: Tomasz Duszynski Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency Message-ID: <20191223164032.78498e6b@archlinux> In-Reply-To: <20191213213808.124603-1-tduszyns@gmail.com> References: <20191213213808.124603-1-tduszyns@gmail.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Dec 2019 22:38:08 +0100 Tomasz Duszynski wrote: > IIO triggered buffer depends on IIO buffer which is missing from Kconfig > file. This should go unnoticed most of the time because there's a > chance something else has already enabled buffers. In some rare cases > though one might experience kbuild warnings about unmet direct > dependencies and build failures due to missing symbols. > > Fix this by selecting IIO_BUFFER explicitly. > > Signed-off-by: Tomasz Duszynski Applied to the fixes-togreg branch of iio.git. Marked for stable and with the addition of a fixes tag. Thanks, Jonathan > --- > drivers/iio/chemical/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig > index fa4586037bb8..0b91de4df8f4 100644 > --- a/drivers/iio/chemical/Kconfig > +++ b/drivers/iio/chemical/Kconfig > @@ -65,6 +65,7 @@ config IAQCORE > config PMS7003 > tristate "Plantower PMS7003 particulate matter sensor" > depends on SERIAL_DEV_BUS > + select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > Say Y here to build support for the Plantower PMS7003 particulate