All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 05/10] drm/i915: prefer 3-letter acronym for cannonlake
Date: Mon, 23 Dec 2019 15:04:06 -0800	[thread overview]
Message-ID: <20191223230406.GN2877816@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20191223173244.30742-6-lucas.demarchi@intel.com>

On Mon, Dec 23, 2019 at 09:32:39AM -0800, Lucas De Marchi wrote:
> We are currently using a mix of platform name and acronym to name the
> functions. Let's prefer the acronym as it should be clear what platform
> it's about and it's shorter, so it doesn't go over 80 columns in a few
> cases. This converts cannonlake to cnl where appropriate.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Acked-by: Jani Nikula <jani.nikula@linux.intel.com>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 18ac15df91c7..98d6bcb4c761 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10440,9 +10440,8 @@ static int hsw_crtc_compute_clock(struct intel_crtc *crtc,
>  	return 0;
>  }
>  
> -static void cannonlake_get_ddi_pll(struct drm_i915_private *dev_priv,
> -				   enum port port,
> -				   struct intel_crtc_state *pipe_config)
> +static void cnl_get_ddi_pll(struct drm_i915_private *dev_priv, enum port port,
> +			    struct intel_crtc_state *pipe_config)
>  {
>  	enum intel_dpll_id id;
>  	u32 temp;
> @@ -10744,7 +10743,7 @@ static void hsw_get_ddi_port_state(struct intel_crtc *crtc,
>  	if (INTEL_GEN(dev_priv) >= 11)
>  		icelake_get_ddi_pll(dev_priv, port, pipe_config);
>  	else if (IS_CANNONLAKE(dev_priv))
> -		cannonlake_get_ddi_pll(dev_priv, port, pipe_config);
> +		cnl_get_ddi_pll(dev_priv, port, pipe_config);
>  	else if (IS_GEN9_BC(dev_priv))
>  		skl_get_ddi_pll(dev_priv, port, pipe_config);
>  	else if (IS_GEN9_LP(dev_priv))
> -- 
> 2.24.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-12-23 23:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23 17:32 [Intel-gfx] [PATCH v3 00/10] Prefer acronym for prefixes Lucas De Marchi
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 01/10] drm/i915: simplify prefixes on device_info Lucas De Marchi
2019-12-23 22:56   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 02/10] drm/i915: prefer 3-letter acronym for pineview Lucas De Marchi
2019-12-23 22:58   ` Matt Roper
2019-12-23 23:20     ` Lucas De Marchi
2019-12-23 23:23       ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 03/10] drm/i915: prefer 3-letter acronym for haswell Lucas De Marchi
2019-12-23 23:00   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 04/10] drm/i915: prefer 3-letter acronym for skylake Lucas De Marchi
2019-12-23 23:01   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 05/10] drm/i915: prefer 3-letter acronym for cannonlake Lucas De Marchi
2019-12-23 23:04   ` Matt Roper [this message]
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 06/10] drm/i915: prefer 3-letter acronym for icelake Lucas De Marchi
2019-12-23 23:08   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 07/10] drm/i915: prefer 3-letter acronym for ironlake Lucas De Marchi
2019-12-23 23:13   ` Matt Roper
2019-12-23 23:22     ` Lucas De Marchi
2019-12-23 23:23       ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 08/10] drm/i915: prefer 3-letter acronym for broadwell Lucas De Marchi
2019-12-23 23:15   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 09/10] drm/i915: prefer 3-letter acronym for ivybridge Lucas De Marchi
2019-12-23 23:16   ` Matt Roper
2019-12-23 17:32 ` [Intel-gfx] [PATCH v3 10/10] drm/i915: prefer 3-letter acronym for tigerlake Lucas De Marchi
2019-12-23 23:17   ` Matt Roper
2019-12-23 19:34 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Prefer acronym for prefixes (rev2) Patchwork
2019-12-23 20:05   ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191223230406.GN2877816@mdroper-desk1.amr.corp.intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.