From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A6DC2D0C0 for ; Tue, 24 Dec 2019 02:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B89FA20643 for ; Tue, 24 Dec 2019 02:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="qPNE7180" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfLXCQL (ORCPT ); Mon, 23 Dec 2019 21:16:11 -0500 Received: from mx.treblig.org ([46.43.15.161]:56642 "EHLO mx.treblig.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726871AbfLXCQL (ORCPT ); Mon, 23 Dec 2019 21:16:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=NzLEtdjTlqXj90V+kD13i4bSksLoslg1n6l/UDFh4MU=; b=qPNE7180sVKGTayax6cRn2LwKh y38ESFKoEzN+71KQgGgRY7786zdHIvd2naGyB95unWc2PrSazhecy8/EVIT4/urOPITGQ/Ealopeo i8Q7EwItSVYtPPh7wZSuvxIdHgLyixtdgJYlgbSz/gQi0b6lAHdDrS4wqo5OA5u6xHgy/tO1KNj6E PfQZ5mvTDtoqH5K1mS1GJfYkus2IGEwVklxH0UooMyM5X3zsDuiLTw5Rywnsli6HQxf5ElsJbSWX/ DpzwuCQ4FKcMGFRva4QyhmIuADEl/O3GQXClgqT8e+iUdC1bWN7XM6vnNcLch580NLw1e5htZnkLw LDB+z+Tw==; Received: from dg by mx.treblig.org with local (Exim 4.92) (envelope-from ) id 1ijZjx-00051K-CI; Tue, 24 Dec 2019 02:16:05 +0000 Date: Tue, 24 Dec 2019 02:16:05 +0000 From: "Dr. David Alan Gilbert" To: Guenter Roeck Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: Re: [PATCH 2/2] hwmon: (w83627ehf) convert to with_info interface Message-ID: <20191224021605.GA19223@gallifrey> References: <20191124202030.45360-1-linux@treblig.org> <20191124202030.45360-3-linux@treblig.org> <20191207135127.GA24852@roeck-us.net> <20191207164936.GA25521@gallifrey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191207164936.GA25521@gallifrey> X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/4.19.0-5-amd64 (x86_64) X-Uptime: 02:15:29 up 114 days, 2:36, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org * Dr. David Alan Gilbert (linux@treblig.org) wrote: > * Guenter Roeck (linux@roeck-us.net) wrote: > > On Sun, Nov 24, 2019 at 08:20:30PM +0000, Dr. David Alan Gilbert wrote: > > > Convert the old hwmon_device_register code to > > > devm_hwmon_device_register_with_info. > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > > Looks good. I am sure I am missing something, given the size of the patch, > > Thanks! I couldn't see an obvious way to split it and keep it working > bisectably. > > > but I am going to apply this to hwmon-next. > > Great. > > > Side note: At some point we should drop support for nct6775 and nct6776 > > from this driver. > > Hehe it would have probably easier to do that first! Oh well, > I've added it to a TODO, that means nothing about if/when I'll actually > get around to it! I've started looking at this. Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/