From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E482C2D0CF for ; Tue, 24 Dec 2019 10:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE24A20409 for ; Tue, 24 Dec 2019 10:29:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbfLXK3x (ORCPT ); Tue, 24 Dec 2019 05:29:53 -0500 Received: from foss.arm.com ([217.140.110.172]:50936 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbfLXK3x (ORCPT ); Tue, 24 Dec 2019 05:29:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93FCF31B; Tue, 24 Dec 2019 02:29:52 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C4773F6CF; Tue, 24 Dec 2019 02:29:51 -0800 (PST) Date: Tue, 24 Dec 2019 10:29:50 +0000 From: Andrew Murray To: Marc Zyngier Cc: will@kernel.org, Catalin Marinas , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/18] arm64: KVM: reset E2PB correctly in MDCR_EL2 when exiting the guest(VHE) Message-ID: <20191224102949.GD42593@e119886-lin.cambridge.arm.com> References: <20191220143025.33853-1-andrew.murray@arm.com> <20191220143025.33853-3-andrew.murray@arm.com> <20191221131214.769a140e@why> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191221131214.769a140e@why> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 21, 2019 at 01:12:14PM +0000, Marc Zyngier wrote: > On Fri, 20 Dec 2019 14:30:09 +0000 > Andrew Murray wrote: > > > From: Sudeep Holla > > > > On VHE systems, the reset value for MDCR_EL2.E2PB=b00 which defaults > > to profiling buffer using the EL2 stage 1 translations. > > Does the reset value actually matter here? I don't see it being > specific to VHE systems, and all we're trying to achieve is to restore > the SPE configuration to a state where it can be used by the host. > > > However if the > > guest are allowed to use profiling buffers changing E2PB settings, we > > How can the guest be allowed to change E2PB settings? Or do you mean > here that allowing the guest to use SPE will mandate changes of the > E2PB settings, and that we'd better restore the hypervisor state once > we exit? > > > need to ensure we resume back MDCR_EL2.E2PB=b00. Currently we just > > do bitwise '&' with MDCR_EL2_E2PB_MASK which will retain the value. > > > > So fix it by clearing all the bits in E2PB. > > > > Signed-off-by: Sudeep Holla > > Signed-off-by: Andrew Murray > > --- > > arch/arm64/kvm/hyp/switch.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > > index 72fbbd86eb5e..250f13910882 100644 > > --- a/arch/arm64/kvm/hyp/switch.c > > +++ b/arch/arm64/kvm/hyp/switch.c > > @@ -228,9 +228,7 @@ void deactivate_traps_vhe_put(void) > > { > > u64 mdcr_el2 = read_sysreg(mdcr_el2); > > > > - mdcr_el2 &= MDCR_EL2_HPMN_MASK | > > - MDCR_EL2_E2PB_MASK << MDCR_EL2_E2PB_SHIFT | > > - MDCR_EL2_TPMS; > > + mdcr_el2 &= MDCR_EL2_HPMN_MASK | MDCR_EL2_TPMS; > > > > write_sysreg(mdcr_el2, mdcr_el2); > > > > I'm OK with this change, but I believe the commit message could use > some tidying up. No problem, I'll update the commit message. Thanks, Andrew Murray > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F6DC2D0D0 for ; Tue, 24 Dec 2019 10:29:58 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 324C720409 for ; Tue, 24 Dec 2019 10:29:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 324C720409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7E3524AF55; Tue, 24 Dec 2019 05:29:57 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fP2IsMA0nKxs; Tue, 24 Dec 2019 05:29:56 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4C6314AF4A; Tue, 24 Dec 2019 05:29:56 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7D8F54AF33 for ; Tue, 24 Dec 2019 05:29:54 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DBQ7VpgNAgp6 for ; Tue, 24 Dec 2019 05:29:53 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 35E044AF17 for ; Tue, 24 Dec 2019 05:29:53 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93FCF31B; Tue, 24 Dec 2019 02:29:52 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C4773F6CF; Tue, 24 Dec 2019 02:29:51 -0800 (PST) Date: Tue, 24 Dec 2019 10:29:50 +0000 From: Andrew Murray To: Marc Zyngier Subject: Re: [PATCH v2 02/18] arm64: KVM: reset E2PB correctly in MDCR_EL2 when exiting the guest(VHE) Message-ID: <20191224102949.GD42593@e119886-lin.cambridge.arm.com> References: <20191220143025.33853-1-andrew.murray@arm.com> <20191220143025.33853-3-andrew.murray@arm.com> <20191221131214.769a140e@why> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191221131214.769a140e@why> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Cc: kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Sudeep Holla , will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Sat, Dec 21, 2019 at 01:12:14PM +0000, Marc Zyngier wrote: > On Fri, 20 Dec 2019 14:30:09 +0000 > Andrew Murray wrote: > > > From: Sudeep Holla > > > > On VHE systems, the reset value for MDCR_EL2.E2PB=b00 which defaults > > to profiling buffer using the EL2 stage 1 translations. > > Does the reset value actually matter here? I don't see it being > specific to VHE systems, and all we're trying to achieve is to restore > the SPE configuration to a state where it can be used by the host. > > > However if the > > guest are allowed to use profiling buffers changing E2PB settings, we > > How can the guest be allowed to change E2PB settings? Or do you mean > here that allowing the guest to use SPE will mandate changes of the > E2PB settings, and that we'd better restore the hypervisor state once > we exit? > > > need to ensure we resume back MDCR_EL2.E2PB=b00. Currently we just > > do bitwise '&' with MDCR_EL2_E2PB_MASK which will retain the value. > > > > So fix it by clearing all the bits in E2PB. > > > > Signed-off-by: Sudeep Holla > > Signed-off-by: Andrew Murray > > --- > > arch/arm64/kvm/hyp/switch.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > > index 72fbbd86eb5e..250f13910882 100644 > > --- a/arch/arm64/kvm/hyp/switch.c > > +++ b/arch/arm64/kvm/hyp/switch.c > > @@ -228,9 +228,7 @@ void deactivate_traps_vhe_put(void) > > { > > u64 mdcr_el2 = read_sysreg(mdcr_el2); > > > > - mdcr_el2 &= MDCR_EL2_HPMN_MASK | > > - MDCR_EL2_E2PB_MASK << MDCR_EL2_E2PB_SHIFT | > > - MDCR_EL2_TPMS; > > + mdcr_el2 &= MDCR_EL2_HPMN_MASK | MDCR_EL2_TPMS; > > > > write_sysreg(mdcr_el2, mdcr_el2); > > > > I'm OK with this change, but I believe the commit message could use > some tidying up. No problem, I'll update the commit message. Thanks, Andrew Murray > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86948C2D0D2 for ; Tue, 24 Dec 2019 10:29:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BC9820706 for ; Tue, 24 Dec 2019 10:29:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UiTpYBYl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BC9820706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=45tfTDfFKqo3DdfGgAJGtFVKugdjir8mhlJYClfT/Xo=; b=UiTpYBYlsAqyaT zuqnCgOW7L5In4onTjdy7hvbsQHktAIPSYasr6H1qY7nBdM1Gy+oKQ7KMbBGFQ7ngoor6rCw1WwLE RQQwg41XgXW5LUw/3woaY6GCCWNiM9R2WfbVqQNDuEkxB1X7aUA5cdGsyy3QlDpT+JPfZgsEr6XEZ pFXhx6+i80r6shyFTKeNbPjTUQyXSV/ZrHZMrsF2JstrIoYH4TKu3I3Z1Y/o/OjbTPzDArjSZJmtG 4xl2R1fBq1nOb+VvGyyLg2Xp/vh0An+PHRkMI2JYlzAxpC7cd9gZE3z2elJBAtDeR/ml8KA/9VScS aOF3SNY2jafv/VPlJg0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijhRs-0007ur-Gw; Tue, 24 Dec 2019 10:29:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijhRp-0007uE-NL for linux-arm-kernel@lists.infradead.org; Tue, 24 Dec 2019 10:29:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93FCF31B; Tue, 24 Dec 2019 02:29:52 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C4773F6CF; Tue, 24 Dec 2019 02:29:51 -0800 (PST) Date: Tue, 24 Dec 2019 10:29:50 +0000 From: Andrew Murray To: Marc Zyngier Subject: Re: [PATCH v2 02/18] arm64: KVM: reset E2PB correctly in MDCR_EL2 when exiting the guest(VHE) Message-ID: <20191224102949.GD42593@e119886-lin.cambridge.arm.com> References: <20191220143025.33853-1-andrew.murray@arm.com> <20191220143025.33853-3-andrew.murray@arm.com> <20191221131214.769a140e@why> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191221131214.769a140e@why> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191224_022953_803771_32DB56BA X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Sudeep Holla , will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 21, 2019 at 01:12:14PM +0000, Marc Zyngier wrote: > On Fri, 20 Dec 2019 14:30:09 +0000 > Andrew Murray wrote: > > > From: Sudeep Holla > > > > On VHE systems, the reset value for MDCR_EL2.E2PB=b00 which defaults > > to profiling buffer using the EL2 stage 1 translations. > > Does the reset value actually matter here? I don't see it being > specific to VHE systems, and all we're trying to achieve is to restore > the SPE configuration to a state where it can be used by the host. > > > However if the > > guest are allowed to use profiling buffers changing E2PB settings, we > > How can the guest be allowed to change E2PB settings? Or do you mean > here that allowing the guest to use SPE will mandate changes of the > E2PB settings, and that we'd better restore the hypervisor state once > we exit? > > > need to ensure we resume back MDCR_EL2.E2PB=b00. Currently we just > > do bitwise '&' with MDCR_EL2_E2PB_MASK which will retain the value. > > > > So fix it by clearing all the bits in E2PB. > > > > Signed-off-by: Sudeep Holla > > Signed-off-by: Andrew Murray > > --- > > arch/arm64/kvm/hyp/switch.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > > index 72fbbd86eb5e..250f13910882 100644 > > --- a/arch/arm64/kvm/hyp/switch.c > > +++ b/arch/arm64/kvm/hyp/switch.c > > @@ -228,9 +228,7 @@ void deactivate_traps_vhe_put(void) > > { > > u64 mdcr_el2 = read_sysreg(mdcr_el2); > > > > - mdcr_el2 &= MDCR_EL2_HPMN_MASK | > > - MDCR_EL2_E2PB_MASK << MDCR_EL2_E2PB_SHIFT | > > - MDCR_EL2_TPMS; > > + mdcr_el2 &= MDCR_EL2_HPMN_MASK | MDCR_EL2_TPMS; > > > > write_sysreg(mdcr_el2, mdcr_el2); > > > > I'm OK with this change, but I believe the commit message could use > some tidying up. No problem, I'll update the commit message. Thanks, Andrew Murray > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel