From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1326066146131473858==" MIME-Version: 1.0 From: kbuild test robot To: kbuild-all@lists.01.org Subject: Re: [RFC PATCH] media: allegro: implement V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE Date: Tue, 24 Dec 2019 16:00:03 +0800 Message-ID: <201912241505.Uwd0w1Wc%lkp@intel.com> In-Reply-To: <20191220134843.25977-1-m.tretter@pengutronix.de> List-Id: --===============1326066146131473858== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Michael, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.5-rc3 next-20191220] [if your patch is applied to the wrong git tree, please drop us a note to h= elp improve the system. BTW, we also suggest to use '--base' option to specify = the base tree in git format-patch, please see https://stackoverflow.com/a/37406= 982] url: https://github.com/0day-ci/linux/commits/Michael-Tretter/media-alle= gro-implement-V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE/20191223-214145 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse # sparse version: v0.6.1-129-g341daf20-dirty make ARCH=3Dx86_64 allmodconfig make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse= : undefined identifier 'V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE' drivers/staging/media/allegro-dvt/allegro-core.c:2270:59: sparse: sparse= : no member 'p_fract' in union v4l2_ctrl_ptr drivers/staging/media/allegro-dvt/allegro-core.c:2271:61: sparse: sparse= : no member 'p_fract' in union v4l2_ctrl_ptr >> drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse= : incompatible types for 'case' statement drivers/staging/media/allegro-dvt/allegro-core.c:2346:25: sparse: sparse= : undefined identifier 'V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE' drivers/staging/media/allegro-dvt/allegro-core.c:2693:9: sparse: sparse:= undefined identifier 'v4l2_ctrl_s_ctrl_fract' drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse= : Expected constant expression in case statement vim +/case +2268 drivers/staging/media/allegro-dvt/allegro-core.c 2237 = 2238 static int allegro_s_ctrl(struct v4l2_ctrl *ctrl) 2239 { 2240 struct allegro_channel *channel =3D container_of(ctrl->handler, 2241 struct allegro_channel, 2242 ctrl_handler); 2243 struct allegro_dev *dev =3D channel->dev; 2244 int div; 2245 = 2246 v4l2_dbg(1, debug, &dev->v4l2_dev, 2247 "s_ctrl: %s =3D %d\n", v4l2_ctrl_get_name(ctrl->id), ctrl->val); 2248 = 2249 switch (ctrl->id) { 2250 case V4L2_CID_MPEG_VIDEO_H264_LEVEL: 2251 channel->level =3D ctrl->val; 2252 break; 2253 case V4L2_CID_MPEG_VIDEO_BITRATE_MODE: 2254 channel->bitrate_mode =3D ctrl->val; 2255 break; 2256 case V4L2_CID_MPEG_VIDEO_BITRATE: 2257 channel->bitrate =3D ctrl->val; 2258 break; 2259 case V4L2_CID_MPEG_VIDEO_BITRATE_PEAK: 2260 channel->bitrate_peak =3D ctrl->val; 2261 break; 2262 case V4L2_CID_MPEG_VIDEO_H264_CPB_SIZE: 2263 channel->cpb_size =3D ctrl->val; 2264 break; 2265 case V4L2_CID_MPEG_VIDEO_GOP_SIZE: 2266 channel->gop_size =3D ctrl->val; 2267 break; > 2268 case V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE: 2269 div =3D gcd(channel->framerate.numerator, channel->framerate.denom= inator); 2270 channel->framerate.numerator =3D ctrl->p_new.p_fract->numerator / = div; 2271 channel->framerate.denominator =3D ctrl->p_new.p_fract->denominato= r / div; 2272 break; 2273 } 2274 = 2275 return 0; 2276 } 2277 = --- 0-DAY kernel test infrastructure Open Source Technology Cen= ter https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corpor= ation --===============1326066146131473858==--