All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] media: allegro: implement V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE
Date: Wed, 25 Dec 2019 01:49:02 +0800	[thread overview]
Message-ID: <201912250115.JbcCikve%lkp@intel.com> (raw)
In-Reply-To: <20191220134843.25977-1-m.tretter@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]

Hi Michael,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Michael-Tretter/media-allegro-implement-V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE/20191223-214145
base:   git://linuxtv.org/media_tree.git master
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-129-g341daf20-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse: undefined identifier 'V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE'
   drivers/staging/media/allegro-dvt/allegro-core.c:2270:59: sparse: sparse: no member 'p_fract' in union v4l2_ctrl_ptr
   drivers/staging/media/allegro-dvt/allegro-core.c:2271:61: sparse: sparse: no member 'p_fract' in union v4l2_ctrl_ptr
>> drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse: incompatible types for 'case' statement
   drivers/staging/media/allegro-dvt/allegro-core.c:2346:25: sparse: sparse: undefined identifier 'V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE'
   drivers/staging/media/allegro-dvt/allegro-core.c:2693:9: sparse: sparse: undefined identifier 'v4l2_ctrl_s_ctrl_fract'
   drivers/staging/media/allegro-dvt/allegro-core.c:2268:14: sparse: sparse: Expected constant expression in case statement

vim +/case +2268 drivers/staging/media/allegro-dvt/allegro-core.c

  2237	
  2238	static int allegro_s_ctrl(struct v4l2_ctrl *ctrl)
  2239	{
  2240		struct allegro_channel *channel = container_of(ctrl->handler,
  2241							       struct allegro_channel,
  2242							       ctrl_handler);
  2243		struct allegro_dev *dev = channel->dev;
  2244		int div;
  2245	
  2246		v4l2_dbg(1, debug, &dev->v4l2_dev,
  2247			 "s_ctrl: %s = %d\n", v4l2_ctrl_get_name(ctrl->id), ctrl->val);
  2248	
  2249		switch (ctrl->id) {
  2250		case V4L2_CID_MPEG_VIDEO_H264_LEVEL:
  2251			channel->level = ctrl->val;
  2252			break;
  2253		case V4L2_CID_MPEG_VIDEO_BITRATE_MODE:
  2254			channel->bitrate_mode = ctrl->val;
  2255			break;
  2256		case V4L2_CID_MPEG_VIDEO_BITRATE:
  2257			channel->bitrate = ctrl->val;
  2258			break;
  2259		case V4L2_CID_MPEG_VIDEO_BITRATE_PEAK:
  2260			channel->bitrate_peak = ctrl->val;
  2261			break;
  2262		case V4L2_CID_MPEG_VIDEO_H264_CPB_SIZE:
  2263			channel->cpb_size = ctrl->val;
  2264			break;
  2265		case V4L2_CID_MPEG_VIDEO_GOP_SIZE:
  2266			channel->gop_size = ctrl->val;
  2267			break;
> 2268		case V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE:
  2269			div = gcd(channel->framerate.numerator, channel->framerate.denominator);
  2270			channel->framerate.numerator = ctrl->p_new.p_fract->numerator / div;
  2271			channel->framerate.denominator = ctrl->p_new.p_fract->denominator / div;
  2272			break;
  2273		}
  2274	
  2275		return 0;
  2276	}
  2277	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

  parent reply	other threads:[~2019-12-24 17:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 11:34 [PATCH 0/5] Stateful Encoding: final bits Hans Verkuil
2019-11-19 11:34 ` [PATCH 1/5] v4l2-ctrls: add support for v4l2_fract types Hans Verkuil
2019-11-19 11:34 ` [PATCH 2/5] v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL Hans Verkuil
2019-11-19 11:34 ` [PATCH 3/5] v4l2-controls.h: add V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE Hans Verkuil
2019-11-19 11:34 ` [PATCH 4/5] videodev2.h: add V4L2_BUF_FLAG_TOO_SMALL flag Hans Verkuil
2019-11-19 14:36   ` Hans Verkuil
2019-11-20 19:13   ` kbuild test robot
2019-11-19 11:34 ` [PATCH 5/5] media: docs-rst: Document memory-to-memory video encoder interface Hans Verkuil
2019-11-19 16:15 ` [PATCH 0/5] Stateful Encoding: final bits Michael Tretter
2019-12-20 13:47 ` Michael Tretter
2019-12-20 13:48   ` [RFC PATCH] media: allegro: implement V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE Michael Tretter
2019-12-23 19:19     ` kbuild test robot
2019-12-24  8:00     ` kbuild test robot
2019-12-24 17:49     ` kbuild test robot [this message]
2019-12-25  7:13     ` kbuild test robot
2019-12-27  3:19     ` kbuild test robot
2020-01-06 15:02   ` [PATCH 0/5] Stateful Encoding: final bits Hans Verkuil
2020-01-18 13:14     ` Nicolas Dufresne
2020-03-11 15:16   ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201912250115.JbcCikve%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.