From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CDDC3F68F for ; Thu, 26 Dec 2019 02:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F152920828 for ; Thu, 26 Dec 2019 02:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577328354; bh=yv/C6ljrIx/+HyZFKoUjNShUUTPWwuzsvZUkhYKmp/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=s0rhXCWHruSwds3cqO10z57AT4Sg4mJl2SYPTNEmrttbLUKhAoH6M1dvQnP9EVrAT i25SmrNwoFeLtGBU4CJOFhPYitJUGkzfhL8du5N7KnFdPcGhJ3qtH3sENaAZH4Ta3k fUchAqf+gtTSYXysNVhGzyNx4MROMJMpzO2tslHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfLZCpx (ORCPT ); Wed, 25 Dec 2019 21:45:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:50342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbfLZCpx (ORCPT ); Wed, 25 Dec 2019 21:45:53 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0B762075B; Thu, 26 Dec 2019 02:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577328352; bh=yv/C6ljrIx/+HyZFKoUjNShUUTPWwuzsvZUkhYKmp/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sw/DrybP2qxeugrbQatqVZwWIem16gtpKDpAM5KEYW+DDcj0+ciN5hUIHYRnqLMG4 a/xVf3l2RMRBwhyIDMOaGzjFMpQ0i0RUWT525uT2XvUNfe8fa5pLiSAQE5t3cFIH2i js6ogOvSBDDeV5fmYqrUHt/HX0INiiU73O+3rGow= Date: Thu, 26 Dec 2019 11:45:47 +0900 From: Masami Hiramatsu To: Jisheng Zhang Cc: Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Mark Rutland , Jonathan Corbet , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v7 2/3] ftrace: introduce FTRACE_IP_EXTENSION Message-Id: <20191226114547.bb5bc2d5ae5ecf6290a90fa7@kernel.org> In-Reply-To: <20191225172836.7f381759@xhacker.debian> References: <20191225172625.69811b3e@xhacker.debian> <20191225172836.7f381759@xhacker.debian> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Dec 2019 09:42:52 +0000 Jisheng Zhang wrote: > On some architectures, the DYNAMIC_FTRACE_WITH_REGS is implemented by > gcc's -fpatchable-function-entry option. Take arm64 for example, arm64 > makes use of GCC -fpatchable-function-entry=2 option to insert two > nops. When the function is traced, the first nop will be modified to > the LR saver, then the second nop to "bl ". we need to > update ftrace_location() to recognise these two instructions as being > part of ftrace. To do this, we introduce FTRACE_IP_EXTENSION to let > ftrace_location search IP, IP + FTRACE_IP_EXTENSION range. > Looks good to me. Reviewed-by: Masami Hiramatsu Thanks! > Signed-off-by: Jisheng Zhang > Suggested-by: Steven Rostedt (VMware) > --- > include/linux/ftrace.h | 4 ++++ > kernel/trace/ftrace.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 7247d35c3d16..05a03b2a2f39 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -20,6 +20,10 @@ > > #include > > +#ifndef FTRACE_IP_EXTENSION > +#define FTRACE_IP_EXTENSION 0 > +#endif > + > /* > * If the arch supports passing the variable contents of > * function_trace_op as the third parameter back from the > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 74439ab5c2b6..a8cfea502369 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -1590,7 +1590,7 @@ unsigned long ftrace_location_range(unsigned long start, unsigned long end) > */ > unsigned long ftrace_location(unsigned long ip) > { > - return ftrace_location_range(ip, ip); > + return ftrace_location_range(ip, ip + FTRACE_IP_EXTENSION); > } > > /** > -- > 2.24.1 > -- Masami Hiramatsu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5965C2D0C8 for ; Thu, 26 Dec 2019 02:45:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8DC420828 for ; Thu, 26 Dec 2019 02:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="glMImG/G"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sw/DrybP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8DC420828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KpjNnQl28QtjUTEuCxfKPbd6bIlYR2r9vX0RWrCL7XU=; b=glMImG/GQX+26f StEStuLXTBgJf/9slPrgqBLZk27UFAy9OQpu5hQ4omXZ7PqPDVbCL+BhLUEbcBjbI9X7jBVOkHZCy 5t+ayOXvYltH8+2DoxHxpD/1PeSAXXRAv8nCeotR4H2bikVM0ZICktAT+cIt0FwUUFdUqjdFvlq9i F3ZV5bib72RyEw1p5xpP4I5poJ01M1/8AxtC0A1HcBnsMuQZPXNSer/W6Gsvcgb55BDVQ7MlI1cxD K4ZdiuRhg2jYRnkBGduZUnU77v9KHyHRAvWlM1OTa/HuLu4bBm3Cia75tM3JuViZwmwTaSUOg5LK2 ripmsAh0aNTic90LP89A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikJ9w-0004nL-7e; Thu, 26 Dec 2019 02:45:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikJ9t-0004mY-Ra for linux-arm-kernel@lists.infradead.org; Thu, 26 Dec 2019 02:45:55 +0000 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0B762075B; Thu, 26 Dec 2019 02:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577328352; bh=yv/C6ljrIx/+HyZFKoUjNShUUTPWwuzsvZUkhYKmp/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sw/DrybP2qxeugrbQatqVZwWIem16gtpKDpAM5KEYW+DDcj0+ciN5hUIHYRnqLMG4 a/xVf3l2RMRBwhyIDMOaGzjFMpQ0i0RUWT525uT2XvUNfe8fa5pLiSAQE5t3cFIH2i js6ogOvSBDDeV5fmYqrUHt/HX0INiiU73O+3rGow= Date: Thu, 26 Dec 2019 11:45:47 +0900 From: Masami Hiramatsu To: Jisheng Zhang Subject: Re: [PATCH v7 2/3] ftrace: introduce FTRACE_IP_EXTENSION Message-Id: <20191226114547.bb5bc2d5ae5ecf6290a90fa7@kernel.org> In-Reply-To: <20191225172836.7f381759@xhacker.debian> References: <20191225172625.69811b3e@xhacker.debian> <20191225172836.7f381759@xhacker.debian> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191225_184553_915634_0DF4BF94 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jonathan Corbet , Catalin Marinas , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Anil S Keshavamurthy , Ingo Molnar , Steven Rostedt , "Naveen N. Rao" , Will Deacon , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Dec 2019 09:42:52 +0000 Jisheng Zhang wrote: > On some architectures, the DYNAMIC_FTRACE_WITH_REGS is implemented by > gcc's -fpatchable-function-entry option. Take arm64 for example, arm64 > makes use of GCC -fpatchable-function-entry=2 option to insert two > nops. When the function is traced, the first nop will be modified to > the LR saver, then the second nop to "bl ". we need to > update ftrace_location() to recognise these two instructions as being > part of ftrace. To do this, we introduce FTRACE_IP_EXTENSION to let > ftrace_location search IP, IP + FTRACE_IP_EXTENSION range. > Looks good to me. Reviewed-by: Masami Hiramatsu Thanks! > Signed-off-by: Jisheng Zhang > Suggested-by: Steven Rostedt (VMware) > --- > include/linux/ftrace.h | 4 ++++ > kernel/trace/ftrace.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 7247d35c3d16..05a03b2a2f39 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -20,6 +20,10 @@ > > #include > > +#ifndef FTRACE_IP_EXTENSION > +#define FTRACE_IP_EXTENSION 0 > +#endif > + > /* > * If the arch supports passing the variable contents of > * function_trace_op as the third parameter back from the > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 74439ab5c2b6..a8cfea502369 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -1590,7 +1590,7 @@ unsigned long ftrace_location_range(unsigned long start, unsigned long end) > */ > unsigned long ftrace_location(unsigned long ip) > { > - return ftrace_location_range(ip, ip); > + return ftrace_location_range(ip, ip + FTRACE_IP_EXTENSION); > } > > /** > -- > 2.24.1 > -- Masami Hiramatsu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel