All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, Steven Rostedt <rostedt@goodmis.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Namhyung Kim <namhyung@kernel.org>, Tim Bird <Tim.Bird@sony.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 21/22] tracing/boot: Add function tracer filter options
Date: Fri, 27 Dec 2019 11:56:39 +0900	[thread overview]
Message-ID: <20191227115639.d6c33d51d2b10f33dbd05796@kernel.org> (raw)
In-Reply-To: <201912270227.Dwa2YddH%lkp@intel.com>


Oops, the ftrace_set_filter/notrace_filter depend on CONFIG_DYNAMIC_FTRACE, not CONFIG_FUNCTION_TRACER

Thanks, I'll fix it.

On Fri, 27 Dec 2019 02:05:11 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi Masami,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on trace/for-next]
> [also build test ERROR on lwn/docs-next linus/master v5.5-rc3]
> [cannot apply to tip/perf/core next-20191220]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing-bootconfig-Boot-time-tracing-and-Extra-boot-config/20191227-002009
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
> config: xtensa-allyesconfig (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=xtensa 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from kernel/trace/trace_boot.c:9:0:
> >> include/linux/ftrace.h:719:50: error: expected identifier or '(' before '{' token
>     #define ftrace_set_filter(ops, buf, len, reset) ({ -ENODEV; })
>                                                      ^
> >> kernel/trace/trace_boot.c:249:12: note: in expansion of macro 'ftrace_set_filter'
>     extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~
>    include/linux/ftrace.h:720:51: error: expected identifier or '(' before '{' token
>     #define ftrace_set_notrace(ops, buf, len, reset) ({ -ENODEV; })
>                                                       ^
> >> kernel/trace/trace_boot.c:251:12: note: in expansion of macro 'ftrace_set_notrace'
>     extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~~
> --
>    In file included from kernel//trace/trace_boot.c:9:0:
> >> include/linux/ftrace.h:719:50: error: expected identifier or '(' before '{' token
>     #define ftrace_set_filter(ops, buf, len, reset) ({ -ENODEV; })
>                                                      ^
>    kernel//trace/trace_boot.c:249:12: note: in expansion of macro 'ftrace_set_filter'
>     extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~
>    include/linux/ftrace.h:720:51: error: expected identifier or '(' before '{' token
>     #define ftrace_set_notrace(ops, buf, len, reset) ({ -ENODEV; })
>                                                       ^
>    kernel//trace/trace_boot.c:251:12: note: in expansion of macro 'ftrace_set_notrace'
>     extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~~
> 
> vim +/ftrace_set_filter +249 kernel/trace/trace_boot.c
> 
>    246	
>    247	#ifdef CONFIG_FUNCTION_TRACER
>    248	extern bool ftrace_filter_param __initdata;
>  > 249	extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>    250				     int len, int reset);
>  > 251	extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>    252				      int len, int reset);
>    253	static void __init
>    254	trace_boot_set_ftrace_filter(struct trace_array *tr, struct xbc_node *node)
>    255	{
>    256		struct xbc_node *anode;
>    257		const char *p;
>    258		char *q;
>    259	
>    260		xbc_node_for_each_array_value(node, "ftrace.filters", anode, p) {
>    261			q = kstrdup(p, GFP_KERNEL);
>    262			if (!q)
>    263				return;
>    264			if (ftrace_set_filter(tr->ops, q, strlen(q), 0) < 0)
>    265				pr_err("Failed to add %s to ftrace filter\n", p);
>    266			else
>    267				ftrace_filter_param = true;
>    268			kfree(q);
>    269		}
>    270		xbc_node_for_each_array_value(node, "ftrace.notraces", anode, p) {
>    271			q = kstrdup(p, GFP_KERNEL);
>    272			if (!q)
>    273				return;
>    274			if (ftrace_set_notrace(tr->ops, q, strlen(q), 0) < 0)
>    275				pr_err("Failed to add %s to ftrace filter\n", p);
>    276			else
>    277				ftrace_filter_param = true;
>    278			kfree(q);
>    279		}
>    280	}
>    281	#else
>    282	#define trace_boot_set_ftrace_filter(tr, node) do {} while (0)
>    283	#endif
>    284	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation


-- 
Masami Hiramatsu <mhiramat@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 21/22] tracing/boot: Add function tracer filter options
Date: Fri, 27 Dec 2019 11:56:39 +0900	[thread overview]
Message-ID: <20191227115639.d6c33d51d2b10f33dbd05796@kernel.org> (raw)
In-Reply-To: <201912270227.Dwa2YddH%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 5023 bytes --]


Oops, the ftrace_set_filter/notrace_filter depend on CONFIG_DYNAMIC_FTRACE, not CONFIG_FUNCTION_TRACER

Thanks, I'll fix it.

On Fri, 27 Dec 2019 02:05:11 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi Masami,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on trace/for-next]
> [also build test ERROR on lwn/docs-next linus/master v5.5-rc3]
> [cannot apply to tip/perf/core next-20191220]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing-bootconfig-Boot-time-tracing-and-Extra-boot-config/20191227-002009
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
> config: xtensa-allyesconfig (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=xtensa 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from kernel/trace/trace_boot.c:9:0:
> >> include/linux/ftrace.h:719:50: error: expected identifier or '(' before '{' token
>     #define ftrace_set_filter(ops, buf, len, reset) ({ -ENODEV; })
>                                                      ^
> >> kernel/trace/trace_boot.c:249:12: note: in expansion of macro 'ftrace_set_filter'
>     extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~
>    include/linux/ftrace.h:720:51: error: expected identifier or '(' before '{' token
>     #define ftrace_set_notrace(ops, buf, len, reset) ({ -ENODEV; })
>                                                       ^
> >> kernel/trace/trace_boot.c:251:12: note: in expansion of macro 'ftrace_set_notrace'
>     extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~~
> --
>    In file included from kernel//trace/trace_boot.c:9:0:
> >> include/linux/ftrace.h:719:50: error: expected identifier or '(' before '{' token
>     #define ftrace_set_filter(ops, buf, len, reset) ({ -ENODEV; })
>                                                      ^
>    kernel//trace/trace_boot.c:249:12: note: in expansion of macro 'ftrace_set_filter'
>     extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~
>    include/linux/ftrace.h:720:51: error: expected identifier or '(' before '{' token
>     #define ftrace_set_notrace(ops, buf, len, reset) ({ -ENODEV; })
>                                                       ^
>    kernel//trace/trace_boot.c:251:12: note: in expansion of macro 'ftrace_set_notrace'
>     extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>                ^~~~~~~~~~~~~~~~~~
> 
> vim +/ftrace_set_filter +249 kernel/trace/trace_boot.c
> 
>    246	
>    247	#ifdef CONFIG_FUNCTION_TRACER
>    248	extern bool ftrace_filter_param __initdata;
>  > 249	extern int ftrace_set_filter(struct ftrace_ops *ops, unsigned char *buf,
>    250				     int len, int reset);
>  > 251	extern int ftrace_set_notrace(struct ftrace_ops *ops, unsigned char *buf,
>    252				      int len, int reset);
>    253	static void __init
>    254	trace_boot_set_ftrace_filter(struct trace_array *tr, struct xbc_node *node)
>    255	{
>    256		struct xbc_node *anode;
>    257		const char *p;
>    258		char *q;
>    259	
>    260		xbc_node_for_each_array_value(node, "ftrace.filters", anode, p) {
>    261			q = kstrdup(p, GFP_KERNEL);
>    262			if (!q)
>    263				return;
>    264			if (ftrace_set_filter(tr->ops, q, strlen(q), 0) < 0)
>    265				pr_err("Failed to add %s to ftrace filter\n", p);
>    266			else
>    267				ftrace_filter_param = true;
>    268			kfree(q);
>    269		}
>    270		xbc_node_for_each_array_value(node, "ftrace.notraces", anode, p) {
>    271			q = kstrdup(p, GFP_KERNEL);
>    272			if (!q)
>    273				return;
>    274			if (ftrace_set_notrace(tr->ops, q, strlen(q), 0) < 0)
>    275				pr_err("Failed to add %s to ftrace filter\n", p);
>    276			else
>    277				ftrace_filter_param = true;
>    278			kfree(q);
>    279		}
>    280	}
>    281	#else
>    282	#define trace_boot_set_ftrace_filter(tr, node) do {} while (0)
>    283	#endif
>    284	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2019-12-27  2:56 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26 14:03 [PATCH v5 00/22] tracing: bootconfig: Boot-time tracing and Extra boot config Masami Hiramatsu
2019-12-26 14:04 ` [PATCH v5 01/22] bootconfig: Add Extra Boot Config support Masami Hiramatsu
2020-01-08  1:59   ` Steven Rostedt
2020-01-08  3:03     ` Steven Rostedt
2020-01-08  5:17     ` Masami Hiramatsu
2020-01-08 14:01       ` Steven Rostedt
2019-12-26 14:04 ` [PATCH v5 02/22] bootconfig: Load boot config from the tail of initrd Masami Hiramatsu
2019-12-26 14:04 ` [PATCH v5 03/22] tools: bootconfig: Add bootconfig command Masami Hiramatsu
2019-12-26 14:04 ` [PATCH v5 04/22] tools: bootconfig: Add bootconfig test script Masami Hiramatsu
2019-12-26 14:04 ` [PATCH v5 05/22] proc: bootconfig: Add /proc/bootconfig to show boot config list Masami Hiramatsu
2020-01-09 21:37   ` Steven Rostedt
2020-01-10  0:52     ` Masami Hiramatsu
2019-12-26 14:05 ` [PATCH v5 06/22] init/main.c: Alloc initcall_command_line in do_initcall() and free it Masami Hiramatsu
2019-12-26 14:05 ` [PATCH v5 07/22] bootconfig: init: Allow admin to use bootconfig for kernel command line Masami Hiramatsu
2019-12-26 14:05 ` [PATCH v5 08/22] bootconfig: init: Allow admin to use bootconfig for init " Masami Hiramatsu
2019-12-26 14:05 ` [PATCH v5 09/22] Documentation: bootconfig: Add a doc for extended boot config Masami Hiramatsu
2019-12-26 14:05 ` [PATCH v5 10/22] tracing: Apply soft-disabled and filter to tracepoints printk Masami Hiramatsu
2019-12-26 14:06 ` [PATCH v5 11/22] tracing: kprobes: Output kprobe event to printk buffer Masami Hiramatsu
2019-12-26 14:06 ` [PATCH v5 12/22] tracing: kprobes: Register to dynevent earlier stage Masami Hiramatsu
2019-12-26 14:06 ` [PATCH v5 13/22] tracing: Accept different type for synthetic event fields Masami Hiramatsu
2019-12-26 14:06 ` [PATCH v5 14/22] tracing: Add NULL trace-array check in print_synth_event() Masami Hiramatsu
2019-12-26 14:06 ` [PATCH v5 15/22] tracing/boot: Add boot-time tracing Masami Hiramatsu
2019-12-26 14:07 ` [PATCH v5 16/22] tracing/boot: Add per-event settings Masami Hiramatsu
2019-12-26 14:07 ` [PATCH v5 17/22] tracing/boot Add kprobe event support Masami Hiramatsu
2019-12-26 14:07 ` [PATCH v5 18/22] tracing/boot: Add synthetic " Masami Hiramatsu
2019-12-26 14:07 ` [PATCH v5 19/22] tracing/boot: Add instance node support Masami Hiramatsu
2019-12-26 14:07 ` [PATCH v5 20/22] tracing/boot: Add cpu_mask option support Masami Hiramatsu
2019-12-26 14:08 ` [PATCH v5 21/22] tracing/boot: Add function tracer filter options Masami Hiramatsu
2019-12-26 18:05   ` kbuild test robot
2019-12-26 18:05     ` kbuild test robot
2019-12-27  2:56     ` Masami Hiramatsu [this message]
2019-12-27  2:56       ` Masami Hiramatsu
2019-12-26 14:08 ` [PATCH v5 22/22] Documentation: tracing: Add boot-time tracing document Masami Hiramatsu
2020-01-09 23:10 ` [PATCH v5 00/22] tracing: bootconfig: Boot-time tracing and Extra boot config Steven Rostedt
2020-01-10 15:30   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191227115639.d6c33d51d2b10f33dbd05796@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=Tim.Bird@sony.com \
    --cc=acme@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jolsa@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.