From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
John Linville <linville@tuxdriver.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE_GET request
Date: Fri, 27 Dec 2019 13:47:59 +0100 [thread overview]
Message-ID: <20191227124759.GK21614@unicorn.suse.cz> (raw)
In-Reply-To: <918da8cd-7ebc-b895-85c8-afad9eed6036@gmail.com>
On Mon, Dec 23, 2019 at 08:44:19PM -0800, Florian Fainelli wrote:
>
>
> On 12/22/2019 3:46 PM, Michal Kubecek wrote:
> > Implement LINKSTATE_GET netlink request to get link state information.
> >
> > At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command
> > is returned.
> >
> > LINKSTATE_GET request can be used with NLM_F_DUMP (without device
> > identification) to request the information for all devices in current
> > network namespace providing the data.
> >
> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> > ---
>
> [snip]
>
> > +Kernel response contents:
> > +
> > + ==================================== ====== ==========================
> > + ``ETHTOOL_A_LINKSTATE_HEADER`` nested reply header
> > + ``ETHTOOL_A_LINKSTATE_LINK`` u8 autonegotiation status
>
> ^ ==== Humm, auto-negotiation status may not be exactly accurate
> especially with complex devices with SerDes/PHY/SFPs/what have you/.
> Other than that, the code looks correct:
It seems I forgot to edit this cell text after copy&paste from
LINKMODES_GET above. Fixed in v9, thanks.
Michal
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian
next prev parent reply other threads:[~2019-12-27 12:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 23:45 [PATCH net-next v8 00/14] ethtool netlink interface, part 1 Michal Kubecek
2019-12-22 23:45 ` [PATCH net-next v8 01/14] ethtool: introduce ethtool netlink interface Michal Kubecek
2019-12-24 4:01 ` Florian Fainelli
2019-12-24 9:45 ` Andrew Lunn
2019-12-22 23:45 ` [PATCH net-next v8 02/14] ethtool: helper functions for " Michal Kubecek
2019-12-24 4:08 ` Florian Fainelli
2019-12-25 11:07 ` Michal Kubecek
2019-12-22 23:45 ` [PATCH net-next v8 03/14] ethtool: netlink bitset handling Michal Kubecek
2019-12-24 4:15 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 04/14] ethtool: support for netlink notifications Michal Kubecek
2019-12-24 4:16 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 05/14] ethtool: default handlers for GET requests Michal Kubecek
2019-12-24 4:23 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 06/14] ethtool: provide string sets with STRSET_GET request Michal Kubecek
2019-12-24 4:28 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 07/14] ethtool: provide link settings with LINKINFO_GET request Michal Kubecek
2019-12-24 4:32 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 08/14] ethtool: set link settings with LINKINFO_SET request Michal Kubecek
2019-12-24 4:30 ` Florian Fainelli
2019-12-22 23:45 ` [PATCH net-next v8 09/14] ethtool: add default notification handler Michal Kubecek
2019-12-24 4:31 ` Florian Fainelli
2019-12-22 23:46 ` [PATCH net-next v8 10/14] ethtool: add LINKINFO_NTF notification Michal Kubecek
2019-12-24 4:34 ` Florian Fainelli
2019-12-22 23:46 ` [PATCH net-next v8 11/14] ethtool: provide link mode information with LINKMODES_GET request Michal Kubecek
2019-12-24 4:35 ` Florian Fainelli
2019-12-22 23:46 ` [PATCH net-next v8 12/14] ethtool: set link modes related data with LINKMODES_SET request Michal Kubecek
2019-12-24 4:40 ` Florian Fainelli
2019-12-22 23:46 ` [PATCH net-next v8 13/14] ethtool: add LINKMODES_NTF notification Michal Kubecek
2019-12-24 4:41 ` Florian Fainelli
2019-12-22 23:46 ` [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE_GET request Michal Kubecek
2019-12-24 4:44 ` Florian Fainelli
2019-12-27 12:47 ` Michal Kubecek [this message]
2019-12-23 16:52 ` [PATCH net-next v8 00/14] ethtool netlink interface, part 1 Florian Fainelli
2019-12-23 22:05 ` Michal Kubecek
2019-12-24 4:45 ` Florian Fainelli
2019-12-25 7:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227124759.GK21614@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.