From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1ikrNB-0002Ea-53
	for mharc-grub-devel@gnu.org; Fri, 27 Dec 2019 10:17:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:48393)
 by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <ps@pks.im>)
 id 1ikrN6-0001mS-3k
 for grub-devel@gnu.org; Fri, 27 Dec 2019 10:17:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ps@pks.im>) id 1ikrE6-0003Ps-I6
 for grub-devel@gnu.org; Fri, 27 Dec 2019 10:08:31 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35247)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ps@pks.im>) id 1ikrE6-0003Hm-52
 for grub-devel@gnu.org; Fri, 27 Dec 2019 10:08:30 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id CC23122076;
 Fri, 27 Dec 2019 10:08:27 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 27 Dec 2019 10:08:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date
 :from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=fm2; bh=kM76vAPgiBxl1jWnJCebst31Asn
 Hgm5PwCdWtl/Nwv0=; b=tasSCDAYd/swFXk6FLaDCGhQs7it+WbBWKoojgCbKAv
 zBX/iLRyv7iahVbISHxdzbrypgR0uKlooHi/An8ZzTwKzKzIhPpPHKR8GcVLaiZ4
 FiuXT0zPxmMkYYuCtnzHxxsj//VTNdwT23qjdB/976+fDdD5+ly2PeRmE6p7l3OE
 dpSNhlKYG4HA+qKqJ3T0zUZQK953UdFaM1hv7N7ASeK5nikqVAjdgbIRKGO8k/H6
 ZJUiO8PIq6NVjuccMO801snAZZPWsoy7qAYMRf4p8/Lk1s97nUPP0J5x1numb44I
 RKjiNdKtR6SlDKYd0abrq/XjqM5JTLns4/Ob/Q7iNGQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=kM76vA
 PgiBxl1jWnJCebst31AsnHgm5PwCdWtl/Nwv0=; b=k7RDW7TII7HM8saPFZydTl
 ma2IH5vhm5ePkUyDgezCtwQHSPQVk6xTvlZCfSgYir23R0B3py4KC5O8QD8AUbWv
 TdAg6yHPKEr0Pe1Uw3hA/uJzvIAH//XWGfvFIdEHaeSyWjw0205yKnVABilLplfd
 419WwjoBBrXBTZR1cg22Phus59E4wqUWlnWU3FnfF2E5abuacrdWiMqD1RQ8p0g+
 0YXW2+hWNxgAfBYOw88Kmkdqa6GeAVIlNEb8R82VBjq+inCEEpk/J1HmEEs1UxAS
 3ynrPgD2Y1ikrc+Srhu/eXXzhY4IUj0G7eZ9F2fX6OgVXsCB/VhYYdA6P9AqjQ1w
 ==
X-ME-Sender: <xms:ax4GXmrDgUJpImoQBDm2eH9aizkjdC3RZF65OvqImAacpz33IoJ94g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddvkedgjedvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi
 tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepkeelrdduvd
 drudeifedrgeelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhmnecu
 vehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:ax4GXky_q1uciYag4mGepUQhqT6kcMa2hK0Ai80ASmodpzC5aLhPog>
 <xmx:ax4GXvWHoBl_UVqxdDQ8kFpw9FakG9p173nLbsOmubZrQLQeNkAasQ>
 <xmx:ax4GXuVJkT6GStWy6IhWAOXmbZrzGW0fuE2IdtlM1ZYayUuciSgDQg>
 <xmx:ax4GXjo7JoZ55G7E760lhSYeQJ8jEmiWA2AEYQrl9BKrjQf2t62cPQ>
Received: from vm-mail (x590ca331.dyn.telefonica.de [89.12.163.49])
 by mail.messagingengine.com (Postfix) with ESMTPA id AA8D230607D5;
 Fri, 27 Dec 2019 10:08:26 -0500 (EST)
Received: from localhost (<unknown> [10.192.0.11])
 by vm-mail (OpenSMTPD) with ESMTPSA id bf268e3a
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Fri, 27 Dec 2019 15:08:22 +0000 (UTC)
Date: Fri, 27 Dec 2019 16:08:44 +0100
From: Patrick Steinhardt <ps@pks.im>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org, Max Tottenham <mtottenh@akamai.com>
Subject: Re: [PATCH v6 0/6] Support for LUKS2 disk encryption
Message-ID: <20191227150837.GA209409@ncase>
References: <cover.1572717208.git.ps@pks.im> <cover.1575969933.git.ps@pks.im>
 <20191220193304.6wo3xzsylckkawxo@tomti.i.net-space.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="MfFXiAuoTsnnDAfZ"
Content-Disposition: inline
In-Reply-To: <20191220193304.6wo3xzsylckkawxo@tomti.i.net-space.pl>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 66.111.4.26
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Dec 2019 15:17:51 -0000


--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 20, 2019 at 08:33:04PM +0100, Daniel Kiper wrote:
> On Tue, Dec 10, 2019 at 10:26:15AM +0100, Patrick Steinhardt wrote:
> > Hi,
> >
> > this is the 6th version of this patchset aiming to implement
> > support for LUKS2 disk encryption. All changes relate to the JSON
> > interface, only:
>=20
> Sadly your patchset brakes at least i386-pc and arm-coreboot builds.
> Compiler spits:
[snip]

Indeed, there's two issues on 32 bit platforms:

    - Mismatch between 32/64 bit types due to misuse of
      `grub_size_t` instead of `grub_uint64_t`. This is easily
      fixed by using the correct type.

    - Use 64-bit division when calculating the disk offset, which
      isn't supported natively on 32 bit platforms. This is also
      easily fixed by using `grub_divmod64`.

I'll send an updated patch series in a few minutes.

Patrick

--MfFXiAuoTsnnDAfZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl4GHnwACgkQEXxntp6r
8SxeLQ/+L5fdjyQ8VDEi+v6pu0UrVtSynSvvcP6HjSCihU7UzSp/YoGUfrzkbhxQ
OPp+qcC2AfKnukh84s9uObIces26ZkcNa0ePoHFT2r+BOsCyUARX1Bp+IVWZUM4o
OeCyzfgR/8zLfUNlGaicnfFk+2yyIsxjL7hHSaukZY7o9N18CS0Q5EaCXZ/hoC72
8tGhkUvP36vLyRy4fj0wZQiQlYk7tZt8njdDbtpNsyqROqCog2PSgQe0ys/SJxps
FY7wO/tiipQ15QDnLqnG8nQlJ/xldcrUlITnEvnng3qlxOPivGuGoLi3/sBuBMWt
HCOqPna75yZkA5OToU9p1NSW8lbQ1H5sbroHiHhNfE9H4AMXc8cOwBki1l4NKL9m
Vi3JCrHFghYW8CeJG0irOg3nenFqvQkRbJG7HxzD3bCHBg7EEyhy/ROOk3fBAsn8
zBpN/9XA0KG0rriamaaxe3nnCkAUw3vDv7u6RWHrdnfK/Nbp3XemUIzyD2kzcbOi
g3i1oUY2/6mTSL96RaHNt1JEUIJ4hMYqOBHac+yEGqJcvcTfYyp5LVclAqmidIuj
SZ7K9zfHLRR9/pSKcROug891A7fJXFaRBftMNNOYTEDhtm3v6DZK0SfZSJFjBpoM
fBl48LZGQQpG2jqhowYnq2cEIgF+Hz03Hz13ED8ThDuJocwLKHk=
=ZzT3
-----END PGP SIGNATURE-----

--MfFXiAuoTsnnDAfZ--