From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A80C2D0CE for ; Sun, 29 Dec 2019 17:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF7221D7E for ; Sun, 29 Dec 2019 17:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640258; bh=PbejQvt92Lv8EXKEFReHeQaUQoigtn6bvBp6eI1MK3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RtbwEMV1DZD9B4KMrxMUhZKg249WV6AvS+bqaGy7yYVnpuptOgF/ERNzSyaOFO5e1 l5VJHIbj1DsXjTCzEtn88XITkOepnYlL5M+8v2w6Lvp0d5nx/LIhorOOby0cqqOuBZ LkXs82T4ir3izYHWQstkex+f/0L9I4i1YTjtEQSY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727702AbfL2RYR (ORCPT ); Sun, 29 Dec 2019 12:24:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:42666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727374AbfL2RYN (ORCPT ); Sun, 29 Dec 2019 12:24:13 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A88E3207FD; Sun, 29 Dec 2019 17:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577640253; bh=PbejQvt92Lv8EXKEFReHeQaUQoigtn6bvBp6eI1MK3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2QozpblgfUXl/NvBSnetolHKQwXILct6IXxQt8VidccBdhVQFDdt9k+rjG5mhXWgJ bxrQ5YIftqwAENBDXyA3oxu6dWq7ObhjWvSSL9CnVk7Oa3NU7eqehNPour/VRPO7gZ NzUR1l4JTPYZRUsHgHgNhhGct8nI/yoRUPeS9ZUw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 043/161] media: flexcop-usb: fix NULL-ptr deref in flexcop_usb_transfer_init() Date: Sun, 29 Dec 2019 18:18:11 +0100 Message-Id: <20191229162412.934047252@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229162355.500086350@linuxfoundation.org> References: <20191229162355.500086350@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 649cd16c438f51d4cd777e71ca1f47f6e0c5e65d ] If usb_set_interface() failed, iface->cur_altsetting will not be assigned and it will be used in flexcop_usb_transfer_init() It may lead a NULL pointer dereference. Check usb_set_interface() return value in flexcop_usb_init() and return failed to avoid using this NULL pointer. Signed-off-by: Yang Yingliang Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/b2c2/flexcop-usb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c index ac4fddfd0a43..f1807c16438d 100644 --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -503,7 +503,13 @@ urb_error: static int flexcop_usb_init(struct flexcop_usb *fc_usb) { /* use the alternate setting with the larges buffer */ - usb_set_interface(fc_usb->udev,0,1); + int ret = usb_set_interface(fc_usb->udev, 0, 1); + + if (ret) { + err("set interface failed."); + return ret; + } + switch (fc_usb->udev->speed) { case USB_SPEED_LOW: err("cannot handle USB speed because it is too slow."); -- 2.20.1